From 52437d1712eabaa6dd35aabd8651eb2898bb30bc Mon Sep 17 00:00:00 2001 From: Kurt Date: Mon, 11 Nov 2024 08:16:58 -0600 Subject: [PATCH] Gen3 PCNY: remove OT gender checks Same as PCJP, uses the recipient's save file gender. Not random. --- .../Encounters/Templates/Gen3/Gifts/EncounterGift3NY.cs | 9 --------- 1 file changed, 9 deletions(-) diff --git a/PKHeX.Core/Legality/Encounters/Templates/Gen3/Gifts/EncounterGift3NY.cs b/PKHeX.Core/Legality/Encounters/Templates/Gen3/Gifts/EncounterGift3NY.cs index 2846af0bf..b02cd57f4 100644 --- a/PKHeX.Core/Legality/Encounters/Templates/Gen3/Gifts/EncounterGift3NY.cs +++ b/PKHeX.Core/Legality/Encounters/Templates/Gen3/Gifts/EncounterGift3NY.cs @@ -87,7 +87,6 @@ public sealed class EncounterGift3NY(ushort Species, Distribution3NY Distributio pk.PID = pid; pk.IV32 = PIDGenerator.SetIVsFromSeedSequentialLCRNG(ref seed); pk.RefreshAbility((int)(pid & 1)); - pk.OriginalTrainerGender = (byte)GetGender(LCRNG.Next16(ref seed)); return; } } @@ -168,14 +167,6 @@ public sealed class EncounterGift3NY(ushort Species, Distribution3NY Distributio if (type is not PIDType.BACD_AX) return false; - var seed = value.OriginSeed; - var rand5 = LCRNG.Next5(seed) >> 16; - var expect = GetGender(rand5); - if (pk.OriginalTrainerGender != expect) - return false; - return true; // Table weight -> gift selection is a separate RNG, nothing to check! } - - private static uint GetGender(uint rand16) => CommonEvent3.GetGenderBit7(rand16); }