Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-23 12:33:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

Verify Contest stats on gen5 origin

Browse source 
extract to separate logic class; only gen3+ call this (was originally called by gen6+); only really needs to include gen5
This commit is contained in:
Kurt 2020-05-09 20:47:32 -07:00
parent 8650b5ceb2
commit 4decaa73f7
4 changed files with 40 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
PKHeX.Core/Legality/Analysis.cs
View file

@ -318,6 +318,8 @@ namespace PKHeX.Core
if (pkm.Format <= 6 && pkm.Format >= 4)
EncounterType.Verify(this); // Gen 6->7 transfer deletes encounter type data
Contest.Verify(this);
if (pkm.Format < 6)
return;

1
PKHeX.Core/Legality/Checks.cs
View file

@ -25,6 +25,7 @@ namespace PKHeX.Core
private static readonly Verifier CXD = new CXDVerifier();
private static readonly Verifier Memory = new MemoryVerifier();
private static readonly Verifier History = new HistoryVerifier();
private static readonly Verifier Contest = new ContestStatVerifier();
private static readonly TrainerNameVerifier Trainer = new TrainerNameVerifier();
private static readonly LevelVerifier Level = new LevelVerifier();

36
PKHeX.Core/Legality/Verifiers/ContestStatVerifier.cs Normal file
View file

@ -0,0 +1,36 @@
namespace PKHeX.Core
{
/// <summary>
/// Verifies the Contest stat details.
/// </summary>
public class ContestStatVerifier : Verifier
{
protected override CheckIdentifier Identifier => CheckIdentifier.Memory;
public override void Verify(LegalityAnalysis data)
{
var pkm = data.pkm;
if (pkm.Format <= 4)
return; // legal || not present
if (pkm is IContestStats s && s.HasContestStats() && !CanHaveContestStats(pkm, data.Info.Generation))
data.AddLine(GetInvalid(LegalityCheckStrings.LContestZero));
// some encounters have contest stats built in. they're already checked by the initial encounter match.
}
private static bool CanHaveContestStats(PKM pkm, int origin)
{
return origin switch
{
1 => false,
2 => false,
3 => true,
4 => true,
5 => (pkm.Format >= 6), // ORAS Contests
6 => (!pkm.IsUntraded || pkm.AO),
7 => false,
_ => false
};
}
}
}

20
PKHeX.Core/Legality/Verifiers/HistoryVerifier.cs
View file

@ -22,15 +22,12 @@ namespace PKHeX.Core
private void VerifyTradeState(LegalityAnalysis data)
{
var pkm = data.pkm;
var Info = data.Info;
if (data.pkm is IGeoTrack t)
VerifyGeoLocationData(data, t, data.pkm);
if (pkm.VC && pkm is PK7 g && g.Geo1_Country == 0) // VC transfers set Geo1 Country
data.AddLine(GetInvalid(LegalityCheckStrings.LGeoMemoryMissing));
if (pkm is IContestStats s && s.HasContestStats() && !CanHaveContestStats(pkm, Info.Generation))
data.AddLine(GetInvalid(LegalityCheckStrings.LContestZero));
if (!pkm.IsUntraded)
{
@ -203,20 +200,5 @@ namespace PKHeX.Core
_ => throw new IndexOutOfRangeException(),
};
}
private static bool CanHaveContestStats(PKM pkm, int origin)
{
return origin switch
{
1 => false,
2 => false,
3 => true,
4 => true,
5 => (pkm.Format >= 6), // ORAS Contests
6 => (!pkm.IsUntraded || pkm.AO),
7 => false,
_ => false
};
}
}
}
}