From 423be8b2c06f8dd6aa878af3dc3fc86458abc68a Mon Sep 17 00:00:00 2001 From: Kurt Date: Wed, 6 Sep 2017 20:02:41 -0700 Subject: [PATCH] Add VC1 tradeback shiny check tradeback implies it was transferred to GS for a bit, thus had to be transported with the new transporter --- PKHeX.Core/Legality/Checks.cs | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/PKHeX.Core/Legality/Checks.cs b/PKHeX.Core/Legality/Checks.cs index 7051e2460..f7c3608da 100644 --- a/PKHeX.Core/Legality/Checks.cs +++ b/PKHeX.Core/Legality/Checks.cs @@ -1919,8 +1919,14 @@ namespace PKHeX.Core AddLine(Severity.Invalid, V368, CheckIdentifier.Egg); } - if (pkm.Format > 2 && pkm.VC2 && pkm.Gender == 1 && pkm.PersonalInfo.Gender == 31 && pkm.IsShiny) - AddLine(Severity.Invalid, V209, CheckIdentifier.PID); + if (pkm.Format > 2) + { + // Female Shinies for a 12.5%-F species are not possible with the 'correct' correlation + // Original Transporter code generated a random nature (VC1 only), so we can ignore in this case + bool checkShiny = pkm.VC2 || pkm.TradebackStatus == TradebackType.WasTradeback && pkm.VC1; + if (checkShiny && pkm.Gender == 1 && pkm.PersonalInfo.Gender == 31 && pkm.IsShiny) + AddLine(Severity.Invalid, V209, CheckIdentifier.PID); + } if (!(pkm is PK1 pk1)) return;