Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-23 12:33:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don't pass key byref

Browse source 
Pass byval and return the result; emits less IL
mark for inlining
This commit is contained in:
Kurt 2021-06-04 14:19:07 -07:00
parent ad79833420
commit 3a1fbc9b88
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
PKHeX.Core/Saves/Encryption/SwishCrypto/SCXorShift32.cs
View file

@ -1,4 +1,6 @@
namespace PKHeX.Core using System.Runtime.CompilerServices;
namespace PKHeX.Core
{ {
/// <summary> /// <summary>
/// Self-mutating value that returns a crypto value to be xor-ed with another (unaligned) byte stream. /// Self-mutating value that returns a crypto value to be xor-ed with another (unaligned) byte stream.
@ -20,7 +22,7 @@
var pop_count = PopCount(seed); var pop_count = PopCount(seed);
#endif #endif
for (var i = 0; i < pop_count; i++) for (var i = 0; i < pop_count; i++)
XorshiftAdvance(ref seed); seed = XorshiftAdvance(seed);
Counter = 0; Counter = 0;
Seed = seed; Seed = seed;
@ -35,7 +37,7 @@
var val = (Seed >> (c << 3)) & 0xFF; var val = (Seed >> (c << 3)) & 0xFF;
if (c == 3) if (c == 3)
{ {
XorshiftAdvance(ref Seed); Seed = XorshiftAdvance(Seed);
Counter = 0; Counter = 0;
} }
else else
@ -53,11 +55,13 @@
return Next() | (Next() << 8) | (Next() << 16) | (Next() << 24); return Next() | (Next() << 8) | (Next() << 16) | (Next() << 24);
} }
private static void XorshiftAdvance(ref uint key) [MethodImpl(MethodImplOptions.AggressiveInlining)]
private static uint XorshiftAdvance(uint key)
{ {
key ^= key << 2; key ^= key << 2;
key ^= key >> 15; key ^= key >> 15;
key ^= key << 13; key ^= key << 13;
return key;
} }
#if !NET5 #if !NET5