Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-22 03:53:08 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix array reference

Browse source 
GC strings are 22 bytes long, but GBA strings are 10 & 7 bytes long. If a 7-char OT name is generated in C/XD and transferred, it would try iterating to the 8th char which is OOB for dest.
Iterate over the smaller array, which is always dest (in this method).
This commit is contained in:
Kurt 2024-10-03 14:44:22 -05:00
parent 7632230edf
commit 1dc94152c3
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
PKHeX.Core/PKM/Strings/StringConverter3GC.cs
View file

@ -132,7 +132,7 @@ public static class StringConverter3GC
var table = jpn ? CharTableJPN : CharTableINT;
int i = 0;
for (; i < data.Length; i++)
for (; i < dest.Length; i++)
{
var c = (char)ReadUInt16BigEndian(data[(i * 2)..]);
if (c == TerminatorBigEndian)