Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-24 04:53:08 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Verifiers/FormVerifier.cs

389 lines
17 KiB
C#
Raw Normal View History

Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
using System;
using static PKHeX.Core.LegalityCheckStrings;
Minor clean
2021-01-11 02:15:33 +00:00
using static PKHeX.Core.Species;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
namespace PKHeX.Core
{
Misc simplifications / xmldoc
2018-07-02 02:17:37 +00:00
/// <summary>
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
/// Verifies the <see cref="PKM.Form"/> value.
Misc simplifications / xmldoc
2018-07-02 02:17:37 +00:00
/// </summary>
public sealed class FormVerifier : Verifier
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
protected override CheckIdentifier Identifier => CheckIdentifier.Form;
public override void Verify(LegalityAnalysis data)
{
var pkm = data.pkm;
if (pkm.Format < 4)
return; // no forms exist
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
var result = VerifyForm(data);
data.AddLine(result);
Add form argument legality checks Closes #2611 (Alcremie) Closes #2604 (Runerigus)
2020-01-11 00:33:40 +00:00
if (pkm is IFormArgument f)
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
data.AddLine(VerifyFormArgument(data, f));
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
private CheckResult VALID => GetValid(LFormValid);
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
private CheckResult VerifyForm(LegalityAnalysis data)
{
var pkm = data.pkm;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
var PersonalInfo = data.PersonalInfo;
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
int count = PersonalInfo.FormCount;
var form = pkm.Form;
cache form/species/format on first get very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
2020-01-17 03:23:29 +00:00
if (count <= 1 && form == 0)
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
return VALID; // no forms to check
cache form/species/format on first get very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
2020-01-17 03:23:29 +00:00
var species = pkm.Species;
Use more expression return style Reduces indentation & bracketing, a bit more concise
2021-01-02 01:08:49 +00:00
var enc = data.EncounterMatch;
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
var Info = data.Info;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
if (!PersonalInfo.IsFormWithinRange(form) && !FormInfo.IsValidOutOfBoundsForm(species, form, Info.Generation))
cache form/species/format on first get very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
2020-01-17 03:23:29 +00:00
return GetInvalid(string.Format(LFormInvalidRange, count - 1, form));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Minor clean
2021-01-11 02:15:33 +00:00
switch ((Species)species)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Minor clean
2021-01-11 02:15:33 +00:00
case Pikachu when Info.Generation == 6: // Cosplay
Use more expression return style Reduces indentation & bracketing, a bit more concise
2021-01-02 01:08:49 +00:00
bool isStatic = enc is EncounterStatic;
Minor clean
2021-01-11 02:15:33 +00:00
bool validCosplay = form == (isStatic ? enc.Form : 0);
if (!validCosplay)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(isStatic ? LFormPikachuCosplayInvalid : LFormPikachuCosplay);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
break;
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
Disallow starter pika/vee on opposite game storage
2021-08-23 23:46:03 +00:00
case Pikachu when form is not 0 && ParseSettings.ActiveTrainer is SAV7b {Version:GameVersion.GE}:
case Eevee when form is not 0 && ParseSettings.ActiveTrainer is SAV7b {Version:GameVersion.GP}:
return GetInvalid(LFormBattle);
Minor clean
2021-01-11 02:15:33 +00:00
case Pikachu when Info.Generation >= 7: // Cap
Update FormVerifier.cs
2021-01-27 00:23:26 +00:00
bool validCap = form == (enc is EncounterInvalid or EncounterEgg ? 0 : enc.Form);
Use more expression return style Reduces indentation & bracketing, a bit more concise
2021-01-02 01:08:49 +00:00
if (!validCap)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Use more expression return style Reduces indentation & bracketing, a bit more concise
2021-01-02 01:08:49 +00:00
bool gift = enc is MysteryGift g && g.Form != form;
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
var msg = gift ? LFormPikachuEventInvalid : LFormInvalidGame;
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
return GetInvalid(msg);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
break;
Minor clean
2021-01-11 02:15:33 +00:00
case Unown when Info.Generation == 2 && form >= 26:
cache form/species/format on first get very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
2020-01-17 03:23:29 +00:00
return GetInvalid(string.Format(LFormInvalidRange, "Z", form == 26 ? "!" : "?"));
Update PKHeX.Core abstractions with latest logic Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com> Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2022-02-05 01:35:15 +00:00
case Dialga or Palkia or Giratina or Arceus when form > 0 && pkm.LA: // can change forms with key items
break;
Minor clean
2021-01-11 02:15:33 +00:00
case Giratina when form == 1 ^ pkm.HeldItem == 112: // Giratina, Origin form only with Griseous Orb
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LFormItemInvalid);
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
Minor clean
2021-01-11 02:15:33 +00:00
case Arceus:
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
cache form/species/format on first get very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
2020-01-17 03:23:29 +00:00
int arceus = GetArceusFormFromHeldItem(pkm.HeldItem, pkm.Format);
return arceus != form ? GetInvalid(LFormItemInvalid) : GetValid(LFormItem);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Update FormVerifier.cs
2021-04-19 04:22:58 +00:00
case Keldeo when enc.Generation != 5 || pkm.Format >= 8:
Minor clean
2021-01-11 02:15:33 +00:00
// can mismatch in gen5 via BW tutor and transfer up
// can mismatch in gen8+ as the form activates in battle when knowing the move; outside of battle can be either state.
Update FormVerifier.cs
2021-04-19 04:22:58 +00:00
// Generation 8 patched out the mismatch; always forced to match moves.
Minor clean
2021-01-11 02:15:33 +00:00
bool hasSword = pkm.HasMove((int) Move.SecretSword);
bool isSword = pkm.Form == 1;
if (isSword != hasSword)
return GetInvalid(LMoveKeldeoMismatch);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
break;
Minor clean
2021-01-11 02:15:33 +00:00
case Genesect:
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
cache form/species/format on first get very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
2020-01-17 03:23:29 +00:00
int genesect = GetGenesectFormFromHeldItem(pkm.HeldItem);
return genesect != form ? GetInvalid(LFormItemInvalid) : GetValid(LFormItem);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Minor clean
2021-01-11 02:15:33 +00:00
case Greninja:
cache form/species/format on first get very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
2020-01-17 03:23:29 +00:00
if (form > 1) // Ash Battle Bond active
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LFormBattle);
Use more expression return style Reduces indentation & bracketing, a bit more concise
2021-01-02 01:08:49 +00:00
if (form != 0 && enc is not MysteryGift) // Formes are not breedable, MysteryGift already checked
cache form/species/format on first get very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
2020-01-17 03:23:29 +00:00
return GetInvalid(string.Format(LFormInvalidRange, 0, form));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
break;
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
Minor clean
2021-01-11 02:15:33 +00:00
case Scatterbug or Spewpa:
Add bounds check for API purposes chris doing things funkily, might as well range check ourselves before blindly accessing the array Use a const value for vivillon max wild form value
2021-08-20 01:59:24 +00:00
if (form > Vivillon3DS.MaxWildFormID) // Fancy & Pokéball
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LFormVivillonEventPre);
this is not that clearer than before, yay
2020-12-22 01:12:39 +00:00
if (pkm is not IRegionOrigin tr)
Split Country/Region/ConsoleRegion to interface
2020-07-31 18:17:31 +00:00
break;
Properly check Vivillon form legality (#3235) This uses more current crowdsourced information to update the country and subregion tables for Vivillon forms. It's possible to change the country/subregion within a 3DS console region, so only forms that cannot be obtained for a console region are flagged as illegal. If a form is not native to the country/subregion, it is marked as Fishy instead. https://docs.google.com/spreadsheets/d/e/2PACX-1vTVVOEZbXLVQvjIdzGACpZ_IrOWgVDBr_Wa-xULK3191BP9lf1tep-z-PsmcAfaH_aE56j3GHDX_9UO/pubhtml
2021-08-02 15:57:21 +00:00
if (!Vivillon3DS.IsPatternValid(form, tr.ConsoleRegion))
return GetInvalid(LFormVivillonInvalid);
Simplify Country/Region/ConsoleRegion to byte from int Only exists in gen6/7 games.
2021-08-03 02:43:57 +00:00
if (!Vivillon3DS.IsPatternNative(form, tr.Country, tr.Region))
Properly check Vivillon form legality (#3235) This uses more current crowdsourced information to update the country and subregion tables for Vivillon forms. It's possible to change the country/subregion within a 3DS console region, so only forms that cannot be obtained for a console region are flagged as illegal. If a form is not native to the country/subregion, it is marked as Fishy instead. https://docs.google.com/spreadsheets/d/e/2PACX-1vTVVOEZbXLVQvjIdzGACpZ_IrOWgVDBr_Wa-xULK3191BP9lf1tep-z-PsmcAfaH_aE56j3GHDX_9UO/pubhtml
2021-08-02 15:57:21 +00:00
data.AddLine(Get(LFormVivillonNonNative, Severity.Fishy));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
break;
Minor clean
2021-01-11 02:15:33 +00:00
case Vivillon:
Add bounds check for API purposes chris doing things funkily, might as well range check ourselves before blindly accessing the array Use a const value for vivillon max wild form value
2021-08-20 01:59:24 +00:00
if (form > Vivillon3DS.MaxWildFormID) // Fancy & Pokéball
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Use more expression return style Reduces indentation & bracketing, a bit more concise
2021-01-02 01:08:49 +00:00
if (enc is not MysteryGift)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LFormVivillonInvalid);
return GetValid(LFormVivillon);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Minor clean
2021-01-11 02:15:33 +00:00
if (pkm is not IRegionOrigin trv)
Split Country/Region/ConsoleRegion to interface
2020-07-31 18:17:31 +00:00
break;
Properly check Vivillon form legality (#3235) This uses more current crowdsourced information to update the country and subregion tables for Vivillon forms. It's possible to change the country/subregion within a 3DS console region, so only forms that cannot be obtained for a console region are flagged as illegal. If a form is not native to the country/subregion, it is marked as Fishy instead. https://docs.google.com/spreadsheets/d/e/2PACX-1vTVVOEZbXLVQvjIdzGACpZ_IrOWgVDBr_Wa-xULK3191BP9lf1tep-z-PsmcAfaH_aE56j3GHDX_9UO/pubhtml
2021-08-02 15:57:21 +00:00
if (!Vivillon3DS.IsPatternValid(form, trv.ConsoleRegion))
return GetInvalid(LFormVivillonInvalid);
Simplify Country/Region/ConsoleRegion to byte from int Only exists in gen6/7 games.
2021-08-03 02:43:57 +00:00
if (!Vivillon3DS.IsPatternNative(form, trv.Country, trv.Region))
Properly check Vivillon form legality (#3235) This uses more current crowdsourced information to update the country and subregion tables for Vivillon forms. It's possible to change the country/subregion within a 3DS console region, so only forms that cannot be obtained for a console region are flagged as illegal. If a form is not native to the country/subregion, it is marked as Fishy instead. https://docs.google.com/spreadsheets/d/e/2PACX-1vTVVOEZbXLVQvjIdzGACpZ_IrOWgVDBr_Wa-xULK3191BP9lf1tep-z-PsmcAfaH_aE56j3GHDX_9UO/pubhtml
2021-08-02 15:57:21 +00:00
data.AddLine(Get(LFormVivillonNonNative, Severity.Fishy));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
break;
Minor clean
2021-01-11 02:15:33 +00:00
case Floette when form == 5: // Floette Eternal Flower -- Never Released
Use more expression return style Reduces indentation & bracketing, a bit more concise
2021-01-02 01:08:49 +00:00
if (enc is not MysteryGift)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LFormEternalInvalid);
return GetValid(LFormEternal);
Minor clean
2021-01-11 02:15:33 +00:00
case Meowstic when form != pkm.Gender:
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LGenderInvalidNone);
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
Minor clean
2021-01-11 02:15:33 +00:00
case Silvally:
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
{
cache form/species/format on first get very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
2020-01-17 03:23:29 +00:00
int silvally = GetSilvallyFormFromHeldItem(pkm.HeldItem);
return silvally != form ? GetInvalid(LFormItemInvalid) : GetValid(LFormItem);
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Minor clean
2021-01-11 02:15:33 +00:00
// Form doesn't exist in SM; cannot originate from that game.
Minor fixes Replace hardcoded move int with enum val Lillipup->Rockruff personal_swsh: remove pledge bitflags (missed in CT update)
2021-09-06 22:38:32 +00:00
case Rockruff when enc.Generation == 7 && form == 1 && pkm.SM:
Minor clean
2021-01-11 02:15:33 +00:00
case Lycanroc when enc.Generation == 7 && form == 2 && pkm.SM:
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LFormInvalidGame);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Enforce toxtricity encounters to have restricted nature
2020-02-08 23:08:12 +00:00
// Toxel encounters have already been checked for the nature-specific evolution criteria.
Minor clean
2021-01-11 02:15:33 +00:00
case Toxtricity when enc.Species == (int)Toxtricity:
Enforce toxtricity encounters to have restricted nature
2020-02-08 23:08:12 +00:00
{
// The game enforces the Nature for Toxtricity encounters too!
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
if (pkm.Form != EvolutionMethod.GetAmpLowKeyResult(pkm.Nature))
Enforce toxtricity encounters to have restricted nature
2020-02-08 23:08:12 +00:00
return GetInvalid(LFormInvalidNature);
break;
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
// Impossible Egg forms
Minor clean
2021-01-11 02:15:33 +00:00
case Rotom when pkm.IsEgg && form != 0:
case Furfrou when pkm.IsEgg && form != 0:
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LEggSpecies);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
// Party Only Forms
Minor clean
2021-01-11 02:15:33 +00:00
case Shaymin:
case Furfrou:
case Hoopa:
Track a PKM's Box,Slot,StorageFlags,Identifier metadata separately (#3222) * Track a PKM's Box,Slot,StorageFlags,Identifier metadata separately Don't store within the object, track the slot origin data separately. Batch editing now pre-filters if using Box/Slot/Identifier logic; split up mods/filters as they're starting to get pretty hefty. - Requesting a Box Data report now shows all slots in the save file (party, misc) - Can now exclude backup saves from database search via toggle (separate from settings preventing load entirely) - Replace some linq usages with direct code * Remove WasLink virtual in PKM Inline any logic, since we now have encounter objects to indicate matching, rather than the proto-legality logic checking properties of a PKM. * Use Fateful to directly check gen5 mysterygift origins No other encounter types in gen5 apply Fateful * Simplify double ball comparison Used to be separate for deferral cases, now no longer needed to be separate. * Grab move/relearn reference and update locally Fix relearn move identifier * Inline defog HM transfer preference check HasMove is faster than getting moves & checking contains. Skips allocation by setting values directly. * Extract more met location metadata checks: WasBredEgg * Replace Console.Write* with Debug.Write* There's no console output UI, so don't include them in release builds. * Inline WasGiftEgg, WasEvent, and WasEventEgg logic Adios legality tags that aren't entirely correct for the specific format. Just put the computations in EncounterFinder.
2021-06-23 03:23:48 +00:00
if (form != 0 && data.SlotOrigin is not SlotOrigin.Party && pkm.Format <= 6) // has form but stored in box
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LFormParty);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
break;
}
Extract battle form logic into a separate class format is included in the method call to futureproof, not currently necessary
2020-10-25 16:15:16 +00:00
var format = pkm.Format;
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
if (FormInfo.IsBattleOnlyForm(species, form, format))
Extract battle form logic into a separate class format is included in the method call to futureproof, not currently necessary
2020-10-25 16:15:16 +00:00
return GetInvalid(LFormBattle);
cache form/species/format on first get very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
2020-01-17 03:23:29 +00:00
if (form == 0)
return VALID;
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
// everything below here is not Form 0, so it has a form.
cache form/species/format on first get very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
2020-01-17 03:23:29 +00:00
if (format >= 7 && Info.Generation < 7)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Minor clean
2021-01-11 02:15:33 +00:00
if (species == 25 || Legal.AlolanOriginForms.Contains(species) || Legal.AlolanVariantEvolutions12.Contains(enc.Species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LFormInvalidGame);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
cache form/species/format on first get very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
2020-01-17 03:23:29 +00:00
if (format >= 8 && Info.Generation < 8)
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
{
Minor clean
2021-01-11 02:15:33 +00:00
var orig = enc.Species;
Add MrMime-1 check for past gen origin permit mime jr evolving to mr mime-1
2020-02-14 04:00:41 +00:00
if (Legal.GalarOriginForms.Contains(species) || Legal.GalarVariantFormEvolutions.Contains(orig))
handle alolan meowth origin in gen8 https://projectpokemon.org/home/forums/topic/56267-checks-associated-with-events-or-forms/
2020-02-14 01:05:06 +00:00
{
Minor clean
2021-01-11 02:15:33 +00:00
if (species == (int)Meowth && enc.Form != 2)
handle alolan meowth origin in gen8 https://projectpokemon.org/home/forums/topic/56267-checks-associated-with-events-or-forms/
2020-02-14 01:05:06 +00:00
{
// We're okay here. There's also Alolan Meowth...
}
Minor clean
2021-01-11 02:15:33 +00:00
else if (((Species)orig is MrMime or MimeJr) && pkm.CurrentLevel > enc.LevelMin && Info.Generation >= 4)
Add MrMime-1 check for past gen origin permit mime jr evolving to mr mime-1
2020-02-14 04:00:41 +00:00
{
// We're okay with a Mime Jr. that has evolved via level up.
}
Use more expression return style Reduces indentation & bracketing, a bit more concise
2021-01-02 01:08:49 +00:00
else if (enc.Version != GameVersion.GO)
handle alolan meowth origin in gen8 https://projectpokemon.org/home/forums/topic/56267-checks-associated-with-events-or-forms/
2020-02-14 01:05:06 +00:00
{
return GetInvalid(LFormInvalidGame);
}
}
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
return VALID;
}
Move some static arrays closer to where they're used Split EvolutionRestrictions to its own class Can probably refine things further to clamp down access to these arrays
2020-11-02 21:11:51 +00:00
private static readonly ushort[] Arceus_PlateIDs = { 303, 306, 304, 305, 309, 308, 310, 313, 298, 299, 301, 300, 307, 302, 311, 312, 644 };
private static readonly ushort[] Arceus_ZCrystal = { 782, 785, 783, 784, 788, 787, 789, 792, 777, 778, 780, 779, 786, 781, 790, 791, 793 };
Expose item->form methods
2020-02-08 05:34:25 +00:00
public static int GetArceusFormFromHeldItem(int item, int format)
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
{
Simplify some repeated comparisons with expressions Less prone for bugs since it uses the same value for all comparisons without re-specifying
2020-12-29 08:37:59 +00:00
if (item is >= 777 and <= 793)
Move some static arrays closer to where they're used Split EvolutionRestrictions to its own class Can probably refine things further to clamp down access to these arrays
2020-11-02 21:11:51 +00:00
return Array.IndexOf(Arceus_ZCrystal, (ushort)item) + 1;
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
int form = 0;
Simplify some repeated comparisons with expressions Less prone for bugs since it uses the same value for all comparisons without re-specifying
2020-12-29 08:37:59 +00:00
if (item is >= 298 and <= 313 or 644)
Move some static arrays closer to where they're used Split EvolutionRestrictions to its own class Can probably refine things further to clamp down access to these arrays
2020-11-02 21:11:51 +00:00
form = Array.IndexOf(Arceus_PlateIDs, (ushort)item) + 1;
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
if (format == 4 && form >= 9)
return form + 1; // ??? type Form shifts everything by 1
return form;
}
Expose item->form methods
2020-02-08 05:34:25 +00:00
public static int GetSilvallyFormFromHeldItem(int item)
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
{
Minor clean Condense some expressions Use less linq Rename some fields
2021-05-29 22:31:47 +00:00
if (item is >= 904 and <= 920)
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
return item - 903;
return 0;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Expose item->form methods
2020-02-08 05:34:25 +00:00
public static int GetGenesectFormFromHeldItem(int item)
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
{
Minor clean Condense some expressions Use less linq Rename some fields
2021-05-29 22:31:47 +00:00
if (item is >= 116 and <= 119)
Refactoring Simplify some verifier logic
2018-06-30 22:01:16 +00:00
return item - 115;
return 0;
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
private CheckResult VerifyFormArgument(LegalityAnalysis data, IFormArgument f)
Add form argument legality checks Closes #2611 (Alcremie) Closes #2604 (Runerigus)
2020-01-11 00:33:40 +00:00
{
var pkm = data.pkm;
Minor clean
2021-01-11 02:15:33 +00:00
var enc = data.EncounterMatch;
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
var arg = f.FormArgument;
var unusedMask = pkm.Format == 6 ? 0xFFFF_FF00 : 0xFF00_0000;
if ((arg & unusedMask) != 0)
return GetInvalid(LFormArgumentHigh);
Update formarg handling
2021-02-06 00:52:46 +00:00
Minor clean
2021-01-11 02:15:33 +00:00
return (Species)pkm.Species switch
Add form argument legality checks Closes #2611 (Alcremie) Closes #2604 (Runerigus)
2020-01-11 00:33:40 +00:00
{
Furfrou Bank edge cases lmao nice meme
2021-02-17 05:22:20 +00:00
// Transfer Edge Cases -- Bank wipes the form but keeps old FormArgument value.
Furfrou when pkm.Format == 7 && pkm.Form == 0 &&
((enc.Generation == 6 && f.FormArgument <= byte.MaxValue) || IsFormArgumentDayCounterValid(f, 5, true))
=> GetValid(LFormArgumentValid),
Update FormVerifier.cs
2021-02-09 07:18:45 +00:00
Furfrou when pkm.Form != 0 => !IsFormArgumentDayCounterValid(f, 5, true) ? GetInvalid(LFormArgumentInvalid) :GetValid(LFormArgumentValid),
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
Hoopa when pkm.Form == 1 => !IsFormArgumentDayCounterValid(f, 3) ? GetInvalid(LFormArgumentInvalid) : GetValid(LFormArgumentValid),
Minor clean
2021-01-11 02:15:33 +00:00
Yamask when pkm.Form == 1 => arg switch
{
not 0 when pkm.IsEgg => GetInvalid(LFormArgumentNotAllowed),
> 9_999 => GetInvalid(LFormArgumentHigh),
Trailing commas No functional change
2021-08-20 20:49:20 +00:00
_ => GetValid(LFormArgumentValid),
Minor clean
2021-01-11 02:15:33 +00:00
},
Runerigus when enc.Species == (int)Runerigus => arg switch
{
not 0 => GetInvalid(LFormArgumentNotAllowed),
Trailing commas No functional change
2021-08-20 20:49:20 +00:00
_ => GetValid(LFormArgumentValid),
Minor clean
2021-01-11 02:15:33 +00:00
},
Runerigus => arg switch // From Yamask-1
{
< 49 => GetInvalid(LFormArgumentLow),
> 9_999 => GetInvalid(LFormArgumentHigh),
Trailing commas No functional change
2021-08-20 20:49:20 +00:00
_ => GetValid(LFormArgumentValid),
Minor clean
2021-01-11 02:15:33 +00:00
},
Alcremie when enc.Species == (int)Alcremie => arg switch
{
not 0 => GetInvalid(LFormArgumentNotAllowed),
Trailing commas No functional change
2021-08-20 20:49:20 +00:00
_ => GetValid(LFormArgumentValid),
Minor clean
2021-01-11 02:15:33 +00:00
},
Alcremie => arg switch // From Milcery
{
> (uint) AlcremieDecoration.Ribbon => GetInvalid(LFormArgumentHigh),
Trailing commas No functional change
2021-08-20 20:49:20 +00:00
_ => GetValid(LFormArgumentValid),
Update PKHeX.Core abstractions with latest logic Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com> Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2022-02-05 01:35:15 +00:00
},
Overqwil when enc.Species == (int)Overqwil => arg switch
{
not 0 => GetInvalid(LFormArgumentNotAllowed),
_ => GetValid(LFormArgumentValid),
},
Wyrdeer when enc.Species == (int)Wyrdeer => arg switch
{
not 0 => GetInvalid(LFormArgumentNotAllowed),
_ => GetValid(LFormArgumentValid),
},
Basculegion when enc.Species == (int)Basculegion => arg switch
{
not 0 => GetInvalid(LFormArgumentNotAllowed),
_ => GetValid(LFormArgumentValid),
},
Basculin when pkm.Form is 2 => arg switch
{
not 0 when pkm.IsEgg => GetInvalid(LFormArgumentNotAllowed),
> 9_999 => GetInvalid(LFormArgumentHigh),
_ => GetValid(LFormArgumentValid),
},
Qwilfish when pkm.Form is 1 => arg switch
{
not 0 when pkm.IsEgg => GetInvalid(LFormArgumentNotAllowed),
> 9_999 => GetInvalid(LFormArgumentHigh),
_ => GetValid(LFormArgumentValid),
},
Stantler when pkm is PA8 => arg switch
{
not 0 when pkm.IsEgg => GetInvalid(LFormArgumentNotAllowed),
> 9_999 => GetInvalid(LFormArgumentHigh),
_ => GetValid(LFormArgumentValid),
},
Wyrdeer => arg switch // From Stantler
{
< 20 => GetInvalid(LFormArgumentLow),
> 9_999 => GetInvalid(LFormArgumentHigh),
_ => GetValid(LFormArgumentValid),
},
Overqwil => arg switch // From Qwilfish-1
{
< 20 => GetInvalid(LFormArgumentLow),
> 9_999 => GetInvalid(LFormArgumentHigh),
_ => GetValid(LFormArgumentValid),
},
Basculegion => arg switch // From Basculin-2
{
< 294 => GetInvalid(LFormArgumentLow),
> 9_999 => GetInvalid(LFormArgumentHigh),
_ => GetValid(LFormArgumentValid),
Minor clean
2021-01-11 02:15:33 +00:00
},
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
_ => VerifyFormArgumentNone(pkm, f),
Minor clean
2021-01-11 02:15:33 +00:00
};
Add form argument legality checks Closes #2611 (Alcremie) Closes #2604 (Runerigus)
2020-01-11 00:33:40 +00:00
}
Update FormVerifier.cs
2021-02-06 01:25:13 +00:00
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
private CheckResult VerifyFormArgumentNone(PKM pkm, IFormArgument f)
Update FormVerifier.cs
2021-02-06 01:25:13 +00:00
{
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
if (pkm is not PK6 pk6)
Update FormVerifier.cs
2021-02-09 07:18:45 +00:00
{
if (f.FormArgument != 0)
{
if (pkm.Species == (int)Furfrou && pkm.Form == 0 && (f.FormArgument & ~0xFF_00_00u) == 0)
return GetValid(LFormArgumentValid);
return GetInvalid(LFormArgumentNotAllowed);
}
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
return GetValid(LFormArgumentValid);
Update FormVerifier.cs
2021-02-09 07:18:45 +00:00
}
if (f.FormArgument != 0)
{
if (pkm.Species == (int)Furfrou && pkm.Form == 0 && (f.FormArgument & ~0xFFu) == 0)
return GetValid(LFormArgumentValid);
return GetInvalid(LFormArgumentNotAllowed);
}
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
// Stored separately from main form argument value
if (pk6.FormArgumentRemain != 0)
return GetInvalid(LFormArgumentNotAllowed);
if (pk6.FormArgumentElapsed != 0)
return GetInvalid(LFormArgumentNotAllowed);
return GetValid(LFormArgumentValid);
}
private static bool IsFormArgumentDayCounterValid(IFormArgument f, uint maxSeed, bool canRefresh = false)
{
var remain = f.FormArgumentRemain;
var elapsed = f.FormArgumentElapsed;
var maxElapsed = f.FormArgumentMaximum;
Update FormVerifier.cs
2021-02-06 01:25:13 +00:00
if (canRefresh)
{
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
if (maxElapsed < elapsed)
return false;
Update FormVerifier.cs
2021-02-06 01:25:13 +00:00
if (remain + elapsed < maxSeed)
return false;
}
else
{
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
if (maxElapsed != 0)
return false;
Update FormVerifier.cs
2021-02-06 01:25:13 +00:00
if (remain + elapsed != maxSeed)
return false;
}
if (remain > maxSeed)
return false;
return remain != 0;
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
}
Reference in a new issue Copy permalink