Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-20 09:23:17 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.WinForms/Controls/PKM Editor/EditPK5.cs

53 lines
1.4 KiB
C#
Raw Normal View History

Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
using PKHeX.Core;
Split out pk# population/retrieval
2016-07-09 23:17:55 +00:00
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
namespace PKHeX.WinForms.Controls
Split out pk# population/retrieval
2016-07-09 23:17:55 +00:00
{
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
public partial class PKMEditor
Split out pk# population/retrieval
2016-07-09 23:17:55 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void PopulateFieldsPK5()
Split out pk# population/retrieval
2016-07-09 23:17:55 +00:00
{
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
if (!(pkm is PK5 pk5))
Split out pk# population/retrieval
2016-07-09 23:17:55 +00:00
return;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
LoadMisc1(pk5);
LoadMisc2(pk5);
LoadMisc3(pk5);
LoadMisc4(pk5);
Split out pk# population/retrieval
2016-07-09 23:17:55 +00:00
CB_EncounterType.SelectedValue = pk5.Gen4 ? pk5.EncounterType : 0;
speed up pkm loading slightly PreparePKM had the opportunity to be recursive (preparation -> validating*N -> preparation*N), lock out preview sprite updating (which calls PreparePKM via Main.cs) while validating all controls remove uncallable paths (format is checked prior, and checksum check is never called as fieldsInitialized is forced false) move gui toggling to loading methods when appropriate
2017-10-26 02:37:31 +00:00
CB_EncounterType.Visible = Label_EncounterType.Visible = pkm.Gen4;
Redesign first 3 tabs of editor Uses many FlowLayoutPanel to automatically collapse controls so that when future properties are hidden, the remaining aren't 'randomly' spaced out. With the collapsing of controls, N's sparkle was added for gen5 pkm.
2016-09-05 21:26:21 +00:00
CHK_NSparkle.Checked = pk5.NPokémon;
Split out pk# population/retrieval
2016-07-09 23:17:55 +00:00
if (HaX)
DEV_Ability.SelectedValue = pk5.Ability;
else if (pk5.HiddenAbility)
CB_Ability.SelectedIndex = CB_Ability.Items.Count - 1;
else
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
LoadAbility4(pk5);
Implement PID-Ability corrections Line 2211: When the fields are loaded, if the user modifies the Ability on a <=Gen5 save file, if the ability is modified, the PID will be randomized to fit the new PID. When the Ability combobox is loaded, the personal entry may have 0 for the ability2 (indicating same as ability1); if so, copy ability1 instead of filtering it out. When the Ability index is loaded, hidden ability is checked first, else it tries to match: invalid, hidden (unflagged=illegal), if abilities same use PIDAbility, else use the actual ability index.
2016-08-23 03:37:50 +00:00
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
LoadPartyStats(pk5);
UpdateStats();
Split out pk# population/retrieval
2016-07-09 23:17:55 +00:00
}
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private PKM PreparePK5()
Split out pk# population/retrieval
2016-07-09 23:17:55 +00:00
{
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
if (!(pkm is PK5 pk5))
Split out pk# population/retrieval
2016-07-09 23:17:55 +00:00
return null;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
SaveMisc1(pk5);
SaveMisc2(pk5);
SaveMisc3(pk5);
SaveMisc4(pk5);
Split out pk# population/retrieval
2016-07-09 23:17:55 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pk5.EncounterType = WinFormsUtil.GetIndex(CB_EncounterType);
Redesign first 3 tabs of editor Uses many FlowLayoutPanel to automatically collapse controls so that when future properties are hidden, the remaining aren't 'randomly' spaced out. With the collapsing of controls, N's sparkle was added for gen5 pkm.
2016-09-05 21:26:21 +00:00
pk5.NPokémon = CHK_NSparkle.Checked;
Don't set HiddenAbility if HaX have user specify via 0x42 extrabyte as it can only be updated from there. closes #1846
2018-02-20 07:34:07 +00:00
if (!HaX) // specify via extra 0x42 instead
pk5.HiddenAbility = CB_Ability.SelectedIndex > 1; // not 0 or 1
Redesign first 3 tabs of editor Uses many FlowLayoutPanel to automatically collapse controls so that when future properties are hidden, the remaining aren't 'randomly' spaced out. With the collapsing of controls, N's sparkle was added for gen5 pkm.
2016-09-05 21:26:21 +00:00
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
SavePartyStats(pk5);
Split out pk# population/retrieval
2016-07-09 23:17:55 +00:00
pk5.FixMoves();
pk5.RefreshChecksum();
return pk5;
}
}
}
Reference in a new issue Copy permalink