Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-28 21:33:11 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Encounters/EncounterSlot.cs

220 lines
8.8 KiB
C#
Raw Normal View History

Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
using System;
namespace PKHeX.Core
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
add more pkhex.core xml documentation adds a bunch of documentation useful for those unfamiliar with the core library
2017-10-24 06:12:58 +00:00
/// <summary>
/// Wild Encounter Slot data
/// </summary>
Refactoring add IVersion interface with common interactions
2018-03-30 23:31:40 +00:00
public class EncounterSlot : IEncounterable, IGeneration, ILocation, IVersion
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
Minor refactoring Switch EncounterGeneric to IEncounterable. A way to tie together all encounters. Added a few setters for mystery gifts if the code is ever reused in other projects for that purpose. No functional change.
2017-01-05 06:25:45 +00:00
public int Species { get; set; }
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public int Form { get; set; }
Gen 1 move analysis improvement. Adapted the valid moves to take into account that move deleter and move reminder do not exits in generation 1 (#1037) * Fix getMoves with min level, when SkipWhile and TakeWhile is used together the index i in TakeWhile is calculated from the enumerator that results of the SkipWhile function, not the index of the initial array, those giving an incorrect index to check Levels array in the TakeWhile * Fix getMoves when levelmin or levelmax is above max level in the levels array, TakeWhile and SkipWhile return empty list if the while goes beyond the last element of the array * Include player hatched egg in the list of possible encounters for parseMoves only if the pokemon was an egg Also change the valur of WasEgg for gen1,2,3 pokemon if the encounter analyzed is not an egg add the non egg encounters to the list instead of checking the non-egg encounter inside parseMovesWasEggPreRelearn * Fix for gen3 egg encounters Remove non-egg encounters without special moves if there is an egg encounter because egg encounter already cover every possible move combination Do not add daycare egg encounter for gen3 unhatched egg if there is another encounter, that means is an event or gift egg, not a daycare egg Remove duplicate encounters * Gift egg should not allow inherited moves even it they dont have special moves Those gift eggs are hatched only with the species base moves * Added getEncounterMoves functions, to be used for generation 1 encounters to find what moves have a pokemon at the moment of being caught because there is no move reminder in generation 1 * Added GBEncounterData, structure for refactor the tuples used in generation 1 and 2 encounters * Add LevelMin and LevelMax to IEncounterable to get the encounter moves by the min level of the generation 1 EncounterLink Add iGeneration to difference generation 1 and generation 2 encounters for GB Era pokemon * Mark generation in gen 1 and 2 encounters There is no need to mark the generation in gen 3 to 7 encounters because in that generations it match the pokemon generation number * Add min level for generation 1 moves in getMoves functions Add function to return the default moves for a GB encounters, for generation 1 games that included both moves from level up table and level 1 moves from personal table Fix getMoves with min level when the moves list is empty, like Raichu generation 1 * Add maxSpecies to getBaseSpecies function for gen1 pokemon with a gen2 egg encounter Refactor VC Encounter changing Tuples for GBData class * Fixed for gen 2 Checks Also do not search for generation1 encounter if the gen2 pokemon have met location from crystal * Fix VC wild encounters, should be stored as array or else other verifyEncounter functions wont work * Add generation 1 parse moves function including default moves * Clean-up get encounters * Verify empty moves for generation 1 encounters, in generation 1 does not exits move deleter That means when a move slot have been used by a level up move or a TM/HM/Tutor move it cant be empty again Does not apply if generation 2 tradeback is allowed, in generation 2 there is a move deleter * Added two edge cases for pokemon that learn in red/blue and yellow different moves at the same level, this combinations can not exits until a later level when they learn again one of the levels in the other game, only happen for flareon and vaporeon * Check incompatible moves between evolution species, it is for species that learn a move in a level as an evolved species and a move at a upper level as a preevolution Also added most edge cases for the min slots used for generation 1 games, i think every weird combination is already covered * Fix gen 1 eevee and evolutions move checks * Cleanup * Move the code to change valid moves for generation 1 to a function * Fix getMoveMinLevelGBEncounter * getUsedMoveSlots, removed wild Butterfree edge case, it is not possible * Filter the min level of the encounter by the possible games the pokemon could be originated, yellow pikachu and kadabra can be detected
2017-04-09 00:17:20 +00:00
public int LevelMin { get; set; }
public int LevelMax { get; set; }
Split encounter areas, relocate slot finding to obj Now logic is reasonably split, and each format of area has its own way of yielding slots Too much junk with checking flute boosts or catch combo applicability; just let the area dictate how slots match.
2019-09-13 06:20:52 +00:00
Fix flute level amp direction The inputs to "IsLevelWithinRange" are the highest value the lowest-level can be, and the lowest value the highest level can be... seems confusing (hence the original error). If a slot is 6-7, with a wild encounter (flute), we can go +/-3 from 6-7, which is 3-10. With an encounter of level 5, the inputs are: 5+3, and 5-3 (8, 2). Since 8>lvlmin and 2<lvlhi, we can get a level 5 pkm from the slot (using a negative flute yielding a -1 adjustment). I could probably refactor it to be a 3-input signature (lvl, lvlneg, lvlpos), and have it do LevelMin - lvlneg <= lvl && lvl <= LevelMax + lvlpos I should probably refactor these methods to do minLevel & maxLevel (so baseSpecies.Level to CurrentLevel for pkm that lost their original met data) but nothing needs the extra logic at this time.
2019-09-20 05:37:56 +00:00
/// <summary>
/// Gets if the specified level inputs are within range of the <see cref="LevelMin"/> and <see cref="LevelMax"/>
/// </summary>
/// <param name="lvl">Single level</param>
/// <returns>True if within slot's range, false if impossible.</returns>
Split encounter areas, relocate slot finding to obj Now logic is reasonably split, and each format of area has its own way of yielding slots Too much junk with checking flute boosts or catch combo applicability; just let the area dictate how slots match.
2019-09-13 06:20:52 +00:00
public bool IsLevelWithinRange(int lvl) => LevelMin <= lvl && lvl <= LevelMax;
Fix flute level amp direction The inputs to "IsLevelWithinRange" are the highest value the lowest-level can be, and the lowest value the highest level can be... seems confusing (hence the original error). If a slot is 6-7, with a wild encounter (flute), we can go +/-3 from 6-7, which is 3-10. With an encounter of level 5, the inputs are: 5+3, and 5-3 (8, 2). Since 8>lvlmin and 2<lvlhi, we can get a level 5 pkm from the slot (using a negative flute yielding a -1 adjustment). I could probably refactor it to be a 3-input signature (lvl, lvlneg, lvlpos), and have it do LevelMin - lvlneg <= lvl && lvl <= LevelMax + lvlpos I should probably refactor these methods to do minLevel & maxLevel (so baseSpecies.Level to CurrentLevel for pkm that lost their original met data) but nothing needs the extra logic at this time.
2019-09-20 05:37:56 +00:00
/// <summary>
/// Gets if the specified level inputs are within range of the <see cref="LevelMin"/> and <see cref="LevelMax"/>
/// </summary>
/// <param name="min">Highest value the low end of levels can be</param>
/// <param name="max">Lowest value the high end of levels can be</param>
/// <returns>True if within slot's range, false if impossible.</returns>
Split encounter areas, relocate slot finding to obj Now logic is reasonably split, and each format of area has its own way of yielding slots Too much junk with checking flute boosts or catch combo applicability; just let the area dictate how slots match.
2019-09-13 06:20:52 +00:00
public bool IsLevelWithinRange(int min, int max) => LevelMin <= min && max <= LevelMax;
Use less efficient IsLevelWithinRange, for clarity See previous commit for discussion; it's easier to read and maintain this rather than have the precomputed min/max comparisons. LevelMin - minDecrease <= min && max <= LevelMax + maxIncrease; See EncounterArea7b: Since we know min and minDecrease (0) before doing the linq filter we can precompute the lowbound, same for highbound; but this isn't immediately obvious to the reader. The perf cost is pretty much negligible in the big picture, so leave it in the more readable state. Thanks @fattard & @ammako ! #2389
2019-09-20 05:54:53 +00:00
/// <summary>
/// Gets if the specified level inputs are within range of the <see cref="LevelMin"/> and <see cref="LevelMax"/>
/// </summary>
/// <param name="lvl">Single level</param>
/// <param name="minDecrease">Highest value the low end of levels can be</param>
/// <param name="maxIncrease">Lowest value the high end of levels can be</param>
/// <returns>True if within slot's range, false if impossible.</returns>
public bool IsLevelWithinRange(int lvl, int minDecrease, int maxIncrease) => LevelMin - minDecrease <= lvl && lvl <= LevelMax + maxIncrease;
/// <summary>
/// Gets if the specified level inputs are within range of the <see cref="LevelMin"/> and <see cref="LevelMax"/>
/// </summary>
/// <param name="min">Lowest level allowed</param>
/// <param name="max">Highest level allowed</param>
/// <param name="minDecrease">Highest value the low end of levels can be</param>
/// <param name="maxIncrease">Lowest value the high end of levels can be</param>
/// <returns>True if within slot's range, false if impossible.</returns>
public bool IsLevelWithinRange(int min, int max, int minDecrease, int maxIncrease) => LevelMin - minDecrease <= min && max <= LevelMax + maxIncrease;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public SlotType Type { get; set; } = SlotType.Any;
public EncounterType TypeEncounter { get; set; } = EncounterType.None;
public int SlotNumber { get; set; }
Gen 1 move analysis improvement. Adapted the valid moves to take into account that move deleter and move reminder do not exits in generation 1 (#1037) * Fix getMoves with min level, when SkipWhile and TakeWhile is used together the index i in TakeWhile is calculated from the enumerator that results of the SkipWhile function, not the index of the initial array, those giving an incorrect index to check Levels array in the TakeWhile * Fix getMoves when levelmin or levelmax is above max level in the levels array, TakeWhile and SkipWhile return empty list if the while goes beyond the last element of the array * Include player hatched egg in the list of possible encounters for parseMoves only if the pokemon was an egg Also change the valur of WasEgg for gen1,2,3 pokemon if the encounter analyzed is not an egg add the non egg encounters to the list instead of checking the non-egg encounter inside parseMovesWasEggPreRelearn * Fix for gen3 egg encounters Remove non-egg encounters without special moves if there is an egg encounter because egg encounter already cover every possible move combination Do not add daycare egg encounter for gen3 unhatched egg if there is another encounter, that means is an event or gift egg, not a daycare egg Remove duplicate encounters * Gift egg should not allow inherited moves even it they dont have special moves Those gift eggs are hatched only with the species base moves * Added getEncounterMoves functions, to be used for generation 1 encounters to find what moves have a pokemon at the moment of being caught because there is no move reminder in generation 1 * Added GBEncounterData, structure for refactor the tuples used in generation 1 and 2 encounters * Add LevelMin and LevelMax to IEncounterable to get the encounter moves by the min level of the generation 1 EncounterLink Add iGeneration to difference generation 1 and generation 2 encounters for GB Era pokemon * Mark generation in gen 1 and 2 encounters There is no need to mark the generation in gen 3 to 7 encounters because in that generations it match the pokemon generation number * Add min level for generation 1 moves in getMoves functions Add function to return the default moves for a GB encounters, for generation 1 games that included both moves from level up table and level 1 moves from personal table Fix getMoves with min level when the moves list is empty, like Raichu generation 1 * Add maxSpecies to getBaseSpecies function for gen1 pokemon with a gen2 egg encounter Refactor VC Encounter changing Tuples for GBData class * Fixed for gen 2 Checks Also do not search for generation1 encounter if the gen2 pokemon have met location from crystal * Fix VC wild encounters, should be stored as array or else other verifyEncounter functions wont work * Add generation 1 parse moves function including default moves * Clean-up get encounters * Verify empty moves for generation 1 encounters, in generation 1 does not exits move deleter That means when a move slot have been used by a level up move or a TM/HM/Tutor move it cant be empty again Does not apply if generation 2 tradeback is allowed, in generation 2 there is a move deleter * Added two edge cases for pokemon that learn in red/blue and yellow different moves at the same level, this combinations can not exits until a later level when they learn again one of the levels in the other game, only happen for flareon and vaporeon * Check incompatible moves between evolution species, it is for species that learn a move in a level as an evolved species and a move at a upper level as a preevolution Also added most edge cases for the min slots used for generation 1 games, i think every weird combination is already covered * Fix gen 1 eevee and evolutions move checks * Cleanup * Move the code to change valid moves for generation 1 to a function * Fix getMoveMinLevelGBEncounter * getUsedMoveSlots, removed wild Butterfree edge case, it is not possible * Filter the min level of the encounter by the possible games the pokemon could be originated, yellow pikachu and kadabra can be detected
2017-04-09 00:17:20 +00:00
public int Generation { get; set; } = -1;
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
private EncounterSlotPermissions? _perm;
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
public EncounterSlotPermissions Permissions => _perm ??= new EncounterSlotPermissions();
Refactoring add IVersion interface with common interactions
2018-03-30 23:31:40 +00:00
public GameVersion Version { get; set; }
Evolution check fixes Evolution info was not checked for non-eggs; for mystery gifts check that the level of the evolution is not less than the level of the matched encounter fix spacing (cosmetic) add temp flagging for magnetpull/static slots (will eventually refactor into something functional that considers a set of slots including swarm/etc)
2017-05-17 04:09:53 +00:00
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
internal EncounterArea? Area { private get; set; }
public int Location { get => Area?.Location ?? 0; set { } }
add location interface for verbose analysis output indicates met location for transferred mons most gen1/2 encounters won't show values due to the location not being stored respective to the string tables (anyone wanna do a location remap after initial load?)
2018-01-02 20:00:41 +00:00
public bool EggEncounter => false;
public int EggLocation { get => 0; set { } }
update static/magnet slot permutations using certain slot modifiers (swarm/game pak) causes different arrangements of slots for different static/magnet pull groups to pull from store a list of permuted/different slots and add them to the table at the end with the rest move static/magnet pull marking into gen4 methods (only leave for gen3) move trophy slot generation into gen4dppt area fetch (necessary for static/magnet permuting) fix electric off-by-one (yay for curse ??? type shifting everything)
2017-12-03 20:20:49 +00:00
public EncounterSlot Clone()
{
var slot = (EncounterSlot) MemberwiseClone();
if (_perm != null)
slot._perm = Permissions.Clone();
return slot;
}
Add origin seed for frame output looks like for gen4 I have to yield twice as many frames (for FixedLevel and non) as level call usage is dependent on encounter
2017-12-02 00:33:03 +00:00
public bool FixedLevel => LevelMin == LevelMax;
Refactoring Move fossils check to static encounter apply small amount of inheritance to all encounter types (including mystery gifts) get actual evolution chain to ignore pre-evolution movepools (example Surf Pikachu event gift cannot devolve to Pichu to get Nasty Plot). #694 A little bit of logic has been moved around, but my 5k pkmdb had no change in legal/illegal counts. Hopefully no false positives from this change :thumbsup:
2017-01-04 04:51:33 +00:00
update static/magnet slot permutations using certain slot modifiers (swarm/game pak) causes different arrangements of slots for different static/magnet pull groups to pull from store a list of permuted/different slots and add them to the table at the end with the rest move static/magnet pull marking into gen4 methods (only leave for gen3) move trophy slot generation into gen4dppt area fetch (necessary for static/magnet permuting) fix electric off-by-one (yay for curse ??? type shifting everything)
2017-12-03 20:20:49 +00:00
public bool IsMatchStatic(int index, int count) => index == Permissions.StaticIndex && count == Permissions.StaticCount;
public bool IsMatchMagnet(int index, int count) => index == Permissions.MagnetPullIndex && count == Permissions.MagnetPullCount;
Add weather indication to detailed parse output
2019-11-28 20:56:26 +00:00
private protected const string wild = "Wild Encounter";
Add short/long name property differentiation
2019-03-18 05:19:37 +00:00
public string Name => wild;
Add weather indication to detailed parse output
2019-11-28 20:56:26 +00:00
public virtual string LongName
Further tweaks Handle terminated strings better for 1->7 Indicate RBY encounter origins when transferred to 7+. Remove check duplication
2017-02-15 06:06:15 +00:00
{
get
{
if (Type == SlotType.Any)
return wild;
"" -> string.Empty be explicit that the string is empty rather than possibly missing disallow encrypted export for BK4 (they're not encrypted), removes type check simplify replaceall in showdownset (don't call ReplaceAll 4x, just get valid chars and rebuild) simplify get ribbon sprite name (precompute ToLower and appended values
2019-02-08 05:40:20 +00:00
return $"{wild} {Type.ToString().Replace('_', ' ')}";
Further tweaks Handle terminated strings better for 1->7 Indicate RBY encounter origins when transferred to 7+. Remove check duplication
2017-02-15 06:06:15 +00:00
}
}
Add IEncounterable -> pkm interface method egg,slot,static,link,trade need to be implemented later remove IEncounterable from PL6
2018-03-29 03:38:07 +00:00
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
public PKM ConvertToPKM(ITrainerInfo SAV) => ConvertToPKM(SAV, EncounterCriteria.Unrestricted);
public PKM ConvertToPKM(ITrainerInfo SAV, EncounterCriteria criteria)
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
{
var version = this.GetCompatibleVersion((GameVersion)SAV.Game);
Extract logic from PKX Extract Species Name logic to SpeciesName Extract Language logic to Language Remove FormConverter wrapper for string[] fetch Rearrange some logic to more appropriate locations, update access modifiers / types Move some pkm array methods to arrayutil, make generic PKX.GetVCLanguage was a dupe of _K12.GuessedLanguage() so just expose the method PKX is now back to pkm data manip only
2019-09-19 02:58:23 +00:00
int lang = (int)Language.GetSafeLanguage(Generation, (LanguageID)SAV.Language);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
int level = LevelMin;
Fix broken tests rework getblank for version specific
2018-11-20 00:14:49 +00:00
var pk = PKMConverter.GetBlank(Generation, Version);
Refactoring & finish eevee test case generates a legal pk* for every possible encounter; there's likely other scenarios and more roughness to smooth out, but seems legit for now
2018-04-01 03:37:36 +00:00
SAV.ApplyToPKM(pk);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
pk.Species = Species;
pk.Language = lang;
pk.CurrentLevel = level;
Misc encounter->pkm generating fixes eggs for Gen1 must be generated in Gen2 gen1 wild encounter initial moves gen4 abilities have 0 for single ability mons
2018-04-28 23:30:56 +00:00
pk.Version = (int)version;
Extract logic from PKX Extract Species Name logic to SpeciesName Extract Language logic to Language Remove FormConverter wrapper for string[] fetch Rearrange some logic to more appropriate locations, update access modifiers / types Move some pkm array methods to arrayutil, make generic PKX.GetVCLanguage was a dupe of _K12.GuessedLanguage() so just expose the method PKX is now back to pkm data manip only
2019-09-19 02:58:23 +00:00
pk.Nickname = SpeciesName.GetSpeciesNameGeneration(Species, lang, Generation);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
pk.Ball = (int)Type.GetBall();
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
pk.Language = lang;
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
pk.OT_Friendship = pk.PersonalInfo.BaseFriendship;
pk.AltForm = GetWildAltForm(pk, Form, SAV);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
SetMetData(pk, level, Location);
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
SetPINGA(pk, criteria);
SetEncounterMoves(pk, version, level);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
SetFormatSpecificData(pk);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
if (pk.Format < 6)
return pk;
SAV.ApplyHandlingTrainerInfo(pk);
pk.SetRandomEC();
return pk;
}
More generator fixes/improvements Fix/add missing gameversion references (BU instead of BW, pokewalker=HGSS) increase reuse of pidgenerator & add more generating methods. seems like it's generating pkm fine besides the PID edge cases, which is nice
2018-04-29 16:31:13 +00:00
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
private void SetEncounterMoves(PKM pk, GameVersion version, int level)
{
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
var moves = this is IMoveset m ? m.Moves : MoveLevelUp.GetEncounterMoves(pk, level, version);
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.Moves = moves;
pk.SetMaximumPPCurrent(moves);
}
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
private void SetFormatSpecificData(PKM pk)
{
if (pk is PK1 pk1)
{
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if (Species == (int)Core.Species.Kadabra && Version == GameVersion.YW) // Kadabra
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
pk1.Catch_Rate = 96;
else if (Species == 148 && Version == GameVersion.YW) // Dragonair
pk1.Catch_Rate = 27;
else
pk1.Catch_Rate = PersonalTable.RB[Species].CatchRate; // RB
}
else if (pk is PK2 pk2)
{
if (Version == GameVersion.C && this is EncounterSlot1 slot)
pk2.Met_TimeOfDay = slot.Time.RandomValidTime();
}
else if (pk is XK3 xk3)
{
xk3.FatefulEncounter = true; // PokeSpot
}
else if (pk is PK4 pk4)
{
pk4.EncounterType = TypeEncounter.GetIndex();
}
else if (pk is PK6 pk6)
{
if (Permissions.IsDexNav)
{
Add Form (AltForm) to IEncounterable interface All of the encounterable templates have Form anyway; funny that I was consistent naming them all differently than pkm.AltForm :) Closes #2452
2019-11-19 06:20:55 +00:00
var eggMoves = MoveEgg.GetEggMoves(pk, Species, Form, Version);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
if (eggMoves.Length > 0)
pk6.RelearnMove1 = eggMoves[Util.Rand.Next(eggMoves.Length)];
}
pk.SetRandomMemory6();
}
}
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
private void SetPINGA(PKM pk, EncounterCriteria criteria)
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
{
int gender = criteria.GetGender(-1, pk.PersonalInfo);
int nature = (int)criteria.GetNature(Nature.Random);
var ability = Util.Rand.Next(2);
if (Type == SlotType.HiddenGrotto) // don't force hidden for DexNav
ability = 2;
var pidtype = GetPIDType();
if (pidtype == PIDType.PokeSpot)
PIDGenerator.SetRandomPokeSpotPID(pk, nature, gender, ability, SlotNumber);
else
PIDGenerator.SetRandomWildPID(pk, pk.Format, nature, ability, gender, pidtype);
pk.Gender = gender;
}
private void SetMetData(PKM pk, int level, int location)
{
if (pk.Format <= 2 && Version != GameVersion.C)
return;
pk.Met_Location = location;
pk.Met_Level = level;
if (pk.Format >= 4)
pk.MetDate = DateTime.Today;
}
private static int GetWildAltForm(PKM pk, int form, ITrainerInfo SAV)
Finish rough generator * handle gen6+ egg case where egg move count < 4 (cannot displace Levelup lvl1 moves) * handle minior altform case generates all species/encounters possible, yielding 144,094 pkm files (all detected as legal!)
2018-05-10 02:21:44 +00:00
{
Misc clean split some methods with optional parameters=null add more xmldoc replace some magic numbers -> enum/const references consolidate common array operations (span soon maybe?)
2019-09-10 07:21:51 +00:00
if (form < 30) // specified form
Finish rough generator * handle gen6+ egg case where egg move count < 4 (cannot displace Levelup lvl1 moves) * handle minior altform case generates all species/encounters possible, yielding 144,094 pkm files (all detected as legal!)
2018-05-10 02:21:44 +00:00
{
Bump lang version to 8 some lang upgrades
2019-10-05 03:10:50 +00:00
if (pk.Species == (int) Core.Species.Minior)
return Util.Rand.Next(7, 14);
return form;
Finish rough generator * handle gen6+ egg case where egg move count < 4 (cannot displace Levelup lvl1 moves) * handle minior altform case generates all species/encounters possible, yielding 144,094 pkm files (all detected as legal!)
2018-05-10 02:21:44 +00:00
}
Misc clean split some methods with optional parameters=null add more xmldoc replace some magic numbers -> enum/const references consolidate common array operations (span soon maybe?)
2019-09-10 07:21:51 +00:00
if (form == 31) // flagged as totally random
Finish rough generator * handle gen6+ egg case where egg move count < 4 (cannot displace Levelup lvl1 moves) * handle minior altform case generates all species/encounters possible, yielding 144,094 pkm files (all detected as legal!)
2018-05-10 02:21:44 +00:00
return Util.Rand.Next(pk.PersonalInfo.FormeCount);
Misc clean split some methods with optional parameters=null add more xmldoc replace some magic numbers -> enum/const references consolidate common array operations (span soon maybe?)
2019-09-10 07:21:51 +00:00
int spec = pk.Species;
if (spec == (int)Core.Species.Scatterbug || spec == (int)Core.Species.Spewpa || spec == (int)Core.Species.Vivillon)
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
return Legal.GetVivillonPattern((byte)SAV.Country, (byte)SAV.SubRegion);
Finish rough generator * handle gen6+ egg case where egg move count < 4 (cannot displace Levelup lvl1 moves) * handle minior altform case generates all species/encounters possible, yielding 144,094 pkm files (all detected as legal!)
2018-05-10 02:21:44 +00:00
return 0;
}
More generator fixes/improvements Fix/add missing gameversion references (BU instead of BW, pokewalker=HGSS) increase reuse of pidgenerator & add more generating methods. seems like it's generating pkm fine besides the PID edge cases, which is nice
2018-04-29 16:31:13 +00:00
private PIDType GetPIDType()
{
if (Version == GameVersion.XD)
return PIDType.PokeSpot;
return PIDType.None; // depends on format, let the program auto-detect.
}
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
}
}
Reference in a new issue Copy permalink