2019-09-03 02:30:58 +00:00
|
|
|
|
using System;
|
PKHeX.Core Nullable cleanup (#2401)
* Handle some nullable cases
Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization
* Handle bits more obviously without null
* Make SaveFile.BAK explicitly readonly again
* merge constructor methods to have readonly fields
* Inline some properties
* More nullable handling
* Rearrange box actions
define straightforward classes to not have any null properties
* Make extrabyte reference array immutable
* Move tooltip creation to designer
* Rearrange some logic to reduce nesting
* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum
* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case
* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable
* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator
* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever
* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)
* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
|
|
|
|
using System.Collections.Generic;
|
2019-09-03 02:30:58 +00:00
|
|
|
|
|
|
|
|
|
namespace PKHeX.Core
|
|
|
|
|
{
|
|
|
|
|
/// <summary>
|
|
|
|
|
/// <see cref="SaveFile"/> format for <see cref="GameVersion.HGSS"/>
|
|
|
|
|
/// </summary>
|
|
|
|
|
public sealed class SAV4HGSS : SAV4
|
|
|
|
|
{
|
2021-05-29 22:31:47 +00:00
|
|
|
|
public SAV4HGSS() : base(GeneralSize, StorageSize)
|
2021-02-21 17:59:10 +00:00
|
|
|
|
{
|
|
|
|
|
Initialize();
|
|
|
|
|
Dex = new Zukan4(this, PokeDex);
|
|
|
|
|
}
|
|
|
|
|
|
2021-05-29 22:31:47 +00:00
|
|
|
|
public SAV4HGSS(byte[] data) : base(data, GeneralSize, StorageSize, GeneralSize + GeneralGap)
|
2021-02-21 17:59:10 +00:00
|
|
|
|
{
|
|
|
|
|
Initialize();
|
|
|
|
|
Dex = new Zukan4(this, PokeDex);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public override Zukan4 Dex { get; }
|
2020-12-05 13:36:23 +00:00
|
|
|
|
protected override SAV4 CloneInternal4() => State.Exportable ? new SAV4HGSS(Data) : new SAV4HGSS();
|
2019-09-03 02:30:58 +00:00
|
|
|
|
|
PKHeX.Core Nullable cleanup (#2401)
* Handle some nullable cases
Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization
* Handle bits more obviously without null
* Make SaveFile.BAK explicitly readonly again
* merge constructor methods to have readonly fields
* Inline some properties
* More nullable handling
* Rearrange box actions
define straightforward classes to not have any null properties
* Make extrabyte reference array immutable
* Move tooltip creation to designer
* Rearrange some logic to reduce nesting
* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum
* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case
* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable
* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator
* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever
* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)
* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
|
|
|
|
public override PersonalTable Personal => PersonalTable.HGSS;
|
|
|
|
|
public override IReadOnlyList<ushort> HeldItems => Legal.HeldItems_HGSS;
|
2021-03-14 23:16:55 +00:00
|
|
|
|
public override int MaxItemID => Legal.MaxItemID_4_HGSS;
|
2021-05-29 22:31:47 +00:00
|
|
|
|
private const int GeneralSize = 0xF628;
|
|
|
|
|
private const int StorageSize = 0x12310; // Start 0xF700, +0 starts box data
|
|
|
|
|
private const int GeneralGap = 0xD8;
|
2019-09-03 02:30:58 +00:00
|
|
|
|
protected override int StorageStart => 0xF700; // unused section right after GeneralSize, alignment?
|
2019-09-04 01:16:10 +00:00
|
|
|
|
protected override int FooterSize => 0x10;
|
2019-09-03 02:30:58 +00:00
|
|
|
|
|
|
|
|
|
private void Initialize()
|
|
|
|
|
{
|
|
|
|
|
Version = GameVersion.HGSS;
|
|
|
|
|
GetSAVOffsets();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private void GetSAVOffsets()
|
|
|
|
|
{
|
|
|
|
|
AdventureInfo = 0;
|
|
|
|
|
Trainer1 = 0x64;
|
|
|
|
|
Party = 0x98;
|
|
|
|
|
PokeDex = 0x12B8;
|
|
|
|
|
WondercardFlags = 0x9D3C;
|
|
|
|
|
WondercardData = 0x9E3C;
|
|
|
|
|
|
|
|
|
|
EventConst = 0xDE4;
|
|
|
|
|
EventFlag = 0x10C4;
|
2019-10-19 03:42:03 +00:00
|
|
|
|
DaycareOffset = 0x15FC;
|
2019-09-03 02:30:58 +00:00
|
|
|
|
Seal = 0x4E20;
|
|
|
|
|
|
|
|
|
|
Box = 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#region Storage
|
|
|
|
|
// box{pk4[30}[18]
|
|
|
|
|
// u32 currentBox
|
|
|
|
|
// u32 counter
|
|
|
|
|
// g4str[18] boxNames
|
|
|
|
|
// byte[18] boxWallpapers
|
|
|
|
|
// -- each box is chunked, padded to nearest 0x100 (resulting in 0x10 trailing zeroes)
|
|
|
|
|
// -- The final 0x16 bytes in the Storage block are unused (padding to nearest 0x100).
|
|
|
|
|
private const int BOX_COUNT = 18;
|
|
|
|
|
private const int BOX_SLOTS = 30;
|
|
|
|
|
private const int BOX_NAME_LEN = 40; // 20 characters
|
|
|
|
|
|
2020-01-04 22:48:39 +00:00
|
|
|
|
private const int BOX_DATA_LEN = (BOX_SLOTS * PokeCrypto.SIZE_4STORED) + 0x10; // 0xFF0, each box chunk is padded to nearest 0x100
|
2019-09-03 02:30:58 +00:00
|
|
|
|
private const int BOX_END = BOX_COUNT * BOX_DATA_LEN; // 18 * 0x1000
|
|
|
|
|
private const int BOX_NAME = 0x12008; // after current & counter
|
|
|
|
|
private const int BOX_WP = BOX_NAME + (BOX_COUNT * BOX_NAME_LEN); // 0x122D8;
|
2019-11-20 19:39:31 +00:00
|
|
|
|
private const int BOX_FLAGS = 18 + BOX_WP; // 0x122EA;
|
2019-09-03 02:30:58 +00:00
|
|
|
|
|
|
|
|
|
public override int GetBoxOffset(int box) => box * 0x1000;
|
|
|
|
|
private static int GetBoxNameOffset(int box) => BOX_NAME + (box * BOX_NAME_LEN);
|
|
|
|
|
protected override int GetBoxWallpaperOffset(int box) => BOX_WP + box;
|
|
|
|
|
|
2019-10-05 21:32:40 +00:00
|
|
|
|
// 8 bytes current box (align 32) & (stored count?)
|
2019-09-03 02:30:58 +00:00
|
|
|
|
public override int CurrentBox
|
|
|
|
|
{
|
2019-10-05 21:32:40 +00:00
|
|
|
|
get => Storage[BOX_END];
|
|
|
|
|
set => Storage[BOX_END] = (byte)value;
|
2019-09-03 02:30:58 +00:00
|
|
|
|
}
|
|
|
|
|
|
2019-11-20 19:39:31 +00:00
|
|
|
|
public override byte[] BoxFlags
|
|
|
|
|
{
|
|
|
|
|
get => new[] { Storage[BOX_FLAGS] };
|
|
|
|
|
set => Storage[BOX_FLAGS] = value[0];
|
|
|
|
|
}
|
|
|
|
|
|
2019-09-03 02:30:58 +00:00
|
|
|
|
public int Counter
|
|
|
|
|
{
|
|
|
|
|
get => BitConverter.ToInt32(Storage, BOX_END + 4);
|
|
|
|
|
set => SetData(Storage, BitConverter.GetBytes(value), BOX_END + 4);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public override string GetBoxName(int box) => GetString(Storage, GetBoxNameOffset(box), BOX_NAME_LEN);
|
|
|
|
|
|
|
|
|
|
public override void SetBoxName(int box, string value)
|
|
|
|
|
{
|
2019-11-19 00:01:36 +00:00
|
|
|
|
const int maxlen = 8;
|
2019-09-03 02:30:58 +00:00
|
|
|
|
if (value.Length > maxlen)
|
2021-05-14 22:30:55 +00:00
|
|
|
|
value = value[..maxlen]; // Hard cap
|
2019-09-03 02:30:58 +00:00
|
|
|
|
int offset = GetBoxNameOffset(box);
|
|
|
|
|
var str = SetString(value, maxlen);
|
|
|
|
|
SetData(Storage, str, offset);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private static int AdjustWallpaper(int value, int shift)
|
|
|
|
|
{
|
|
|
|
|
// Pt's Special Wallpapers 1-8 are shifted by +0x8
|
|
|
|
|
// HG/SS Special Wallpapers 1-8 (Primo Phrases) are shifted by +0x10
|
|
|
|
|
if (value >= 0x10) // special
|
|
|
|
|
return value + shift;
|
|
|
|
|
return value;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public override int GetBoxWallpaper(int box)
|
|
|
|
|
{
|
2020-02-12 07:24:03 +00:00
|
|
|
|
int offset = GetBoxWallpaperOffset(box);
|
2019-09-03 02:30:58 +00:00
|
|
|
|
int value = Storage[offset];
|
|
|
|
|
return AdjustWallpaper(value, -0x10);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public override void SetBoxWallpaper(int box, int value)
|
|
|
|
|
{
|
|
|
|
|
value = AdjustWallpaper(value, 0x10);
|
|
|
|
|
Storage[GetBoxWallpaperOffset(box)] = (byte)value;
|
|
|
|
|
}
|
|
|
|
|
#endregion
|
|
|
|
|
|
2020-12-05 14:09:33 +00:00
|
|
|
|
public override IReadOnlyList<InventoryPouch> Inventory
|
PKHeX.Core Nullable cleanup (#2401)
* Handle some nullable cases
Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization
* Handle bits more obviously without null
* Make SaveFile.BAK explicitly readonly again
* merge constructor methods to have readonly fields
* Inline some properties
* More nullable handling
* Rearrange box actions
define straightforward classes to not have any null properties
* Make extrabyte reference array immutable
* Move tooltip creation to designer
* Rearrange some logic to reduce nesting
* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum
* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case
* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable
* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator
* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever
* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)
* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
|
|
|
|
{
|
|
|
|
|
get
|
|
|
|
|
{
|
|
|
|
|
InventoryPouch[] pouch =
|
|
|
|
|
{
|
|
|
|
|
new InventoryPouch4(InventoryType.Items, Legal.Pouch_Items_HGSS, 999, 0x644), // 0x644-0x8D7 (0x8CB)
|
|
|
|
|
new InventoryPouch4(InventoryType.KeyItems, Legal.Pouch_Key_HGSS, 1, 0x8D8), // 0x8D8-0x99F (0x979)
|
|
|
|
|
new InventoryPouch4(InventoryType.TMHMs, Legal.Pouch_TMHM_HGSS, 99, 0x9A0), // 0x9A0-0xB33 (0xB2F)
|
|
|
|
|
new InventoryPouch4(InventoryType.MailItems, Legal.Pouch_Mail_HGSS, 999, 0xB34), // 0xB34-0xB63 (0xB63)
|
|
|
|
|
new InventoryPouch4(InventoryType.Medicine, Legal.Pouch_Medicine_HGSS, 999, 0xB64), // 0xB64-0xC03 (0xBFB)
|
|
|
|
|
new InventoryPouch4(InventoryType.Berries, Legal.Pouch_Berries_HGSS, 999, 0xC04), // 0xC04-0xD03
|
|
|
|
|
new InventoryPouch4(InventoryType.Balls, Legal.Pouch_Ball_HGSS, 999, 0xD04), // 0xD04-0xD63
|
|
|
|
|
new InventoryPouch4(InventoryType.BattleItems, Legal.Pouch_Battle_HGSS, 999, 0xD64), // 0xD64-0xD97
|
|
|
|
|
};
|
|
|
|
|
return pouch.LoadAll(General);
|
|
|
|
|
}
|
|
|
|
|
set => value.SaveAll(General);
|
|
|
|
|
}
|
|
|
|
|
|
2021-05-18 20:04:23 +00:00
|
|
|
|
public override int M { get => BitConverter.ToUInt16(General, 0x1234); set => BitConverter.GetBytes((ushort)value).CopyTo(General, 0x1234); }
|
|
|
|
|
public override int X { get => BitConverter.ToUInt16(General, 0x123C); set => BitConverter.GetBytes((ushort)(X2 = value)).CopyTo(General, 0x123C); }
|
|
|
|
|
public override int Y { get => BitConverter.ToUInt16(General, 0x1240); set => BitConverter.GetBytes((ushort)(Y2 = value)).CopyTo(General, 0x1240); }
|
|
|
|
|
public override int X2 { get => BitConverter.ToUInt16(General, 0x236E); set => BitConverter.GetBytes((ushort)value).CopyTo(General, 0x236E); }
|
|
|
|
|
public override int Y2 { get => BitConverter.ToUInt16(General, 0x2372); set => BitConverter.GetBytes((ushort)value).CopyTo(General, 0x2372); }
|
|
|
|
|
public override int Z { get => BitConverter.ToUInt16(General, 0x2376); set => BitConverter.GetBytes((ushort)value).CopyTo(General, 0x2376); }
|
|
|
|
|
|
2019-09-03 02:30:58 +00:00
|
|
|
|
public int Badges16
|
|
|
|
|
{
|
|
|
|
|
get => General[Trainer1 + 0x1F];
|
|
|
|
|
set => General[Trainer1 + 0x1F] = (byte)value;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private const int OFS_GearRolodex = 0xC0EC;
|
|
|
|
|
private const byte GearMaxCallers = (byte)(PokegearNumber.Ernest + 1);
|
|
|
|
|
|
|
|
|
|
public PokegearNumber GetCallerAtIndex(int index) => (PokegearNumber)General[OFS_GearRolodex + index];
|
|
|
|
|
public void SetCallerAtIndex(int index, PokegearNumber caller) => General[OFS_GearRolodex + index] = (byte)caller;
|
|
|
|
|
|
2020-12-05 14:09:33 +00:00
|
|
|
|
public PokegearNumber[] GetPokeGearRoloDex()
|
2019-09-03 02:30:58 +00:00
|
|
|
|
{
|
2020-12-05 14:09:33 +00:00
|
|
|
|
var arr = new PokegearNumber[GearMaxCallers];
|
|
|
|
|
for (int i = 0; i < arr.Length; i++)
|
|
|
|
|
arr[i] = GetCallerAtIndex(i);
|
|
|
|
|
return arr;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public void SetPokeGearRoloDex(IReadOnlyList<PokegearNumber> value)
|
|
|
|
|
{
|
|
|
|
|
for (int i = 0; i < value.Count; i++)
|
|
|
|
|
SetCallerAtIndex(i, value[i]);
|
2019-09-03 02:30:58 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public void PokeGearUnlockAllCallers()
|
|
|
|
|
{
|
|
|
|
|
for (int i = 0; i < GearMaxCallers; i++)
|
|
|
|
|
SetCallerAtIndex(i, (PokegearNumber)i);
|
|
|
|
|
}
|
|
|
|
|
|
2019-09-03 04:24:49 +00:00
|
|
|
|
public void PokeGearClearAllCallers(int start = 0)
|
|
|
|
|
{
|
|
|
|
|
for (int i = start; i < GearMaxCallers; i++)
|
|
|
|
|
SetCallerAtIndex(i, PokegearNumber.None);
|
|
|
|
|
}
|
|
|
|
|
|
2019-09-03 02:30:58 +00:00
|
|
|
|
public void PokeGearUnlockAllCallersNoTrainers()
|
|
|
|
|
{
|
|
|
|
|
var nonTrainers = new[]
|
|
|
|
|
{
|
|
|
|
|
PokegearNumber.Mother,
|
|
|
|
|
PokegearNumber.Professor_Elm,
|
|
|
|
|
PokegearNumber.Professor_Oak,
|
|
|
|
|
PokegearNumber.Ethan,
|
|
|
|
|
PokegearNumber.Lyra,
|
|
|
|
|
PokegearNumber.Kurt,
|
|
|
|
|
PokegearNumber.Daycare_Man,
|
|
|
|
|
PokegearNumber.Daycare_Lady,
|
|
|
|
|
PokegearNumber.Bill,
|
|
|
|
|
PokegearNumber.Bike_Shop,
|
|
|
|
|
PokegearNumber.Baoba,
|
|
|
|
|
};
|
|
|
|
|
for (int i = 0; i < nonTrainers.Length; i++)
|
|
|
|
|
SetCallerAtIndex(i, nonTrainers[i]);
|
2019-09-03 04:24:49 +00:00
|
|
|
|
|
|
|
|
|
// clear remaining callers
|
|
|
|
|
PokeGearClearAllCallers(nonTrainers.Length);
|
2019-09-03 02:30:58 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Apricorn Pouch
|
2021-08-06 03:33:25 +00:00
|
|
|
|
public int GetApricornCount(int index) => General[0xE558 + index];
|
|
|
|
|
public void SetApricornCount(int index, int count) => General[0xE558 + index] = (byte)count;
|
2019-09-03 02:30:58 +00:00
|
|
|
|
|
|
|
|
|
// Pokewalker
|
2021-05-25 17:07:14 +00:00
|
|
|
|
public const int WalkerPair = 0xE5E0;
|
2020-08-01 16:20:13 +00:00
|
|
|
|
private const int OFS_WALKER = 0xE704;
|
|
|
|
|
|
|
|
|
|
public uint PokewalkerSteps { get => BitConverter.ToUInt32(General, OFS_WALKER); set => SetData(General, BitConverter.GetBytes(value), OFS_WALKER); }
|
|
|
|
|
public uint PokewalkerWatts { get => BitConverter.ToUInt32(General, OFS_WALKER + 0x4); set => SetData(General, BitConverter.GetBytes(value), OFS_WALKER + 0x4); }
|
2019-09-03 02:30:58 +00:00
|
|
|
|
|
2020-12-05 14:09:33 +00:00
|
|
|
|
public bool[] GetPokewalkerCoursesUnlocked() => ArrayUtil.GitBitFlagArray(General, OFS_WALKER + 0x8, 32);
|
|
|
|
|
public void SetPokewalkerCoursesUnlocked(bool[] value) => ArrayUtil.SetBitFlagArray(General, OFS_WALKER + 0x8, value);
|
2019-09-03 02:30:58 +00:00
|
|
|
|
|
2020-08-01 16:20:13 +00:00
|
|
|
|
public void PokewalkerCoursesSetAll(uint value = 0x07FF_FFFFu) => SetData(General, BitConverter.GetBytes(value), OFS_WALKER + 0x8);
|
2019-09-03 02:30:58 +00:00
|
|
|
|
}
|
2020-08-01 16:20:13 +00:00
|
|
|
|
}
|