Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves
In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.
The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.
The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.
* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 23:15:27 +00:00
|
|
|
using System;
|
2016-11-12 18:19:17 +00:00
|
|
|
using System.ComponentModel;
|
|
|
|
using System.Windows.Forms;
|
2017-01-08 07:54:09 +00:00
|
|
|
using PKHeX.Core;
|
2019-09-29 16:47:06 +00:00
|
|
|
using PKHeX.Drawing;
|
2021-11-27 23:48:08 +00:00
|
|
|
using PKHeX.Drawing.Misc;
|
|
|
|
using PKHeX.Drawing.PokeSprite;
|
2016-11-12 18:19:17 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
namespace PKHeX.WinForms;
|
2017-06-18 01:37:19 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
public partial class KChart : Form
|
|
|
|
{
|
|
|
|
private readonly SaveFile SAV;
|
2022-08-10 02:16:55 +00:00
|
|
|
private readonly string[] abilities;
|
2016-11-12 18:19:17 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
public KChart(SaveFile sav)
|
|
|
|
{
|
|
|
|
InitializeComponent();
|
|
|
|
Icon = Properties.Resources.Icon;
|
|
|
|
WinFormsUtil.TranslateInterface(this, Main.CurrentLanguage);
|
|
|
|
SAV = sav;
|
2016-11-12 18:19:17 +00:00
|
|
|
|
2022-08-10 02:16:55 +00:00
|
|
|
var pt = SAV.Personal;
|
|
|
|
var strings = GameInfo.Strings;
|
|
|
|
var species = strings.specieslist;
|
|
|
|
abilities = strings.abilitylist;
|
2016-11-12 18:19:17 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
DGV.Rows.Clear();
|
2022-08-27 06:43:36 +00:00
|
|
|
for (ushort s = 1; s <= pt.MaxSpeciesID; s++)
|
2022-08-10 02:16:55 +00:00
|
|
|
{
|
|
|
|
var fc = pt[s, 0].FormCount;
|
|
|
|
var formNames = fc <= 1
|
|
|
|
? Array.Empty<string>()
|
|
|
|
: FormConverter.GetFormList(s, strings.Types, strings.forms, Main.GenderSymbols, SAV.Context);
|
2022-08-10 06:33:41 +00:00
|
|
|
|
2022-08-27 06:43:36 +00:00
|
|
|
for (byte f = 0; f < fc; f++)
|
2022-08-10 02:16:55 +00:00
|
|
|
{
|
|
|
|
var name = f == 0 ? species[s] : $"{species[s]}-{(f < formNames.Length ? formNames[f] : f.ToString())}";
|
|
|
|
PopEntry(s, f, name);
|
|
|
|
}
|
|
|
|
}
|
2019-11-16 01:34:18 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
DGV.DoubleBuffered(true);
|
2016-11-12 18:19:17 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
DGV.Sort(DGV.Columns[0], ListSortDirection.Ascending);
|
|
|
|
}
|
2016-11-12 18:19:17 +00:00
|
|
|
|
2022-08-27 06:43:36 +00:00
|
|
|
private void PopEntry(ushort species, byte form, string name)
|
2022-06-18 18:04:24 +00:00
|
|
|
{
|
2022-08-10 02:16:55 +00:00
|
|
|
var p = SAV.Personal.GetFormEntry(species, form);
|
2022-06-18 18:04:24 +00:00
|
|
|
if (p.HP == 0)
|
|
|
|
return;
|
2016-11-12 18:19:17 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
var row = new DataGridViewRow();
|
|
|
|
row.CreateCells(DGV);
|
2022-08-10 02:16:55 +00:00
|
|
|
var cells = row.Cells;
|
|
|
|
int c = 0;
|
2022-08-10 06:33:41 +00:00
|
|
|
|
Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves
In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.
The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.
The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.
* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 23:15:27 +00:00
|
|
|
var bst = p.GetBaseStatTotal();
|
2022-08-10 02:16:55 +00:00
|
|
|
cells[c++].Value = species.ToString("000") + (form > 0 ? $"-{form:00}" : "");
|
|
|
|
cells[c++].Value = SpriteUtil.GetSprite(species, form, 0, 0, 0, false, Shiny.Never, SAV.Generation);
|
|
|
|
cells[c++].Value = name;
|
|
|
|
cells[c++].Value = GetIsNative(p, species);
|
|
|
|
cells[c].Style.BackColor = ColorUtil.ColorBaseStatTotal(bst);
|
|
|
|
cells[c++].Value = bst.ToString("000");
|
|
|
|
cells[c++].Value = p.CatchRate.ToString("000");
|
|
|
|
cells[c++].Value = TypeSpriteUtil.GetTypeSprite(p.Type1, SAV.Generation);
|
|
|
|
cells[c++].Value = p.Type1 == p.Type2 ? SpriteUtil.Spriter.Transparent : TypeSpriteUtil.GetTypeSprite(p.Type2, SAV.Generation);
|
|
|
|
cells[c].Style.BackColor = ColorUtil.ColorBaseStat(p.HP);
|
|
|
|
cells[c++].Value = p.HP.ToString("000");
|
|
|
|
cells[c].Style.BackColor = ColorUtil.ColorBaseStat(p.ATK);
|
|
|
|
cells[c++].Value = p.ATK.ToString("000");
|
|
|
|
cells[c].Style.BackColor = ColorUtil.ColorBaseStat(p.DEF);
|
|
|
|
cells[c++].Value = p.DEF.ToString("000");
|
|
|
|
cells[c].Style.BackColor = ColorUtil.ColorBaseStat(p.SPA);
|
|
|
|
cells[c++].Value = p.SPA.ToString("000");
|
|
|
|
cells[c].Style.BackColor = ColorUtil.ColorBaseStat(p.SPD);
|
|
|
|
cells[c++].Value = p.SPD.ToString("000");
|
|
|
|
cells[c].Style.BackColor = ColorUtil.ColorBaseStat(p.SPE);
|
|
|
|
cells[c++].Value = p.SPE.ToString("000");
|
2022-09-02 17:20:19 +00:00
|
|
|
var abils = p.AbilityCount;
|
|
|
|
cells[c++].Value = abilities[abils > 0 ? p.GetAbilityAtIndex(0) : 0];
|
|
|
|
cells[c++].Value = abilities[abils > 1 ? p.GetAbilityAtIndex(1) : 0];
|
|
|
|
cells[c].Value = abilities[abils > 2 ? p.GetAbilityAtIndex(2) : 0];
|
2022-08-10 06:33:41 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
row.Height = SpriteUtil.Spriter.Height + 1;
|
|
|
|
DGV.Rows.Add(row);
|
|
|
|
}
|
2020-09-06 17:53:13 +00:00
|
|
|
|
2022-08-27 06:43:36 +00:00
|
|
|
private static bool GetIsNative(IPersonalInfo personalInfo, ushort s) => personalInfo switch
|
2022-06-18 18:04:24 +00:00
|
|
|
{
|
Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves
In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.
The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.
The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.
* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 23:15:27 +00:00
|
|
|
PersonalInfo7 => s > 721 || Legal.PastGenAlolanNatives.Contains(s),
|
|
|
|
PersonalInfo8SWSH ss => ss.IsInDex,
|
|
|
|
PersonalInfo8BDSP bs => bs.IsInDex,
|
2022-09-02 17:20:19 +00:00
|
|
|
PersonalInfo8LA bs => bs.IsPresentInGame,
|
2022-06-18 18:04:24 +00:00
|
|
|
_ => true,
|
|
|
|
};
|
2016-11-12 18:19:17 +00:00
|
|
|
}
|