Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-30 15:59:13 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Game/GameStrings/GameInfo.cs

84 lines
4.1 KiB
C#
Raw Normal View History

Extract datasource filtered lists to object GameInfo has been the storage for the current Game Language environment When using GameInfo, only one environment is tracked at a time, which is initialized by the PKM editor (items, moves). Rework things to allow multiple filtered sources to exist, and keep the filtering logic in PKHeX.Core for reuse in other programs... ;)
2019-06-22 17:50:32 +00:00
using System.Collections.Generic;
Refactoring No functional change besides changing the default save to sav7. Main changes are moving the string data fetching out of the winforms-specific Main.cs
2016-10-29 22:41:55 +00:00
Split winforms to separate project resources still are associated with winforms, eh program still runs fine and I've replicated the mono build options. lmk if this breaks stuff
2017-01-08 07:54:09 +00:00
namespace PKHeX.Core
Refactoring No functional change besides changing the default save to sav7. Main changes are moving the string data fetching out of the winforms-specific Main.cs
2016-10-29 22:41:55 +00:00
{
Extract datasource filtered lists to object GameInfo has been the storage for the current Game Language environment When using GameInfo, only one environment is tracked at a time, which is initialized by the PKM editor (items, moves). Rework things to allow multiple filtered sources to exist, and keep the filtering logic in PKHeX.Core for reuse in other programs... ;)
2019-06-22 17:50:32 +00:00
/// <summary>
/// Shared instance for fetching <see cref="GameStrings"/> data
/// </summary>
Refactoring No functional change besides changing the default save to sav7. Main changes are moving the string data fetching out of the winforms-specific Main.cs
2016-10-29 22:41:55 +00:00
public static class GameInfo
{
Minor clean Remove unnecessary null checks Mark some methods with nullable type
2020-04-05 02:30:50 +00:00
private static readonly GameStrings?[] Languages = new GameStrings[GameLanguage.LanguageCount];
Refactoring No functional change besides changing the default save to sav7. Main changes are moving the string data fetching out of the winforms-specific Main.cs
2016-10-29 22:41:55 +00:00
Extract datasource filtered lists to object GameInfo has been the storage for the current Game Language environment When using GameInfo, only one environment is tracked at a time, which is initialized by the PKM editor (items, moves). Rework things to allow multiple filtered sources to exist, and keep the filtering logic in PKHeX.Core for reuse in other programs... ;)
2019-06-22 17:50:32 +00:00
public static string CurrentLanguage { get; set; } = GameLanguage.DefaultLanguage;
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
public static readonly IReadOnlyList<string> GenderSymbolUnicode = new[] {"♂", "♀", "-"};
public static readonly IReadOnlyList<string> GenderSymbolASCII = new[] {"M", "F", "-"};
Extract datasource filtered lists to object GameInfo has been the storage for the current Game Language environment When using GameInfo, only one environment is tracked at a time, which is initialized by the PKM editor (items, moves). Rework things to allow multiple filtered sources to exist, and keep the filtering logic in PKHeX.Core for reuse in other programs... ;)
2019-06-22 17:50:32 +00:00
private static GameStrings _strings = GetStrings(CurrentLanguage);
Style updates
2018-07-29 20:27:48 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public static GameStrings GetStrings(string lang)
Refactoring No functional change besides changing the default save to sav7. Main changes are moving the string data fetching out of the winforms-specific Main.cs
2016-10-29 22:41:55 +00:00
{
Extract datasource filtered lists to object GameInfo has been the storage for the current Game Language environment When using GameInfo, only one environment is tracked at a time, which is initialized by the PKM editor (items, moves). Rework things to allow multiple filtered sources to exist, and keep the filtering logic in PKHeX.Core for reuse in other programs... ;)
2019-06-22 17:50:32 +00:00
int index = GameLanguage.GetLanguageIndex(lang);
Add showdownset localization for slot previews Localization only for game strings (not Ability/Nature/Stat/etc labels) feels kinda goofy but it works
2018-07-14 02:13:25 +00:00
return GetStrings(index);
}
Style updates
2018-07-29 20:27:48 +00:00
Add showdownset localization for slot previews Localization only for game strings (not Ability/Nature/Stat/etc labels) feels kinda goofy but it works
2018-07-14 02:13:25 +00:00
public static GameStrings GetStrings(int index)
{
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
return Languages[index] ??= new GameStrings(GameLanguage.Language2Char(index));
Refactoring No functional change besides changing the default save to sav7. Main changes are moving the string data fetching out of the winforms-specific Main.cs
2016-10-29 22:41:55 +00:00
}
Style updates
2018-07-29 20:27:48 +00:00
Extract datasource filtered lists to object GameInfo has been the storage for the current Game Language environment When using GameInfo, only one environment is tracked at a time, which is initialized by the PKM editor (items, moves). Rework things to allow multiple filtered sources to exist, and keep the filtering logic in PKHeX.Core for reuse in other programs... ;)
2019-06-22 17:50:32 +00:00
public static GameStrings Strings
Refactoring No functional change besides changing the default save to sav7. Main changes are moving the string data fetching out of the winforms-specific Main.cs
2016-10-29 22:41:55 +00:00
{
Extract datasource filtered lists to object GameInfo has been the storage for the current Game Language environment When using GameInfo, only one environment is tracked at a time, which is initialized by the PKM editor (items, moves). Rework things to allow multiple filtered sources to exist, and keep the filtering logic in PKHeX.Core for reuse in other programs... ;)
2019-06-22 17:50:32 +00:00
get => _strings;
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
set => Sources = new GameDataSource(_strings = value);
Refactoring No functional change besides changing the default save to sav7. Main changes are moving the string data fetching out of the winforms-specific Main.cs
2016-10-29 22:41:55 +00:00
}
Target type'd new
2020-12-22 01:17:56 +00:00
public static GameDataSource Sources { get; private set; } = new(_strings);
Minor clean variable swaps, simplifications
2021-08-20 20:42:25 +00:00
public static FilteredGameDataSource FilteredSources { get; set; } = new(FakeSaveFile.Default, Sources);
Refactoring No functional change besides changing the default save to sav7. Main changes are moving the string data fetching out of the winforms-specific Main.cs
2016-10-29 22:41:55 +00:00
Add version name fetch only for pkm game IDs that have already been localized; not game groupings. use version name long description if hide-savefile details is enabled.
2018-12-22 21:16:16 +00:00
public static string GetVersionName(GameVersion version)
{
Simplify some expressions for game datasources Reduce allocations for ball Use a clean switch expression for version->met list
2020-12-28 21:32:36 +00:00
var list = (ComboItem[]) VersionDataSource;
var first = System.Array.Find(list, z => z.Value == (int) version);
return first == null ? version.ToString() : first.Text;
Add version name fetch only for pkm game IDs that have already been localized; not game groupings. use version name long description if hide-savefile details is enabled.
2018-12-22 21:16:16 +00:00
}
Refactoring No functional change besides changing the default save to sav7. Main changes are moving the string data fetching out of the winforms-specific Main.cs
2016-10-29 22:41:55 +00:00
// DataSource providing
Extract datasource filtered lists to object GameInfo has been the storage for the current Game Language environment When using GameInfo, only one environment is tracked at a time, which is initialized by the PKM editor (items, moves). Rework things to allow multiple filtered sources to exist, and keep the filtering logic in PKHeX.Core for reuse in other programs... ;)
2019-06-22 17:50:32 +00:00
public static IReadOnlyList<ComboItem> ItemDataSource => FilteredSources.Items;
public static IReadOnlyList<ComboItem> SpeciesDataSource => Sources.SpeciesDataSource;
public static IReadOnlyList<ComboItem> BallDataSource => Sources.BallDataSource;
public static IReadOnlyList<ComboItem> NatureDataSource => Sources.NatureDataSource;
public static IReadOnlyList<ComboItem> AbilityDataSource => Sources.AbilityDataSource;
public static IReadOnlyList<ComboItem> VersionDataSource => Sources.VersionDataSource;
public static IReadOnlyList<ComboItem> MoveDataSource => Sources.HaXMoveDataSource;
Finish renaming EncounterType->GroundTile Update the localization for GroundTile for english (and Italian, which is untranslated)
2021-07-04 06:25:09 +00:00
public static IReadOnlyList<ComboItem> GroundTileDataSource => Sources.GroundTileDataSource;
Extract datasource filtered lists to object GameInfo has been the storage for the current Game Language environment When using GameInfo, only one environment is tracked at a time, which is initialized by the PKM editor (items, moves). Rework things to allow multiple filtered sources to exist, and keep the filtering logic in PKHeX.Core for reuse in other programs... ;)
2019-06-22 17:50:32 +00:00
public static IReadOnlyList<ComboItem> Regions => GameDataSource.Regions;
public static IReadOnlyList<ComboItem> LanguageDataSource(int gen) => GameDataSource.LanguageDataSource(gen);
Split out location bank fetch Getting a little congested in one method
2018-12-22 22:45:47 +00:00
Misc refactoring add docs, move some data fetching to more appropriate class remove old XP memecrypto support handling, was previously removed due to net standard/core split refactor memecrypto to handle multiple save sizes (USUM won't be the same size save file); placeholder -1 for USUM size
2017-09-16 18:38:58 +00:00
/// <summary>
/// Gets the location name for the specified parameters.
/// </summary>
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
/// <param name="isEggLocation">Location is from the <see cref="PKM.Egg_Location"/></param>
/// <param name="location">Location value</param>
Misc refactoring add docs, move some data fetching to more appropriate class remove old XP memecrypto support handling, was previously removed due to net standard/core split refactor memecrypto to handle multiple save sizes (USUM won't be the same size save file); placeholder -1 for USUM size
2017-09-16 18:38:58 +00:00
/// <param name="format">Current <see cref="PKM.Format"/></param>
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
/// <param name="generation"><see cref="PKM.Generation"/> of origin</param>
Split GO from "GG" gameversion Make Gen7b as the combined ver for that expression
2020-08-07 01:24:20 +00:00
/// <param name="version">Current GameVersion (only applicable for <see cref="GameVersion.Gen7b"/> differentiation)</param>
Misc refactoring add docs, move some data fetching to more appropriate class remove old XP memecrypto support handling, was previously removed due to net standard/core split refactor memecrypto to handle multiple save sizes (USUM won't be the same size save file); placeholder -1 for USUM size
2017-09-16 18:38:58 +00:00
/// <returns>Location name</returns>
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
public static string GetLocationName(bool isEggLocation, int location, int format, int generation, GameVersion version)
Misc refactoring add docs, move some data fetching to more appropriate class remove old XP memecrypto support handling, was previously removed due to net standard/core split refactor memecrypto to handle multiple save sizes (USUM won't be the same size save file); placeholder -1 for USUM size
2017-09-16 18:38:58 +00:00
{
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
return Strings.GetLocationName(isEggLocation, location, format, generation, version);
Misc refactoring add docs, move some data fetching to more appropriate class remove old XP memecrypto support handling, was previously removed due to net standard/core split refactor memecrypto to handle multiple save sizes (USUM won't be the same size save file); placeholder -1 for USUM size
2017-09-16 18:38:58 +00:00
}
Refactoring pull out GameStrings add debug output for crystal headbutt trees fix qrpkm item access
2018-05-19 04:35:57 +00:00
/// <summary>
/// Gets the location list for a specific version, which can retrieve either met locations or egg locations.
/// </summary>
/// <param name="version">Version to retrieve for</param>
/// <param name="pkmFormat">Generation to retrieve for</param>
/// <param name="egg">Egg Locations are to be retrieved instead of regular Met Locations</param>
/// <returns>Consumable list of met locations</returns>
Refactoring put some string[] behind IReadOnlyList to prevent any consumer from modifying it
2018-06-30 16:59:48 +00:00
public static IReadOnlyList<ComboItem> GetLocationList(GameVersion version, int pkmFormat, bool egg = false)
Refactoring pull out GameStrings add debug output for crystal headbutt trees fix qrpkm item access
2018-05-19 04:35:57 +00:00
{
Split MetDataSource from GameDataSource
2020-12-29 05:12:46 +00:00
return Sources.Met.GetLocationList(version, pkmFormat, egg);
Refactoring pull out GameStrings add debug output for crystal headbutt trees fix qrpkm item access
2018-05-19 04:35:57 +00:00
}
Refactoring No functional change besides changing the default save to sav7. Main changes are moving the string data fetching out of the winforms-specific Main.cs
2016-10-29 22:41:55 +00:00
}
}
Reference in a new issue Copy permalink