2018-06-24 05:00:01 +00:00
|
|
|
|
using System;
|
|
|
|
|
using static PKHeX.Core.LegalityCheckStrings;
|
|
|
|
|
|
|
|
|
|
namespace PKHeX.Core
|
|
|
|
|
{
|
2018-07-02 02:17:37 +00:00
|
|
|
|
/// <summary>
|
|
|
|
|
/// Verifies the <see cref="PKM.IVs"/>.
|
|
|
|
|
/// </summary>
|
2018-06-24 05:00:01 +00:00
|
|
|
|
public sealed class IndividualValueVerifier : Verifier
|
|
|
|
|
{
|
|
|
|
|
protected override CheckIdentifier Identifier => CheckIdentifier.IVs;
|
2018-07-27 02:34:27 +00:00
|
|
|
|
|
2018-06-24 05:00:01 +00:00
|
|
|
|
public override void Verify(LegalityAnalysis data)
|
|
|
|
|
{
|
|
|
|
|
switch (data.EncounterMatch)
|
|
|
|
|
{
|
|
|
|
|
case EncounterStatic s:
|
|
|
|
|
VerifyIVsStatic(data, s);
|
|
|
|
|
break;
|
|
|
|
|
case EncounterSlot w:
|
|
|
|
|
VerifyIVsSlot(data, w);
|
|
|
|
|
break;
|
|
|
|
|
case MysteryGift g:
|
|
|
|
|
VerifyIVsMystery(data, g);
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
var pkm = data.pkm;
|
|
|
|
|
if (pkm.IVTotal == 0)
|
2018-07-27 02:34:27 +00:00
|
|
|
|
{
|
2018-09-01 21:11:12 +00:00
|
|
|
|
data.AddLine(Get(LFatefulMystery, Severity.Fishy));
|
2018-07-27 02:34:27 +00:00
|
|
|
|
}
|
2018-06-30 22:01:16 +00:00
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
var hpiv = pkm.IV_HP;
|
|
|
|
|
if (hpiv < 30 && AllIVsEqual(pkm, hpiv))
|
2018-09-01 21:11:12 +00:00
|
|
|
|
data.AddLine(Get(LIVAllEqual, Severity.Fishy));
|
2018-06-30 22:01:16 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public static bool AllIVsEqual(PKM pkm) => AllIVsEqual(pkm, pkm.IV_HP);
|
|
|
|
|
|
|
|
|
|
private static bool AllIVsEqual(PKM pkm, int hpiv)
|
|
|
|
|
{
|
|
|
|
|
return (pkm.IV_ATK == hpiv) && (pkm.IV_DEF == hpiv) && (pkm.IV_SPA == hpiv) && (pkm.IV_SPD == hpiv) && (pkm.IV_SPE == hpiv);
|
2018-06-24 05:00:01 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private void VerifyIVsMystery(LegalityAnalysis data, MysteryGift g)
|
|
|
|
|
{
|
PKHeX.Core Nullable cleanup (#2401)
* Handle some nullable cases
Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization
* Handle bits more obviously without null
* Make SaveFile.BAK explicitly readonly again
* merge constructor methods to have readonly fields
* Inline some properties
* More nullable handling
* Rearrange box actions
define straightforward classes to not have any null properties
* Make extrabyte reference array immutable
* Move tooltip creation to designer
* Rearrange some logic to reduce nesting
* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum
* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case
* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable
* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator
* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever
* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)
* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
|
|
|
|
var IVs = g.IVs;
|
|
|
|
|
if (IVs.Length == 0)
|
2018-06-24 05:00:01 +00:00
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
var ivflag = Array.Find(IVs, iv => (byte)(iv - 0xFC) < 3);
|
|
|
|
|
if (ivflag == 0) // Random IVs
|
|
|
|
|
{
|
2019-05-15 19:07:48 +00:00
|
|
|
|
bool valid = Legal.GetIsFixedIVSequenceValidSkipRand(IVs, data.pkm);
|
2018-06-24 05:00:01 +00:00
|
|
|
|
if (!valid)
|
2018-09-01 21:11:12 +00:00
|
|
|
|
data.AddLine(GetInvalid(LEncGiftIVMismatch));
|
2018-06-24 05:00:01 +00:00
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
int IVCount = ivflag - 0xFB; // IV2/IV3
|
2018-06-30 22:01:16 +00:00
|
|
|
|
VerifyIVsFlawless(data, IVCount);
|
2018-06-24 05:00:01 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private void VerifyIVsSlot(LegalityAnalysis data, EncounterSlot w)
|
|
|
|
|
{
|
2018-11-15 02:25:43 +00:00
|
|
|
|
switch (w.Generation)
|
|
|
|
|
{
|
|
|
|
|
case 6: VerifyIVsGen6(data, w); break;
|
|
|
|
|
case 7: VerifyIVsGen7(data); break;
|
2020-09-09 19:47:24 +00:00
|
|
|
|
// case 8: VerifyIVsGen8(data); break; // No rules for IV generation.
|
2018-11-15 02:25:43 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private void VerifyIVsGen7(LegalityAnalysis data)
|
|
|
|
|
{
|
2018-06-24 05:00:01 +00:00
|
|
|
|
var pkm = data.pkm;
|
2020-04-16 19:48:18 +00:00
|
|
|
|
if (pkm.GO)
|
|
|
|
|
VerifyIVsGoTransfer(data);
|
2020-10-10 19:30:57 +00:00
|
|
|
|
else if (pkm.AbilityNumber == 4 && !AbilityVerifier.CanAbilityPatch(pkm.Format, pkm.PersonalInfo.Abilities))
|
2018-07-10 00:02:13 +00:00
|
|
|
|
VerifyIVsFlawless(data, 2); // Chain of 10 yields 5% HA and 2 flawless IVs
|
2018-11-15 02:25:43 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private void VerifyIVsGen6(LegalityAnalysis data, EncounterSlot w)
|
|
|
|
|
{
|
|
|
|
|
var pkm = data.pkm;
|
|
|
|
|
if (pkm.XY && PersonalTable.XY[data.EncounterMatch.Species].IsEggGroup(15)) // Undiscovered
|
2018-06-25 04:55:00 +00:00
|
|
|
|
VerifyIVsFlawless(data, 3);
|
2020-08-30 17:23:22 +00:00
|
|
|
|
else if (w.Area.Type == SlotType.FriendSafari)
|
2018-06-30 22:01:16 +00:00
|
|
|
|
VerifyIVsFlawless(data, 2);
|
2018-06-25 04:55:00 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private void VerifyIVsFlawless(LegalityAnalysis data, int count)
|
|
|
|
|
{
|
2019-01-05 18:51:41 +00:00
|
|
|
|
if (data.pkm.FlawlessIVCount < count)
|
2018-09-01 21:11:12 +00:00
|
|
|
|
data.AddLine(GetInvalid(string.Format(LIVF_COUNT0_31, count)));
|
2018-06-24 05:00:01 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private void VerifyIVsStatic(LegalityAnalysis data, EncounterStatic s)
|
|
|
|
|
{
|
2018-06-30 22:01:16 +00:00
|
|
|
|
if (s.FlawlessIVCount != 0)
|
|
|
|
|
VerifyIVsFlawless(data, s.FlawlessIVCount);
|
2018-06-24 05:00:01 +00:00
|
|
|
|
}
|
2018-11-15 02:25:43 +00:00
|
|
|
|
|
|
|
|
|
private void VerifyIVsGoTransfer(LegalityAnalysis data)
|
|
|
|
|
{
|
2018-11-19 21:07:21 +00:00
|
|
|
|
var pkm = data.pkm;
|
|
|
|
|
if (!IsGoIVSetValid(pkm))
|
2018-11-16 01:35:11 +00:00
|
|
|
|
data.AddLine(GetInvalid(LIVNotCorrect));
|
2018-11-19 21:07:21 +00:00
|
|
|
|
|
|
|
|
|
if (!pkm.IsShiny)
|
|
|
|
|
return;
|
2019-06-28 18:04:23 +00:00
|
|
|
|
var banlist = Legal.GoTransferSpeciesShinyBan;
|
|
|
|
|
|
|
|
|
|
// all Shiny Alola Forms are legal, while some of their respective Kanto Forms are not
|
|
|
|
|
if (banlist.Contains(pkm.Species) && pkm.AltForm != 1)
|
2018-11-19 21:07:21 +00:00
|
|
|
|
data.AddLine(GetInvalid(LEncStaticPIDShiny, CheckIdentifier.PID));
|
2018-11-15 02:25:43 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private static bool IsGoIVSetValid(PKM pkm)
|
|
|
|
|
{
|
|
|
|
|
// Stamina*2 | 1 -> HP
|
|
|
|
|
// ATK * 2 | 1 -> ATK&SPA
|
|
|
|
|
// DEF * 2 | 1 -> DEF&SPD
|
|
|
|
|
// Speed is random.
|
|
|
|
|
|
|
|
|
|
// All IVs must be odd (except speed) and equal to their counterpart.
|
|
|
|
|
if ((pkm.GetIV(1) & 1) != 1 || pkm.GetIV(1) != pkm.GetIV(4)) // ATK=SPA
|
|
|
|
|
return false;
|
|
|
|
|
if ((pkm.GetIV(2) & 1) != 1 || pkm.GetIV(2) != pkm.GetIV(5)) // DEF=SPD
|
|
|
|
|
return false;
|
|
|
|
|
return (pkm.GetIV(0) & 1) == 1; // HP
|
|
|
|
|
}
|
2018-06-24 05:00:01 +00:00
|
|
|
|
}
|
|
|
|
|
}
|