Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-27 04:43:13 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.WinForms/Controls/PKM Editor/LoadSave.cs

472 lines
17 KiB
C#
Raw Normal View History

Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
using System;
Load indexes with clamped minmax Bad DynamaxLevel values no longer throw an exception, and just clamp back to the normal range.
2022-06-05 03:21:36 +00:00
using System.Windows.Forms;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
using PKHeX.Core;
Add .NET Core 3.0 build option for WinForms project (#2396) * Move pkhex.drawing calls out of form constructors designer doesn't like it; if Main can't be designed then there's some call that it can't process for whatever reason * Add netcore3 targeting Closes #2198 by adding a netcore3 build option Closes #2391 by retaining designer functionality and net46 builds
2019-10-02 01:12:08 +00:00
using PKHeX.Drawing;
Split PKHeX.Drawing into subprojects Allows trimmed dll usage by keeping pkm sprites in one project, and all other cosmetic UI stuff in another project
2021-11-27 23:48:08 +00:00
using PKHeX.Drawing.PokeSprite;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
namespace PKHeX.WinForms.Controls
{
public partial class PKMEditor
{
private void LoadNickname(PKM pk)
{
CHK_Nicknamed.Checked = pk.IsNicknamed;
TB_Nickname.Text = pk.Nickname;
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
private void SaveNickname(PKM pk)
{
pk.IsNicknamed = CHK_Nicknamed.Checked;
pk.Nickname = TB_Nickname.Text;
}
private void LoadSpeciesLevelEXP(PKM pk)
{
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
if (!HaX)
{
// Sanity check level and EXP
var current = pk.CurrentLevel;
if (current == 100) // clamp back to max EXP
pk.CurrentLevel = 100;
}
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
CB_Species.SelectedValue = pk.Species;
TB_Level.Text = pk.Stat_Level.ToString();
TB_EXP.Text = pk.EXP.ToString();
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
private void SaveSpeciesLevelEXP(PKM pk)
{
pk.Species = WinFormsUtil.GetIndex(CB_Species);
pk.EXP = Util.ToUInt32(TB_EXP.Text);
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
pk.Stat_Level = Util.ToInt32(TB_Level.Text);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
Rework TID/SID loading Move TID/SID load to after version set (special handling for pk1/pk2 which don't store version, just call manually). Update TID/SID on every gameversion change anyway Rename LoadOTID to LoadOT since it does not deal with ID. Closes #1962
2018-05-24 23:53:51 +00:00
private void LoadOT(PKM pk)
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
{
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
GB_OT.BackgroundImage = null; // clear the Current Handler indicator just in case we switched formats.
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
TB_OT.Text = pk.OT_Name;
Add gender sprites for main GUI Might trickle this out to the other editors that have gender toggles.
2022-04-25 03:19:50 +00:00
UC_OTGender.Gender = pk.OT_Gender & 1;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Rework TID/SID loading Move TID/SID load to after version set (special handling for pk1/pk2 which don't store version, just call manually). Update TID/SID on every gameversion change anyway Rename LoadOTID to LoadOT since it does not deal with ID. Closes #1962
2018-05-24 23:53:51 +00:00
private void SaveOT(PKM pk)
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
{
pk.OT_Name = TB_OT.Text;
Add gender sprites for main GUI Might trickle this out to the other editors that have gender toggles.
2022-04-25 03:19:50 +00:00
pk.OT_Gender = UC_OTGender.Gender;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
private void LoadPKRS(PKM pk)
{
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
Label_PKRS.Visible = CB_PKRSStrain.Visible = CHK_Infected.Checked = Label_PKRSdays.Visible = CB_PKRSDays.Visible = pk.PKRS_Infected;
Load indexes with clamped minmax Bad DynamaxLevel values no longer throw an exception, and just clamp back to the normal range.
2022-06-05 03:21:36 +00:00
LoadClamp(CB_PKRSStrain, pk.PKRS_Strain);
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
CHK_Cured.Checked = pk.PKRS_Cured;
Load indexes with clamped minmax Bad DynamaxLevel values no longer throw an exception, and just clamp back to the normal range.
2022-06-05 03:21:36 +00:00
LoadClamp(CB_PKRSDays, pk.PKRS_Days); // clamp to valid day values for the current strain
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
private void SavePKRS(PKM pk)
{
pk.PKRS_Days = CB_PKRSDays.SelectedIndex;
pk.PKRS_Strain = CB_PKRSStrain.SelectedIndex;
}
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
private void LoadIVs(PKM pk) => Stats.LoadIVs(pk.IVs);
private void LoadEVs(PKM pk) => Stats.LoadEVs(pk.EVs);
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
private void LoadAVs(IAwakened pk) => Stats.LoadAVs(pk);
Update program GUI abstractions Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
2022-02-05 01:36:51 +00:00
private void LoadGVs(IGanbaru pk) => Stats.LoadGVs(pk);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
Load indexes with clamped minmax Bad DynamaxLevel values no longer throw an exception, and just clamp back to the normal range.
2022-06-05 03:21:36 +00:00
private static void LoadClamp(ComboBox cb, int value)
{
var max = cb.Items.Count - 1;
if (value > max)
value = max;
else if (value < -1)
value = 0;
cb.SelectedIndex = value;
}
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
private void LoadMoves(PKM pk)
{
CB_Move1.SelectedValue = pk.Move1;
CB_Move2.SelectedValue = pk.Move2;
CB_Move3.SelectedValue = pk.Move3;
CB_Move4.SelectedValue = pk.Move4;
Load indexes with clamped minmax Bad DynamaxLevel values no longer throw an exception, and just clamp back to the normal range.
2022-06-05 03:21:36 +00:00
LoadClamp(CB_PPu1, pk.Move1_PPUps);
LoadClamp(CB_PPu2, pk.Move2_PPUps);
LoadClamp(CB_PPu3, pk.Move3_PPUps);
LoadClamp(CB_PPu4, pk.Move4_PPUps);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
TB_PP1.Text = pk.Move1_PP.ToString();
TB_PP2.Text = pk.Move2_PP.ToString();
TB_PP3.Text = pk.Move3_PP.ToString();
TB_PP4.Text = pk.Move4_PP.ToString();
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
private void SaveMoves(PKM pk)
{
pk.Move1 = WinFormsUtil.GetIndex(CB_Move1);
pk.Move2 = WinFormsUtil.GetIndex(CB_Move2);
pk.Move3 = WinFormsUtil.GetIndex(CB_Move3);
pk.Move4 = WinFormsUtil.GetIndex(CB_Move4);
pk.Move1_PP = WinFormsUtil.GetIndex(CB_Move1) > 0 ? Util.ToInt32(TB_PP1.Text) : 0;
pk.Move2_PP = WinFormsUtil.GetIndex(CB_Move2) > 0 ? Util.ToInt32(TB_PP2.Text) : 0;
pk.Move3_PP = WinFormsUtil.GetIndex(CB_Move3) > 0 ? Util.ToInt32(TB_PP3.Text) : 0;
pk.Move4_PP = WinFormsUtil.GetIndex(CB_Move4) > 0 ? Util.ToInt32(TB_PP4.Text) : 0;
pk.Move1_PPUps = WinFormsUtil.GetIndex(CB_Move1) > 0 ? CB_PPu1.SelectedIndex : 0;
pk.Move2_PPUps = WinFormsUtil.GetIndex(CB_Move2) > 0 ? CB_PPu2.SelectedIndex : 0;
pk.Move3_PPUps = WinFormsUtil.GetIndex(CB_Move3) > 0 ? CB_PPu3.SelectedIndex : 0;
pk.Move4_PPUps = WinFormsUtil.GetIndex(CB_Move4) > 0 ? CB_PPu4.SelectedIndex : 0;
}
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
private void LoadShadow3(IShadowPKM pk)
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
{
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
NUD_ShadowID.Value = pk.ShadowID;
FLP_Purification.Visible = pk.ShadowID > 0;
if (pk.ShadowID > 0)
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
{
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
int value = pk.Purification;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
if (value < NUD_Purification.Minimum)
value = (int)NUD_Purification.Minimum;
NUD_Purification.Value = value;
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
CHK_Shadow.Checked = pk.IsShadow;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
Use actual primitive instead of int Some interfaces aren't needed to be exposed as int
2022-03-06 02:30:35 +00:00
NUD_ShadowID.Value = Math.Max(pk.ShadowID, (ushort)0);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
else
{
NUD_Purification.Value = 0;
CHK_Shadow.Checked = false;
NUD_ShadowID.Value = 0;
}
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
private void SaveShadow3(IShadowPKM pk)
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
{
Use actual primitive instead of int Some interfaces aren't needed to be exposed as int
2022-03-06 02:30:35 +00:00
pk.ShadowID = (ushort)NUD_ShadowID.Value;
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
if (pk.ShadowID > 0)
pk.Purification = (int)NUD_Purification.Value;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
private void LoadRelearnMoves(PKM pk)
{
CB_RelearnMove1.SelectedValue = pk.RelearnMove1;
CB_RelearnMove2.SelectedValue = pk.RelearnMove2;
CB_RelearnMove3.SelectedValue = pk.RelearnMove3;
CB_RelearnMove4.SelectedValue = pk.RelearnMove4;
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
private void SaveRelearnMoves(PKM pk)
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
{
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
pk.RelearnMove1 = WinFormsUtil.GetIndex(CB_RelearnMove1);
pk.RelearnMove2 = WinFormsUtil.GetIndex(CB_RelearnMove2);
pk.RelearnMove3 = WinFormsUtil.GetIndex(CB_RelearnMove3);
pk.RelearnMove4 = WinFormsUtil.GetIndex(CB_RelearnMove4);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
private void LoadMisc1(PKM pk)
{
LoadSpeciesLevelEXP(pk);
LoadNickname(pk);
Rework TID/SID loading Move TID/SID load to after version set (special handling for pk1/pk2 which don't store version, just call manually). Update TID/SID on every gameversion change anyway Rename LoadOTID to LoadOT since it does not deal with ID. Closes #1962
2018-05-24 23:53:51 +00:00
LoadOT(pk);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
LoadIVs(pk);
LoadEVs(pk);
LoadMoves(pk);
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
private void SaveMisc1(PKM pk)
{
SaveSpeciesLevelEXP(pk);
SaveNickname(pk);
Rework TID/SID loading Move TID/SID load to after version set (special handling for pk1/pk2 which don't store version, just call manually). Update TID/SID on every gameversion change anyway Rename LoadOTID to LoadOT since it does not deal with ID. Closes #1962
2018-05-24 23:53:51 +00:00
SaveOT(pk);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
SaveMoves(pk);
}
private void LoadMisc2(PKM pk)
{
LoadPKRS(pk);
CHK_IsEgg.Checked = pk.IsEgg;
CB_HeldItem.SelectedValue = pk.HeldItem;
Load indexes with clamped minmax Bad DynamaxLevel values no longer throw an exception, and just clamp back to the normal range.
2022-06-05 03:21:36 +00:00
LoadClamp(CB_Form, pk.Form);
Add alcremie formArg gui Closes #2538 Standardize nomenclature as FormArgument, add interface for those exposing the property.
2019-11-29 18:44:52 +00:00
if (pk is IFormArgument f)
Make FormArg editing a complex control Shows a dropdown for alcremie only, and a number entry for everything else. See https://github.com/kwsch/PKHeX/commit/771086a2224778bef0cc4f7fe693195f7f2dd76c for initial implementation; I don't want the lag anymore lol
2020-12-28 19:51:25 +00:00
FA_Form.LoadArgument(f, pk.Species, pk.Form, pk.Format);
Add alcremie formArg gui Closes #2538 Standardize nomenclature as FormArgument, add interface for those exposing the property.
2019-11-29 18:44:52 +00:00
Show correct HatchCounter value for BDSP traded eggs Yay abstractions to hide away the quirks. BDSP traded eggs set HT_Friendship and the CurrentHandler flag, but the HatchCounter is always the OT_Friendship value. Trades always receive BaseFriendship, instead of a hardcoded 50. Necessary to not hardcode because it's immutable for eggs. Clicking the hatch counter label now sets it to the legal minimum hatch counter (best), and control clicking sets it to the max (worst). Check the encounter template for the true maximum.
2021-11-22 03:53:13 +00:00
ReloadToFriendshipTextBox(pk);
speed up pkm loading slightly PreparePKM had the opportunity to be recursive (preparation -> validating*N -> preparation*N), lock out preview sprite updating (which calls PreparePKM via Main.cs) while validating all controls remove uncallable paths (format is checked prior, and checksum check is never called as fieldsInitialized is forced false) move gui toggling to loading methods when appropriate
2017-10-26 02:37:31 +00:00
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
Label_HatchCounter.Visible = CHK_IsEgg.Checked;
Label_Friendship.Visible = !CHK_IsEgg.Checked;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Show correct HatchCounter value for BDSP traded eggs Yay abstractions to hide away the quirks. BDSP traded eggs set HT_Friendship and the CurrentHandler flag, but the HatchCounter is always the OT_Friendship value. Trades always receive BaseFriendship, instead of a hardcoded 50. Necessary to not hardcode because it's immutable for eggs. Clicking the hatch counter label now sets it to the legal minimum hatch counter (best), and control clicking sets it to the max (worst). Check the encounter template for the true maximum.
2021-11-22 03:53:13 +00:00
private void ReloadToFriendshipTextBox(PKM pk)
{
// Show OT friendship always if it is an egg.
var fs = (pk.IsEgg ? pk.OT_Friendship : pk.CurrentFriendship);
TB_Friendship.Text = fs.ToString();
}
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
private void SaveMisc2(PKM pk)
{
SavePKRS(pk);
pk.IsEgg = CHK_IsEgg.Checked;
pk.HeldItem = WinFormsUtil.GetIndex(CB_HeldItem);
Widen pkm form dropdowns Removes the hax form ID specifying; just use batch commands to mod the slot for out of bounds values.
2021-08-07 05:04:11 +00:00
pk.Form = CB_Form.Enabled ? CB_Form.SelectedIndex & 0x1F : 0;
Add alcremie formArg gui Closes #2538 Standardize nomenclature as FormArgument, add interface for those exposing the property.
2019-11-29 18:44:52 +00:00
if (Entity is IFormArgument f)
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
FA_Form.SaveArgument(f);
Show correct HatchCounter value for BDSP traded eggs Yay abstractions to hide away the quirks. BDSP traded eggs set HT_Friendship and the CurrentHandler flag, but the HatchCounter is always the OT_Friendship value. Trades always receive BaseFriendship, instead of a hardcoded 50. Necessary to not hardcode because it's immutable for eggs. Clicking the hatch counter label now sets it to the legal minimum hatch counter (best), and control clicking sets it to the max (worst). Check the encounter template for the true maximum.
2021-11-22 03:53:13 +00:00
var friendship = Util.ToInt32(TB_Friendship.Text);
UpdateFromFriendshipTextBox(pk, friendship);
}
private static void UpdateFromFriendshipTextBox(PKM pk, int friendship)
{
if (pk.IsEgg)
pk.OT_Friendship = friendship;
else
pk.CurrentFriendship = friendship;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
private void LoadMisc3(PKM pk)
{
TB_PID.Text = $"{pk.PID:X8}";
Add gender sprites for main GUI Might trickle this out to the other editors that have gender toggles.
2022-04-25 03:19:50 +00:00
UC_Gender.Gender = pk.Gender;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
CB_Nature.SelectedValue = pk.Nature;
CB_Language.SelectedValue = pk.Language;
CB_GameOrigin.SelectedValue = pk.Version;
CB_Ball.SelectedValue = pk.Ball;
CB_MetLocation.SelectedValue = pk.Met_Location;
TB_MetLevel.Text = pk.Met_Level.ToString();
CHK_Fateful.Checked = pk.FatefulEncounter;
Simplify IContestStats usage remove new[] creating for checking if any contest stats exist (HasContestStats)
2018-06-03 04:19:03 +00:00
if (pk is IContestStats s)
s.CopyContestStatsTo(Contest);
Rework TID/SID loading Move TID/SID load to after version set (special handling for pk1/pk2 which don't store version, just call manually). Update TID/SID on every gameversion change anyway Rename LoadOTID to LoadOT since it does not deal with ID. Closes #1962
2018-05-24 23:53:51 +00:00
TID_Trainer.LoadIDValues(pk);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
// Load Extrabyte Value
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
var offset = Convert.ToInt32(CB_ExtraBytes.Text, 16);
var value = pk.Data[offset];
TB_ExtraByte.Text = value.ToString();
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
private void SaveMisc3(PKM pk)
{
pk.PID = Util.GetHexValue(TB_PID.Text);
pk.Nature = WinFormsUtil.GetIndex(CB_Nature);
Add gender sprites for main GUI Might trickle this out to the other editors that have gender toggles.
2022-04-25 03:19:50 +00:00
pk.Gender = UC_Gender.Gender;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
Split IContestStats, mark trades as records
2020-12-24 08:06:40 +00:00
if (pk is IContestStatsMutable s)
Simplify IContestStats usage remove new[] creating for checking if any contest stats exist (HasContestStats)
2018-06-03 04:19:03 +00:00
Contest.CopyContestStatsTo(s);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
pk.FatefulEncounter = CHK_Fateful.Checked;
pk.Ball = WinFormsUtil.GetIndex(CB_Ball);
pk.Version = WinFormsUtil.GetIndex(CB_GameOrigin);
pk.Language = WinFormsUtil.GetIndex(CB_Language);
Save met level closes #1514 , needed to go in savemisc for gen3 pkm met_location is saved when changing it in the forms, save anyways
2017-10-06 15:22:12 +00:00
pk.Met_Level = Util.ToInt32(TB_MetLevel.Text);
pk.Met_Location = WinFormsUtil.GetIndex(CB_MetLocation);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
private void LoadMisc4(PKM pk)
{
CAL_MetDate.Value = pk.MetDate ?? new DateTime(2000, 1, 1);
HOME 2.0.0: Handle conversion behavior & restrictions (#3506) * Revises legality checks to account for traveling between the three game islands (PLA/BDSP/SWSH) * Adds conversion mechanisms between the three formats, as well as flexible conversion options to backfill missing data (thanks GameFreak/ILCA for opting for lossy conversion instead of updating the games). * Adds API abstractions for HOME data storage format (EKH/PKH format 1, aka EH1/PH1). * Revises some APIs for better usage: - `PKM` now exposes a `Context` to indicate the isolation context for legality purposes. - Some method signatures have changed to accept `Context` or `GameVersion` instead of a vague `int` for Generation. - Evolution History is now tracked in the Legality parse for specific contexts, rather than only per generation.
2022-05-31 04:43:52 +00:00
if (!Legal.IsMetAsEgg(pk))
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
{
CHK_AsEgg.Checked = GB_EggConditions.Enabled = false;
CAL_EggDate.Value = new DateTime(2000, 01, 01);
}
else
{
// Was obtained initially as an egg.
CHK_AsEgg.Checked = GB_EggConditions.Enabled = true;
CAL_EggDate.Value = pk.EggMetDate ?? new DateTime(2000, 1, 1);
}
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
CB_EggLocation.SelectedValue = pk.Egg_Location;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
private void SaveMisc4(PKM pk)
{
if (CHK_AsEgg.Checked) // If encountered as an egg, load the Egg Met data from fields.
{
HOME 2.0.0: Handle conversion behavior & restrictions (#3506) * Revises legality checks to account for traveling between the three game islands (PLA/BDSP/SWSH) * Adds conversion mechanisms between the three formats, as well as flexible conversion options to backfill missing data (thanks GameFreak/ILCA for opting for lossy conversion instead of updating the games). * Adds API abstractions for HOME data storage format (EKH/PKH format 1, aka EH1/PH1). * Revises some APIs for better usage: - `PKM` now exposes a `Context` to indicate the isolation context for legality purposes. - Some method signatures have changed to accept `Context` or `GameVersion` instead of a vague `int` for Generation. - Evolution History is now tracked in the Legality parse for specific contexts, rather than only per generation.
2022-05-31 04:43:52 +00:00
pk.EggMetDate = CAL_EggDate.Value;
pk.Egg_Location = WinFormsUtil.GetIndex(CB_EggLocation);
}
else // Default Dates
{
pk.EggMetDate = null; // clear
pk.Egg_Location = LocationEdits.GetNoneLocation(pk);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
HOME 2.0.0: Handle conversion behavior & restrictions (#3506) * Revises legality checks to account for traveling between the three game islands (PLA/BDSP/SWSH) * Adds conversion mechanisms between the three formats, as well as flexible conversion options to backfill missing data (thanks GameFreak/ILCA for opting for lossy conversion instead of updating the games). * Adds API abstractions for HOME data storage format (EKH/PKH format 1, aka EH1/PH1). * Revises some APIs for better usage: - `PKM` now exposes a `Context` to indicate the isolation context for legality purposes. - Some method signatures have changed to accept `Context` or `GameVersion` instead of a vague `int` for Generation. - Evolution History is now tracked in the Legality parse for specific contexts, rather than only per generation.
2022-05-31 04:43:52 +00:00
// Met Data
if (pk.IsEgg && pk.Met_Location == LocationEdits.GetNoneLocation(pk)) // If still an egg, it has no hatch location/date. Zero it!
pk.MetDate = null; // clear
else
pk.MetDate = CAL_MetDate.Value;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
Sword/Shield Update
2019-11-16 01:34:18 +00:00
pk.Ability = WinFormsUtil.GetIndex(HaX ? DEV_Ability : CB_Ability);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
private void LoadMisc6(PKM pk)
{
TB_EC.Text = $"{pk.EncryptionConstant:X8}";
DEV_Ability.SelectedValue = pk.Ability;
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
// with some simple error handling
var bitNumber = pk.AbilityNumber;
int abilityIndex = AbilityVerifier.IsValidAbilityBits(bitNumber) ? bitNumber >> 1 : 0;
Load indexes with clamped minmax Bad DynamaxLevel values no longer throw an exception, and just clamp back to the normal range.
2022-06-05 03:21:36 +00:00
LoadClamp(CB_Ability, abilityIndex);
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
TB_AbilityNumber.Text = bitNumber.ToString();
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
LoadRelearnMoves(pk);
LoadHandlingTrainer(pk);
Split Country/Region/ConsoleRegion to interface
2020-07-31 18:17:31 +00:00
Split VivillonTables into two classes Indicate that the content is for 3DS specific logic Reduce restriction for parameters requiring IGeoTrack => IRegionOrigin
2020-10-04 21:15:13 +00:00
if (pk is IRegionOrigin tr)
Split Country/Region/ConsoleRegion to interface
2020-07-31 18:17:31 +00:00
LoadGeolocation(tr);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
private void SaveMisc6(PKM pk)
{
pk.EncryptionConstant = Util.GetHexValue(TB_EC.Text);
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
if (PIDVerifier.GetTransferEC(pk, out var ec))
pk.EncryptionConstant = ec;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
pk.AbilityNumber = Util.ToInt32(TB_AbilityNumber.Text);
SaveRelearnMoves(pk);
SaveHandlingTrainer(pk);
Sword/Shield Update
2019-11-16 01:34:18 +00:00
Split VivillonTables into two classes Indicate that the content is for 3DS specific logic Reduce restriction for parameters requiring IGeoTrack => IRegionOrigin
2020-10-04 21:15:13 +00:00
if (pk is IRegionOrigin tr)
Split Country/Region/ConsoleRegion to interface
2020-07-31 18:17:31 +00:00
SaveGeolocation(tr);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
Split VivillonTables into two classes Indicate that the content is for 3DS specific logic Reduce restriction for parameters requiring IGeoTrack => IRegionOrigin
2020-10-04 21:15:13 +00:00
private void LoadGeolocation(IRegionOrigin pk)
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
{
Fix value -> gui previous commits changed interface to byte; combo binding uses ints for value
2021-08-03 03:43:32 +00:00
CB_Country.SelectedValue = (int)pk.Country;
CB_SubRegion.SelectedValue = (int)pk.Region;
CB_3DSReg.SelectedValue = (int)pk.ConsoleRegion;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Split VivillonTables into two classes Indicate that the content is for 3DS specific logic Reduce restriction for parameters requiring IGeoTrack => IRegionOrigin
2020-10-04 21:15:13 +00:00
private void SaveGeolocation(IRegionOrigin pk)
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
{
Simplify Country/Region/ConsoleRegion to byte from int Only exists in gen6/7 games.
2021-08-03 02:43:57 +00:00
pk.Country = (byte)WinFormsUtil.GetIndex(CB_Country);
pk.Region = (byte)WinFormsUtil.GetIndex(CB_SubRegion);
pk.ConsoleRegion = (byte)WinFormsUtil.GetIndex(CB_3DSReg);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
private void LoadHandlingTrainer(PKM pk)
{
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
var handler = pk.HT_Name;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
int gender = pk.HT_Gender & 1;
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
Add gender sprites for main GUI Might trickle this out to the other editors that have gender toggles.
2022-04-25 03:19:50 +00:00
TB_HT.Text = handler;
UC_HTGender.Gender = gender;
if (handler.Length == 0)
UC_HTGender.Visible = false;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
Add .NET Core 3.0 build option for WinForms project (#2396) * Move pkhex.drawing calls out of form constructors designer doesn't like it; if Main can't be designed then there's some call that it can't process for whatever reason * Add netcore3 targeting Closes #2198 by adding a netcore3 build option Closes #2391 by retaining designer functionality and net46 builds
2019-10-02 01:12:08 +00:00
// Indicate who is currently in possession of the PKM
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
UpadteHandlingTrainerBackground(pk.CurrentHandler);
Add .NET Core 3.0 build option for WinForms project (#2396) * Move pkhex.drawing calls out of form constructors designer doesn't like it; if Main can't be designed then there's some call that it can't process for whatever reason * Add netcore3 targeting Closes #2198 by adding a netcore3 build option Closes #2391 by retaining designer functionality and net46 builds
2019-10-02 01:12:08 +00:00
}
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
private void UpadteHandlingTrainerBackground(int handler)
Add .NET Core 3.0 build option for WinForms project (#2396) * Move pkhex.drawing calls out of form constructors designer doesn't like it; if Main can't be designed then there's some call that it can't process for whatever reason * Add netcore3 targeting Closes #2198 by adding a netcore3 build option Closes #2391 by retaining designer functionality and net46 builds
2019-10-02 01:12:08 +00:00
{
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
var activeColor = ImageUtil.ChangeOpacity(SpriteUtil.Spriter.Set, 0.5);
if (handler == 0) // OT
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
{
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
GB_OT.BackgroundImage = activeColor;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
GB_nOT.BackgroundImage = null;
}
else // Handling Trainer
{
Minor refactoring for pkmeditor GUI Cleans up some interactions to be a little more obvious
2021-07-31 01:05:17 +00:00
GB_nOT.BackgroundImage = activeColor;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
GB_OT.BackgroundImage = null;
}
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
private void SaveHandlingTrainer(PKM pk)
{
Add gender sprites for main GUI Might trickle this out to the other editors that have gender toggles.
2022-04-25 03:19:50 +00:00
pk.HT_Name = TB_HT.Text;
pk.HT_Gender = UC_HTGender.Gender;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
private void LoadAbility4(PKM pk)
{
Minor refactoring Change Ability array to IReadOnlyList, add method to check ability index in personal data Suppress some message warnings Change EvolutionChain short-circuit for VC to jump from gen6 directly down to gen2. There aren't any notradeback 1 situations, so a notradeback1 will always start with g=1, so no need for the other if-continue. Simplify pk5 conversion
2020-09-06 17:53:13 +00:00
var index = GetAbilityIndex4(pk);
Load indexes with clamped minmax Bad DynamaxLevel values no longer throw an exception, and just clamp back to the normal range.
2022-06-05 03:21:36 +00:00
LoadClamp(CB_Ability, index);
Handle legal pichu form values Closes #1828 , thanks @SpiredMoth ! slightly optimize batrev key init fix exception for pkm loading switching between gen3->4 saves
2018-02-11 01:43:00 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Minor refactoring Change Ability array to IReadOnlyList, add method to check ability index in personal data Suppress some message warnings Change EvolutionChain short-circuit for VC to jump from gen6 directly down to gen2. There aren't any notradeback 1 situations, so a notradeback1 will always start with g=1, so no need for the other if-continue. Simplify pk5 conversion
2020-09-06 17:53:13 +00:00
private static int GetAbilityIndex4(PKM pk)
Handle legal pichu form values Closes #1828 , thanks @SpiredMoth ! slightly optimize batrev key init fix exception for pkm loading switching between gen3->4 saves
2018-02-11 01:43:00 +00:00
{
Minor refactoring Change Ability array to IReadOnlyList, add method to check ability index in personal data Suppress some message warnings Change EvolutionChain short-circuit for VC to jump from gen6 directly down to gen2. There aren't any notradeback 1 situations, so a notradeback1 will always start with g=1, so no need for the other if-continue. Simplify pk5 conversion
2020-09-06 17:53:13 +00:00
var pi = pk.PersonalInfo;
int abilityIndex = pi.GetAbilityIndex(pk.Ability);
Handle legal pichu form values Closes #1828 , thanks @SpiredMoth ! slightly optimize batrev key init fix exception for pkm loading switching between gen3->4 saves
2018-02-11 01:43:00 +00:00
if (abilityIndex < 0)
return 0;
if (abilityIndex >= 2)
return 2;
Minor refactoring Change Ability array to IReadOnlyList, add method to check ability index in personal data Suppress some message warnings Change EvolutionChain short-circuit for VC to jump from gen6 directly down to gen2. There aren't any notradeback 1 situations, so a notradeback1 will always start with g=1, so no need for the other if-continue. Simplify pk5 conversion
2020-09-06 17:53:13 +00:00
var abils = pi.Abilities;
Fill empty ability values with ability1 update handling that checked for this case to instead check for equivalence to ability1 instead of 0 was generating a PGF with ability[1] = 0, which is not correct. Just fix the binaries to behave and get rid of all the workarounds since future tables don't have missing values.
2018-06-16 06:41:07 +00:00
if (abils[0] == abils[1])
Handle legal pichu form values Closes #1828 , thanks @SpiredMoth ! slightly optimize batrev key init fix exception for pkm loading switching between gen3->4 saves
2018-02-11 01:43:00 +00:00
return pk.PIDAbility;
return abilityIndex;
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
Sword/Shield Update
2019-11-16 01:34:18 +00:00
private void LoadMisc8(PK8 pk8)
{
CB_StatNature.SelectedValue = pk8.StatNature;
Load indexes with clamped minmax Bad DynamaxLevel values no longer throw an exception, and just clamp back to the normal range.
2022-06-05 03:21:36 +00:00
LoadClamp(Stats.CB_DynamaxLevel, pk8.DynamaxLevel);
Sword/Shield Update
2019-11-16 01:34:18 +00:00
Stats.CHK_Gigantamax.Checked = pk8.CanGigantamax;
More specific primitives for Memories/others
2022-03-06 20:01:47 +00:00
CB_HTLanguage.SelectedValue = (int)pk8.HT_Language;
Add tracker editor
2020-02-13 02:10:03 +00:00
TB_HomeTracker.Text = pk8.Tracker.ToString("X16");
More specific primitives for Memories/others
2022-03-06 20:01:47 +00:00
CB_BattleVersion.SelectedValue = (int)pk8.BattleVersion;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
}
private void SaveMisc8(PK8 pk8)
{
pk8.StatNature = WinFormsUtil.GetIndex(CB_StatNature);
pk8.DynamaxLevel = (byte)Math.Max(0, Stats.CB_DynamaxLevel.SelectedIndex);
pk8.CanGigantamax = Stats.CHK_Gigantamax.Checked;
More specific primitives for Memories/others
2022-03-06 20:01:47 +00:00
pk8.HT_Language = (byte)WinFormsUtil.GetIndex(CB_HTLanguage);
pk8.BattleVersion = (byte)WinFormsUtil.GetIndex(CB_BattleVersion);
Sword/Shield Update
2019-11-16 01:34:18 +00:00
}
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
private void LoadMisc8(PB8 pk8)
{
CB_StatNature.SelectedValue = pk8.StatNature;
Load indexes with clamped minmax Bad DynamaxLevel values no longer throw an exception, and just clamp back to the normal range.
2022-06-05 03:21:36 +00:00
LoadClamp(Stats.CB_DynamaxLevel, pk8.DynamaxLevel);
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
Stats.CHK_Gigantamax.Checked = pk8.CanGigantamax;
More specific primitives for Memories/others
2022-03-06 20:01:47 +00:00
CB_HTLanguage.SelectedValue = (int)pk8.HT_Language;
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
TB_HomeTracker.Text = pk8.Tracker.ToString("X16");
More specific primitives for Memories/others
2022-03-06 20:01:47 +00:00
CB_BattleVersion.SelectedValue = (int)pk8.BattleVersion;
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
}
private void SaveMisc8(PB8 pk8)
{
pk8.StatNature = WinFormsUtil.GetIndex(CB_StatNature);
pk8.DynamaxLevel = (byte)Math.Max(0, Stats.CB_DynamaxLevel.SelectedIndex);
pk8.CanGigantamax = Stats.CHK_Gigantamax.Checked;
More specific primitives for Memories/others
2022-03-06 20:01:47 +00:00
pk8.HT_Language = (byte)WinFormsUtil.GetIndex(CB_HTLanguage);
pk8.BattleVersion = (byte)WinFormsUtil.GetIndex(CB_BattleVersion);
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
}
Update program GUI abstractions Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
2022-02-05 01:36:51 +00:00
private void LoadMisc8(PA8 pk8)
{
CB_StatNature.SelectedValue = pk8.StatNature;
Load indexes with clamped minmax Bad DynamaxLevel values no longer throw an exception, and just clamp back to the normal range.
2022-06-05 03:21:36 +00:00
LoadClamp(Stats.CB_DynamaxLevel, pk8.DynamaxLevel);
Update program GUI abstractions Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
2022-02-05 01:36:51 +00:00
Stats.CHK_Gigantamax.Checked = pk8.CanGigantamax;
More specific primitives for Memories/others
2022-03-06 20:01:47 +00:00
CB_HTLanguage.SelectedValue = (int)pk8.HT_Language;
Update program GUI abstractions Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
2022-02-05 01:36:51 +00:00
TB_HomeTracker.Text = pk8.Tracker.ToString("X16");
More specific primitives for Memories/others
2022-03-06 20:01:47 +00:00
CB_BattleVersion.SelectedValue = (int)pk8.BattleVersion;
Update program GUI abstractions Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
2022-02-05 01:36:51 +00:00
Stats.CHK_IsAlpha.Checked = pk8.IsAlpha;
Stats.CHK_IsNoble.Checked = pk8.IsNoble;
More specific primitives for Memories/others
2022-03-06 20:01:47 +00:00
CB_AlphaMastered.SelectedValue = (int)pk8.AlphaMove;
Update program GUI abstractions Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
2022-02-05 01:36:51 +00:00
}
private void SaveMisc8(PA8 pk8)
{
pk8.StatNature = WinFormsUtil.GetIndex(CB_StatNature);
pk8.DynamaxLevel = (byte)Math.Max(0, Stats.CB_DynamaxLevel.SelectedIndex);
pk8.CanGigantamax = Stats.CHK_Gigantamax.Checked;
More specific primitives for Memories/others
2022-03-06 20:01:47 +00:00
pk8.HT_Language = (byte)WinFormsUtil.GetIndex(CB_HTLanguage);
pk8.BattleVersion = (byte)WinFormsUtil.GetIndex(CB_BattleVersion);
Update program GUI abstractions Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
2022-02-05 01:36:51 +00:00
pk8.IsAlpha = Stats.CHK_IsAlpha.Checked;
pk8.IsNoble = Stats.CHK_IsNoble.Checked;
More specific primitives for Memories/others
2022-03-06 20:01:47 +00:00
pk8.AlphaMove = (ushort)WinFormsUtil.GetIndex(CB_AlphaMastered);
Update program GUI abstractions Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
2022-02-05 01:36:51 +00:00
}
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
}
}
Reference in a new issue Copy permalink