Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-23 12:33:06 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Areas/EncounterArea6AO.cs

56 lines
2 KiB
C#
Raw Normal View History

Split encounter areas, relocate slot finding to obj Now logic is reasonably split, and each format of area has its own way of yielding slots Too much junk with checking flute boosts or catch combo applicability; just let the area dictate how slots match.
2019-09-13 06:20:52 +00:00
using System.Collections.Generic;
namespace PKHeX.Core
{
/// <inheritdoc />
/// <summary>
/// <see cref="GameVersion.ORAS"/> encounter area
/// </summary>
public sealed class EncounterArea6AO : EncounterArea32
{
Flute boost/decrease 3->4 Closes #2678 ty @Rayqo dat level 1 wild pokemon :+1:
2020-02-04 02:40:31 +00:00
private const int FluteBoostMin = 4; // White Flute decreases levels.
private const int FluteBoostMax = 4; // Black Flute increases levels.
Use less efficient IsLevelWithinRange, for clarity See previous commit for discussion; it's easier to read and maintain this rather than have the precomputed min/max comparisons. LevelMin - minDecrease <= min && max <= LevelMax + maxIncrease; See EncounterArea7b: Since we know min and minDecrease (0) before doing the linq filter we can precompute the lowbound, same for highbound; but this isn't immediately obvious to the reader. The perf cost is pretty much negligible in the big picture, so leave it in the more readable state. Thanks @fattard & @ammako ! #2389
2019-09-20 05:54:53 +00:00
private const int DexNavBoost = 30; // Maximum DexNav chain
Split encounter areas, relocate slot finding to obj Now logic is reasonably split, and each format of area has its own way of yielding slots Too much junk with checking flute boosts or catch combo applicability; just let the area dictate how slots match.
2019-09-13 06:20:52 +00:00
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
private const int RandomForm = 31;
Split encounter areas, relocate slot finding to obj Now logic is reasonably split, and each format of area has its own way of yielding slots Too much junk with checking flute boosts or catch combo applicability; just let the area dictate how slots match.
2019-09-13 06:20:52 +00:00
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
public override IEnumerable<EncounterSlot> GetMatchingSlots(PKM pkm, IReadOnlyList<EvoCriteria> chain)
Split encounter areas, relocate slot finding to obj Now logic is reasonably split, and each format of area has its own way of yielding slots Too much junk with checking flute boosts or catch combo applicability; just let the area dictate how slots match.
2019-09-13 06:20:52 +00:00
{
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
foreach (var slot in Slots)
Split encounter areas, relocate slot finding to obj Now logic is reasonably split, and each format of area has its own way of yielding slots Too much junk with checking flute boosts or catch combo applicability; just let the area dictate how slots match.
2019-09-13 06:20:52 +00:00
{
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
foreach (var evo in chain)
Split encounter areas, relocate slot finding to obj Now logic is reasonably split, and each format of area has its own way of yielding slots Too much junk with checking flute boosts or catch combo applicability; just let the area dictate how slots match.
2019-09-13 06:20:52 +00:00
{
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
if (slot.Species != evo.Species)
continue;
var boostMax = slot.Type != SlotType.Rock_Smash ? DexNavBoost : FluteBoostMax;
const int boostMin = FluteBoostMin;
if (!slot.IsLevelWithinRange(pkm.Met_Level, boostMin, boostMax))
break;
if (slot.Form != evo.Form && slot.Form != RandomForm)
break;
var clone = (EncounterSlot6AO)slot.Clone();
MarkSlotDetails(pkm, clone, evo);
yield return clone;
break;
Split encounter areas, relocate slot finding to obj Now logic is reasonably split, and each format of area has its own way of yielding slots Too much junk with checking flute boosts or catch combo applicability; just let the area dictate how slots match.
2019-09-13 06:20:52 +00:00
}
}
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
}
Split encounter areas, relocate slot finding to obj Now logic is reasonably split, and each format of area has its own way of yielding slots Too much junk with checking flute boosts or catch combo applicability; just let the area dictate how slots match.
2019-09-13 06:20:52 +00:00
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
private static void MarkSlotDetails(PKM pkm, EncounterSlot6AO slot, EvoCriteria evo)
{
bool nav = slot.AllowDexNav && (pkm.RelearnMove1 != 0 || pkm.AbilityNumber == 4);
slot.DexNav = nav;
if (slot.LevelMin > evo.MinLevel)
slot.WhiteFlute = true;
if (slot.LevelMax + 1 <= evo.MinLevel && evo.MinLevel <= slot.LevelMax + FluteBoostMax)
slot.BlackFlute = true;
if (slot.LevelMax != evo.MinLevel && slot.AllowDexNav)
slot.DexNav = true;
Split encounter areas, relocate slot finding to obj Now logic is reasonably split, and each format of area has its own way of yielding slots Too much junk with checking flute boosts or catch combo applicability; just let the area dictate how slots match.
2019-09-13 06:20:52 +00:00
}
}
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
}
Reference in a new issue Copy permalink