Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-16 00:58:01 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/Legality/Checks.cs

721 lines
35 KiB
C#
Raw Normal View History

Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
using System;
using System.Collections.Generic;
using System.Linq;
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
namespace PKHeX
{
public enum Severity
{
Indeterminate = -2,
Invalid = -1,
Fishy = 0,
Valid = 1,
NotImplemented = 2,
}
public class LegalityCheck
{
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
public Severity Judgement = Severity.Valid;
Minor tweaks
2016-03-18 01:28:51 +00:00
public readonly string Comment = "Valid";
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
public bool Valid => Judgement >= Severity.Fishy;
RelearnMove suggestion instead of copyMoves
2016-03-25 07:10:11 +00:00
public bool Flag;
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
public LegalityCheck() { }
public LegalityCheck(Severity s, string c)
{
Judgement = s;
Comment = c;
}
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
}
public partial class LegalityAnalysis
{
private LegalityCheck verifyECPID()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
// Secondary Checks
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.EncryptionConstant == 0)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck(Severity.Fishy, "Encryption Constant is not set.");
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.PID == 0)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck(Severity.Fishy, "PID is not set.");
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.Gen6)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck();
// When transferred to Generation 6, the Encryption Constant is copied from the PID.
// The PID is then checked to see if it becomes shiny with the new Shiny rules (>>4 instead of >>3)
// If the PID is nonshiny->shiny, the top bit is flipped.
// Check to see if the PID and EC are properly configured.
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
bool xorPID = ((pk6.TID ^ pk6.SID ^ (int)(pk6.PID & 0xFFFF) ^ (int)(pk6.PID >> 16)) & 0x7) == 8;
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
bool valid = xorPID
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
? pk6.EncryptionConstant == (pk6.PID ^ 0x8000000)
: pk6.EncryptionConstant == pk6.PID;
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
if (!valid)
if (xorPID)
return new LegalityCheck(Severity.Invalid, "PID should be equal to EC [with top bit flipped]!");
else
return new LegalityCheck(Severity.Invalid, "PID should be equal to EC!");
return new LegalityCheck();
}
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
private LegalityCheck verifyNickname()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
// If the Pokémon is not nicknamed, it should match one of the language strings.
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.Nickname.Length == 0)
Add Nickname legality check
2016-03-16 01:56:18 +00:00
return new LegalityCheck(Severity.Indeterminate, "Nickname is empty.");
if (pk6.Species > PKX.SpeciesLang[0].Length)
return new LegalityCheck(Severity.Indeterminate, "Species index invalid for Nickname comparison.");
Tweak nickname check severity
2016-03-20 01:06:02 +00:00
if (!Encounter.Valid)
return new LegalityCheck(Severity.Valid, "Skipped Nickname check due to other check being invalid.");
Add Ingame Trade OT/Nick check
2016-03-27 00:23:53 +00:00
if (pk6.Language > 8)
return new LegalityCheck(Severity.Indeterminate, "Language ID > 8.");
Add more strict ball checks Sport/Apricorn/Safari/Dream checked Also snuck in encountertype tracking for readability/calcOnce
2016-03-28 05:05:51 +00:00
if (EncounterType == typeof(EncounterTrade))
Add Ingame Trade OT/Nick check
2016-03-27 00:23:53 +00:00
{
string[] validOT = new string[0];
int index = -1;
if (pk6.XY)
{
validOT = Legal.TradeXY[pk6.Language];
index = Array.IndexOf(Legal.TradeGift_XY, EncounterMatch);
}
else if (pk6.AO)
{
validOT = Legal.TradeAO[pk6.Language];
index = Array.IndexOf(Legal.TradeGift_AO, EncounterMatch);
}
if (validOT.Length == 0)
return new LegalityCheck(Severity.Indeterminate, "Ingame Trade invalid version?");
if (index == -1 || validOT.Length < index * 2)
return new LegalityCheck(Severity.Indeterminate, "Ingame Trade invalid lookup?");
string nick = validOT[index];
string OT = validOT[validOT.Length/2 + index];
if (nick != pk6.Nickname)
return new LegalityCheck(Severity.Fishy, "Ingame Trade nickname has been altered.");
if (OT != pk6.OT_Name)
return new LegalityCheck(Severity.Invalid, "Ingame Trade OT has been altered.");
return new LegalityCheck(Severity.Valid, "Ingame Trade OT/Nickname have not been altered.");
}
Tweak nickname check severity
2016-03-20 01:06:02 +00:00
Add Egg name checks
2016-03-16 04:15:40 +00:00
if (pk6.IsEgg)
{
if (!pk6.IsNicknamed)
return new LegalityCheck(Severity.Invalid, "Eggs must be nicknamed.");
return PKX.SpeciesLang[pk6.Language][0] == pk6.Nickname
? new LegalityCheck(Severity.Valid, "Egg matches language Egg name.")
: new LegalityCheck(Severity.Invalid, "Egg name does not match language Egg name.");
}
Farfetch'd edge case
2016-03-16 04:40:11 +00:00
string nickname = pk6.Nickname.Replace("'", "’");
Add Nickname legality check
2016-03-16 01:56:18 +00:00
if (pk6.IsNicknamed)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Tweak nickname check severity
2016-03-20 01:06:02 +00:00
for (int i = 0; i < PKX.SpeciesLang.Length; i++)
{
string[] lang = PKX.SpeciesLang[i];
int index = Array.IndexOf(lang, nickname);
if (index < 0)
continue;
return index == pk6.Species && i != pk6.Language
? new LegalityCheck(Severity.Fishy, "Nickname matches another species name (+language).")
: new LegalityCheck(Severity.Fishy, "Nickname flagged, matches species name.");
}
return new LegalityCheck(Severity.Valid, "Nickname does not match another species name.");
Add Nickname legality check
2016-03-16 01:56:18 +00:00
}
// else
{
// Can't have another language name if it hasn't evolved.
Farfetch'd edge case
2016-03-16 04:40:11 +00:00
return Legal.getHasEvolved(pk6) && PKX.SpeciesLang.Any(lang => lang[pk6.Species] == nickname)
|| PKX.SpeciesLang[pk6.Language][pk6.Species] == nickname
Add XY/AO attribute for PK6 A little more explicit.
2016-03-16 02:06:13 +00:00
? new LegalityCheck(Severity.Valid, "Nickname matches species name.")
: new LegalityCheck(Severity.Invalid, "Nickname does not match species name.");
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
}
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
private LegalityCheck verifyEVs()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
var evs = pk6.EVs;
int sum = evs.Sum();
if (sum == 0 && pk6.Met_Level != pk6.Stat_Level && pk6.Stat_Level > 1)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck(Severity.Fishy, "All EVs are zero, but leveled above Met Level");
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (sum == 508)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck(Severity.Fishy, "2 EVs remaining.");
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (sum > 510)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck(Severity.Invalid, "EV total cannot be above 510.");
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (evs.Any(ev => ev > 252))
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck(Severity.Invalid, "EVs cannot go above 252.");
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (evs.All(ev => pk6.EVs[0] == ev) && evs[0] != 0)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck(Severity.Fishy, "EVs are all equal.");
return new LegalityCheck();
}
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
private LegalityCheck verifyIVs()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.IVs.Sum() == 0)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck(Severity.Fishy, "All IVs are zero.");
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.IVs[0] < 30 && pk6.IVs.All(iv => pk6.IVs[0] == iv))
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck(Severity.Fishy, "All IVs are equal.");
return new LegalityCheck();
}
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
private LegalityCheck verifyID()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.TID == 0 && pk6.SID == 0)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck(Severity.Fishy, "TID and SID are zero.");
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.TID == 0)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck(Severity.Fishy, "TID is zero.");
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.SID == 0)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
return new LegalityCheck(Severity.Fishy, "SID is zero.");
return new LegalityCheck();
}
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
private LegalityCheck verifyEncounter()
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
{
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (!pk6.Gen6)
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
return new LegalityCheck {Judgement = Severity.NotImplemented};
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.WasLink)
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
{
Minor fixes Fix hot springs egg location Fix link gift not returning valid
2016-03-16 05:04:04 +00:00
// Should NOT be Fateful, and should be in Database
Add Link origin game lockouts Certain link gifts can only be received in certain games.
2016-03-24 00:57:22 +00:00
EncounterLink enc = EncounterMatch as EncounterLink;
if (enc == null)
return new LegalityCheck(Severity.Invalid, "Not a valid Link gift -- unable to find matching gift.");
if (pk6.XY && !enc.XY)
return new LegalityCheck(Severity.Invalid, "Not a valid Link gift -- can't obtain in XY.");
if (pk6.AO && !enc.ORAS)
return new LegalityCheck(Severity.Invalid, "Not a valid Link gift -- can't obtain in ORAS.");
return pk6.FatefulEncounter
? new LegalityCheck(Severity.Invalid, "Not a valid Link gift -- should not be Fateful Encounter.")
Minor fixes Fix hot springs egg location Fix link gift not returning valid
2016-03-16 05:04:04 +00:00
: new LegalityCheck(Severity.Valid, "Valid Link gift.");
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
}
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.WasEvent || pk6.WasEventEgg)
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
{
Move MatchedWC6 into EncounterMatch
2016-03-23 05:49:46 +00:00
WC6 MatchedWC6 = EncounterMatch as WC6;
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
return MatchedWC6 != null // Matched in RelearnMoves check.
? new LegalityCheck(Severity.Valid, $"Matches #{MatchedWC6.CardID.ToString("0000")} ({MatchedWC6.CardTitle})")
: new LegalityCheck(Severity.Invalid, "Not a valid Wonder Card gift.");
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
}
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
EncounterMatch = null; // Reset object
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.WasEgg)
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
{
// Check Hatch Locations
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.Met_Level != 1)
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
return new LegalityCheck(Severity.Invalid, "Invalid met level, expected 1.");
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
if (pk6.IsEgg)
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
{
Add Nickname legality check
2016-03-16 01:56:18 +00:00
return pk6.Met_Location == 0
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
? new LegalityCheck(Severity.Valid, "Valid un-hatched egg.")
: new LegalityCheck(Severity.Invalid, "Invalid location for un-hatched egg (expected ID:0)");
}
Add XY/AO attribute for PK6 A little more explicit.
2016-03-16 02:06:13 +00:00
if (pk6.XY)
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
{
Add Nickname legality check
2016-03-16 01:56:18 +00:00
return Legal.ValidMet_XY.Contains(pk6.Met_Location)
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
? new LegalityCheck(Severity.Valid, "Valid X/Y hatched egg.")
: new LegalityCheck(Severity.Invalid, "Invalid X/Y location for hatched egg.");
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
}
Add XY/AO attribute for PK6 A little more explicit.
2016-03-16 02:06:13 +00:00
if (pk6.AO)
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
{
Add Nickname legality check
2016-03-16 01:56:18 +00:00
return Legal.ValidMet_AO.Contains(pk6.Met_Location)
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
? new LegalityCheck(Severity.Valid, "Valid OR/AS hatched egg.")
: new LegalityCheck(Severity.Invalid, "Invalid OR/AS location for hatched egg.");
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
}
return new LegalityCheck(Severity.Invalid, "Invalid location for hatched egg.");
}
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
EncounterMatch = Legal.getValidStaticEncounter(pk6);
if (EncounterMatch != null)
Add Static/Friend Safari Encounter checking
2016-03-13 21:56:23 +00:00
return new LegalityCheck(Severity.Valid, "Valid gift/static encounter.");
Add fossil encounter checks
2016-03-17 02:15:49 +00:00
if (Legal.getIsFossil(pk6))
{
return pk6.AbilityNumber != 4
? new LegalityCheck(Severity.Valid, "Valid revived fossil.")
: new LegalityCheck(Severity.Invalid, "Hidden ability on revived fossil.");
}
Refactor Safari to be an encounter slot
2016-03-23 05:31:30 +00:00
EncounterMatch = Legal.getValidFriendSafari(pk6);
if (EncounterMatch != null)
Add Friend Safari exclusive forms
2016-03-16 01:35:40 +00:00
{
if (pk6.Species == 670 || pk6.Species == 671) // Floette
if (pk6.AltForm % 2 != 0) // 0/2/4
return new LegalityCheck(Severity.Invalid, "Friend Safari: Not valid color.");
else if (pk6.Species == 710 || pk6.Species == 711) // Pumpkaboo
if (pk6.AltForm != 1) // Average
return new LegalityCheck(Severity.Invalid, "Friend Safari: Not average sized.");
else if (pk6.Species == 586) // Sawsbuck
if (pk6.AltForm != 0)
return new LegalityCheck(Severity.Invalid, "Friend Safari: Not Spring form.");
Add Static/Friend Safari Encounter checking
2016-03-13 21:56:23 +00:00
return new LegalityCheck(Severity.Valid, "Valid friend safari encounter.");
Add Friend Safari exclusive forms
2016-03-16 01:35:40 +00:00
}
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
EncounterMatch = Legal.getValidWildEncounters(pk6);
if (EncounterMatch != null)
Add ability check for wild pokemon
2016-03-13 23:42:03 +00:00
{
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
return ((EncounterSlot[]) EncounterMatch).Any(slot => !slot.DexNav)
? new LegalityCheck(Severity.Valid, "Valid encounter at location.")
: new LegalityCheck(Severity.Valid, "Valid DexNav encounter at location.");
Add ability check for wild pokemon
2016-03-13 23:42:03 +00:00
}
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
EncounterMatch = Legal.getValidIngameTrade(pk6);
if (EncounterMatch != null)
Add ingame trade checks There's memories associated, IVs, EVs, whatever; best to check them in the individual legality check methods.
2016-03-18 00:25:21 +00:00
{
return new LegalityCheck(Severity.Valid, "Valid ingame trade.");
}
Legality ContextMenu now returns analysis Hooked up all the methods and can spit out if invalid. I plan to put a legality indication where QR! was, but the legality analysis needs more checks (moves, ability, nickname, ball, fateful... you get it) and stability. Have fun playing with the initial legality checks :smile:
2016-03-12 03:43:40 +00:00
return new LegalityCheck(Severity.Invalid, "Not a valid encounter.");
}
Add level check Met level > Current Level
2016-03-19 05:49:21 +00:00
private LegalityCheck verifyLevel()
{
Move MatchedWC6 into EncounterMatch
2016-03-23 05:49:46 +00:00
WC6 MatchedWC6 = EncounterMatch as WC6;
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
if (MatchedWC6 != null && MatchedWC6.Level != pk6.Met_Level)
return new LegalityCheck(Severity.Invalid, "Met Level does not match Wonder Card level.");
Add level check Met level > Current Level
2016-03-19 05:49:21 +00:00
return pk6.CurrentLevel < pk6.Met_Level
? new LegalityCheck(Severity.Invalid, "Current level is below met level.")
: new LegalityCheck(Severity.Valid, "Current level is not below met level.");
}
Add ribbon legality check
2016-03-20 22:20:11 +00:00
private LegalityCheck verifyRibbons()
{
if (!Encounter.Valid)
return new LegalityCheck(Severity.Valid, "Skipped Ribbon check due to other check being invalid.");
List<string> missingRibbons = new List<string>();
List<string> invalidRibbons = new List<string>();
// Check Event Ribbons
bool[] EventRib =
{
pk6.RIB2_6, pk6.RIB2_7, pk6.RIB3_0, pk6.RIB3_1, pk6.RIB3_2,
pk6.RIB3_3, pk6.RIB3_4, pk6.RIB3_5, pk6.RIB3_6, pk6.RIB3_7,
pk6.RIB4_0, pk6.RIB4_1, pk6.RIB4_2, pk6.RIB4_3, pk6.RIB4_4
};
Move MatchedWC6 into EncounterMatch
2016-03-23 05:49:46 +00:00
WC6 MatchedWC6 = EncounterMatch as WC6;
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
if (MatchedWC6 != null) // Wonder Card
Add ribbon legality check
2016-03-20 22:20:11 +00:00
{
bool[] wc6rib =
{
MatchedWC6.RIB0_3, MatchedWC6.RIB0_4, MatchedWC6.RIB0_5, MatchedWC6.RIB0_6, MatchedWC6.RIB1_5,
MatchedWC6.RIB1_6, MatchedWC6.RIB0_7, MatchedWC6.RIB1_1, MatchedWC6.RIB1_2, MatchedWC6.RIB1_3,
MatchedWC6.RIB1_4, MatchedWC6.RIB0_0, MatchedWC6.RIB0_1, MatchedWC6.RIB0_2, MatchedWC6.RIB1_0
};
for (int i = 0; i < EventRib.Length; i++)
if (EventRib[i] ^ wc6rib[i]) // Mismatch
(wc6rib[i] ? missingRibbons : invalidRibbons).Add(EventRibName[i]);
}
Add more strict ball checks Sport/Apricorn/Safari/Dream checked Also snuck in encountertype tracking for readability/calcOnce
2016-03-28 05:05:51 +00:00
else if (EncounterType == typeof(EncounterLink))
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
{
// No Event Ribbons except Classic (unless otherwise specified, ie not for Demo)
for (int i = 0; i < EventRib.Length; i++)
if (i != 4 && EventRib[i])
invalidRibbons.Add(EventRibName[i]);
if (EventRib[4] ^ ((EncounterLink)EncounterMatch).Classic)
(EventRib[4] ? invalidRibbons : missingRibbons).Add(EventRibName[4]);
}
else // No ribbons
Add ribbon legality check
2016-03-20 22:20:11 +00:00
{
for (int i = 0; i < EventRib.Length; i++)
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
if (EventRib[i])
Add ribbon legality check
2016-03-20 22:20:11 +00:00
invalidRibbons.Add(EventRibName[i]);
}
// Unobtainable ribbons for Gen6 Origin
if (pk6.RIB0_1)
invalidRibbons.Add("GBA Champion"); // RSE HoF
if (pk6.RIB0_2)
invalidRibbons.Add("Sinnoh Champ"); // DPPt HoF
Minor fixes Fix ribbon bits, fix formchange
2016-03-22 06:43:03 +00:00
if (pk6.RIB2_2)
Add ribbon legality check
2016-03-20 22:20:11 +00:00
invalidRibbons.Add("Artist"); // RSE Master Rank Portrait
Minor fixes Fix ribbon bits, fix formchange
2016-03-22 06:43:03 +00:00
if (pk6.RIB2_4)
Add ribbon legality check
2016-03-20 22:20:11 +00:00
invalidRibbons.Add("Record"); // Unobtainable
Minor fixes Fix ribbon bits, fix formchange
2016-03-22 06:43:03 +00:00
if (pk6.RIB2_5)
Add ribbon legality check
2016-03-20 22:20:11 +00:00
invalidRibbons.Add("Legend"); // HGSS Defeat Red @ Mt.Silver
if (pk6.Memory_ContestCount > 0)
invalidRibbons.Add("Contest Memory"); // Gen3/4 Contest
if (pk6.Memory_BattleCount > 0)
invalidRibbons.Add("Battle Memory"); // Gen3/4 Battle
if (missingRibbons.Count + invalidRibbons.Count == 0)
return new LegalityCheck(Severity.Valid, "All ribbons accounted for.");
string[] result = new string[2];
if (missingRibbons.Count > 0)
result[0] = "Missing Ribbons: " + string.Join(", ", missingRibbons);
if (invalidRibbons.Count > 0)
result[1] = "Invalid Ribbons: " + string.Join(", ", invalidRibbons);
return new LegalityCheck(Severity.Invalid, string.Join(Environment.NewLine, result.Where(s=>!string.IsNullOrEmpty(s))));
}
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
private LegalityCheck verifyAbility()
{
int index = Legal.PersonalAO[pk6.Species].FormeIndex(pk6.Species, pk6.AltForm);
byte[] abilities = Legal.PersonalAO[index].Abilities;
int abilval = Array.IndexOf(abilities, (byte)pk6.Ability);
if (abilval < 0)
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
return new LegalityCheck(Severity.Invalid, "Ability is not valid for species/form.");
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
if (EncounterMatch != null)
{
Add more strict ball checks Sport/Apricorn/Safari/Dream checked Also snuck in encountertype tracking for readability/calcOnce
2016-03-28 05:05:51 +00:00
if (EncounterType == typeof(EncounterStatic))
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
if (pk6.AbilityNumber == 4 ^ ((EncounterStatic)EncounterMatch).Ability == 4)
return new LegalityCheck(Severity.Invalid, "Hidden Ability mismatch for static encounter.");
Add more strict ball checks Sport/Apricorn/Safari/Dream checked Also snuck in encountertype tracking for readability/calcOnce
2016-03-28 05:05:51 +00:00
if (EncounterType == typeof(EncounterTrade))
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
if (pk6.AbilityNumber == 4 ^ ((EncounterTrade)EncounterMatch).Ability == 4)
return new LegalityCheck(Severity.Invalid, "Hidden Ability mismatch for ingame trade.");
Add more strict ball checks Sport/Apricorn/Safari/Dream checked Also snuck in encountertype tracking for readability/calcOnce
2016-03-28 05:05:51 +00:00
if (EncounterType == typeof (EncounterSlot[]) && pk6.AbilityNumber == 4)
Refactor Safari to be an encounter slot
2016-03-23 05:31:30 +00:00
if (((EncounterSlot[]) EncounterMatch).All(slot => slot.Type != SlotType.FriendSafari) &&
((EncounterSlot[]) EncounterMatch).All(slot => slot.Type != SlotType.Horde))
return new LegalityCheck(Severity.Invalid, "Hidden Ability on non-horde/friend safari wild encounter.");
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
}
Add Ingame Trade ability, chk Fix Egg Ball chk Missed the return at the end
2016-03-22 04:50:39 +00:00
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
return abilities[pk6.AbilityNumber >> 1] != pk6.Ability
? new LegalityCheck(Severity.Invalid, "Ability does not match ability number.")
: new LegalityCheck(Severity.Valid, "Ability matches ability number.");
}
private LegalityCheck verifyBall()
{
Add Gen3/4 Ball exclusions Additional Changes: Removed duplicate EncounterLink check Moved RelearnBase resetting to the verifyRelearn() method.
2016-03-29 05:30:23 +00:00
if (!pk6.Gen6)
return new LegalityCheck();
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
if (!Encounter.Valid)
return new LegalityCheck(Severity.Valid, "Skipped Ball check due to other check being invalid.");
Add Gen3/4 Ball exclusions Additional Changes: Removed duplicate EncounterLink check Moved RelearnBase resetting to the verifyRelearn() method.
2016-03-29 05:30:23 +00:00
if (EncounterType == typeof(WC6))
return pk6.Ball != ((WC6)EncounterMatch).Pokéball
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
? new LegalityCheck(Severity.Invalid, "Ball does not match specified Wonder Card Ball.")
: new LegalityCheck(Severity.Valid, "Ball matches Wonder Card.");
Add Gen3/4 Ball exclusions Additional Changes: Removed duplicate EncounterLink check Moved RelearnBase resetting to the verifyRelearn() method.
2016-03-29 05:30:23 +00:00
if (EncounterType == typeof(EncounterLink))
return ((EncounterLink)EncounterMatch).Ball != pk6.Ball
? new LegalityCheck(Severity.Invalid, "Incorrect ball on Link gift.")
: new LegalityCheck(Severity.Valid, "Correct ball on Link gift.");
if (EncounterType == typeof(EncounterTrade))
return pk6.Ball != 4 // Pokeball
? new LegalityCheck(Severity.Invalid, "Incorrect ball on ingame trade encounter.")
: new LegalityCheck(Severity.Valid, "Correct ball on ingame trade encounter.");
if (EncounterType == typeof(EncounterStatic))
return !Legal.WildPokeballs.Contains(pk6.Ball)
? new LegalityCheck(Severity.Invalid, "Incorrect ball on ingame static encounter.")
: new LegalityCheck(Severity.Valid, "Correct ball on ingame static encounter.");
if (EncounterType == typeof(EncounterSlot[]))
return !Legal.WildPokeballs.Contains(pk6.Ball)
? new LegalityCheck(Severity.Invalid, "Incorrect ball on ingame encounter.")
: new LegalityCheck(Severity.Valid, "Correct ball on ingame encounter.");
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
if (pk6.WasEgg)
{
Add Gen3/4 Ball exclusions Additional Changes: Removed duplicate EncounterLink check Moved RelearnBase resetting to the verifyRelearn() method.
2016-03-29 05:30:23 +00:00
if (pk6.Ball == 0x04) // Poké Ball
return new LegalityCheck(Severity.Valid, "Standard Poké Ball.");
Add Master Ball & Gender based Ball checks Safari ball and general ball checks for past gen pkm are still weaker than they can be.
2016-03-27 00:12:09 +00:00
if (pk6.Ball == 0x01) // Master Ball
return new LegalityCheck(Severity.Invalid, "Master Ball on egg origin.");
Add more strict ball checks Sport/Apricorn/Safari/Dream checked Also snuck in encountertype tracking for readability/calcOnce
2016-03-28 05:05:51 +00:00
if (pk6.Ball == 0x10) // Cherish Ball
Add Master Ball & Gender based Ball checks Safari ball and general ball checks for past gen pkm are still weaker than they can be.
2016-03-27 00:12:09 +00:00
return new LegalityCheck(Severity.Invalid, "Cherish Ball on non-event.");
if (pk6.Gender == 2) // Genderless
return pk6.Ball != 0x04 // Must be Pokéball as ball can only pass via mother (not Ditto!)
? new LegalityCheck(Severity.Invalid, "Non-Pokéball on genderless egg.")
: new LegalityCheck(Severity.Valid, "Pokéball on genderless egg.");
if (Legal.BreedMaleOnly.Contains(pk6.Species))
return pk6.Ball != 0x04 // Must be Pokéball as ball can only pass via mother (not Ditto!)
? new LegalityCheck(Severity.Invalid, "Non-Pokéball on Male-Only egg.")
: new LegalityCheck(Severity.Valid, "Pokéball on Male-Only egg.");
Add more strict ball checks Sport/Apricorn/Safari/Dream checked Also snuck in encountertype tracking for readability/calcOnce
2016-03-28 05:05:51 +00:00
if (pk6.Ball == 0x05) // Safari Ball
{
if (Legal.getLineage(pk6).All(e => !Legal.Inherit_Safari.Contains(e)))
return new LegalityCheck(Severity.Invalid, "Safari Ball not possible for species.");
if (pk6.AbilityNumber == 4)
return new LegalityCheck(Severity.Invalid, "Safari Ball with Hidden Ability.");
return new LegalityCheck(Severity.Valid, "Safari Ball possible for species.");
}
if (0x10 < pk6.Ball && pk6.Ball < 0x18) // Apricorn Ball
{
if (Legal.getLineage(pk6).All(e => !Legal.Inherit_Apricorn.Contains(e)))
return new LegalityCheck(Severity.Invalid, "Apricorn Ball not possible for species.");
if (pk6.AbilityNumber == 4)
return new LegalityCheck(Severity.Invalid, "Apricorn Ball with Hidden Ability.");
return new LegalityCheck(Severity.Valid, "Apricorn Ball possible for species.");
}
if (pk6.Ball == 0x18) // Sport Ball
{
if (Legal.getLineage(pk6).All(e => !Legal.Inherit_Sport.Contains(e)))
return new LegalityCheck(Severity.Invalid, "Sport Ball not possible for species.");
if (pk6.AbilityNumber == 4)
return new LegalityCheck(Severity.Invalid, "Sport Ball with Hidden Ability.");
return new LegalityCheck(Severity.Valid, "Sport Ball possible for species.");
}
if (pk6.Ball == 0x19) // Dream Ball
{
if (Legal.getLineage(pk6).All(e => !Legal.Inherit_Dream.Contains(e)))
return new LegalityCheck(Severity.Invalid, "Dream Ball not possible for species.");
return new LegalityCheck(Severity.Valid, "Dream Ball possible for species.");
}
Add Apricorn & Hidden Ability check Thanks Eskuero!
2016-03-27 03:52:06 +00:00
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
if (pk6.Species > 650 && pk6.Species != 700) // Sylveon
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
return !Legal.WildPokeballs.Contains(pk6.Ball)
? new LegalityCheck(Severity.Invalid, "Unobtainable ball for Kalos origin.")
: new LegalityCheck(Severity.Valid, "Obtainable ball for Kalos origin.");
Add more strict ball checks Sport/Apricorn/Safari/Dream checked Also snuck in encountertype tracking for readability/calcOnce
2016-03-28 05:05:51 +00:00
Add Gen3/4 Ball exclusions Additional Changes: Removed duplicate EncounterLink check Moved RelearnBase resetting to the verifyRelearn() method.
2016-03-29 05:30:23 +00:00
if (0x0D <= pk6.Ball && pk6.Ball <= 0x0F)
{
if (Legal.Ban_Gen4Ball.Contains(pk6.Species))
return new LegalityCheck(Severity.Invalid, "Unobtainable capture for Gen4 Ball.");
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
Add Gen3/4 Ball exclusions Additional Changes: Removed duplicate EncounterLink check Moved RelearnBase resetting to the verifyRelearn() method.
2016-03-29 05:30:23 +00:00
return new LegalityCheck(Severity.Valid, "Obtainable capture for Gen4 Ball.");
}
if (0x02 <= pk6.Ball && pk6.Ball <= 0x0C) // Don't worry, Ball # 0x05 was already checked.
{
if (Legal.Ban_Gen3Ball.Contains(pk6.Species))
return new LegalityCheck(Severity.Invalid, "Unobtainable capture for Gen4 Ball.");
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
Add Gen3/4 Ball exclusions Additional Changes: Removed duplicate EncounterLink check Moved RelearnBase resetting to the verifyRelearn() method.
2016-03-29 05:30:23 +00:00
return new LegalityCheck(Severity.Valid, "Obtainable capture for Gen4 Ball.");
}
}
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
Add Gen3/4 Ball exclusions Additional Changes: Removed duplicate EncounterLink check Moved RelearnBase resetting to the verifyRelearn() method.
2016-03-29 05:30:23 +00:00
return new LegalityCheck(Severity.Invalid, "No ball check satisfied, assuming illegal.");
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
}
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
private LegalityCheck verifyHandlerMemories()
{
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
if (!Encounter.Valid)
return new LegalityCheck(Severity.Valid, "Skipped Memory check due to other check being invalid.");
Move MatchedWC6 into EncounterMatch
2016-03-23 05:49:46 +00:00
WC6 MatchedWC6 = EncounterMatch as WC6;
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
if (MatchedWC6?.OT.Length > 0) // Has Event OT -- null propagation yields false if MatchedWC6=null
{
if (pk6.OT_Friendship != PKX.getBaseFriendship(pk6.Species))
return new LegalityCheck(Severity.Invalid, "Event OT Friendship does not match base friendship.");
if (pk6.OT_Affection != 0)
return new LegalityCheck(Severity.Invalid, "Event OT Affection should be zero.");
if (pk6.CurrentHandler != 1)
return new LegalityCheck(Severity.Invalid, "Current handler should not be Event OT.");
}
if (!pk6.WasEvent && (pk6.HT_Name.Length == 0 || pk6.Geo1_Country == 0)) // Is not Traded
{
if (pk6.HT_Name.Length != 0)
return new LegalityCheck(Severity.Invalid, "GeoLocation -- HT Name present but has no previous Country.");
if (pk6.Geo1_Country != 0)
return new LegalityCheck(Severity.Invalid, "GeoLocation -- Previous country of residence but no Handling Trainer.");
if (pk6.HT_Memory != 0)
return new LegalityCheck(Severity.Invalid, "Memory -- Handling Trainer memory present but no Handling Trainer.");
if (pk6.CurrentHandler != 0) // Badly edited; PKHeX doesn't trip this.
return new LegalityCheck(Severity.Invalid, "Untraded -- Current handler should not be the Handling Trainer.");
if (pk6.HT_Friendship != 0)
return new LegalityCheck(Severity.Invalid, "Untraded -- Handling Trainer Friendship should be zero.");
if (pk6.HT_Affection != 0)
return new LegalityCheck(Severity.Invalid, "Untraded -- Handling Trainer Affection should be zero.");
// We know it is untraded (HT is empty), if it must be trade evolved flag it.
if (Legal.getHasTradeEvolved(pk6))
{
if (pk6.Species != 350) // Milotic
return new LegalityCheck(Severity.Invalid, "Untraded -- requires a trade evolution.");
if (pk6.CNT_Beauty < 170) // Beauty Contest Stat Requirement
return new LegalityCheck(Severity.Invalid, "Untraded -- Beauty is not high enough for Levelup Evolution.");
}
}
else // Is Traded
{
if (pk6.HT_Memory == 0)
return new LegalityCheck(Severity.Invalid, "Memory -- missing Handling Trainer Memory.");
}
// Unimplemented: Ingame Trade Memories
return new LegalityCheck(Severity.Valid, "History is valid.");
}
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
private LegalityCheck[] verifyMoves()
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
{
int[] Moves = pk6.Moves;
LegalityCheck[] res = new LegalityCheck[4];
for (int i = 0; i < 4; i++)
res[i] = new LegalityCheck();
if (!pk6.Gen6)
return res;
var validMoves = Legal.getValidMoves(pk6).ToArray();
if (pk6.Species == 235)
{
for (int i = 0; i < 4; i++)
res[i] = Legal.InvalidSketch.Contains(Moves[i])
? new LegalityCheck(Severity.Invalid, "Invalid Sketch move.")
: new LegalityCheck();
}
else
{
int[] RelearnMoves = pk6.RelearnMoves;
Move MatchedWC6 into EncounterMatch
2016-03-23 05:49:46 +00:00
WC6 MatchedWC6 = EncounterMatch as WC6;
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
int[] WC6Moves = MatchedWC6?.Moves ?? new int[0];
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
for (int i = 0; i < 4; i++)
{
if (Moves[i] == Legal.Struggle)
res[i] = new LegalityCheck(Severity.Invalid, "Invalid Move: Struggle.");
else if (validMoves.Contains(Moves[i]))
res[i] = new LegalityCheck(Severity.Valid, "Level-up.");
else if (RelearnMoves.Contains(Moves[i]))
RelearnMove suggestion instead of copyMoves
2016-03-25 07:10:11 +00:00
res[i] = new LegalityCheck(Severity.Valid, "Relearn Move.") {Flag = true};
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
else if (WC6Moves.Contains(Moves[i]))
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
res[i] = new LegalityCheck(Severity.Valid, "Wonder Card Non-Relearn Move.");
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
else
res[i] = new LegalityCheck(Severity.Invalid, "Invalid Move.");
}
}
if (Moves[0] == 0)
res[0] = new LegalityCheck(Severity.Invalid, "Invalid Move.");
Add Keldeo move mismatch Probably going to move to a form check later.
2016-03-15 06:54:13 +00:00
if (pk6.Species == 647) // Keldeo
Fix Keldeo Secret Sword
2016-03-19 14:53:55 +00:00
if (pk6.AltForm == 1 ^ pk6.Moves.Contains(548))
res[0] = new LegalityCheck(Severity.Invalid, "Secret Sword / Resolute Keldeo Mismatch.");
Add Keldeo move mismatch Probably going to move to a form check later.
2016-03-15 06:54:13 +00:00
Add duplicate move check Cleanup the class too.
2016-03-15 06:26:51 +00:00
// Duplicate Moves Check
for (int i = 0; i < 4; i++)
if (Moves.Count(m => m != 0 && m == Moves[i]) > 1)
res[i] = new LegalityCheck(Severity.Invalid, "Duplicate Move.");
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
return res;
}
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
private LegalityCheck[] verifyRelearn()
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
{
Add Gen3/4 Ball exclusions Additional Changes: Removed duplicate EncounterLink check Moved RelearnBase resetting to the verifyRelearn() method.
2016-03-29 05:30:23 +00:00
RelearnBase = null;
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
LegalityCheck[] res = new LegalityCheck[4];
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
int[] Moves = pk6.RelearnMoves;
if (!pk6.Gen6)
goto noRelearn;
if (pk6.WasLink)
{
Move MatchedWC6 into EncounterMatch
2016-03-23 05:49:46 +00:00
var Link = Legal.getValidLinkGifts(pk6);
if (Link == null)
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
{
for (int i = 0; i < 4; i++)
res[i] = new LegalityCheck();
return res;
}
Move MatchedWC6 into EncounterMatch
2016-03-23 05:49:46 +00:00
EncounterMatch = Link;
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
int[] moves = ((EncounterLink)EncounterMatch).RelearnMoves;
RelearnMove suggestion instead of copyMoves
2016-03-25 07:10:11 +00:00
RelearnBase = moves;
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
for (int i = 0; i < 4; i++)
res[i] = moves[i] != Moves[i]
Update changelog (03-26-16) new release posted (03-26-16)
2016-03-26 03:39:31 +00:00
? new LegalityCheck(Severity.Invalid, $"Expected ID: {moves[i]}.")
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
: new LegalityCheck();
return res;
}
if (pk6.WasEvent || pk6.WasEventEgg)
{
// Get WC6's that match
IEnumerable<WC6> vwc6 = Legal.getValidWC6s(pk6);
foreach (var wc in vwc6)
{
int[] moves = wc.RelearnMoves;
for (int i = 0; i < 4; i++)
res[i] = moves[i] != Moves[i]
Update changelog (03-26-16) new release posted (03-26-16)
2016-03-26 03:39:31 +00:00
? new LegalityCheck(Severity.Invalid, $"Expected ID: {moves[i]}.")
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
: new LegalityCheck(Severity.Valid, $"Matched WC #{wc.CardID.ToString("0000")}");
if (res.All(r => r.Valid))
RelearnMove suggestion instead of copyMoves
2016-03-25 07:10:11 +00:00
{ EncounterMatch = wc; RelearnBase = moves; return res; }
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
}
Add more strict ball checks Sport/Apricorn/Safari/Dream checked Also snuck in encountertype tracking for readability/calcOnce
2016-03-28 05:05:51 +00:00
EncounterMatch = EncounterType = null;
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
goto noRelearn; // No WC match
}
if (pk6.WasEgg)
{
const int games = 2;
bool checkAllGames = pk6.WasTradedEgg;
bool splitBreed = Legal.SplitBreed.Contains(pk6.Species);
int iterate = (checkAllGames ? games : 1) * (splitBreed ? 2 : 1);
for (int i = 0; i < iterate; i++)
{
int gameSource = !checkAllGames ? -1 : i % iterate / (splitBreed ? 2 : 1);
int skipOption = splitBreed && iterate / 2 <= i ? 1 : 0;
Further relearn tweaks
2016-03-12 22:07:57 +00:00
// Obtain level1 moves
Tweak egg move check Renamed some variables, fixed an internal error
2016-03-12 18:35:17 +00:00
List<int> baseMoves = new List<int>(Legal.getBaseEggMoves(pk6, skipOption, gameSource));
int baseCt = baseMoves.Count;
if (baseCt > 4) baseCt = 4;
Further relearn tweaks
2016-03-12 22:07:57 +00:00
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
// Obtain Nonstandard moves
Further relearn tweaks
2016-03-12 22:07:57 +00:00
var relearnMoves = Legal.getValidRelearn(pk6, skipOption).ToArray();
var relearn = pk6.RelearnMoves.Where(move => move != 0
&& (!baseMoves.Contains(move) || relearnMoves.Contains(move))
).ToArray();
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
int relearnCt = relearn.Length;
Further relearn tweaks
2016-03-12 22:07:57 +00:00
Tweak egg move check Renamed some variables, fixed an internal error
2016-03-12 18:35:17 +00:00
// Get Move Window
List<int> window = new List<int>(baseMoves);
window.AddRange(relearn);
int[] moves = window.Skip(baseCt + relearnCt - 4).Take(4).ToArray();
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
Array.Resize(ref moves, 4);
Tweak egg move check Renamed some variables, fixed an internal error
2016-03-12 18:35:17 +00:00
int req;
if (relearnCt == 4)
req = 0;
else if (baseCt + relearnCt > 4)
req = 4 - relearnCt;
else
req = baseCt;
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
// Movepool finalized! Check validity.
int[] rl = pk6.RelearnMoves;
Tweak egg move check Renamed some variables, fixed an internal error
2016-03-12 18:35:17 +00:00
string em = string.Join(", ", baseMoves);
RelearnMove suggestion instead of copyMoves
2016-03-25 07:10:11 +00:00
RelearnBase = baseMoves.ToArray();
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
// Base Egg Move
for (int j = 0; j < req; j++)
Tweak egg move check Renamed some variables, fixed an internal error
2016-03-12 18:35:17 +00:00
res[j] = !baseMoves.Contains(rl[j])
? new LegalityCheck(Severity.Invalid, $"Base egg move missing; expected one of: {em}.")
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
: new LegalityCheck(Severity.Valid, "Base egg move.");
// Non-Base
Further relearn tweaks
2016-03-12 22:07:57 +00:00
if (Legal.LightBall.Contains(pk6.Species))
relearnMoves = relearnMoves.Concat(new[] { 344 }).ToArray();
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
for (int j = req; j < 4; j++)
res[j] = !relearnMoves.Contains(rl[j])
? new LegalityCheck(Severity.Invalid, "Not an expected relearn move.")
: new LegalityCheck(Severity.Valid, "Relearn move.");
if (res.All(r => r.Valid))
break;
}
return res;
}
if (Moves[0] != 0) // DexNav only?
{
// Check DexNav
if (!Legal.getDexNavValid(pk6))
goto noRelearn;
res[0] = !Legal.getValidRelearn(pk6, 0).Contains(Moves[0])
? new LegalityCheck(Severity.Invalid, "Not an expected DexNav move.")
: new LegalityCheck();
for (int i = 1; i < 4; i++)
res[i] = Moves[i] != 0
? new LegalityCheck(Severity.Invalid, "Expected no Relearn Move in slot.")
: new LegalityCheck();
RelearnMove suggestion instead of copyMoves
2016-03-25 07:10:11 +00:00
if (res[0].Valid)
RelearnBase = new[] { Moves[0], 0, 0, 0 };
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
return res;
}
// Should have no relearn moves.
noRelearn:
for (int i = 0; i < 4; i++)
res[i] = Moves[i] != 0
? new LegalityCheck(Severity.Invalid, "Expected no Relearn Moves.")
: new LegalityCheck();
return res;
}
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
Update changelog (03-26-16) new release posted (03-26-16)
2016-03-26 03:39:31 +00:00
private static readonly string[] EventRibName =
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
{
"Country", "National", "Earth", "World", "Classic",
"Premier", "Event", "Birthday", "Special", "Souvenir",
"Wishing", "Battle Champ", "Regional Champ", "National Champ", "World Champ"
};
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
}
Reference in a new issue Copy permalink