PKHeX/PKHeX.Core/Saves/Substructures/Gen7/FieldMoveModelSave7.cs

using System;
using static System.Buffers.Binary.BinaryPrimitives;

namespace PKHeX.Core;

public sealed class FieldMoveModelSave7 : SaveBlock<SAV7>
{
    public FieldMoveModelSave7(SAV7SM sav, int offset) : base(sav) => Offset = offset;
    public FieldMoveModelSave7(SAV7USUM sav, int offset) : base(sav) => Offset = offset;

    public int M { get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x00)); set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x00), (ushort)value); }
    public float X { get => ReadSingleLittleEndian(Data.AsSpan(Offset + 0x08)); set => WriteSingleLittleEndian(Data.AsSpan(Offset + 0x08), value); }
    public float Z { get => ReadSingleLittleEndian(Data.AsSpan(Offset + 0x10)); set => WriteSingleLittleEndian(Data.AsSpan(Offset + 0x10), value); }
    public float Y { get => (int)ReadSingleLittleEndian(Data.AsSpan(Offset + 0x18)); set => WriteSingleLittleEndian(Data.AsSpan(Offset + 0x18), value); }
    public float R { get => (int)ReadSingleLittleEndian(Data.AsSpan(Offset + 0x20)); set => WriteSingleLittleEndian(Data.AsSpan(Offset + 0x20), value); }
}
-												Split gen5-7 saves with inheritance (#2319)

refer to pull request comments for summary
											
										
										
											2019-06-09 02:56:11 +00:00
+								using System;
-												Refactoring: Span-based value writes and method signatures (#3361)

Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to.

`System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API.

The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder.

Other Fixes included:
- The Super Training UI for Gen6 has been reworked according to the latest block structure additions.
- Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list).
- Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
											
										
										
											2022-01-03 05:35:59 +00:00
+								using static System.Buffers.Binary.BinaryPrimitives;
-												Split gen5-7 saves with inheritance (#2319)

refer to pull request comments for summary
											
										
										
											2019-06-09 02:56:11 +00:00
-												File scoped namespaces (#3529)

[Language Reference](https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-10.0/file-scoped-namespaces)

Updates all the files, one less level of indentation.

Some small changes were made to API surfaces, renaming `PKM pkm` -> `PKM pk`, and `LegalityAnalysis.pkm` -> `LegalityAnalysis.Entity`
											
										
										
											2022-06-18 18:04:24 +00:00
+								namespace PKHeX.Core;
 								public sealed class FieldMoveModelSave7 : SaveBlock<SAV7>
-												Split gen5-7 saves with inheritance (#2319)

refer to pull request comments for summary
											
										
										
											2019-06-09 02:56:11 +00:00
+								{
-												File scoped namespaces (#3529)

[Language Reference](https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-10.0/file-scoped-namespaces)

Updates all the files, one less level of indentation.

Some small changes were made to API surfaces, renaming `PKM pkm` -> `PKM pk`, and `LegalityAnalysis.pkm` -> `LegalityAnalysis.Entity`
											
										
										
											2022-06-18 18:04:24 +00:00
+								    public FieldMoveModelSave7(SAV7SM sav, int offset) : base(sav) => Offset = offset;
 								    public FieldMoveModelSave7(SAV7USUM sav, int offset) : base(sav) => Offset = offset;
-												Split gen5-7 saves with inheritance (#2319)

refer to pull request comments for summary
											
										
										
											2019-06-09 02:56:11 +00:00
-												File scoped namespaces (#3529)

[Language Reference](https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-10.0/file-scoped-namespaces)

Updates all the files, one less level of indentation.

Some small changes were made to API surfaces, renaming `PKM pkm` -> `PKM pk`, and `LegalityAnalysis.pkm` -> `LegalityAnalysis.Entity`
											
										
										
											2022-06-18 18:04:24 +00:00
+								    public int M { get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x00)); set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x00), (ushort)value); }
 								    public float X { get => ReadSingleLittleEndian(Data.AsSpan(Offset + 0x08)); set => WriteSingleLittleEndian(Data.AsSpan(Offset + 0x08), value); }
 								    public float Z { get => ReadSingleLittleEndian(Data.AsSpan(Offset + 0x10)); set => WriteSingleLittleEndian(Data.AsSpan(Offset + 0x10), value); }
 								    public float Y { get => (int)ReadSingleLittleEndian(Data.AsSpan(Offset + 0x18)); set => WriteSingleLittleEndian(Data.AsSpan(Offset + 0x18), value); }
 								    public float R { get => (int)ReadSingleLittleEndian(Data.AsSpan(Offset + 0x20)); set => WriteSingleLittleEndian(Data.AsSpan(Offset + 0x20), value); }
 								}