Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-24 13:03:06 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Verifiers/BallVerifier.cs

371 lines
16 KiB
C#
Raw Normal View History

Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
using System.Collections.Generic;
using static PKHeX.Core.LegalityCheckStrings;
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
using static PKHeX.Core.Ball;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
namespace PKHeX.Core
{
Misc simplifications / xmldoc
2018-07-02 02:17:37 +00:00
/// <summary>
/// Verifies the <see cref="PKM.Ball"/> value.
/// </summary>
public sealed class BallVerifier : Verifier
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
protected override CheckIdentifier Identifier => CheckIdentifier.Ball;
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
private CheckResult NONE => GetInvalid(LBallNone);
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
public override void Verify(LegalityAnalysis data)
{
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
if (data.pkm.Format <= 2)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
return; // no ball info saved
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
var result = VerifyBall(data);
data.AddLine(result);
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
private CheckResult VerifyBall(LegalityAnalysis data)
{
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
var EncounterMatch = data.EncounterMatch;
var Info = data.Info;
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
// Fixed ball cases -- can be only one ball ever
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
switch (EncounterMatch)
{
case MysteryGift g:
return VerifyBallMysteryGift(data, g);
case EncounterTrade t:
return VerifyBallEquals(data, t.Ball);
case EncounterStatic s when s.Gift:
return VerifyBallEquals(data, s.Ball);
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
// Capture / Inherit cases -- can be one of many balls
var pkm = data.pkm;
More shedinja edge cases Don't allow shedinja evolution moves if it wasn't evolved in that generation
2020-04-12 18:28:03 +00:00
if (pkm.Species == (int)Species.Shedinja && data.EncounterMatch.Species != (int)Species.Shedinja) // Shedinja. For gen3, copy the ball from Nincada
{
// Only Gen3 origin Shedinja can copy the wild ball.
// Evolution chains will indicate if it could have existed as Shedinja in Gen3.
// The special move verifier has a similar check!
if (Info.Generation != 3 || Info.EvoChainsAllGens[3].Count != 2)
return VerifyBallEquals(data, (int)Poke); // Pokeball Only
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (pkm.Ball == (int)Heavy && Legal.AlolanCaptureNoHeavyBall.Contains(EncounterMatch.Species) && !EncounterMatch.EggEncounter && pkm.SM)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallHeavy); // Heavy Ball, can inherit if from egg (USUM fixed catch rate calc)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Bump lang version to 8 some lang upgrades
2019-10-05 03:10:50 +00:00
return EncounterMatch switch
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
{
Bump lang version to 8 some lang upgrades
2019-10-05 03:10:50 +00:00
EncounterStatic e => VerifyBallStatic(data, e),
EncounterSlot w => VerifyBallWild(data, w),
EncounterEgg _ => VerifyBallEgg(data),
EncounterInvalid _ => VerifyBallEquals(data, pkm.Ball), // ignore ball, pass whatever
_ => VerifyBallEquals(data, (int)Poke)
};
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
private CheckResult VerifyBallMysteryGift(LegalityAnalysis data, MysteryGift g)
{
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if (g.Generation == 4 && g.Species == (int)Species.Manaphy && g.Ball == 0) // there is no ball data in Manaphy Mystery Gift from Gen4
sync missing content yay rename
2018-08-26 18:29:47 +00:00
return VerifyBallEquals(data, (int)Poke); // Pokeball
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
return VerifyBallEquals(data, g.Ball);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
private CheckResult VerifyBallStatic(LegalityAnalysis data, EncounterStatic s)
{
if (s.Location == 75 && s.Generation == 5) // Entree Forest (Dream World)
return VerifyBallEquals(data, Legal.DreamWorldBalls);
Remove some reliance on GenNumber
2020-05-31 19:12:48 +00:00
return VerifyBallEquals(data, Legal.GetWildBalls(data.Info.Generation, data.Info.Game));
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Offload EncounterSlot loading logic to reduce complexity (#2980) * Rework gen1 slot loading Slot templates are precomputed from ROM data and just loaded straight in, with tight coupling to the encounter area (grouped by slot types). * Revise fuzzy met check for underleveled wild evos Example: Level 23 poliwhirl in RBY as a level 50 poliwhirl, will assume the chain is 25-50 for poliwhirl (as poliwag evolves at 25). Instead of revising the origin chain, just ignore the evo min level in the comparison. Previous commit fixed it for gen1. * Rework gen2-4 slot loading Gen4 not finished, Type Encounter data and some edge encounters not recognizing yet... * Add feebas slots for old/good encounters * Begin moving properties Great news! Gen5-7 need to be de-dumbed like Gen1-4. Then I can remove the bang (!) on the Area accessor and ensure that it's never null! * Split off XD pokespot slot encounter table type * Set area in constructor * Deduplicate g3 roaming encounters * Deduplicate xd encounter locations (rebattle) Only difference is met location; no need to create 500 extra encounter objects. A simple contains check is ok (rarely in gen3 format). * Make all slots have a readonly reference to their parent area * Minor clean * Remove "Safari" slot type flag Can be determined via other means (generation-location), allows us to reduce the size of SlotType member to a byte Output of slot binaries didn't preserve the Safari flag anyway. * Update SlotType.cs * Handle type encounters correctly * Merge safari area into regular xy area * Merge dexnav accessor logic * fix some logic so that tests pass again rearrange g5 dw init to be done outside of static constructor (initializer instead) PIDGenerator: friend safari slots now generate with required flawless IV count * Add cianwood tentacool gift encounter * Remove unnecessary abstractions Fake area just returned a slot; since Slots have a non-null reference to the area, we can just return the slot and use the API to grab a list of possible slots for the chain. Increase restrictiveness of location/type get-set operations * Minor tweaks, pass parameters DexNav observed state isn't necessary to use, only need to see if it's possible to dexnav. Now that we have metadata for slots, we can. * Remove unused legality tables
2020-08-30 17:23:22 +00:00
private CheckResult VerifyBallWild(LegalityAnalysis data, EncounterSlot w)
{
Minor clean Add some xmldoc, remove some empty lines, move some small logic pieces to a better spot
2020-09-03 21:28:51 +00:00
var req = w.Area.Type.GetRequiredBallValueWild(w.Generation, w.Location);
Offload EncounterSlot loading logic to reduce complexity (#2980) * Rework gen1 slot loading Slot templates are precomputed from ROM data and just loaded straight in, with tight coupling to the encounter area (grouped by slot types). * Revise fuzzy met check for underleveled wild evos Example: Level 23 poliwhirl in RBY as a level 50 poliwhirl, will assume the chain is 25-50 for poliwhirl (as poliwag evolves at 25). Instead of revising the origin chain, just ignore the evo min level in the comparison. Previous commit fixed it for gen1. * Rework gen2-4 slot loading Gen4 not finished, Type Encounter data and some edge encounters not recognizing yet... * Add feebas slots for old/good encounters * Begin moving properties Great news! Gen5-7 need to be de-dumbed like Gen1-4. Then I can remove the bang (!) on the Area accessor and ensure that it's never null! * Split off XD pokespot slot encounter table type * Set area in constructor * Deduplicate g3 roaming encounters * Deduplicate xd encounter locations (rebattle) Only difference is met location; no need to create 500 extra encounter objects. A simple contains check is ok (rarely in gen3 format). * Make all slots have a readonly reference to their parent area * Minor clean * Remove "Safari" slot type flag Can be determined via other means (generation-location), allows us to reduce the size of SlotType member to a byte Output of slot binaries didn't preserve the Safari flag anyway. * Update SlotType.cs * Handle type encounters correctly * Merge safari area into regular xy area * Merge dexnav accessor logic * fix some logic so that tests pass again rearrange g5 dw init to be done outside of static constructor (initializer instead) PIDGenerator: friend safari slots now generate with required flawless IV count * Add cianwood tentacool gift encounter * Remove unnecessary abstractions Fake area just returned a slot; since Slots have a non-null reference to the area, we can just return the slot and use the API to grab a list of possible slots for the chain. Increase restrictiveness of location/type get-set operations * Minor tweaks, pass parameters DexNav observed state isn't necessary to use, only need to see if it's possible to dexnav. Now that we have metadata for slots, we can. * Remove unused legality tables
2020-08-30 17:23:22 +00:00
if (req != None)
return VerifyBallEquals(data, (int) req);
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
Remove some reliance on GenNumber
2020-05-31 19:12:48 +00:00
return VerifyBallEquals(data, Legal.GetWildBalls(data.Info.Generation, data.Info.Game));
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
private CheckResult VerifyBallEgg(LegalityAnalysis data)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
var pkm = data.pkm;
if (data.Info.Generation < 6) // No inheriting Balls
sync missing content yay rename
2018-08-26 18:29:47 +00:00
return VerifyBallEquals(data, (int)Poke); // Must be Pokéball -- no ball inheritance.
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
Bump lang version to 8 some lang upgrades
2019-10-05 03:10:50 +00:00
return pkm.Ball switch
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Bump lang version to 8 some lang upgrades
2019-10-05 03:10:50 +00:00
(int)Poke => GetValid(LBallEnc), // Poké Ball
(int)Master => GetInvalid(LBallEggMaster), // Master Ball
(int)Cherish => GetInvalid(LBallEggCherish), // Cherish Ball
_ => VerifyBallInherited(data)
};
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
private CheckResult VerifyBallInherited(LegalityAnalysis data)
{
Bump lang version to 8 some lang upgrades
2019-10-05 03:10:50 +00:00
return data.Info.Generation switch
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Bump lang version to 8 some lang upgrades
2019-10-05 03:10:50 +00:00
6 => VerifyBallEggGen6(data), // Gen6 Inheritance Rules
7 => VerifyBallEggGen7(data), // Gen7 Inheritance Rules
8 => VerifyBallEggGen8(data),
_ => NONE
};
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
private CheckResult VerifyBallEggGen6(LegalityAnalysis data)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
var pkm = data.pkm;
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
int species = data.EncounterMatch.Species;
if (pkm.Gender == 2 || Legal.BreedMaleOnly.Contains(species)) // Genderless
sync missing content yay rename
2018-08-26 18:29:47 +00:00
return VerifyBallEquals(data, (int)Poke); // Must be Pokéball as ball can only pass via mother (not Ditto!)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
Ball ball = (Ball)pkm.Ball;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (ball == Safari) // Safari Ball
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Simplify ball/catchrate lineage checks should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.
2018-07-01 17:13:26 +00:00
if (!Legal.Inherit_Safari.Contains(species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallSpecies);
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if (IsHiddenAndNotPossible(pkm))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallAbility);
return GetValid(LBallSpeciesPass);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (ball.IsApricornBall()) // Apricorn Ball
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Simplify ball/catchrate lineage checks should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.
2018-07-01 17:13:26 +00:00
if (!Legal.Inherit_Apricorn6.Contains(species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallSpecies);
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if (IsHiddenAndNotPossible(pkm))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallAbility);
return GetValid(LBallSpeciesPass);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (ball == Sport) // Sport Ball
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Simplify ball/catchrate lineage checks should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.
2018-07-01 17:13:26 +00:00
if (!Legal.Inherit_Sport.Contains(species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallSpecies);
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if (IsHiddenAndNotPossible(pkm))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallAbility);
return GetValid(LBallSpeciesPass);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (ball == Dream) // Dream Ball
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if (Legal.Ban_DreamHidden.Contains(species) && IsHiddenAndNotPossible(pkm))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallAbility);
Simplify ball/catchrate lineage checks should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.
2018-07-01 17:13:26 +00:00
if (Legal.Inherit_Dream.Contains(species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetValid(LBallSpeciesPass);
return GetInvalid(LBallSpecies);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (Dusk <= ball && ball <= Quick) // Dusk Heal Quick
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
if (!Legal.Ban_Gen4Ball_6.Contains(species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetValid(LBallSpeciesPass);
return GetInvalid(LBallSpecies);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (Ultra <= ball && ball <= Premier) // Don't worry, Safari was already checked.
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
if (Legal.Ban_Gen3Ball.Contains(species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallSpecies);
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if (Legal.Ban_Gen3BallHidden.Contains(pkm.SpecForm) && IsHiddenAndNotPossible(pkm))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallAbility);
return GetValid(LBallSpeciesPass);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
if (species > 650 && species != 700) // Sylveon
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
if (Legal.WildPokeballs6.Contains(pkm.Ball))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetValid(LBallSpeciesPass);
return GetInvalid(LBallSpecies);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (ball >= Dream)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallUnavailable);
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
return NONE;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
private CheckResult VerifyBallEggGen7(LegalityAnalysis data)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
var pkm = data.pkm;
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
int species = data.EncounterMatch.Species;
if (722 <= species && species <= 730) // G7 Starters
sync missing content yay rename
2018-08-26 18:29:47 +00:00
return VerifyBallEquals(data, (int)Poke);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
Ball ball = (Ball)pkm.Ball;
Simplify ball/catchrate lineage checks should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.
2018-07-01 17:13:26 +00:00
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (ball == Safari)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Simplify ball/catchrate lineage checks should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.
2018-07-01 17:13:26 +00:00
if (!(Legal.Inherit_Safari.Contains(species) || Legal.Inherit_SafariMale.Contains(species)))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallSpecies);
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if (Legal.Ban_SafariBallHidden_7.Contains(species) && IsHiddenAndNotPossible(pkm))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallAbility);
return GetValid(LBallSpeciesPass);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (ball.IsApricornBall()) // Apricorn Ball
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Simplify ball/catchrate lineage checks should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.
2018-07-01 17:13:26 +00:00
if (!Legal.Inherit_Apricorn7.Contains(species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallSpecies);
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if (Legal.Ban_NoHidden7Apricorn.Contains(species | pkm.AltForm << 11) && IsHiddenAndNotPossible(pkm))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallAbility);
return GetValid(LBallSpeciesPass);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (ball == Sport) // Sport Ball
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Simplify ball/catchrate lineage checks should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.
2018-07-01 17:13:26 +00:00
if (!Legal.Inherit_Sport.Contains(species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallSpecies);
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if ((species == (int)Species.Volbeat || species == (int)Species.Illumise) && IsHiddenAndNotPossible(pkm)) // Volbeat/Illumise
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallAbility);
return GetValid(LBallSpeciesPass);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (ball == Dream) // Dream Ball
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Simplify ball/catchrate lineage checks should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.
2018-07-01 17:13:26 +00:00
if (Legal.Inherit_Dream.Contains(species) || Legal.Inherit_DreamMale.Contains(species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetValid(LBallSpeciesPass);
return GetInvalid(LBallSpecies);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (Dusk <= ball && ball <= Quick) // Dusk Heal Quick
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Simplify ball/catchrate lineage checks should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.
2018-07-01 17:13:26 +00:00
if (!Legal.Ban_Gen4Ball_7.Contains(species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetValid(LBallSpeciesPass);
return GetInvalid(LBallSpecies);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (Ultra <= ball && ball <= Premier) // Don't worry, Safari was already checked.
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Simplify ball/catchrate lineage checks should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.
2018-07-01 17:13:26 +00:00
if (!Legal.Ban_Gen3Ball_7.Contains(species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetValid(LBallSpeciesPass);
return GetInvalid(LBallSpecies);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (ball == Beast)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if (species == (int)Species.Flabébé && pkm.AltForm == 3 && IsHiddenAndNotPossible(pkm))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallAbility); // Can't obtain Flabébé-Blue with Hidden Ability in wild
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if (species == (int)Species.Voltorb && IsHiddenAndNotPossible(pkm))
Ban bred HA voltorb in beast ball https://projectpokemon.org/home/forums/topic/56212-legality-ha-voltorb-in-beast-ball/ https://www.reddit.com/r/BankBallExchange/comments/7boi0h/new_apricorn_and_beast_ball_combinations_for_usum/dpwu5in/ ty Prophet丶W
2020-02-09 04:24:02 +00:00
return GetInvalid(LBallAbility); // Can't obtain with Hidden Ability in wild (can only breed with Ditto)
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if (((int)Species.Pikipek <= species && species <= (int)Species.Kommoo) || (Legal.AlolanCaptureOffspring.Contains(species) && !Legal.PastGenAlolanNativesUncapturable.Contains(species)))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetValid(LBallSpeciesPass);
Simplify ball/catchrate lineage checks should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.
2018-07-01 17:13:26 +00:00
if (Legal.PastGenAlolanScans.Contains(species))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetValid(LBallSpeciesPass);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
// next statement catches all new alolans
}
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if (species > (int)Species.Volcanion)
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
return VerifyBallEquals(data, Legal.WildPokeballs7);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Add enum for ball; use in checks Increases readability instead of using hex IDs
2018-08-26 18:15:32 +00:00
if (ball > Beast)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LBallUnavailable);
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
return NONE;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
private CheckResult VerifyBallEggGen8(LegalityAnalysis data)
{
var pkm = data.pkm;
int species = data.EncounterMatch.Species;
Initial Isle of Armor support Co-Authored-By: sciresm <sciresm@users.noreply.github.com> Co-Authored-By: Matt <sora10pls@users.noreply.github.com> Co-Authored-By: Archit Date <architdate@gmail.com>
2020-06-19 23:51:15 +00:00
if (722 <= species && species <= 730) // G7 Starters
return VerifyBallEquals(data, (int)Poke);
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if ((int)Species.Grookey <= species && species <= (int)Species.Inteleon) // G8 Starters
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
return VerifyBallEquals(data, (int)Poke);
Initial Isle of Armor support Co-Authored-By: sciresm <sciresm@users.noreply.github.com> Co-Authored-By: Matt <sora10pls@users.noreply.github.com> Co-Authored-By: Archit Date <architdate@gmail.com>
2020-06-19 23:51:15 +00:00
if (IsGalarCatchAndBreed(species))
Add initial nieve check for ball inheritance Closes #2438
2019-11-17 01:45:51 +00:00
{
Permit galar native species to inherit past-gen balls
2020-03-11 00:53:56 +00:00
if (Legal.WildPokeballs8.Contains(pkm.Ball))
return GetValid(LBallSpeciesPass);
if (species >= (int)Species.Grookey)
Add initial nieve check for ball inheritance Closes #2438
2019-11-17 01:45:51 +00:00
return GetInvalid(LBallSpecies);
}
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
Ball ball = (Ball)pkm.Ball;
if (ball == Safari)
{
if (!(Legal.Inherit_Safari.Contains(species) || Legal.Inherit_SafariMale.Contains(species)))
return GetInvalid(LBallSpecies);
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if (Legal.Ban_SafariBallHidden_7.Contains(species) && IsHiddenAndNotPossible(pkm))
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
return GetInvalid(LBallAbility);
return GetValid(LBallSpeciesPass);
}
if (ball.IsApricornBall()) // Apricorn Ball
{
if (!Legal.Inherit_Apricorn7.Contains(species))
return GetInvalid(LBallSpecies);
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if (Legal.Ban_NoHidden8Apricorn.Contains(species | pkm.AltForm << 11) && IsHiddenAndNotPossible(pkm)) // lineage is 3->2->origin
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
return GetInvalid(LBallAbility);
return GetValid(LBallSpeciesPass);
}
if (ball == Sport) // Sport Ball
{
if (!Legal.Inherit_Sport.Contains(species))
return GetInvalid(LBallSpecies);
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if ((species == (int)Species.Volbeat || species == (int)Species.Illumise) && IsHiddenAndNotPossible(pkm)) // Volbeat/Illumise
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
return GetInvalid(LBallAbility);
return GetValid(LBallSpeciesPass);
}
if (ball == Dream) // Dream Ball
{
if (Legal.Inherit_Dream.Contains(species) || Legal.Inherit_DreamMale.Contains(species))
return GetValid(LBallSpeciesPass);
return GetInvalid(LBallSpecies);
}
if (Dusk <= ball && ball <= Quick) // Dusk Heal Quick
{
if (!Legal.Ban_Gen4Ball_7.Contains(species))
return GetValid(LBallSpeciesPass);
return GetInvalid(LBallSpecies);
}
if (Ultra <= ball && ball <= Premier) // Don't worry, Safari was already checked.
{
if (!Legal.Ban_Gen3Ball_7.Contains(species))
return GetValid(LBallSpeciesPass);
return GetInvalid(LBallSpecies);
}
if (ball == Beast)
{
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
if (species == (int)Species.Flabébé && pkm.AltForm == 3 && IsHiddenAndNotPossible(pkm))
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
return GetInvalid(LBallAbility); // Can't obtain Flabébé-Blue with Hidden Ability in wild
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if (((int)Species.Pikipek <= species && species <= (int)Species.Kommoo) || (Legal.AlolanCaptureOffspring.Contains(species) && !Legal.PastGenAlolanNativesUncapturable.Contains(species)))
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
return GetValid(LBallSpeciesPass);
if (Legal.PastGenAlolanScans.Contains(species))
return GetValid(LBallSpeciesPass);
// next statement catches all new alolans
}
if (species > Legal.MaxSpeciesID_7_USUM)
return VerifyBallEquals(data, Legal.WildPokeballs8);
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if (species > (int)Species.Volcanion)
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
return VerifyBallEquals(data, Legal.WildPokeballs7);
if (ball > Beast)
return GetInvalid(LBallUnavailable);
return NONE;
}
Handle Ability Patch changed abilities (#3024) Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 19:30:57 +00:00
private static bool IsHiddenAndNotPossible(PKM pkm)
{
if (pkm.AbilityNumber != 4)
return false;
return !AbilityVerifier.CanAbilityPatch(pkm.Format, pkm.PersonalInfo.Abilities);
}
Minor clean
2020-10-25 17:02:52 +00:00
private static bool IsGalarCatchAndBreed(int species)
Add initial nieve check for ball inheritance Closes #2438
2019-11-17 01:45:51 +00:00
{
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if ((int)Species.Grookey <= species && species <= (int)Species.Inteleon) // starter
Add initial nieve check for ball inheritance Closes #2438
2019-11-17 01:45:51 +00:00
return false;
Update legality comparisons for Crown Tundra Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com> Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2020-10-24 18:16:01 +00:00
Minor clean
2020-10-25 17:02:52 +00:00
// Everything breed-able that is in the Galar Dex can be captured in-game.
Add initial nieve check for ball inheritance Closes #2438
2019-11-17 01:45:51 +00:00
var pt = PersonalTable.SWSH;
Update legality comparisons for Crown Tundra Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com> Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2020-10-24 18:16:01 +00:00
var pi = (PersonalInfoSWSH) pt.GetFormeEntry(species, 0);
Allow Gen8 balls on gen3-species eggs originating in Gen8
2020-10-26 01:07:13 +00:00
if (pi.IsInDex)
return true;
// Foreign Captures
if ((int)Species.Treecko <= species && species <= (int)Species.Swampert) // Dynamax Adventures
return true;
return false;
Add initial nieve check for ball inheritance Closes #2438
2019-11-17 01:45:51 +00:00
}
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
private CheckResult VerifyBallEquals(LegalityAnalysis data, int ball) => GetResult(ball == data.pkm.Ball);
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
private CheckResult VerifyBallEquals(LegalityAnalysis data, HashSet<int> balls) => GetResult(balls.Contains(data.pkm.Ball));
Simplify ball check logic fetch a single result and add it to the analysis can probably remove the GetLineage call since the encountermatch stores the original species
2018-06-30 17:34:09 +00:00
private CheckResult VerifyBallEquals(LegalityAnalysis data, ICollection<int> balls) => GetResult(balls.Contains(data.pkm.Ball));
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
private CheckResult GetResult(bool valid) => valid ? GetValid(LBallEnc) : GetInvalid(LBallEncMismatch);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
}
Reference in a new issue Copy permalink