PKHeX/PKHeX.Core/Legality/Encounters/EncounterTrade/EncounterTradeGB.cs

namespace PKHeX.Core
{
    /// <inheritdoc cref="EncounterTrade"/>
    public abstract record EncounterTradeGB : EncounterTrade
    {
        protected EncounterTradeGB(int species, byte level, GameVersion game) : base(game)
        {
            Species = species;
            Level = level;
        }

        public abstract override bool IsMatchExact(PKM pkm, EvoCriteria evo);
    }
}
-												Abstract some gen1/2 encounter types from their parent class

											
										
										
											2020-07-18 20:36:30 +00:00
+								namespace PKHeX.Core
 								{
-												Minor tweaks

For BigEndian we don't have to invert the array access if we just iterate backwards :)
Fix xmldoc for gen1 trades ampersand
Add xmldoc for enc trade classes

No functional change.

											
										
										
											2021-09-16 01:13:17 +00:00
+								    /// <inheritdoc cref="EncounterTrade"/>
-												Split IContestStats, mark trades as records

											
										
										
											2020-12-24 08:06:40 +00:00
+								    public abstract record EncounterTradeGB : EncounterTrade
-												Abstract some gen1/2 encounter types from their parent class

											
										
										
											2020-07-18 20:36:30 +00:00
+								    {
-												-8 bytes from each encounter template

saves about ~1MB RAM savings (>=179,142 objects)

											
										
										
											2022-03-07 07:25:47 +00:00
+								        protected EncounterTradeGB(int species, byte level, GameVersion game) : base(game)
-												Abstract some gen1/2 encounter types from their parent class

											
										
										
											2020-07-18 20:36:30 +00:00
+								        {
 								            Species = species;
 								            Level = level;
 								        }
-												Eliminate boxing on encounter search (criteria)

struct implementing interface is boxed when passed to method that accepts interface (not generic method).
Removes IDexLevel (no other inheritors but EvoCriteria) and uses the primitive the data is stored (array, not IReadOnlyList) for slightly better perf.

											
										
										
											2022-05-08 01:29:36 +00:00
+								        public abstract override bool IsMatchExact(PKM pkm, EvoCriteria evo);
-												Abstract some gen1/2 encounter types from their parent class

											
										
										
											2020-07-18 20:36:30 +00:00
+								    }
 								}