PKHeX/PKHeX.Core/Legality/Encounters/EncounterTradePID.cs

namespace PKHeX.Core
{
    /// <summary>
    /// Trade Encounter data with a fixed PID.
    /// </summary>
    public sealed class EncounterTradePID : EncounterTrade
    {
        public uint PID;
        public override Shiny Shiny { get; set; } = Shiny.FixedValue;
    }
}
-												Refactoring

relocate location of stuff

											
										
										
											2018-03-09 05:18:32 +00:00
+								namespace PKHeX.Core
 								{
 								    /// <summary>
 								    /// Trade Encounter data with a fixed PID.
 								    /// </summary>
-												Update iencounterable api with new criteria arg

rearrange some logic for clearer function (extract some methods)

											
										
										
											2018-12-30 06:24:34 +00:00
+								    public sealed class EncounterTradePID : EncounterTrade
-												Refactoring

relocate location of stuff

											
										
										
											2018-03-09 05:18:32 +00:00
+								    {
 								        public uint PID;
-												Merge PIDType and bool? shiny property

Gen5 does not follow the same convention, 0 = non, 1 = rnd, 2 = always;
not gonna bother updating for just that one

bool? occupies 2 bytes; enum:byte is 1 byte.

should probably move validity checking logic into the IEncounterable
objects instead...

											
										
										
											2018-03-17 02:35:55 +00:00
+								        public override Shiny Shiny { get; set; } = Shiny.FixedValue;
-												Refactoring

relocate location of stuff

											
										
										
											2018-03-09 05:18:32 +00:00
+								    }
 								}