Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-27 14:30:56 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Verifiers/MiscVerifier.cs

564 lines
23 KiB
C#
Raw Normal View History

Add more pb7 legality checks can give nicknames to chinese mons now! Encoding looks the same @wwwwwwzx :)
2018-11-17 01:42:50 +00:00
using System;
Add fullness legality check Closes #2836 Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-05-25 03:00:32 +00:00
using System.Collections.Generic;
Add more pb7 legality checks can give nicknames to chinese mons now! Encoding looks the same @wwwwwwzx :)
2018-11-17 01:42:50 +00:00
using System.Linq;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
using static PKHeX.Core.LegalityCheckStrings;
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
using static PKHeX.Core.CheckIdentifier;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
namespace PKHeX.Core
{
Misc simplifications / xmldoc
2018-07-02 02:17:37 +00:00
/// <summary>
/// Verifies miscellaneous data including <see cref="PKM.FatefulEncounter"/> and minor values.
/// </summary>
public sealed class MiscVerifier : Verifier
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
protected override CheckIdentifier Identifier => Misc;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
public override void Verify(LegalityAnalysis data)
{
var pkm = data.pkm;
if (pkm.IsEgg)
{
VerifyMiscEggCommon(data);
if (pkm is IContestStats s && s.HasContestStats())
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LEggContest, Egg));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
switch (pkm)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Add pokestar studio fame / star stat pk5[0x87] how did this get forgotten so easily lol added legality check; eggs can't participate in pokestar studio. not editable from GUI, use ExtraBytes editor. Re-add 0x86 (array was copied from pk4?) and reorder/comment
2019-01-01 05:01:54 +00:00
case PK5 pk5 when pk5.PokeStarFame != 0 && pk5.IsEgg:
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LEggShinyPokeStar, Egg));
Add pokestar studio fame / star stat pk5[0x87] how did this get forgotten so easily lol added legality check; eggs can't participate in pokestar studio. not editable from GUI, use ExtraBytes editor. Re-add 0x86 (array was copied from pk4?) and reorder/comment
2019-01-01 05:01:54 +00:00
break;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
case PK4 pk4 when pk4.ShinyLeaf != 0:
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LEggShinyLeaf, Egg));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
break;
case PK4 pk4 when pk4.PokéathlonStat != 0:
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LEggPokeathlon, Egg));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
break;
Minor clean Handle remainder of c#9 sugar Fix some spelling mistakes
2020-12-22 07:37:07 +00:00
case PK3 when pkm.Language != 1: // All Eggs are Japanese and flagged specially for localized string
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(string.Format(LOTLanguage, LanguageID.Japanese, (LanguageID)pkm.Language), Egg));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
break;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Fix move record flag check overflow to tracker Would return true if tracker is set; this bool is only checked if is egg. Add a check for eggs with home tracker.
2020-08-12 02:42:40 +00:00
Invert some "!is" to "is not"
2020-12-29 08:58:08 +00:00
if (pkm is IHomeTrack {Tracker: not 0})
Fix move record flag check overflow to tracker Would return true if tracker is set; this bool is only checked if is egg. Add a check for eggs with home tracker.
2020-08-12 02:42:40 +00:00
data.AddLine(GetInvalid(LTransferTrackerShouldBeZero));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add Move PP verification Eggs already had it, adding now for regular pkm Closes #2602
2019-12-26 22:28:01 +00:00
else
{
VerifyMiscMovePP(data);
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Add fullness legality check Closes #2836 Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-05-25 03:00:32 +00:00
switch (pkm)
{
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
case PK7 {ResortEventStatus: >= ResortEventState.MAX}:
Add fullness legality check Closes #2836 Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-05-25 03:00:32 +00:00
data.AddLine(GetInvalid(LTransferBad));
break;
case PB7 pb7:
VerifyBelugaStats(data, pb7);
break;
case PK8 pk8:
VerifySWSHStats(data, pk8);
break;
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
case PB8 pb8:
VerifyBDSPStats(data, pb8);
break;
Add fullness legality check Closes #2836 Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-05-25 03:00:32 +00:00
}
if (pkm.Format >= 6)
VerifyFullness(data, pkm);
Add pelago status value check + etc 0, [9,19] are set (didn't see 15), but there's also a switch case which references all values 0-19. these values are used by a 80 sbyte array (4*20) in the Resort.cro remove usages of "goto case"
2018-08-28 03:44:26 +00:00
Minor clean Slap on interface for EntreeSlot De-magic some :100: numbers to indicate what they're doing Improve perf of move-match-relearn check Add an "else" as valid is never both values (history verifier)
2021-08-13 22:36:30 +00:00
var enc = data.EncounterMatch;
if (enc is WC8 { IsHOMEGift: true } w)
Add initial date checks for HOME gifts
2021-02-04 06:57:59 +00:00
{
Update HOME date legality Update dictionary to use proper format (yyyy-mm-dd), as well as verifier to properly check met year. Also updated IsValidDateWC8 to clamp latest met date based on UTC, like with GO encounters.
2021-02-04 14:12:47 +00:00
var date = new DateTime(pkm.Met_Year + 2000, pkm.Met_Month, pkm.Met_Day);
Revise IsHOMEGift, check Card ID for gift date range Currently, HOME gifts present in wc8.pkl will not be flagged for invalid dates due to them missing their respective Card IDs. This will be fixed with the next stable release, so this works for now.
2021-07-13 15:14:04 +00:00
if (!EncountersHOME.IsValidDateWC8(w.CardID, date))
Add initial date checks for HOME gifts
2021-02-04 06:57:59 +00:00
data.AddLine(GetInvalid(LDateOutsideDistributionWindow));
}
Minor clean Slap on interface for EntreeSlot De-magic some :100: numbers to indicate what they're doing Improve perf of move-match-relearn check Add an "else" as valid is never both values (history verifier)
2021-08-13 22:36:30 +00:00
else if (enc is IOverworldCorrelation8 z)
Minor clean
2021-02-14 23:14:45 +00:00
{
var match = z.IsOverworldCorrelationCorrect(pkm);
Show seed in output, flag correlations that shouldn't
2021-02-15 00:00:43 +00:00
var req = z.GetRequirement(pkm);
if (match)
{
var seed = Overworld8RNG.GetOriginalSeed(pkm);
data.Info.PIDIV = new PIDIV(PIDType.Overworld8, seed);
}
bool valid = req switch
{
OverworldCorrelation8Requirement.MustHave => match,
OverworldCorrelation8Requirement.MustNotHave => !match,
_ => true,
};
if (!valid)
data.AddLine(GetInvalid(LPIDTypeMismatch));
Minor clean
2021-02-14 23:14:45 +00:00
}
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
else if (enc is IStaticCorrelation8b s8b)
{
var match = s8b.IsStaticCorrelationCorrect(pkm);
var req = s8b.GetRequirement(pkm);
if (match)
data.Info.PIDIV = new PIDIV(PIDType.Roaming8b, pkm.EncryptionConstant);
bool valid = req switch
{
StaticCorrelation8bRequirement.MustHave => match,
StaticCorrelation8bRequirement.MustNotHave => !match,
_ => true,
};
if (!valid)
data.AddLine(GetInvalid(LPIDTypeMismatch));
}
Add initial date checks for HOME gifts
2021-02-04 06:57:59 +00:00
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
VerifyMiscFatefulEncounter(data);
}
public void VerifyMiscG1(LegalityAnalysis data)
{
var pkm = data.pkm;
if (pkm.IsEgg)
VerifyMiscEggCommon(data);
this is not that clearer than before, yay
2020-12-22 01:12:39 +00:00
if (pkm is not PK1 pk1)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
return;
VerifyMiscG1Types(data, pk1);
VerifyMiscG1CatchRate(data, pk1);
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
private void VerifyMiscG1Types(LegalityAnalysis data, PK1 pk1)
{
var Type_A = pk1.Type_A;
var Type_B = pk1.Type_B;
Continued refactoring EncounterTrade: don't init Location to -1; keep as default 0 and use that as the pivot for default met location. Move Fateful property to the sub-type that uses it (EncounterTrade4, for Ranch). Move some EncounterStatic->PKM logic that is per-type to the associated type overloaded methods. Rearrange order of properties to be more consistent with interfaces Gen3: Initialize some classes without using post-constructor setters. The `init` setter functionality coming in c#9 won't be usable as the net46 runtime/netstandard2 doesn't support it on current previews. Do it this way so we can explicity initialize some required properties rather than apply version on a second iteration.
2020-09-13 21:40:10 +00:00
var species = pk1.Species;
if (species == (int)Species.Porygon)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
// Can have any type combination of any species by using Conversion.
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
if (!GBRestrictions.TypeIDExists(Type_A))
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
data.AddLine(GetInvalid(LG1TypePorygonFail1));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
}
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
if (!GBRestrictions.TypeIDExists(Type_B))
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
data.AddLine(GetInvalid(LG1TypePorygonFail2));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
}
Continued refactoring EncounterTrade: don't init Location to -1; keep as default 0 and use that as the pivot for default met location. Move Fateful property to the sub-type that uses it (EncounterTrade4, for Ranch). Move some EncounterStatic->PKM logic that is per-type to the associated type overloaded methods. Rearrange order of properties to be more consistent with interfaces Gen3: Initialize some classes without using post-constructor setters. The `init` setter functionality coming in c#9 won't be usable as the net46 runtime/netstandard2 doesn't support it on current previews. Do it this way so we can explicity initialize some required properties rather than apply version on a second iteration.
2020-09-13 21:40:10 +00:00
else // Both types exist, ensure a Gen1 species has this combination
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
var TypesAB_Match = PersonalTable.RB.IsValidTypeCombination(Type_A, Type_B);
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
var result = TypesAB_Match ? GetValid(LG1TypeMatchPorygon) : GetInvalid(LG1TypePorygonFail);
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
data.AddLine(result);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
}
else // Types must match species types
{
Continued refactoring EncounterTrade: don't init Location to -1; keep as default 0 and use that as the pivot for default met location. Move Fateful property to the sub-type that uses it (EncounterTrade4, for Ranch). Move some EncounterStatic->PKM logic that is per-type to the associated type overloaded methods. Rearrange order of properties to be more consistent with interfaces Gen3: Initialize some classes without using post-constructor setters. The `init` setter functionality coming in c#9 won't be usable as the net46 runtime/netstandard2 doesn't support it on current previews. Do it this way so we can explicity initialize some required properties rather than apply version on a second iteration.
2020-09-13 21:40:10 +00:00
var pi = PersonalTable.RB[species];
var Type_A_Match = Type_A == pi.Type1;
var Type_B_Match = Type_B == pi.Type2;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
var first = Type_A_Match ? GetValid(LG1TypeMatch1) : GetInvalid(LG1Type1Fail);
moar is or
2020-12-25 20:30:26 +00:00
var second = Type_B_Match || (ParseSettings.AllowGBCartEra && ((species is (int)Species.Magnemite or (int)Species.Magneton) && Type_B == 9)) // Steel Magnemite via Stadium2
Allow steel-typed magnemite for gbera ty MrPerson0!
2020-09-07 01:36:37 +00:00
? GetValid(LG1TypeMatch2) : GetInvalid(LG1Type2Fail);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
data.AddLine(first);
data.AddLine(second);
}
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
private void VerifyMiscG1CatchRate(LegalityAnalysis data, PK1 pk1)
{
var catch_rate = pk1.Catch_Rate;
Remove Tradeback state caching in PKM data Since we have more metadata with move learn sourcing, we can check if it was traded to gen2 to get new moves / deleted. Adjust call sites appropriately might have some issues, to be ironed out maybe
2021-08-20 22:59:54 +00:00
var tradeback = GBRestrictions.IsTimeCapsuleTransferred(pk1, data.Info.Moves, data.EncounterMatch);
var result = tradeback == TimeCapsuleEvaluation.NotTransferred
? GetWasNotTradeback(tradeback)
: GetWasTradeback(tradeback);
Add pelago status value check + etc 0, [9,19] are set (didn't see 15), but there's also a switch case which references all values 0-19. these values are used by a 80 sbyte array (4*20) in the Resort.cro remove usages of "goto case"
2018-08-28 03:44:26 +00:00
data.AddLine(result);
Remove Tradeback state caching in PKM data Since we have more metadata with move learn sourcing, we can check if it was traded to gen2 to get new moves / deleted. Adjust call sites appropriately might have some issues, to be ironed out maybe
2021-08-20 22:59:54 +00:00
CheckResult GetWasTradeback(TimeCapsuleEvaluation timeCapsuleEvalution)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Add pelago status value check + etc 0, [9,19] are set (didn't see 15), but there's also a switch case which references all values 0-19. these values are used by a 80 sbyte array (4*20) in the Resort.cro remove usages of "goto case"
2018-08-28 03:44:26 +00:00
if (catch_rate == 0 || Legal.HeldItems_GSC.Contains((ushort)catch_rate))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetValid(LG1CatchRateMatchTradeback);
Remove Tradeback state caching in PKM data Since we have more metadata with move learn sourcing, we can check if it was traded to gen2 to get new moves / deleted. Adjust call sites appropriately might have some issues, to be ironed out maybe
2021-08-20 22:59:54 +00:00
if (timeCapsuleEvalution == TimeCapsuleEvaluation.BadCatchRate)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetInvalid(LG1CatchRateItem);
Add pelago status value check + etc 0, [9,19] are set (didn't see 15), but there's also a switch case which references all values 0-19. these values are used by a 80 sbyte array (4*20) in the Resort.cro remove usages of "goto case"
2018-08-28 03:44:26 +00:00
Remove Tradeback state caching in PKM data Since we have more metadata with move learn sourcing, we can check if it was traded to gen2 to get new moves / deleted. Adjust call sites appropriately might have some issues, to be ironed out maybe
2021-08-20 22:59:54 +00:00
return GetWasNotTradeback(timeCapsuleEvalution);
Add pelago status value check + etc 0, [9,19] are set (didn't see 15), but there's also a switch case which references all values 0-19. these values are used by a 80 sbyte array (4*20) in the Resort.cro remove usages of "goto case"
2018-08-28 03:44:26 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Remove Tradeback state caching in PKM data Since we have more metadata with move learn sourcing, we can check if it was traded to gen2 to get new moves / deleted. Adjust call sites appropriately might have some issues, to be ironed out maybe
2021-08-20 22:59:54 +00:00
CheckResult GetWasNotTradeback(TimeCapsuleEvaluation timeCapsuleEvalution)
Add pelago status value check + etc 0, [9,19] are set (didn't see 15), but there's also a switch case which references all values 0-19. these values are used by a 80 sbyte array (4*20) in the Resort.cro remove usages of "goto case"
2018-08-28 03:44:26 +00:00
{
Use EncounterMatch when EncounterOriginal doesn't matter
2021-01-02 22:47:39 +00:00
var e = data.EncounterMatch;
Extract catchrate check
2021-06-10 05:54:21 +00:00
if (e is EncounterStatic1E {Version: GameVersion.Stadium} or EncounterTrade1)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetValid(LG1CatchRateMatchPrevious); // Encounters detected by the catch rate, cant be invalid if match this encounters
Continued refactoring EncounterTrade: don't init Location to -1; keep as default 0 and use that as the pivot for default met location. Move Fateful property to the sub-type that uses it (EncounterTrade4, for Ranch). Move some EncounterStatic->PKM logic that is per-type to the associated type overloaded methods. Rearrange order of properties to be more consistent with interfaces Gen3: Initialize some classes without using post-constructor setters. The `init` setter functionality coming in c#9 won't be usable as the net46 runtime/netstandard2 doesn't support it on current previews. Do it this way so we can explicity initialize some required properties rather than apply version on a second iteration.
2020-09-13 21:40:10 +00:00
int species = pk1.Species;
Extract catchrate check
2021-06-10 05:54:21 +00:00
if (GBRestrictions.Species_NotAvailable_CatchRate.Contains(species) && catch_rate == PersonalTable.RB[species].CatchRate)
{
if (species != (int) Species.Dragonite || catch_rate != 45 || !e.Version.Contains(GameVersion.YW))
return GetInvalid(LG1CatchRateEvo);
}
if (!GBRestrictions.RateMatchesEncounter(e.Species, e.Version, catch_rate))
Remove Tradeback state caching in PKM data Since we have more metadata with move learn sourcing, we can check if it was traded to gen2 to get new moves / deleted. Adjust call sites appropriately might have some issues, to be ironed out maybe
2021-08-20 22:59:54 +00:00
return GetInvalid(timeCapsuleEvalution == TimeCapsuleEvaluation.Transferred12 ? LG1CatchRateChain : LG1CatchRateNone);
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
return GetValid(LG1CatchRateMatchPrevious);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
private static void VerifyMiscFatefulEncounter(LegalityAnalysis data)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
var pkm = data.pkm;
Minor clean
2021-01-11 02:15:33 +00:00
var enc = data.EncounterMatch;
switch (enc)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Merge type check with usage in if statements if x is y with z property true, then :D
2020-12-22 06:33:48 +00:00
case WC3 {Fateful: true} w:
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
if (w.IsEgg)
{
// Eggs hatched in RS clear the obedience flag!
Revise egg wc3 fateful check to return instead of break Emerald has the same met locations too, which doesn't clear fateful. So if it was hatched in an RS(E) location, we can't know for sure. Closes #2790 , but keep in mind the posted file is illegal anyways -- can't get egg move aromatherapy with wish.
2020-03-20 00:05:16 +00:00
// Hatching in Gen3 doesn't change the origin version.
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
if (pkm.Format != 3)
return; // possible hatched in either game, don't bother checking
Revise egg wc3 fateful check to return instead of break Emerald has the same met locations too, which doesn't clear fateful. So if it was hatched in an RS(E) location, we can't know for sure. Closes #2790 , but keep in mind the posted file is illegal anyways -- can't get egg move aromatherapy with wish.
2020-03-20 00:05:16 +00:00
if (pkm.Met_Location <= 087) // hatched in RS or Emerald
return; // possible hatched in either game, don't bother checking
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
// else, ensure fateful is active (via below)
}
VerifyFatefulIngameActive(data);
VerifyWC3Shiny(data, w);
return;
case WC3 w:
if (w.Version == GameVersion.XD)
return; // Can have either state
VerifyWC3Shiny(data, w);
break;
Minor clean
2020-12-24 23:23:38 +00:00
case MysteryGift g: // WC3 handled above
Use wcxfull version/language restriction data some cards may permit being recieved on incorrect games some wcxfulls permit games they shouldn't (tapu koko flags permit USUM but games released after the distribution window) lots of wcx lacking restrictions completely tested flagging USUM rockruff & zeraora might be worth discarding MysteryGiftVerifier and instead just using unused fields for prior formats to supply the data.
2018-07-28 05:26:27 +00:00
VerifyReceivability(data, g);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
VerifyFatefulMysteryGift(data, g);
return;
Merge type check with usage in if statements if x is y with z property true, then :D
2020-12-22 06:33:48 +00:00
case EncounterStatic {Fateful: true}: // ingame fateful
Minor clean Handle remainder of c#9 sugar Fix some spelling mistakes
2020-12-22 07:37:07 +00:00
case EncounterSlot3PokeSpot: // ingame pokespot
Minor clean
2020-12-24 23:23:38 +00:00
case EncounterTrade4RanchSpecial: // ranch varied PID
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
VerifyFatefulIngameActive(data);
return;
}
if (pkm.FatefulEncounter)
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LFatefulInvalid, Fateful));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Add Move PP verification Eggs already had it, adding now for regular pkm Closes #2602
2019-12-26 22:28:01 +00:00
private static void VerifyMiscMovePP(LegalityAnalysis data)
{
var pkm = data.pkm;
if (pkm.Move1_PP > pkm.GetMovePP(pkm.Move1, pkm.Move1_PPUps))
Rename CheckIdentifier.Move to CheckIdentifier.CurrentMove
2021-01-09 21:05:56 +00:00
data.AddLine(GetInvalid(string.Format(LMovePPTooHigh_0, 1), CurrentMove));
Add Move PP verification Eggs already had it, adding now for regular pkm Closes #2602
2019-12-26 22:28:01 +00:00
if (pkm.Move2_PP > pkm.GetMovePP(pkm.Move2, pkm.Move2_PPUps))
Rename CheckIdentifier.Move to CheckIdentifier.CurrentMove
2021-01-09 21:05:56 +00:00
data.AddLine(GetInvalid(string.Format(LMovePPTooHigh_0, 2), CurrentMove));
Add Move PP verification Eggs already had it, adding now for regular pkm Closes #2602
2019-12-26 22:28:01 +00:00
if (pkm.Move3_PP > pkm.GetMovePP(pkm.Move3, pkm.Move3_PPUps))
Rename CheckIdentifier.Move to CheckIdentifier.CurrentMove
2021-01-09 21:05:56 +00:00
data.AddLine(GetInvalid(string.Format(LMovePPTooHigh_0, 3), CurrentMove));
Add Move PP verification Eggs already had it, adding now for regular pkm Closes #2602
2019-12-26 22:28:01 +00:00
if (pkm.Move4_PP > pkm.GetMovePP(pkm.Move4, pkm.Move4_PPUps))
Rename CheckIdentifier.Move to CheckIdentifier.CurrentMove
2021-01-09 21:05:56 +00:00
data.AddLine(GetInvalid(string.Format(LMovePPTooHigh_0, 4), CurrentMove));
Add Move PP verification Eggs already had it, adding now for regular pkm Closes #2602
2019-12-26 22:28:01 +00:00
}
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
private static void VerifyMiscEggCommon(LegalityAnalysis data)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
var pkm = data.pkm;
if (pkm.Move1_PPUps > 0 || pkm.Move2_PPUps > 0 || pkm.Move3_PPUps > 0 || pkm.Move4_PPUps > 0)
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LEggPPUp, Egg));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
if (pkm.Move1_PP != pkm.GetMovePP(pkm.Move1, 0) || pkm.Move2_PP != pkm.GetMovePP(pkm.Move2, 0) || pkm.Move3_PP != pkm.GetMovePP(pkm.Move3, 0) || pkm.Move4_PP != pkm.GetMovePP(pkm.Move4, 0))
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LEggPP, Egg));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Minor clean
2021-01-11 02:15:33 +00:00
var enc = data.EncounterMatch;
var HatchCycles = enc is EncounterStatic s ? s.EggCycles : 0;
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
if (HatchCycles == 0) // no value set
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
HatchCycles = pkm.PersonalInfo.HatchCycles;
Handle gen2 gift egg collision with low hatch cycle req Closes #2824 ty @KR1dude ! change miscverifier to use OT_Friendship instead of CurrentFriendship.
2020-05-24 17:46:08 +00:00
if (pkm.OT_Friendship > HatchCycles)
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LEggHatchCycles, Egg));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
Minor clean Slap on interface for EntreeSlot De-magic some :100: numbers to indicate what they're doing Improve perf of move-match-relearn check Add an "else" as valid is never both values (history verifier)
2021-08-13 22:36:30 +00:00
if (pkm.Format >= 6 && enc is EncounterEgg && !MovesMatchRelearn(pkm))
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
Move species/move names to parsesettings
2020-11-28 02:45:06 +00:00
var moves = string.Join(", ", ParseSettings.GetMoveNames(pkm.Moves));
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
var msg = string.Format(LMoveFExpect_0, moves);
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(msg, Egg));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Add more egg verification for statnature/techrecord
2019-12-21 22:51:52 +00:00
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
if (pkm is G8PKM pk8)
Add more egg verification for statnature/techrecord
2019-12-21 22:51:52 +00:00
{
if (pk8.HasAnyMoveRecordFlag())
data.AddLine(GetInvalid(LEggRelearnFlags, Egg));
if (pk8.StatNature != pk8.Nature)
data.AddLine(GetInvalid(LEggNature, Egg));
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Minor clean Slap on interface for EntreeSlot De-magic some :100: numbers to indicate what they're doing Improve perf of move-match-relearn check Add an "else" as valid is never both values (history verifier)
2021-08-13 22:36:30 +00:00
private static bool MovesMatchRelearn(PKM pkm)
{
if (pkm.Move1 != pkm.RelearnMove1)
return false;
if (pkm.Move2 != pkm.RelearnMove2)
return false;
if (pkm.Move3 != pkm.RelearnMove3)
return false;
if (pkm.Move4 != pkm.RelearnMove4)
return false;
return true;
}
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
private static void VerifyFatefulMysteryGift(LegalityAnalysis data, MysteryGift g)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
var pkm = data.pkm;
Merge type check with usage in if statements if x is y with z property true, then :D
2020-12-22 06:33:48 +00:00
if (g is PGF {IsShiny: true})
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
var Info = data.Info;
Info.PIDIV = MethodFinder.Analyze(pkm);
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
if (Info.PIDIV.Type != PIDType.G5MGShiny && pkm.Egg_Location != Locations.LinkTrade5)
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LPIDTypeMismatch, PID));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Track a PKM's Box,Slot,StorageFlags,Identifier metadata separately (#3222) * Track a PKM's Box,Slot,StorageFlags,Identifier metadata separately Don't store within the object, track the slot origin data separately. Batch editing now pre-filters if using Box/Slot/Identifier logic; split up mods/filters as they're starting to get pretty hefty. - Requesting a Box Data report now shows all slots in the save file (party, misc) - Can now exclude backup saves from database search via toggle (separate from settings preventing load entirely) - Replace some linq usages with direct code * Remove WasLink virtual in PKM Inline any logic, since we now have encounter objects to indicate matching, rather than the proto-legality logic checking properties of a PKM. * Use Fateful to directly check gen5 mysterygift origins No other encounter types in gen5 apply Fateful * Simplify double ball comparison Used to be separate for deferral cases, now no longer needed to be separate. * Grab move/relearn reference and update locally Fix relearn move identifier * Inline defog HM transfer preference check HasMove is faster than getting moves & checking contains. Skips allocation by setting values directly. * Extract more met location metadata checks: WasBredEgg * Replace Console.Write* with Debug.Write* There's no console output UI, so don't include them in release builds. * Inline WasGiftEgg, WasEvent, and WasEventEgg logic Adios legality tags that aren't entirely correct for the specific format. Just put the computations in EncounterFinder.
2021-06-23 03:23:48 +00:00
bool shouldHave = GetFatefulState(g);
var result = pkm.FatefulEncounter == shouldHave
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
? GetValid(LFatefulMystery, Fateful)
: GetInvalid(LFatefulMysteryMissing, Fateful);
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
data.AddLine(result);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Track a PKM's Box,Slot,StorageFlags,Identifier metadata separately (#3222) * Track a PKM's Box,Slot,StorageFlags,Identifier metadata separately Don't store within the object, track the slot origin data separately. Batch editing now pre-filters if using Box/Slot/Identifier logic; split up mods/filters as they're starting to get pretty hefty. - Requesting a Box Data report now shows all slots in the save file (party, misc) - Can now exclude backup saves from database search via toggle (separate from settings preventing load entirely) - Replace some linq usages with direct code * Remove WasLink virtual in PKM Inline any logic, since we now have encounter objects to indicate matching, rather than the proto-legality logic checking properties of a PKM. * Use Fateful to directly check gen5 mysterygift origins No other encounter types in gen5 apply Fateful * Simplify double ball comparison Used to be separate for deferral cases, now no longer needed to be separate. * Grab move/relearn reference and update locally Fix relearn move identifier * Inline defog HM transfer preference check HasMove is faster than getting moves & checking contains. Skips allocation by setting values directly. * Extract more met location metadata checks: WasBredEgg * Replace Console.Write* with Debug.Write* There's no console output UI, so don't include them in release builds. * Inline WasGiftEgg, WasEvent, and WasEventEgg logic Adios legality tags that aren't entirely correct for the specific format. Just put the computations in EncounterFinder.
2021-06-23 03:23:48 +00:00
private static bool GetFatefulState(MysteryGift g)
{
if (g is WC6 {IsLinkGift: true})
return false; // Pokémon Link fake-gifts do not have Fateful
return true;
}
Use wcxfull version/language restriction data some cards may permit being recieved on incorrect games some wcxfulls permit games they shouldn't (tapu koko flags permit USUM but games released after the distribution window) lots of wcx lacking restrictions completely tested flagging USUM rockruff & zeraora might be worth discarding MysteryGiftVerifier and instead just using unused fields for prior formats to supply the data.
2018-07-28 05:26:27 +00:00
private static void VerifyReceivability(LegalityAnalysis data, MysteryGift g)
{
var pkm = data.pkm;
switch (g)
{
Allow traded eggs when checking g6+ receivability As noted in the EncounterEgg generator, Gen6+ update the origin game to the OT's when hatched. Thanks Zaskarel!
2018-10-27 16:44:47 +00:00
case WC6 wc6 when !wc6.CanBeReceivedByVersion(pkm.Version) && !pkm.WasTradedEgg:
case WC7 wc7 when !wc7.CanBeReceivedByVersion(pkm.Version) && !pkm.WasTradedEgg:
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
case WC8 wc8 when !wc8.CanBeReceivedByVersion(pkm.Version):
case WB8 wb8 when !wb8.CanBeReceivedByVersion(pkm.Version):
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LEncGiftVersionNotDistributed, GameOrigin));
Use wcxfull version/language restriction data some cards may permit being recieved on incorrect games some wcxfulls permit games they shouldn't (tapu koko flags permit USUM but games released after the distribution window) lots of wcx lacking restrictions completely tested flagging USUM rockruff & zeraora might be worth discarding MysteryGiftVerifier and instead just using unused fields for prior formats to supply the data.
2018-07-28 05:26:27 +00:00
return;
Misc iencounterable->pkm generator fixes Still some pending stuff like bad mystery gifts gen2 static encounters on g/s applying met level and not location gen6 ralts trade (no nickname) being flagged as nicknamed when it shouldn't gen4 manaphy egg not having a hatch location (worked fine if you transferred it up) gen3 antishiny gifts not setting their PIDs (jirachi WC3) gen5 N's pkm gifts setting the wrong nature gen3 unown not being generated correctly, cosplay pikachu being allowed form0, non-BugCatchingContest no longer require Sport ball, oras dexnav marill now uses the azurill eggmove table
2020-09-04 02:00:46 +00:00
case WC6 wc6 when wc6.RestrictLanguage != 0 && pkm.Language != wc6.RestrictLanguage:
Extract logic from PKX Extract Species Name logic to SpeciesName Extract Language logic to Language Remove FormConverter wrapper for string[] fetch Rearrange some logic to more appropriate locations, update access modifiers / types Move some pkm array methods to arrayutil, make generic PKX.GetVCLanguage was a dupe of _K12.GuessedLanguage() so just expose the method PKX is now back to pkm data manip only
2019-09-19 02:58:23 +00:00
data.AddLine(GetInvalid(string.Format(LOTLanguage, wc6.RestrictLanguage, pkm.Language), CheckIdentifier.Language));
Use wcxfull version/language restriction data some cards may permit being recieved on incorrect games some wcxfulls permit games they shouldn't (tapu koko flags permit USUM but games released after the distribution window) lots of wcx lacking restrictions completely tested flagging USUM rockruff & zeraora might be worth discarding MysteryGiftVerifier and instead just using unused fields for prior formats to supply the data.
2018-07-28 05:26:27 +00:00
return;
Misc iencounterable->pkm generator fixes Still some pending stuff like bad mystery gifts gen2 static encounters on g/s applying met level and not location gen6 ralts trade (no nickname) being flagged as nicknamed when it shouldn't gen4 manaphy egg not having a hatch location (worked fine if you transferred it up) gen3 antishiny gifts not setting their PIDs (jirachi WC3) gen5 N's pkm gifts setting the wrong nature gen3 unown not being generated correctly, cosplay pikachu being allowed form0, non-BugCatchingContest no longer require Sport ball, oras dexnav marill now uses the azurill eggmove table
2020-09-04 02:00:46 +00:00
case WC7 wc7 when wc7.RestrictLanguage != 0 && pkm.Language != wc7.RestrictLanguage:
Extract logic from PKX Extract Species Name logic to SpeciesName Extract Language logic to Language Remove FormConverter wrapper for string[] fetch Rearrange some logic to more appropriate locations, update access modifiers / types Move some pkm array methods to arrayutil, make generic PKX.GetVCLanguage was a dupe of _K12.GuessedLanguage() so just expose the method PKX is now back to pkm data manip only
2019-09-19 02:58:23 +00:00
data.AddLine(GetInvalid(string.Format(LOTLanguage, wc7.RestrictLanguage, pkm.Language), CheckIdentifier.Language));
Use wcxfull version/language restriction data some cards may permit being recieved on incorrect games some wcxfulls permit games they shouldn't (tapu koko flags permit USUM but games released after the distribution window) lots of wcx lacking restrictions completely tested flagging USUM rockruff & zeraora might be worth discarding MysteryGiftVerifier and instead just using unused fields for prior formats to supply the data.
2018-07-28 05:26:27 +00:00
return;
}
}
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
private static void VerifyWC3Shiny(LegalityAnalysis data, WC3 g3)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
// check for shiny locked gifts
if (!g3.Shiny.IsValid(data.pkm))
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LEncGiftShinyMismatch, Fateful));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
private static void VerifyFatefulIngameActive(LegalityAnalysis data)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
var pkm = data.pkm;
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
var result = pkm.FatefulEncounter
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
? GetValid(LFateful, Fateful)
: GetInvalid(LFatefulMissing, Fateful);
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 17:49:11 +00:00
data.AddLine(result);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Rename Data -> BinLinker
2020-03-20 22:18:59 +00:00
public void VerifyVersionEvolution(LegalityAnalysis data)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
var pkm = data.pkm;
if (pkm.Format < 7 || data.EncounterMatch.Species == pkm.Species)
return;
// No point using the evolution tree. Just handle certain species.
switch (pkm.Species)
{
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
case (int)Species.Lycanroc when pkm.Format == 7 && ((pkm.Form == 0 && Moon()) || (pkm.Form == 1 && Sun())):
Sword/Shield Update
2019-11-16 01:34:18 +00:00
case (int)Species.Solgaleo when Moon():
case (int)Species.Lunala when Sun():
bool Sun() => (pkm.Version & 1) == 0;
bool Moon() => (pkm.Version & 1) == 1;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
if (pkm.IsUntraded)
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LEvoTradeRequired, Evolution));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
break;
}
}
Add more pb7 legality checks can give nicknames to chinese mons now! Encoding looks the same @wwwwwwzx :)
2018-11-17 01:42:50 +00:00
Add fullness legality check Closes #2836 Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-05-25 03:00:32 +00:00
private static void VerifyFullness(LegalityAnalysis data, PKM pkm)
{
Allow fullness values for format8 ty anubis this totally isn't fullness, but the toys increase the value (saturation?)
2020-05-31 20:29:13 +00:00
if (pkm.IsEgg)
Add fullness legality check Closes #2836 Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-05-25 03:00:32 +00:00
{
if (pkm.Fullness != 0)
data.AddLine(GetInvalid(string.Format(LMemoryStatFullness, 0), Encounter));
if (pkm.Enjoyment != 0)
data.AddLine(GetInvalid(string.Format(LMemoryStatEnjoyment, 0), Encounter));
Allow fullness values for format8 ty anubis this totally isn't fullness, but the toys increase the value (saturation?)
2020-05-31 20:29:13 +00:00
return;
}
if (pkm.Format >= 8)
{
Clamp fullness-byte (Playfulness) at maximum
2021-05-24 05:06:40 +00:00
if (pkm.Fullness > 245) // Exiting camp is -10
data.AddLine(GetInvalid(string.Format(LMemoryStatFullness, "<=245"), Encounter));
Allow fullness values for format8 ty anubis this totally isn't fullness, but the toys increase the value (saturation?)
2020-05-31 20:29:13 +00:00
if (pkm.Enjoyment != 0)
data.AddLine(GetInvalid(string.Format(LMemoryStatEnjoyment, 0), Encounter));
Add fullness legality check Closes #2836 Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-05-25 03:00:32 +00:00
return;
}
if (pkm.Format != 6 || !pkm.IsUntraded || pkm.XY)
return;
// OR/AS PK6
if (pkm.Fullness == 0)
return;
if (pkm.Species != data.EncounterMatch.Species)
return; // evolved
if (Unfeedable.Contains(pkm.Species))
data.AddLine(GetInvalid(string.Format(LMemoryStatFullness, 0), Encounter));
}
Target type'd new
2020-12-22 01:17:56 +00:00
private static readonly HashSet<int> Unfeedable = new()
Add fullness legality check Closes #2836 Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-05-25 03:00:32 +00:00
{
(int)Species.Metapod,
(int)Species.Kakuna,
(int)Species.Pineco,
(int)Species.Silcoon,
(int)Species.Cascoon,
(int)Species.Shedinja,
(int)Species.Spewpa,
};
Add more pb7 legality checks can give nicknames to chinese mons now! Encoding looks the same @wwwwwwzx :)
2018-11-17 01:42:50 +00:00
private static void VerifyBelugaStats(LegalityAnalysis data, PB7 pb7)
{
Increase precision for cp/size calc still isn't close enough, but removes the usage of decimals for cp calc. redd.it/ahac9i CP calc doesn't flag anything I have that is legal, but the calc is still off by 2 bits at most... whyyyy? Even the same code run in cpp results in the same inaccuracy? Maybe this is some arm64 difference?
2019-01-23 05:08:48 +00:00
// ReSharper disable once CompareOfFloatsByEqualityOperator -- THESE MUST MATCH EXACTLY
if (!IsCloseEnough(pb7.HeightAbsolute, pb7.CalcHeightAbsolute))
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LStatIncorrectHeight, Encounter));
Increase precision for cp/size calc still isn't close enough, but removes the usage of decimals for cp calc. redd.it/ahac9i CP calc doesn't flag anything I have that is legal, but the calc is still off by 2 bits at most... whyyyy? Even the same code run in cpp results in the same inaccuracy? Maybe this is some arm64 difference?
2019-01-23 05:08:48 +00:00
// ReSharper disable once CompareOfFloatsByEqualityOperator -- THESE MUST MATCH EXACTLY
if (!IsCloseEnough(pb7.WeightAbsolute, pb7.CalcWeightAbsolute))
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LStatIncorrectWeight, Encounter));
Minor clean Slap on interface for EntreeSlot De-magic some :100: numbers to indicate what they're doing Improve perf of move-match-relearn check Add an "else" as valid is never both values (history verifier)
2021-08-13 22:36:30 +00:00
if (pb7.Stat_CP != pb7.CalcCP && !IsStarterLGPE(pb7))
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
data.AddLine(GetInvalid(LStatIncorrectCP, Encounter));
Add outsider evo check for beluga Closes #2200
2018-12-06 02:38:05 +00:00
}
Increase precision for cp/size calc still isn't close enough, but removes the usage of decimals for cp calc. redd.it/ahac9i CP calc doesn't flag anything I have that is legal, but the calc is still off by 2 bits at most... whyyyy? Even the same code run in cpp results in the same inaccuracy? Maybe this is some arm64 difference?
2019-01-23 05:08:48 +00:00
private static bool IsCloseEnough(float a, float b)
{
var ia = BitConverter.ToInt32(BitConverter.GetBytes(a), 0);
var ib = BitConverter.ToInt32(BitConverter.GetBytes(b), 0);
Weaken float comparison for weight/height ThePunish3D was able to find examples with less precise calcs https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=240188 assuming these were unmodified
2019-02-08 00:57:17 +00:00
return Math.Abs(ia - ib) <= 7;
Increase precision for cp/size calc still isn't close enough, but removes the usage of decimals for cp calc. redd.it/ahac9i CP calc doesn't flag anything I have that is legal, but the calc is still off by 2 bits at most... whyyyy? Even the same code run in cpp results in the same inaccuracy? Maybe this is some arm64 difference?
2019-01-23 05:08:48 +00:00
}
Minor clean Slap on interface for EntreeSlot De-magic some :100: numbers to indicate what they're doing Improve perf of move-match-relearn check Add an "else" as valid is never both values (history verifier)
2021-08-13 22:36:30 +00:00
private static bool IsStarterLGPE(ISpeciesForm pk) => pk.Species switch
{
(int)Species.Pikachu when pk.Form == 8 => true,
(int)Species.Eevee when pk.Form == 1 => true,
_ => false,
};
Sword/Shield Update
2019-11-16 01:34:18 +00:00
private void VerifySWSHStats(LegalityAnalysis data, PK8 pk8)
{
if (pk8.Favorite)
data.AddLine(GetInvalid(LFavoriteMarkingUnavailable, Encounter));
Add sociability to Memory editor, add legality checks
2021-05-23 18:22:09 +00:00
var social = pk8.Sociability;
if (pk8.IsEgg)
{
if (social != 0)
data.AddLine(GetInvalid(LMemorySocialZero, Encounter));
}
else if (social > byte.MaxValue)
{
data.AddLine(GetInvalid(string.Format(LMemorySocialTooHigh_0, byte.MaxValue), Encounter));
}
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
VerifyStatNature(data, pk8);
Initial Isle of Armor support Co-Authored-By: sciresm <sciresm@users.noreply.github.com> Co-Authored-By: Matt <sora10pls@users.noreply.github.com> Co-Authored-By: Archit Date <architdate@gmail.com>
2020-06-19 23:51:15 +00:00
var bv = pk8.BattleVersion;
if (bv != 0)
{
Refactoring change some expressions for better perf/readability
2020-07-19 22:48:45 +00:00
if ((bv != (int)GameVersion.SW && bv != (int)GameVersion.SH) || pk8.SWSH)
Initial Isle of Armor support Co-Authored-By: sciresm <sciresm@users.noreply.github.com> Co-Authored-By: Matt <sora10pls@users.noreply.github.com> Co-Authored-By: Archit Date <architdate@gmail.com>
2020-06-19 23:51:15 +00:00
data.AddLine(GetInvalid(LStatBattleVersionInvalid));
}
Make CanToggleGigantamax have a form argument no more meowth-1/2 and or perrserker Closes #2973
2020-08-17 06:06:49 +00:00
var enc = data.EncounterMatch;
Merge type check with usage in if statements if x is y with z property true, then :D
2020-12-22 06:33:48 +00:00
bool originGMax = enc is IGigantamax {CanGigantamax: true};
Initial Isle of Armor support Co-Authored-By: sciresm <sciresm@users.noreply.github.com> Co-Authored-By: Matt <sora10pls@users.noreply.github.com> Co-Authored-By: Archit Date <architdate@gmail.com>
2020-06-19 23:51:15 +00:00
if (originGMax != pk8.CanGigantamax)
{
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
bool ok = !pk8.IsEgg && pk8.CanToggleGigantamax(pk8.Species, pk8.Form, enc.Species, enc.Form);
Handle pika/meow soup evolutions Can lose gmax flag if its current species is able to eat soup, or its origin species could eat soup this handles stuff like charmander->charizard, as charmeleon would not pass hopefully there's never a mid-stage evo that has a gmax form, and its final evo doesn't... (don't get any ideas, gamefreak)
2020-06-24 23:59:26 +00:00
var chk = ok ? GetValid(LStatGigantamaxValid) : GetInvalid(LStatGigantamaxInvalid);
data.AddLine(chk);
Initial Isle of Armor support Co-Authored-By: sciresm <sciresm@users.noreply.github.com> Co-Authored-By: Matt <sora10pls@users.noreply.github.com> Co-Authored-By: Archit Date <architdate@gmail.com>
2020-06-19 23:51:15 +00:00
}
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (pk8.DynamaxLevel != 0)
{
Add Dynamax Level = 10 to showdownset if legal Closes #2835 ; zacian/zamazenta/eternatus can't have a DynamaxLevel other than 0. Co-Authored-By: Mikewando <mikewando@users.noreply.github.com>
2020-05-16 22:15:41 +00:00
if (!pk8.CanHaveDynamaxLevel(pk8) || pk8.DynamaxLevel > 10)
Sword/Shield Update
2019-11-16 01:34:18 +00:00
data.AddLine(GetInvalid(LStatDynamaxInvalid));
}
PersonalInfo? pi = null;
Minor clean Slap on interface for EntreeSlot De-magic some :100: numbers to indicate what they're doing Improve perf of move-match-relearn check Add an "else" as valid is never both values (history verifier)
2021-08-13 22:36:30 +00:00
for (int i = 0; i < PersonalInfoSWSH.CountTR; i++)
Sword/Shield Update
2019-11-16 01:34:18 +00:00
{
if (!pk8.GetMoveRecordFlag(i))
continue;
Handle unfused Calyrex with fused-TR flags Thanks CC6174 # 4880 (Discord) !
2020-10-25 02:10:59 +00:00
if ((pi ??= pk8.PersonalInfo).TMHM[i + 100])
continue;
// Calyrex-0 can have TR flags for Calyrex-1/2 after it has force unlearned them.
// Re-fusing can be reacquire the move via relearner, rather than needing another TR.
// Calyrex-0 cannot reacquire the move via relearner, even though the TR is checked off in the TR list.
if (pk8.Species == (int) Species.Calyrex)
{
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
var form = pk8.Form;
Handle unfused Calyrex with fused-TR flags Thanks CC6174 # 4880 (Discord) !
2020-10-25 02:10:59 +00:00
// Check if another alt form can learn the TR
if ((form != 1 && CanLearnTR((int) Species.Calyrex, 1, i)) || (form != 2 && CanLearnTR((int) Species.Calyrex, 2, i)))
continue;
}
Minor clean Slap on interface for EntreeSlot De-magic some :100: numbers to indicate what they're doing Improve perf of move-match-relearn check Add an "else" as valid is never both values (history verifier)
2021-08-13 22:36:30 +00:00
data.AddLine(GetInvalid(string.Format(LMoveSourceTR, ParseSettings.MoveStrings[Legal.TMHM_SWSH[i + PersonalInfoSWSH.CountTM]])));
Sword/Shield Update
2019-11-16 01:34:18 +00:00
}
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
// weight/height scalars can be legally 0 so don't bother checking
}
private void VerifyBDSPStats(LegalityAnalysis data, PB8 pb8)
{
if (pb8.Favorite)
data.AddLine(GetInvalid(LFavoriteMarkingUnavailable, Encounter));
Enforce AffixedRibbon -1 All your hacks are still hacks Re-expose affixed ribbon in the ribbon editor for PB8 Since there's no way to change it in BDSP, flag anything non-neg1
2021-11-20 17:04:09 +00:00
var affix = pb8.AffixedRibbon;
if (affix != -1) // None
data.AddLine(GetInvalid(string.Format(LRibbonMarkingAffixedF_0, affix)));
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
var social = pb8.Sociability;
if (social != 0)
data.AddLine(GetInvalid(LMemorySocialZero, Encounter));
VerifyStatNature(data, pb8);
var bv = pb8.BattleVersion;
if (bv != 0)
data.AddLine(GetInvalid(LStatBattleVersionInvalid));
if (pb8.CanGigantamax)
GetInvalid(LStatGigantamaxInvalid);
if (pb8.DynamaxLevel != 0)
data.AddLine(GetInvalid(LStatDynamaxInvalid));
if (pb8.HasAnyMoveRecordFlag() && !pb8.IsEgg) // already checked for eggs
data.AddLine(GetInvalid(LEggRelearnFlags));
// weight/height scalars can be legally 0 so don't bother checking
}
private void VerifyStatNature(LegalityAnalysis data, PKM pk)
{
var sn = pk.StatNature;
if (sn == pk.Nature)
return;
// Only allow Serious nature (12); disallow all other neutral natures.
if (sn != 12 && (sn > 24 || sn % 6 == 0))
data.AddLine(GetInvalid(LStatNatureInvalid));
Sword/Shield Update
2019-11-16 01:34:18 +00:00
}
Handle unfused Calyrex with fused-TR flags Thanks CC6174 # 4880 (Discord) !
2020-10-25 02:10:59 +00:00
private static bool CanLearnTR(int species, int form, int tr)
{
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
var pi = PersonalTable.SWSH.GetFormEntry(species, form);
Minor clean Slap on interface for EntreeSlot De-magic some :100: numbers to indicate what they're doing Improve perf of move-match-relearn check Add an "else" as valid is never both values (history verifier)
2021-08-13 22:36:30 +00:00
return pi.TMHM[tr + PersonalInfoSWSH.CountTM];
Handle unfused Calyrex with fused-TR flags Thanks CC6174 # 4880 (Discord) !
2020-10-25 02:10:59 +00:00
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
}
Reference in a new issue Copy permalink