PKHeX/PKHeX.Core/PersonalInfo/PersonalInfoXY.cs

namespace PKHeX.Core
{
    /// <summary>
    /// <see cref="PersonalInfo"/> class with values from the X &amp; Y games.
    /// </summary>
    public class PersonalInfoXY : PersonalInfoBW
    {
        public new const int SIZE = 0x40;

        public PersonalInfoXY(byte[] data) : base(data)
        {
            // Unpack TMHM & Tutors
            TMHM = GetBits(Data, 0x28, 0x10);
            TypeTutors = GetBits(Data, 0x38, 0x4);
            // 0x3C-0x40 unknown
        }

        public override byte[] Write()
        {
            SetBits(TMHM).CopyTo(Data, 0x28);
            SetBits(TypeTutors).CopyTo(Data, 0x38);
            return Data;
        }
    }
}
-												remove linq personalinfo bit fetch

reads the bits out of the original array (saves a few ms by not
allocating/gc)

											
										
										
											2018-02-17 03:34:42 +00:00
+								namespace PKHeX.Core
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								{
-												add more pkhex.core xml documentation

adds a bunch of documentation useful for those unfamiliar with the core
library

											
										
										
											2017-10-24 06:12:58 +00:00
+								    /// <summary>
-												Misc clean / xmldoc updates

remove unused label in QR (use window Font)
escape & -> &amp; for xmldoc proper style

											
										
										
											2018-07-22 02:20:11 +00:00
+								    /// <see cref="PersonalInfo"/> class with values from the X &amp; Y games.
-												add more pkhex.core xml documentation

adds a bunch of documentation useful for those unfamiliar with the core
library

											
										
										
											2017-10-24 06:12:58 +00:00
+								    /// </summary>
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								    public class PersonalInfoXY : PersonalInfoBW
 								    {
-												Add&Split out PersonalTable

Will eventually have more complex operations associated with it, as the
PersonalInfo[] could not do that sort of logic.

											
										
										
											2016-07-18 05:39:18 +00:00
+								        public new const int SIZE = 0x40;
-												Respacening

Style guidelines, handle a bunch of files
no functional change

											
										
										
											2018-07-27 02:34:27 +00:00
-												PKHeX.Core Nullable cleanup (#2401)

* Handle some nullable cases

Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization

* Handle bits more obviously without null

* Make SaveFile.BAK explicitly readonly again

* merge constructor methods to have readonly fields

* Inline some properties

* More nullable handling

* Rearrange box actions

define straightforward classes to not have any null properties

* Make extrabyte reference array immutable

* Move tooltip creation to designer

* Rearrange some logic to reduce nesting

* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum

* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case

* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable

* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator

* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever

* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)

* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
											
										
										
											2019-10-17 01:47:31 +00:00
+								        public PersonalInfoXY(byte[] data) : base(data)
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								        {
-												Sync remaining

Missed the last bugfix

											
										
										
											2016-07-03 03:25:47 +00:00
+								            // Unpack TMHM & Tutors
-												remove linq personalinfo bit fetch

reads the bits out of the original array (saves a few ms by not
allocating/gc)

											
										
										
											2018-02-17 03:34:42 +00:00
+								            TMHM = GetBits(Data, 0x28, 0x10);
 								            TypeTutors = GetBits(Data, 0x38, 0x4);
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								            // 0x3C-0x40 unknown
 								        }
-												Respacening

Style guidelines, handle a bunch of files
no functional change

											
										
										
											2018-07-27 02:34:27 +00:00
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								        public override byte[] Write()
 								        {
-												Refactoring

mostly renaming things, includes a little bit of added sugar and
splitting methods to simplify the codebase.

all methods are now PascalCase

											
										
										
											2017-06-18 01:37:19 +00:00
+								            SetBits(TMHM).CopyTo(Data, 0x28);
 								            SetBits(TypeTutors).CopyTo(Data, 0x38);
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								            return Data;
 								        }
 								    }
 								}