Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-23 20:43:07 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Verifiers/Ribbons/RibbonVerifier.cs

688 lines
32 KiB
C#
Raw Normal View History

Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
using System;
using System.Collections.Generic;
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
using System.Linq;
using static PKHeX.Core.LegalityCheckStrings;
namespace PKHeX.Core
{
Add xmldoc
2018-07-21 03:22:46 +00:00
/// <summary>
/// Verifies the <see cref="PKM"/> Ribbon values.
/// </summary>
public sealed class RibbonVerifier : Verifier
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
protected override CheckIdentifier Identifier => CheckIdentifier.Ribbon;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
public override void Verify(LegalityAnalysis data)
{
Add shedinja dropped ribbons/marking considerations Nice bug ya got there, gamefreak. Coulda cleared the AffixedRibbon value instead of copying it on Shedinja creation, and it would have made this unnecessary. Please ditch the Affixed Ribbon gimmick for future games, thanks!
2021-04-21 22:20:16 +00:00
// Flag VC (Gen1/2) ribbons using Gen7 origin rules.
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
var enc = data.EncounterMatch;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
var pkm = data.pkm;
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
// Check Unobtainable Ribbons
if (pkm.IsEgg)
{
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
if (GetIncorrectRibbonsEgg(pkm, enc))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
data.AddLine(GetInvalid(LRibbonEgg));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
return;
}
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
var result = GetIncorrectRibbons(pkm, data.Info.EvoChainsAllGens, enc);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
if (result.Count != 0)
{
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
var msg = string.Join(Environment.NewLine, result);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
data.AddLine(GetInvalid(msg));
}
else
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
data.AddLine(GetValid(LRibbonAllValid));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
}
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
private static List<string> GetIncorrectRibbons(PKM pkm, IReadOnlyList<EvoCriteria>[] evos, IEncounterTemplate enc)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
Target type'd new
2020-12-22 01:17:56 +00:00
List<string> missingRibbons = new();
List<string> invalidRibbons = new();
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
var ribs = GetRibbonResults(pkm, evos, enc);
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
foreach (var bad in ribs)
(bad.Invalid ? invalidRibbons : missingRibbons).Add(bad.Name);
var result = new List<string>();
if (missingRibbons.Count > 0)
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
result.Add(string.Format(LRibbonFMissing_0, string.Join(", ", missingRibbons).Replace(RibbonInfo.PropertyPrefix, string.Empty)));
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (invalidRibbons.Count > 0)
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
result.Add(string.Format(LRibbonFInvalid_0, string.Join(", ", invalidRibbons).Replace(RibbonInfo.PropertyPrefix, string.Empty)));
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
return result;
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Change interface for method call to less restricted Don't need "Name" or "LongName" for these methods.
2021-07-14 00:33:23 +00:00
private static bool GetIncorrectRibbonsEgg(PKM pkm, IEncounterTemplate enc)
Flag invalid nsparkle previously would only flag if it was missing on npokemon also fix gen5 traded egg locations move egg ribbon verification to the new class
2017-09-06 03:32:07 +00:00
{
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
var names = ReflectUtil.GetPropertiesStartWithPrefix(pkm.GetType(), RibbonInfo.PropertyPrefix);
if (enc is IRibbonSetEvent3 event3)
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
names = names.Except(event3.RibbonNames());
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
if (enc is IRibbonSetEvent4 event4)
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
names = names.Except(event4.RibbonNames());
Flag invalid nsparkle previously would only flag if it was missing on npokemon also fix gen5 traded egg locations move egg ribbon verification to the new class
2017-09-06 03:32:07 +00:00
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
foreach (var value in names.Select(name => ReflectUtil.GetValue(pkm, name)))
Flag invalid nsparkle previously would only flag if it was missing on npokemon also fix gen5 traded egg locations move egg ribbon verification to the new class
2017-09-06 03:32:07 +00:00
{
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
if (value is null)
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
continue;
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
if (HasFlag(value) || HasCount(value))
Flag invalid nsparkle previously would only flag if it was missing on npokemon also fix gen5 traded egg locations move egg ribbon verification to the new class
2017-09-06 03:32:07 +00:00
return true;
Minor clean Condense some expressions Use less linq Rename some fields
2021-05-29 22:31:47 +00:00
static bool HasFlag(object o) => o is true;
static bool HasCount(object o) => o is > 0;
Flag invalid nsparkle previously would only flag if it was missing on npokemon also fix gen5 traded egg locations move egg ribbon verification to the new class
2017-09-06 03:32:07 +00:00
}
return false;
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
internal static IEnumerable<RibbonResult> GetRibbonResults(PKM pkm, IReadOnlyList<EvoCriteria>[] evos, IEncounterTemplate enc)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
return GetInvalidRibbons(pkm, evos, enc)
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
.Concat(GetInvalidRibbonsEvent1(pkm, enc))
.Concat(GetInvalidRibbonsEvent2(pkm, enc));
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
}
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbons(PKM pkm, IReadOnlyList<EvoCriteria>[] evos, IEncounterTemplate enc)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
Minor clean Condense some expressions Use less linq Rename some fields
2021-05-29 22:31:47 +00:00
// is a part of Event4, but O3 doesn't have the others
if (pkm is IRibbonSetOnly3 {RibbonWorld: true})
yield return new RibbonResult(nameof(IRibbonSetOnly3.RibbonWorld));
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (pkm is IRibbonSetUnique3 u3)
{
Add shedinja dropped ribbons/marking considerations Nice bug ya got there, gamefreak. Coulda cleared the AffixedRibbon value instead of copying it on Shedinja creation, and it would have made this unnecessary. Please ditch the Affixed Ribbon gimmick for future games, thanks!
2021-04-21 22:20:16 +00:00
if (enc.Generation != 3)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
if (u3.RibbonWinning)
yield return new RibbonResult(nameof(u3.RibbonWinning));
if (u3.RibbonVictory)
yield return new RibbonResult(nameof(u3.RibbonVictory));
}
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
else
{
if (u3.RibbonWinning && !CanHaveRibbonWinning(pkm, enc, 3))
yield return new RibbonResult(nameof(u3.RibbonWinning));
if (u3.RibbonVictory && !CanHaveRibbonVictory(pkm, 3))
yield return new RibbonResult(nameof(u3.RibbonVictory));
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
}
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
Add shedinja dropped ribbons/marking considerations Nice bug ya got there, gamefreak. Coulda cleared the AffixedRibbon value instead of copying it on Shedinja creation, and it would have made this unnecessary. Please ditch the Affixed Ribbon gimmick for future games, thanks!
2021-04-21 22:20:16 +00:00
int gen = enc.Generation;
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (pkm is IRibbonSetUnique4 u4)
{
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
if (!IsAllowedBattleFrontier(pkm.Species, pkm.Form, 4) || gen > 4)
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
foreach (var z in GetInvalidRibbonsNone(u4.RibbonBitsAbility(), u4.RibbonNamesAbility()))
yield return z;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
Minor clean Remove RibbonWishing as property, just calc on the fly since it's a single case Update type info for vc transfer to indicate it's an es7 Split up dreamworld encounters as intended, fix logic lol
2020-08-31 05:37:14 +00:00
var c3 = u4.RibbonBitsContest3();
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
var c3n = u4.RibbonNamesContest3();
var iter3 = gen == 3 ? GetMissingContestRibbons(c3, c3n) : GetInvalidRibbonsNone(c3, c3n);
foreach (var z in iter3)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
yield return z;
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
var c4 = u4.RibbonBitsContest4();
var c4n = u4.RibbonNamesContest4();
Disallow sister version exclusive ribbons for exclusive forms Spiky pichu cannot receive Sinnoh ribbons Cosplay pikachu cannot receive Kalos ribbons Closes #3286 Co-Authored-By: Kermalis <29823718+Kermalis@users.noreply.github.com> Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-11-26 23:41:24 +00:00
var iter4 = (gen is 3 or 4) && IsAllowedInContest4(pkm.Species, pkm.Form) ? GetMissingContestRibbons(c4, c4n) : GetInvalidRibbonsNone(c4, c4n);
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
foreach (var z in iter4)
yield return z;
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
}
if (pkm is IRibbonSetCommon4 s4)
{
Simplify some repeated comparisons with expressions Less prone for bugs since it uses the same value for all comparisons without re-specifying
2020-12-29 08:37:59 +00:00
bool inhabited4 = gen is 3 or 4;
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
var iterate = GetInvalidRibbons4Any(pkm, evos, s4, gen);
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (!inhabited4)
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
{
if (pkm.BDSP) // Allow Sinnoh Champion. ILCA reused the Gen4 ribbon for the remake.
iterate = iterate.Concat(GetInvalidRibbonsNoneSkipIndex(s4.RibbonBitsOnly(), s4.RibbonNamesOnly(), 1));
else
iterate = iterate.Concat(GetInvalidRibbonsNone(s4.RibbonBitsOnly(), s4.RibbonNamesOnly()));
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
foreach (var z in iterate)
yield return z;
}
if (pkm is IRibbonSetCommon6 s6)
{
Simplify some repeated comparisons with expressions Less prone for bugs since it uses the same value for all comparisons without re-specifying
2020-12-29 08:37:59 +00:00
bool inhabited6 = gen is >= 3 and <= 6;
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
var iterate = inhabited6
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
? GetInvalidRibbons6Any(pkm, s6, gen, enc)
Update ribbon legality for BDSP rules Closes #3307
2021-11-25 20:28:23 +00:00
: pkm.Format >= 8
? GetInvalidRibbons6AnyG8(pkm, s6)
: GetInvalidRibbonsNone(s6.RibbonBits(), s6.RibbonNamesBool());
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
foreach (var z in iterate)
yield return z;
if (!inhabited6)
{
if (s6.RibbonCountMemoryContest > 0)
yield return new RibbonResult(nameof(s6.RibbonCountMemoryContest));
if (s6.RibbonCountMemoryBattle > 0)
yield return new RibbonResult(nameof(s6.RibbonCountMemoryBattle));
}
Gen8: Update rules for having BestFriends ribbon Closes #2562 ty @iiippppk
2019-12-07 04:22:23 +00:00
// Gen8+ replaced with Max Friendship. Gen6/7 uses affection.
Split gen6/7 affection stats to interface not in future formats, doesn't belong
2020-08-02 18:06:30 +00:00
if (pkm is IAffection a && s6.RibbonBestFriends) // can't lower affection
Gen8: Update rules for having BestFriends ribbon Closes #2562 ty @iiippppk
2019-12-07 04:22:23 +00:00
{
Split gen6/7 affection stats to interface not in future formats, doesn't belong
2020-08-02 18:06:30 +00:00
if (a.OT_Affection < 255 && pkm.IsUntraded)
Gen8: Update rules for having BestFriends ribbon Closes #2562 ty @iiippppk
2019-12-07 04:22:23 +00:00
yield return new RibbonResult(nameof(s6.RibbonBestFriends));
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
}
if (pkm is IRibbonSetCommon7 s7)
{
Disallow gen7 ribbons on lgpe origin
2020-02-17 01:41:38 +00:00
bool inhabited7 = gen <= 7 && !pkm.GG;
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
var iterate = inhabited7 ? GetInvalidRibbons7Any(pkm, s7) : GetInvalidRibbonsNone(s7.RibbonBits(), s7.RibbonNames());
foreach (var z in iterate)
yield return z;
}
if (pkm is IRibbonSetCommon3 s3)
{
Rename Gen3 Champ ribbon to be more accurate been like this since mid 2016 this ribbon can be obtained in either Hoenn or Kanto within Gen3 https://bulbapedia.bulbagarden.net/wiki/List_of_Ribbons_in_the_games#League_Ribbons
2021-04-10 19:09:43 +00:00
if (s3.RibbonChampionG3 && gen != 3)
yield return new RibbonResult(nameof(s3.RibbonChampionG3)); // RSE HoF
Remove artist ribbon restriction requiring master ribbon Closes #2997 ty @sarahlicity for an interesting bypass mechanic :P
2020-09-24 03:47:48 +00:00
if (s3.RibbonArtist && gen != 3)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
yield return new RibbonResult(nameof(s3.RibbonArtist)); // RSE Master Rank Portrait
if (s3.RibbonEffort && gen == 5 && pkm.Format == 5) // unobtainable in Gen 5
yield return new RibbonResult(nameof(s3.RibbonEffort));
}
Add gen8 ribbon verification
2019-12-07 19:58:56 +00:00
if (pkm is IRibbonSetCommon8 s8)
{
Fix ribbon compare oops
2019-12-08 07:39:32 +00:00
bool inhabited8 = gen <= 8;
Add mythical table, allow non-mythical legends in latest ruleset (master ribbon)
2021-02-17 05:42:36 +00:00
var iterate = inhabited8 ? GetInvalidRibbons8Any(pkm, s8, enc) : GetInvalidRibbonsNone(s8.RibbonBits(), s8.RibbonNames());
Add gen8 ribbon verification
2019-12-07 19:58:56 +00:00
foreach (var z in iterate)
yield return z;
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
private static IEnumerable<RibbonResult> GetMissingContestRibbons(IReadOnlyList<bool> bits, IReadOnlyList<string> names)
{
for (int i = 0; i < bits.Count; i += 4)
{
bool required = false;
for (int j = i + 3; j >= i; j--)
{
if (bits[j])
required = true;
else if (required) yield return new RibbonResult(names[j], false);
}
}
}
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbons4Any(PKM pkm, IReadOnlyList<EvoCriteria>[] evos, IRibbonSetCommon4 s4, int gen)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
if (s4.RibbonRecord)
yield return new RibbonResult(nameof(s4.RibbonRecord)); // Unobtainable
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
if (s4.RibbonFootprint && !CanHaveFootprintRibbon(pkm, evos, gen))
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
yield return new RibbonResult(nameof(s4.RibbonFootprint));
Update ribbon legality for BDSP rules Closes #3307
2021-11-25 20:28:23 +00:00
bool visitBDSP = pkm.BDSP;
moar is or
2020-12-25 20:30:26 +00:00
bool gen34 = gen is 3 or 4;
bool not6 = pkm.Format < 6 || gen is > 6 or < 3;
Update ribbon legality for BDSP rules Closes #3307
2021-11-25 20:28:23 +00:00
bool noDaily = !gen34 && not6 && !visitBDSP;
Disallow sister version exclusive ribbons for exclusive forms Spiky pichu cannot receive Sinnoh ribbons Cosplay pikachu cannot receive Kalos ribbons Closes #3286 Co-Authored-By: Kermalis <29823718+Kermalis@users.noreply.github.com> Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-11-26 23:41:24 +00:00
bool noSinnoh = pkm is G4PKM { Species: (int)Species.Pichu, Form: 1 }; // Spiky Pichu
bool noCosmetic = (!gen34 && (not6 || (pkm.XY && pkm.IsUntraded)) && !visitBDSP) || noSinnoh;
if (noSinnoh)
{
if (s4.RibbonChampionSinnoh)
yield return new RibbonResult(nameof(s4.RibbonChampionSinnoh));
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (noDaily)
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
foreach (var z in GetInvalidRibbonsNone(s4.RibbonBitsDaily(), s4.RibbonNamesDaily()))
yield return z;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (noCosmetic)
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
foreach (var z in GetInvalidRibbonsNone(s4.RibbonBitsCosmetic(), s4.RibbonNamesCosmetic()))
yield return z;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Change interface for method call to less restricted Don't need "Name" or "LongName" for these methods.
2021-07-14 00:33:23 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbons6Any(PKM pkm, IRibbonSetCommon6 s6, int gen, IEncounterTemplate enc)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
foreach (var p in GetInvalidRibbons6Memory(pkm, s6, gen, enc))
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
yield return p;
Disallow sister version exclusive ribbons for exclusive forms Spiky pichu cannot receive Sinnoh ribbons Cosplay pikachu cannot receive Kalos ribbons Closes #3286 Co-Authored-By: Kermalis <29823718+Kermalis@users.noreply.github.com> Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-11-26 23:41:24 +00:00
bool untraded = pkm.IsUntraded || (enc is EncounterStatic6 {Species:(int)Species.Pikachu, Form: not 0}); // Disallow cosplay pikachu from XY ribbons
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
var iter = untraded ? GetInvalidRibbons6Untraded(pkm, s6) : GetInvalidRibbons6Traded(pkm, s6);
foreach (var p in iter)
yield return p;
Add oras contest master ribbon affection check Each contest victory requires a contest participation; each participation gives 20 OT affection (not current trainer!) Thanks @WyrXIII , @JusLi, @Cresceda !
2018-03-26 23:42:18 +00:00
var contest = s6.RibbonBitsContest();
bool allContest = contest.All(z => z);
Update ribbon legality for BDSP rules Closes #3307
2021-11-25 20:28:23 +00:00
if ((allContest != s6.RibbonContestStar) && !(untraded && pkm.XY)) // if not already checked
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
yield return new RibbonResult(nameof(s6.RibbonContestStar), s6.RibbonContestStar);
Add oras contest master ribbon affection check Each contest victory requires a contest participation; each participation gives 20 OT affection (not current trainer!) Thanks @WyrXIII , @JusLi, @Cresceda !
2018-03-26 23:42:18 +00:00
// Each contest victory requires a contest participation; each participation gives 20 OT affection (not current trainer).
Only check g6 contest ribbon affection in g6/7 Affection is discarded on PK7->PK8 in favor of friendship, which can be lowered.
2020-02-15 19:43:21 +00:00
// Affection is discarded on PK7->PK8 in favor of friendship, which can be lowered.
Split gen6/7 affection stats to interface not in future formats, doesn't belong
2020-08-02 18:06:30 +00:00
if (pkm is IAffection a)
Only check g6 contest ribbon affection in g6/7 Affection is discarded on PK7->PK8 in favor of friendship, which can be lowered.
2020-02-15 19:43:21 +00:00
{
Split gen6/7 affection stats to interface not in future formats, doesn't belong
2020-08-02 18:06:30 +00:00
var affect = a.OT_Affection;
Only check g6 contest ribbon affection in g6/7 Affection is discarded on PK7->PK8 in favor of friendship, which can be lowered.
2020-02-15 19:43:21 +00:00
var contMemory = s6.RibbonNamesContest();
int contCount = 0;
var present = contMemory.Where((_, i) => contest[i] && affect < 20 * ++contCount);
foreach (var rib in present)
yield return new RibbonResult(rib);
}
Add oras contest master ribbon affection check Each contest victory requires a contest participation; each participation gives 20 OT affection (not current trainer!) Thanks @WyrXIII , @JusLi, @Cresceda !
2018-03-26 23:42:18 +00:00
Allow Strongest Trainer memory on gen6-visitors banned from Maison https://projectpokemon.org/home/forums/topic/57375-pkhex-new-update-legality-errors-contribution-page/?do=findComment&comment=265898 End result is only gen7-origin-in-gen7 are disallowed. Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-04-16 15:53:50 +00:00
// Gen6 can get the memory on those who did not participate by being in the party with other participants.
// This includes those who cannot enter into the Maison; having memory and no ribbon.
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
const int memChatelaine = 30;
Allow Strongest Trainer memory on gen6-visitors banned from Maison https://projectpokemon.org/home/forums/topic/57375-pkhex-new-update-legality-errors-contribution-page/?do=findComment&comment=265898 End result is only gen7-origin-in-gen7 are disallowed. Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-04-16 15:53:50 +00:00
bool hasChampMemory = enc.Generation == 7 && pkm.Format == 7 && pkm is ITrainerMemories m && (m.HT_Memory == memChatelaine || m.OT_Memory == memChatelaine);
Flag maison banned species having maison ribbons https://projectpokemon.org/home/forums/topic/45410-skillfulexpert-battler-ribbon/ Thanks Davil!
2018-05-26 02:54:25 +00:00
if (!IsAllowedBattleFrontier(pkm.Species))
{
if (hasChampMemory || s6.RibbonBattlerSkillful) // having memory and not ribbon is too rare, just flag here.
yield return new RibbonResult(nameof(s6.RibbonBattlerSkillful));
if (s6.RibbonBattlerExpert)
yield return new RibbonResult(nameof(s6.RibbonBattlerExpert));
yield break;
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (!hasChampMemory || s6.RibbonBattlerSkillful || s6.RibbonBattlerExpert)
yield break;
var result = new RibbonResult(nameof(s6.RibbonBattlerSkillful), false);
result.Combine(new RibbonResult(nameof(s6.RibbonBattlerExpert)));
yield return result;
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Update ribbon legality for BDSP rules Closes #3307
2021-11-25 20:28:23 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbons6AnyG8(PKM pkm, IRibbonSetCommon6 s6)
{
if (!pkm.BDSP)
{
var none = GetInvalidRibbonsNone(s6.RibbonBits(), s6.RibbonNamesBool());
foreach (var x in none)
yield return x;
Update RibbonVerifier.cs
2021-11-27 03:37:29 +00:00
yield break;
Update ribbon legality for BDSP rules Closes #3307
2021-11-25 20:28:23 +00:00
}
if (s6.RibbonChampionKalos)
yield return new RibbonResult(nameof(s6.RibbonChampionKalos));
if (s6.RibbonChampionG6Hoenn)
yield return new RibbonResult(nameof(s6.RibbonChampionG6Hoenn));
Update RibbonVerifier.cs
2021-11-27 03:37:29 +00:00
//if (s6.RibbonBestFriends)
// yield return new RibbonResult(nameof(s6.RibbonBestFriends));
Update ribbon legality for BDSP rules Closes #3307
2021-11-25 20:28:23 +00:00
if (s6.RibbonTraining)
yield return new RibbonResult(nameof(s6.RibbonTraining));
if (s6.RibbonBattlerSkillful)
yield return new RibbonResult(nameof(s6.RibbonBattlerSkillful));
if (s6.RibbonBattlerExpert)
yield return new RibbonResult(nameof(s6.RibbonBattlerExpert));
if (s6.RibbonCountMemoryContest != 0)
yield return new RibbonResult(nameof(s6.RibbonCountMemoryContest));
if (s6.RibbonCountMemoryBattle != 0)
yield return new RibbonResult(nameof(s6.RibbonCountMemoryBattle));
// Can get contest ribbons via BD/SP contests.
//if (s6.RibbonContestStar)
// yield return new RibbonResult(nameof(s6.RibbonContestStar));
//if (s6.RibbonMasterCoolness)
// yield return new RibbonResult(nameof(s6.RibbonMasterCoolness));
//if (s6.RibbonMasterBeauty)
// yield return new RibbonResult(nameof(s6.RibbonMasterBeauty));
//if (s6.RibbonMasterCuteness)
// yield return new RibbonResult(nameof(s6.RibbonMasterCuteness));
//if (s6.RibbonMasterCleverness)
// yield return new RibbonResult(nameof(s6.RibbonMasterCleverness));
//if (s6.RibbonMasterToughness)
// yield return new RibbonResult(nameof(s6.RibbonMasterToughness));
var contest = s6.RibbonBitsContest();
bool allContest = contest.All(z => z);
if (allContest != s6.RibbonContestStar) // if not already checked
yield return new RibbonResult(nameof(s6.RibbonContestStar), s6.RibbonContestStar);
}
Change interface for method call to less restricted Don't need "Name" or "LongName" for these methods.
2021-07-14 00:33:23 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbons6Memory(PKM pkm, IRibbonSetCommon6 s6, int gen, IEncounterTemplate enc)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
int contest = 0;
int battle = 0;
switch (gen)
{
case 3:
Disallow sister version exclusive ribbons for exclusive forms Spiky pichu cannot receive Sinnoh ribbons Cosplay pikachu cannot receive Kalos ribbons Closes #3286 Co-Authored-By: Kermalis <29823718+Kermalis@users.noreply.github.com> Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-11-26 23:41:24 +00:00
contest = IsAllowedInContest4(pkm.Species, pkm.Form) ? 40 : 20;
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
battle = IsAllowedBattleFrontier(pkm.Species) ? CanHaveRibbonWinning(pkm, enc, 3) ? 8 : 7 : 0;
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
break;
case 4:
Disallow sister version exclusive ribbons for exclusive forms Spiky pichu cannot receive Sinnoh ribbons Cosplay pikachu cannot receive Kalos ribbons Closes #3286 Co-Authored-By: Kermalis <29823718+Kermalis@users.noreply.github.com> Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-11-26 23:41:24 +00:00
contest = IsAllowedInContest4(pkm.Species, pkm.Form) ? 20 : 0;
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
battle = IsAllowedBattleFrontier(pkm.Species) ? 6 : 0;
break;
}
if (s6.RibbonCountMemoryContest > contest)
yield return new RibbonResult(nameof(s6.RibbonCountMemoryContest));
if (s6.RibbonCountMemoryBattle > battle)
yield return new RibbonResult(nameof(s6.RibbonCountMemoryBattle));
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbons6Untraded(PKM pkm, IRibbonSetCommon6 s6)
{
if (pkm.XY)
{
if (s6.RibbonChampionG6Hoenn)
yield return new RibbonResult(nameof(s6.RibbonChampionG6Hoenn));
if (s6.RibbonContestStar)
yield return new RibbonResult(nameof(s6.RibbonContestStar));
if (s6.RibbonMasterCoolness)
yield return new RibbonResult(nameof(s6.RibbonMasterCoolness));
if (s6.RibbonMasterBeauty)
yield return new RibbonResult(nameof(s6.RibbonMasterBeauty));
if (s6.RibbonMasterCuteness)
yield return new RibbonResult(nameof(s6.RibbonMasterCuteness));
if (s6.RibbonMasterCleverness)
yield return new RibbonResult(nameof(s6.RibbonMasterCleverness));
if (s6.RibbonMasterToughness)
yield return new RibbonResult(nameof(s6.RibbonMasterToughness));
}
else if (pkm.AO)
{
if (s6.RibbonChampionKalos)
yield return new RibbonResult(nameof(s6.RibbonChampionKalos));
}
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbons6Traded(PKM pkm, IRibbonSetCommon6 s6)
{
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
// Medal count is wiped on transfer to pk8
if (s6.RibbonTraining && pkm.Format <= 7)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
const int req = 12; // only first 12
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
int count = ((ISuperTrain)pkm).SuperTrainingMedalCount(req);
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (count < req)
yield return new RibbonResult(nameof(s6.RibbonTraining));
}
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
const int memChampion = 27;
Split memories from main pkm class to interface pk6/7/8, not pb7
2020-08-01 00:25:14 +00:00
bool hasChampMemory = pkm is ITrainerMemories m && ((pkm.Format < 8 && m.HT_Memory == memChampion) || (pkm.Gen6 && m.OT_Memory == memChampion));
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (!hasChampMemory || s6.RibbonChampionKalos || s6.RibbonChampionG6Hoenn)
yield break;
var result = new RibbonResult(nameof(s6.RibbonChampionKalos), false);
result.Combine(new RibbonResult(nameof(s6.RibbonChampionG6Hoenn)));
yield return result;
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbons7Any(PKM pkm, IRibbonSetCommon7 s7)
{
if (!IsAllowedBattleFrontier(pkm.Species))
{
if (s7.RibbonBattleRoyale)
yield return new RibbonResult(nameof(s7.RibbonBattleRoyale));
Allow chatelaine memory ^ skillful check on format >= 8 Check the memory for RibbonTowerMaster; if the memory is present, permit the lack of ribbon if it was granted via past gen and has the other ribbon. Simplify !(x || !y) to !x && y Closes #2926 ty @randomdice101
2020-07-10 03:53:57 +00:00
if (s7.RibbonBattleTreeGreat && !pkm.USUM && pkm.IsUntraded)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
yield return new RibbonResult(nameof(s7.RibbonBattleTreeGreat));
if (s7.RibbonBattleTreeMaster)
yield return new RibbonResult(nameof(s7.RibbonBattleTreeMaster));
}
}
Use Generation property when available
2021-08-06 22:34:28 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbons8Any(PKM pkm, IRibbonSetCommon8 s8, IEncounterTemplate enc)
Add gen8 ribbon verification
2019-12-07 19:58:56 +00:00
{
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
if (!pkm.InhabitedGeneration(8) || !((PersonalInfoSWSH)PersonalTable.SWSH[pkm.Species]).IsPresentInGame || pkm.BDSP)
Add gen8 ribbon verification
2019-12-07 19:58:56 +00:00
{
if (s8.RibbonChampionGalar)
yield return new RibbonResult(nameof(s8.RibbonChampionGalar));
Update ribbon legality for BDSP rules Closes #3307
2021-11-25 20:28:23 +00:00
if (s8.RibbonTowerMaster && !(pkm.SWSH || pkm.BDSP) && pkm.IsUntraded)
Add gen8 ribbon verification
2019-12-07 19:58:56 +00:00
yield return new RibbonResult(nameof(s8.RibbonTowerMaster));
if (s8.RibbonMasterRank)
yield return new RibbonResult(nameof(s8.RibbonMasterRank));
}
else
{
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
const int memChampion = 27;
Split memories from main pkm class to interface pk6/7/8, not pb7
2020-08-01 00:25:14 +00:00
{
Merge type check with usage in if statements if x is y with z property true, then :D
2020-12-22 06:33:48 +00:00
bool hasChampMemory = (pkm.Format == 8 && pkm is IMemoryHT {HT_Memory: memChampion}) ||
Use Generation property when available
2021-08-06 22:34:28 +00:00
(enc.Generation == 8 && pkm is IMemoryOT {OT_Memory: memChampion});
Split memories from main pkm class to interface pk6/7/8, not pb7
2020-08-01 00:25:14 +00:00
if (hasChampMemory && !s8.RibbonChampionGalar)
yield return new RibbonResult(nameof(s8.RibbonChampionGalar));
}
Disallow galar master rank ribbon on legends Closes #2858
2020-06-17 03:16:21 +00:00
// Legends cannot compete in Ranked, thus cannot reach Master Rank and obtain the ribbon.
Check battleversion state for past-gen master rank ribbon
2020-06-20 02:24:58 +00:00
// Past gen Pokemon can get the ribbon only if they've been reset.
Add mythical table, allow non-mythical legends in latest ruleset (master ribbon)
2021-02-17 05:42:36 +00:00
if (s8.RibbonMasterRank && !CanParticipateInRankedSWSH(pkm, enc))
Disallow galar master rank ribbon on legends Closes #2858
2020-06-17 03:16:21 +00:00
yield return new RibbonResult(nameof(s8.RibbonMasterRank));
Allow chatelaine memory ^ skillful check on format >= 8 Check the memory for RibbonTowerMaster; if the memory is present, permit the lack of ribbon if it was granted via past gen and has the other ribbon. Simplify !(x || !y) to !x && y Closes #2926 ty @randomdice101
2020-07-10 03:53:57 +00:00
if (s8.RibbonTowerMaster)
{
Update ribbon legality for BDSP rules Closes #3307
2021-11-25 20:28:23 +00:00
if (!(pkm.SWSH || pkm.BDSP) && pkm.IsUntraded)
Allow chatelaine memory ^ skillful check on format >= 8 Check the memory for RibbonTowerMaster; if the memory is present, permit the lack of ribbon if it was granted via past gen and has the other ribbon. Simplify !(x || !y) to !x && y Closes #2926 ty @randomdice101
2020-07-10 03:53:57 +00:00
yield return new RibbonResult(nameof(s8.RibbonTowerMaster));
}
else
{
// If the Tower Master ribbon is not present but a memory hint implies it should...
// This memory can also be applied in Gen6/7 via defeating the Chatelaines, where legends are disallowed.
const int strongest = 30;
Condense some expressions
2021-08-22 08:26:28 +00:00
if (pkm is IMemoryOT {OT_Memory: strongest} or IMemoryHT {HT_Memory: strongest})
Allow chatelaine memory ^ skillful check on format >= 8 Check the memory for RibbonTowerMaster; if the memory is present, permit the lack of ribbon if it was granted via past gen and has the other ribbon. Simplify !(x || !y) to !x && y Closes #2926 ty @randomdice101
2020-07-10 03:53:57 +00:00
{
Use Generation property when available
2021-08-06 22:34:28 +00:00
if (enc.Generation == 8 || !IsAllowedBattleFrontier(pkm.Species) || pkm is IRibbonSetCommon6 {RibbonBattlerSkillful: false})
Allow chatelaine memory ^ skillful check on format >= 8 Check the memory for RibbonTowerMaster; if the memory is present, permit the lack of ribbon if it was granted via past gen and has the other ribbon. Simplify !(x || !y) to !x && y Closes #2926 ty @randomdice101
2020-07-10 03:53:57 +00:00
yield return new RibbonResult(nameof(s8.RibbonTowerMaster));
}
}
Add gen8 ribbon verification
2019-12-07 19:58:56 +00:00
}
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
// can be expanded upon if SWSH gets updated with the new ribbon when HOME has BDSP support
Restrict Twinkling to require ContestStar as well
2021-11-26 04:51:17 +00:00
if (s8.RibbonTwinklingStar && (pkm is IRibbonSetCommon6 {RibbonContestStar:false} || !pkm.BDSP))
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
{
yield return new RibbonResult(nameof(s8.RibbonTwinklingStar));
}
Update PKHeX.Core abstractions with latest logic Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com> Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2022-02-05 01:35:15 +00:00
// received when capturing photos with Pokémon in the Photography Studio
if (s8.RibbonPioneer && !pkm.LA)
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
{
yield return new RibbonResult(nameof(s8.RibbonPioneer));
}
Add gen8 ribbon verification
2019-12-07 19:58:56 +00:00
}
Change interface for method call to less restricted Don't need "Name" or "LongName" for these methods.
2021-07-14 00:33:23 +00:00
private static bool CanParticipateInRankedSWSH(PKM pkm, IEncounterTemplate enc)
Revise master rank ribbon again ty terry & chris
2020-06-20 02:51:57 +00:00
{
Merge type check with usage in if statements if x is y with z property true, then :D
2020-12-22 06:33:48 +00:00
if (!pkm.SWSH && pkm is IBattleVersion {BattleVersion: 0})
Revise master rank ribbon again ty terry & chris
2020-06-20 02:51:57 +00:00
return false;
// Clamp to permitted species
spec->species
2020-12-29 06:22:52 +00:00
var species = pkm.Species;
if (species > Legal.MaxSpeciesID_8_R2)
Handle Ranked Battle Series 7 permissions Closes #3070 Exclude all classified as Legends; everything else is permitted assuming it can exist in SW/SH. Co-Authored-By: Chris <28743231+Bappsack@users.noreply.github.com>
2020-11-03 00:38:00 +00:00
return false;
spec->species
2020-12-29 06:22:52 +00:00
if (Legal.Legends.Contains(species))
Add mythical table, allow non-mythical legends in latest ruleset (master ribbon)
2021-02-17 05:42:36 +00:00
{
// Box Legends were only allowed for a single rule-set until May 1st.
// This rule-set disallowed Mythicals, but everything else present in the game was usable.
if (Legal.Mythicals.Contains(species))
return false;
if (enc.Version == GameVersion.GO) // Capture date is global time, and not console changeable.
{
Extend Ranked Ribbon availability for GO encounters Also hange >= to > because of new GO => HOME met date legality.9/1/2022 is legal if it was transferred in somewhere like Kiribati or New Zealand, but 9/2/2022 isn't.
2022-01-16 19:53:04 +00:00
if (pkm.MetDate > new DateTime(2022, 9, 1)) // Series 12 end date
Add mythical table, allow non-mythical legends in latest ruleset (master ribbon)
2021-02-17 05:42:36 +00:00
return false;
}
}
spec->species
2020-12-29 06:22:52 +00:00
var pi = (PersonalInfoSWSH)PersonalTable.SWSH[species];
return pi.IsPresentInGame;
Revise master rank ribbon again ty terry & chris
2020-06-20 02:51:57 +00:00
}
Change interface for method call to less restricted Don't need "Name" or "LongName" for these methods.
2021-07-14 00:33:23 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbonsEvent1(PKM pkm, IEncounterTemplate enc)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
this is not that clearer than before, yay
2020-12-22 01:12:39 +00:00
if (pkm is not IRibbonSetEvent3 set1)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
yield break;
var names = set1.RibbonNames();
var sb = set1.RibbonBits();
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
var eb = enc is IRibbonSetEvent3 e3 ? e3.RibbonBits() : new bool[sb.Length];
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
if (enc.Generation == 3)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
eb[0] = sb[0]; // permit Earth Ribbon
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
if (pkm.Version == 15 && enc is EncounterStaticShadow s)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
// only require national ribbon if no longer on origin game
More pattern matching expressions Shapes are fancy; nested pattern checks
2021-04-20 09:17:28 +00:00
bool untraded = s.Version == GameVersion.XD
? pkm is XK3 {RibbonNational: false}
: pkm is CK3 {RibbonNational: false};
eb[1] = !untraded;
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
}
}
for (int i = 0; i < sb.Length; i++)
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (sb[i] != eb[i])
yield return new RibbonResult(names[i], !eb[i]); // only flag if invalid
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Change interface for method call to less restricted Don't need "Name" or "LongName" for these methods.
2021-07-14 00:33:23 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbonsEvent2(PKM pkm, IEncounterTemplate enc)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
this is not that clearer than before, yay
2020-12-22 01:12:39 +00:00
if (pkm is not IRibbonSetEvent4 set2)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
yield break;
var names = set2.RibbonNames();
var sb = set2.RibbonBits();
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
var eb = enc is IRibbonSetEvent4 e4 ? e4.RibbonBits() : new bool[sb.Length];
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
Merge type check with usage in if statements if x is y with z property true, then :D
2020-12-22 06:33:48 +00:00
if (enc is EncounterStatic7 {Species: (int)Species.Magearna})
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
eb[1] = true; // require Wishing Ribbon
for (int i = 0; i < sb.Length; i++)
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (sb[i] != eb[i])
yield return new RibbonResult(names[i], !eb[i]); // only flag if invalid
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbonsNone(IReadOnlyList<bool> bits, IReadOnlyList<string> names)
{
for (int i = 0; i < bits.Count; i++)
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (bits[i])
yield return new RibbonResult(names[i]);
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
}
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
private static IEnumerable<RibbonResult> GetInvalidRibbonsNoneSkipIndex(IReadOnlyList<bool> bits, IReadOnlyList<string> names, int skipIndex)
{
for (int i = 0; i < bits.Count; i++)
{
if (bits[i] && i != skipIndex)
yield return new RibbonResult(names[i]);
}
}
Disallow sister version exclusive ribbons for exclusive forms Spiky pichu cannot receive Sinnoh ribbons Cosplay pikachu cannot receive Kalos ribbons Closes #3286 Co-Authored-By: Kermalis <29823718+Kermalis@users.noreply.github.com> Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-11-26 23:41:24 +00:00
private static bool IsAllowedInContest4(int species, int form) => species switch
{
// Disallow Unown and Ditto, and Spiky Pichu (cannot trade)
(int)Species.Ditto => false,
(int)Species.Unown => false,
(int)Species.Pichu when form == 1 => false,
_ => true,
};
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Misc qol updates Check max case for level first, then iterate upwards (eliminates inner if) change wc* nature to sbyte (update comparisons, 0xFF too magic-y) use Rand.Next(x) instead of (0, x)
2018-10-28 04:59:31 +00:00
private static bool IsAllowedBattleFrontier(int species) => !Legal.BattleFrontierBanlist.Contains(species);
private static bool IsAllowedBattleFrontier(int species, int form, int gen)
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
{
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if (gen == 4 && species == (int)Species.Pichu && form == 1) // spiky
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
return false;
Misc qol updates Check max case for level first, then iterate upwards (eliminates inner if) change wc* nature to sbyte (update comparisons, 0xFF too magic-y) use Rand.Next(x) instead of (0, x)
2018-10-28 04:59:31 +00:00
return IsAllowedBattleFrontier(species);
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
}
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
private static bool CanHaveFootprintRibbon(PKM pkm, IReadOnlyList<EvoCriteria>[] evos, int gen)
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
{
if (gen <= 4) // Friendship Check unnecessary - can decrease after obtaining ribbon.
return true;
// Gen5: Can't obtain
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
if (pkm.Format < 6)
return false;
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
// Gen6/7: Increase level by 30 from original level
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
if (gen != 8 && !pkm.GG && (pkm.CurrentLevel - pkm.Met_Level >= 30))
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
return true;
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
// Gen8-BDSP: Variable by species Footprint
if (pkm.BDSP)
{
if (evos[8].Any(z => z.Species <= Legal.MaxSpeciesID_4 && !HasFootprintBDSP[z.Species]))
return true; // no footprint
if (pkm.CurrentLevel - pkm.Met_Level >= 30)
return true; // traveled well
}
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
// Gen8: Can't obtain
return false;
}
Change interface for method call to less restricted Don't need "Name" or "LongName" for these methods.
2021-07-14 00:33:23 +00:00
private static bool CanHaveRibbonWinning(PKM pkm, IEncounterTemplate enc, int gen)
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
{
if (gen != 3)
return false;
if (!IsAllowedBattleFrontier(pkm.Species))
return false;
if (pkm.Format == 3)
return pkm.Met_Level <= 50;
// Most encounter types can be below level 50; only Shadow Dragonite & Tyranitar, and select Gen3 Event Gifts.
// These edge cases can't be obtained below level 50, unlike some wild Pokémon which can be encountered at different locations for lower levels.
if (enc.LevelMin <= 50)
return true;
Fix pattern matching comparison Wish I had an analyzer to catch this (missing parens) similar to boolean logic #3271 - resolves the traded egg recognition issue
2021-10-14 03:05:19 +00:00
return enc is not (EncounterStaticShadow or WC3);
Check Winning/Victory ribbons for gen3 origin based on encounter Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 23:23:17 +00:00
}
private static bool CanHaveRibbonVictory(PKM pkm, int gen)
{
return gen == 3 && IsAllowedBattleFrontier(pkm.Species);
}
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
// Footprint type is not Type 5, requiring 30 levels.
private static readonly bool[] HasFootprintBDSP =
{
true, true, true, true, true, true, true, true, true, true,
true, false, true, true, false, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, false, false, true, false,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, false, false, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
false, false, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, false, true, true,
false, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, false, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, false, true, true, false, false, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, false, true, true, true, true, true, true,
true, true, true, false, true, true, true, true, true, true,
true, true, true, true, true, true, true, false, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, false, true, false, true,
true, true, true, false, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
false, true, true, true, true, true, true, true, true, false,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, false, false, true,
true, true, true, false, false, false, false, false, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, false, true, false, false, true, false, false, false,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, false, false, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true, true,
true, true, false, true, true, true, true, true, true, true,
true, true, true, true, false, true, false, true, true, true,
true, true, true, true, true, true, false, true, true, true,
true, true, true, true,
};
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
}
}
Reference in a new issue Copy permalink