Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-24 04:53:08 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Core.cs

249 lines
11 KiB
C#
Raw Normal View History

Refactoring Move fossils check to static encounter apply small amount of inheritance to all encounter types (including mystery gifts) get actual evolution chain to ignore pre-evolution movepools (example Surf Pikachu event gift cannot devolve to Pichu to get Nasty Plot). #694 A little bit of logic has been moved around, but my 5k pkmdb had no change in legal/illegal counts. Hopefully no false positives from this change :thumbsup:
2017-01-04 04:51:33 +00:00
using System;
using System.Collections.Generic;
Reorganization for future changes Moving legality stuff into separate class
2016-02-23 06:52:48 +00:00
using System.Linq;
Split winforms to separate project resources still are associated with winforms, eh program still runs fine and I've replicated the mono build options. lmk if this breaks stuff
2017-01-08 07:54:09 +00:00
namespace PKHeX.Core
Reorganization for future changes Moving legality stuff into separate class
2016-02-23 06:52:48 +00:00
{
public static partial class Legal
{
Add gen1 learnset/evo information Still need encounter info for all 3 games.
2017-02-11 23:20:44 +00:00
// Gen 1
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
internal static readonly Learnset[] LevelUpRB = LearnsetReader.GetArray(Util.GetBinaryResource("lvlmove_rb.pkl"), MaxSpeciesID_1);
internal static readonly Learnset[] LevelUpY = LearnsetReader.GetArray(Util.GetBinaryResource("lvlmove_y.pkl"), MaxSpeciesID_1);
Add gen1 learnset/evo information Still need encounter info for all 3 games.
2017-02-11 23:20:44 +00:00
Add gen2 evolutions/learnset
2017-02-25 20:37:01 +00:00
// Gen 2
Add GetEncounterMoves method dictionary mapping common gameversions to their associated obj
2018-03-30 08:02:22 +00:00
internal static readonly EggMoves[] EggMovesGS = EggMoves2.GetArray(Util.GetBinaryResource("eggmove_gs.pkl"), MaxSpeciesID_2);
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
internal static readonly Learnset[] LevelUpGS = LearnsetReader.GetArray(Util.GetBinaryResource("lvlmove_gs.pkl"), MaxSpeciesID_2);
Add GetEncounterMoves method dictionary mapping common gameversions to their associated obj
2018-03-30 08:02:22 +00:00
internal static readonly EggMoves[] EggMovesC = EggMoves2.GetArray(Util.GetBinaryResource("eggmove_c.pkl"), MaxSpeciesID_2);
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
internal static readonly Learnset[] LevelUpC = LearnsetReader.GetArray(Util.GetBinaryResource("lvlmove_c.pkl"), MaxSpeciesID_2);
Add gen2 evolutions/learnset
2017-02-25 20:37:01 +00:00
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
// Gen 3
Rename Data -> BinLinker
2020-03-20 22:18:59 +00:00
internal static readonly Learnset[] LevelUpE = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_e.pkl"), "em"));
internal static readonly Learnset[] LevelUpRS = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_rs.pkl"), "rs"));
internal static readonly Learnset[] LevelUpFR = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_fr.pkl"), "fr"));
internal static readonly Learnset[] LevelUpLG = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_lg.pkl"), "lg"));
internal static readonly EggMoves6[] EggMovesRS = EggMoves6.GetArray(BinLinker.Unpack(Util.GetBinaryResource("eggmove_rs.pkl"), "rs"));
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
// Gen 4
Rename Data -> BinLinker
2020-03-20 22:18:59 +00:00
internal static readonly Learnset[] LevelUpDP = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_dp.pkl"), "dp"));
internal static readonly Learnset[] LevelUpPt = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_pt.pkl"), "pt"));
internal static readonly Learnset[] LevelUpHGSS = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_hgss.pkl"), "hs"));
internal static readonly EggMoves6[] EggMovesDPPt = EggMoves6.GetArray(BinLinker.Unpack(Util.GetBinaryResource("eggmove_dppt.pkl"), "dp"));
internal static readonly EggMoves6[] EggMovesHGSS = EggMoves6.GetArray(BinLinker.Unpack(Util.GetBinaryResource("eggmove_hgss.pkl"), "hs"));
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
// Gen 5
Rename Data -> BinLinker
2020-03-20 22:18:59 +00:00
internal static readonly Learnset[] LevelUpBW = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_bw.pkl"), "51"));
internal static readonly Learnset[] LevelUpB2W2 = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_b2w2.pkl"), "52"));
internal static readonly EggMoves6[] EggMovesBW = EggMoves6.GetArray(BinLinker.Unpack(Util.GetBinaryResource("eggmove_bw.pkl"), "bw"));
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
// Gen 6
Rename Data -> BinLinker
2020-03-20 22:18:59 +00:00
internal static readonly EggMoves6[] EggMovesXY = EggMoves6.GetArray(BinLinker.Unpack(Util.GetBinaryResource("eggmove_xy.pkl"), "xy"));
internal static readonly Learnset[] LevelUpXY = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_xy.pkl"), "xy"));
internal static readonly EggMoves6[] EggMovesAO = EggMoves6.GetArray(BinLinker.Unpack(Util.GetBinaryResource("eggmove_ao.pkl"), "ao"));
internal static readonly Learnset[] LevelUpAO = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_ao.pkl"), "ao"));
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
// Gen 7
Rename Data -> BinLinker
2020-03-20 22:18:59 +00:00
internal static readonly EggMoves7[] EggMovesSM = EggMoves7.GetArray(BinLinker.Unpack(Util.GetBinaryResource("eggmove_sm.pkl"), "sm"));
internal static readonly Learnset[] LevelUpSM = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_sm.pkl"), "sm"));
internal static readonly EggMoves7[] EggMovesUSUM = EggMoves7.GetArray(BinLinker.Unpack(Util.GetBinaryResource("eggmove_uu.pkl"), "uu"));
internal static readonly Learnset[] LevelUpUSUM = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_uu.pkl"), "uu"));
internal static readonly Learnset[] LevelUpGG = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_gg.pkl"), "gg"));
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
// Gen 8
Rename Data -> BinLinker
2020-03-20 22:18:59 +00:00
internal static readonly EggMoves7[] EggMovesSWSH = EggMoves7.GetArray(BinLinker.Unpack(Util.GetBinaryResource("eggmove_swsh.pkl"), "ss"));
internal static readonly Learnset[] LevelUpSWSH = LearnsetReader.GetArray(BinLinker.Unpack(Util.GetBinaryResource("lvlmove_swsh.pkl"), "ss"));
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
Use byte for pp value storage more appropriate storage; for 3887 indexes -> saves 11.3KB
2019-04-11 05:05:57 +00:00
public static IReadOnlyList<byte> GetPPTable(PKM pkm, int format)
Add pkm variant for beluga
2018-11-14 03:10:31 +00:00
{
Use byte for pp value storage more appropriate storage; for 3887 indexes -> saves 11.3KB
2019-04-11 05:05:57 +00:00
if (format != 7)
return GetPPTable(format);
return pkm.GG ? MovePP_GG : MovePP_SM;
Add pkm variant for beluga
2018-11-14 03:10:31 +00:00
}
Use byte for pp value storage more appropriate storage; for 3887 indexes -> saves 11.3KB
2019-04-11 05:05:57 +00:00
public static IReadOnlyList<byte> GetPPTable(int format)
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return format switch
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
1 => MovePP_RBY,
2 => MovePP_GSC,
3 => MovePP_RS,
4 => MovePP_DP,
5 => MovePP_BW,
6 => MovePP_XY,
7 => MovePP_SM,
8 => MovePP_SWSH,
_ => Array.Empty<byte>()
};
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
}
Remove some reliance on GenNumber
2020-05-31 19:12:48 +00:00
internal static ICollection<int> GetWildBalls(int gen, GameVersion game)
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
Remove some reliance on GenNumber
2020-05-31 19:12:48 +00:00
return gen switch
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
1 => WildPokeBalls1,
2 => WildPokeBalls2,
3 => WildPokeBalls3,
Remove some reliance on GenNumber
2020-05-31 19:12:48 +00:00
4 => GameVersion.HGSS.Contains(game) ? WildPokeBalls4_HGSS : WildPokeBalls4_DPPt,
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
5 => WildPokeBalls5,
6 => WildPokeballs6,
Split GO from "GG" gameversion Make Gen7b as the combined ver for that expression
2020-08-07 01:24:20 +00:00
7 => GameVersion.Gen7b.Contains(game) ? WildPokeballs7b : WildPokeballs7,
Add initial legality checks for GO->HOME transfers took me less than an hour to do these changes, and i can flag bad form movesets no problemo Expect tightening of restrictions (ball, level, shininess) later if someone wants to curate met date restrictions, go ahead!
2020-11-11 06:10:53 +00:00
8 => GameVersion.GO == game ? WildPokeballs8g : WildPokeballs8,
Remove unnecessary casts
2020-01-07 01:50:18 +00:00
_ => Array.Empty<int>()
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
};
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
internal static int GetMaxSpeciesOrigin(PKM pkm)
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
{
Weaken gen2 egg species checks for pre-evos in gen1 VC can inhabit both gens Add Tradeback setting setter for legality tests Add GBCartEra setting setter for legality tests Thanks @iiippppk !
2018-06-13 01:46:31 +00:00
if (pkm.Format == 1)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return GetMaxSpeciesOrigin(1);
Weaken gen2 egg species checks for pre-evos in gen1 VC can inhabit both gens Add Tradeback setting setter for legality tests Add GBCartEra setting setter for legality tests Thanks @iiippppk !
2018-06-13 01:46:31 +00:00
if (pkm.Format == 2 || pkm.VC)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return GetMaxSpeciesOrigin(2);
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
return GetMaxSpeciesOrigin(pkm.Generation);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
internal static int GetMaxSpeciesOrigin(int generation)
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return generation switch
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
1 => MaxSpeciesID_1,
2 => MaxSpeciesID_2,
3 => MaxSpeciesID_3,
4 => MaxSpeciesID_4,
5 => MaxSpeciesID_5,
6 => MaxSpeciesID_6,
7 => MaxSpeciesID_7b,
8 => MaxSpeciesID_8,
_ => -1
};
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
internal static ICollection<int> GetFutureGenEvolutions(int generation)
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return generation switch
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
1 => FutureEvolutionsGen1,
2 => FutureEvolutionsGen2,
3 => FutureEvolutionsGen3,
4 => FutureEvolutionsGen4,
5 => FutureEvolutionsGen5,
Remove unnecessary casts
2020-01-07 01:50:18 +00:00
_ => Array.Empty<int>()
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
};
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Add DebutGeneration get https://projectpokemon.org/home/forums/topic/43378-generation-search-in-pkmdb-andor-batch-editor/ (less than) < and (greater than) > not currently supported (no plan to add, would need to rewrite value eval logic)
2018-01-10 23:40:33 +00:00
internal static int GetDebutGeneration(int species)
{
if (species <= MaxSpeciesID_1)
return 1;
if (species <= MaxSpeciesID_2)
return 2;
if (species <= MaxSpeciesID_3)
return 3;
if (species <= MaxSpeciesID_4)
return 4;
if (species <= MaxSpeciesID_5)
return 5;
if (species <= MaxSpeciesID_6)
return 6;
Add pkm variant for beluga
2018-11-14 03:10:31 +00:00
if (species <= MaxSpeciesID_7b)
Add DebutGeneration get https://projectpokemon.org/home/forums/topic/43378-generation-search-in-pkmdb-andor-batch-editor/ (less than) < and (greater than) > not currently supported (no plan to add, would need to rewrite value eval logic)
2018-01-10 23:40:33 +00:00
return 7;
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
if (species <= MaxSpeciesID_8)
return 8;
Add DebutGeneration get https://projectpokemon.org/home/forums/topic/43378-generation-search-in-pkmdb-andor-batch-editor/ (less than) < and (greater than) > not currently supported (no plan to add, would need to rewrite value eval logic)
2018-01-10 23:40:33 +00:00
return -1;
}
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
Misc languageID legality checking update Checks for max language ID on transferred pkm (gen5 pkm on gen7 can't have CHS/CHT etc) handles edge case for JPN B/W ingame trades update pk5->pk6 transfer logic to bump langID 0 to 1. Thanks HaxAras & Britty for providing samples!
2017-09-16 00:43:31 +00:00
internal static int GetMaxLanguageID(int generation)
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return generation switch
Misc languageID legality checking update Checks for max language ID on transferred pkm (gen5 pkm on gen7 can't have CHS/CHT etc) handles edge case for JPN B/W ingame trades update pk5->pk6 transfer logic to bump langID 0 to 1. Thanks HaxAras & Britty for providing samples!
2017-09-16 00:43:31 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
1 => (int) LanguageID.Spanish, // 1-7 except 6
3 => (int) LanguageID.Spanish, // 1-7 except 6
2 => (int) LanguageID.Korean,
4 => (int) LanguageID.Korean,
5 => (int) LanguageID.Korean,
6 => (int) LanguageID.Korean,
7 => (int) LanguageID.ChineseT,
8 => (int) LanguageID.ChineseT,
_ => -1
};
Misc languageID legality checking update Checks for max language ID on transferred pkm (gen5 pkm on gen7 can't have CHS/CHT etc) handles edge case for JPN B/W ingame trades update pk5->pk6 transfer logic to bump langID 0 to 1. Thanks HaxAras & Britty for providing samples!
2017-09-16 00:43:31 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
internal static bool GetCanLearnMachineMove(PKM pkm, int move, int generation, GameVersion version = GameVersion.Any)
Use the list of evolution chains from every generation to search valid moves from a given pokemon
2017-02-15 22:33:59 +00:00
{
Permit TR flags for "Can Relearn", split branching for TR checks
2020-12-22 17:10:10 +00:00
var evos = EvolutionChain.GetValidPreEvolutions(pkm);
return MoveList.GetValidMoves(pkm, version, evos, generation, types: MoveSourceType.AllMachines).Contains(move);
Use the list of evolution chains from every generation to search valid moves from a given pokemon
2017-02-15 22:33:59 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Pass evolution chain for generation memory check chain details are already computed; pass them in
2020-07-19 02:57:15 +00:00
internal static bool GetCanRelearnMove(PKM pkm, int move, int generation, IReadOnlyList<EvoCriteria> evos, GameVersion version = GameVersion.Any)
Add Memory 21 None of my database mons even had this memory :\
2016-05-10 01:19:31 +00:00
{
Permit TR flags for "Can Relearn", split branching for TR checks
2020-12-22 17:10:10 +00:00
return MoveList.GetValidMoves(pkm, version, evos, generation, types: MoveSourceType.Reminder).Contains(move);
Cleanup Commit the rest of the code why github
2016-05-10 02:24:52 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Pass evolution chain for generation memory check chain details are already computed; pass them in
2020-07-19 02:57:15 +00:00
internal static bool GetCanKnowMove(PKM pkm, int move, int generation, IReadOnlyList<EvoCriteria> evos, GameVersion version = GameVersion.Any)
Cleanup Commit the rest of the code why github
2016-05-10 02:24:52 +00:00
{
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if (pkm.Species == (int)Species.Smeargle)
Enhance IEncounterable list summarization separates by type (wild, egg, etc) then groups by generation, listing the locations and games that can obtain it in that location
2019-03-20 05:05:13 +00:00
return !InvalidSketch.Contains(move);
Allow shared moves from daycare as "can know move" See b58f3bbc22723cbe14d7a71baae16c40ec83533a
2020-12-22 00:49:42 +00:00
if (generation >= 8 && MoveEgg.GetIsSharedEggMove(pkm, generation, move))
return true;
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
return MoveList.GetValidMoves(pkm, version, evos, generation, types: MoveSourceType.All).Contains(move);
Add encounter slot checking, edge case handling So much information is needed to check a given aspect that it's best to just pass the pk6 around to functions.
2016-02-26 15:52:08 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Misc parse settings reorg makes it more centralized for defining parsing settings, maybe can have flags to change severity of certain preferential checks
2018-10-06 02:58:30 +00:00
internal static bool IsCatchRateHeldItem(int rate) => ParseSettings.AllowGen1Tradeback && HeldItems_GSC.Contains((ushort) rate);
Update catch rate related logic #2071
2018-07-25 02:33:42 +00:00
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
internal const GameVersion NONE = GameVersion.Invalid;
Target type'd new
2020-12-22 01:17:56 +00:00
internal static readonly LearnVersion LearnNONE = new(-1);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
Pass species param to exists-in check Closes #2905
2020-06-27 19:04:28 +00:00
internal static bool HasVisitedB2W2(this PKM pkm, int species) => pkm.InhabitedGeneration(5, species);
internal static bool HasVisitedORAS(this PKM pkm, int species) => pkm.InhabitedGeneration(6, species) && (pkm.AO || !pkm.IsUntraded);
internal static bool HasVisitedUSUM(this PKM pkm, int species) => pkm.InhabitedGeneration(7, species) && (pkm.USUM || !pkm.IsUntraded);
Fix lgpe moveset restriction Closes #2704 Co-Authored-By: BetaLeaf <betaleaf@gmail.com>
2020-02-13 04:25:39 +00:00
internal static bool IsMovesetRestricted(this PKM pkm, int gen) => (pkm.GG && gen == 7) || pkm.IsUntraded;
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
Flag langid=0 when appropriate only jpn bw ingame trades can lack a languageID. skip language checks for pk1/pk2 as they have no language stored.
2018-05-26 21:40:02 +00:00
public static bool IsValidMissingLanguage(PKM pkm)
{
return pkm.Format == 5 && pkm.BW;
}
Refactoring Relocate fixed OTs to core (iencounterable & checks now reference same values)
2018-06-23 16:49:04 +00:00
Update Ho-Oh mattle check More languages than Italian have a rule-breaking name. Rework checks a bit Flag eggs more accurately Update force hatch to move Link Trade met location to Egg Location fix Ho-oh -> Ho-Oh text strings (correctness is key!)
2018-10-27 23:06:06 +00:00
public static int GetMaxLengthOT(int gen, LanguageID lang)
{
switch (lang)
{
case LanguageID.Korean:
case LanguageID.Japanese: return gen >= 6 ? 6 : 5;
default: return gen >= 6 ? 12 : 7;
}
}
public static int GetMaxLengthNickname(int gen, LanguageID lang)
Add OT name max length checks Closes #2094
2018-08-15 21:58:55 +00:00
{
switch (lang)
{
case LanguageID.Korean:
case LanguageID.Japanese: return gen >= 6 ? 6 : 5;
Lessen string length severity on egg encounters Hatched eggs can have mismatched languages<->OT/Nick restrictions
2018-08-15 22:26:42 +00:00
default: return gen >= 6 ? 12 : 10;
Add OT name max length checks Closes #2094
2018-08-15 21:58:55 +00:00
}
}
Move GetIV to pkm, misc simplifications remove linq for characteristic calc (get max IV) and others remove some reliance on new[] for iv/ev pk5 replace bitmagic with property get->set copy for cleanliness
2019-01-05 18:51:41 +00:00
Fix Static/Gift IV method call (#2310)
2019-05-15 19:07:48 +00:00
public static bool GetIsFixedIVSequenceValidSkipRand(IReadOnlyList<int> IVs, PKM pkm, int max = 31)
Move GetIV to pkm, misc simplifications remove linq for characteristic calc (get max IV) and others remove some reliance on new[] for iv/ev pk5 replace bitmagic with property get->set copy for cleanliness
2019-01-05 18:51:41 +00:00
{
for (int i = 0; i < 6; i++)
{
if ((uint) IVs[i] > max) // random
continue;
if (IVs[i] != pkm.GetIV(i))
return false;
}
return true;
}
public static bool GetIsFixedIVSequenceValidNoRand(IReadOnlyList<int> IVs, PKM pkm)
{
for (int i = 0; i < 6; i++)
{
if (IVs[i] != pkm.GetIV(i))
return false;
}
return true;
}
Reorganization for future changes Moving legality stuff into separate class
2016-02-23 06:52:48 +00:00
}
}
Reference in a new issue Copy permalink