2023-01-22 04:02:33 +00:00
|
|
|
using System;
|
Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves
In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.
The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.
The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.
* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 23:15:27 +00:00
|
|
|
using System.Runtime.InteropServices;
|
2021-08-22 01:24:38 +00:00
|
|
|
using FluentAssertions;
|
2021-08-21 02:52:31 +00:00
|
|
|
using Xunit;
|
|
|
|
|
2023-01-22 04:02:33 +00:00
|
|
|
namespace PKHeX.Core.Tests.General;
|
2022-03-26 02:47:23 +00:00
|
|
|
|
|
|
|
public class MarshalTests
|
2021-08-21 02:52:31 +00:00
|
|
|
{
|
2023-01-22 04:02:33 +00:00
|
|
|
[Theory]
|
2024-02-23 03:20:54 +00:00
|
|
|
[InlineData(10, typeof(PIDIV))]
|
2023-01-22 04:02:33 +00:00
|
|
|
[InlineData(8, typeof(MoveResult))]
|
|
|
|
[InlineData(8, typeof(EvolutionMethod))]
|
|
|
|
[InlineData(8, typeof(Moveset))]
|
2023-07-08 19:46:46 +00:00
|
|
|
[InlineData(8, typeof(SCXorShift32))]
|
|
|
|
[InlineData(16, typeof(Xoroshiro128Plus))]
|
|
|
|
[InlineData(16, typeof(Xoroshiro128Plus8b))]
|
|
|
|
[InlineData(16, typeof(XorShift128))]
|
2023-01-22 04:02:33 +00:00
|
|
|
public void MarshalSizeExact(int expect, Type t) => Marshal.SizeOf(t).Should().Be(expect);
|
|
|
|
|
|
|
|
[Theory]
|
2024-02-23 03:20:54 +00:00
|
|
|
[InlineData( 8, typeof(LeadSeed))]
|
2023-01-22 04:02:33 +00:00
|
|
|
[InlineData( 8, typeof(NPCLock))]
|
|
|
|
[InlineData( 8, typeof(IndividualValueSet))]
|
2023-09-05 01:23:10 +00:00
|
|
|
[InlineData( 8, typeof(EvolutionOrigin))]
|
2023-01-22 04:02:33 +00:00
|
|
|
[InlineData(16, typeof(DreamWorldEntry))]
|
2023-04-23 23:04:04 +00:00
|
|
|
[InlineData(16, typeof(CheckResult))]
|
2023-07-06 04:14:09 +00:00
|
|
|
[InlineData(16, typeof(EvolutionLink))]
|
2023-01-27 02:07:27 +00:00
|
|
|
[InlineData(24, typeof(GenerateParam9))]
|
2023-01-22 04:02:33 +00:00
|
|
|
public void MarshalSizeLessThanEqual(int expect, Type t) => Marshal.SizeOf(t).Should().BeLessOrEqualTo(expect);
|
2021-08-21 02:52:31 +00:00
|
|
|
}
|