Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-30 15:59:13 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Encounters/EncounterStatic.cs

438 lines
15 KiB
C#
Raw Normal View History

Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
using System;
Make Relearn array for encounters readonly No change em
2020-01-19 00:31:24 +00:00
using System.Collections.Generic;
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
using System.Linq;
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
namespace PKHeX.Core
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
add more pkhex.core xml documentation adds a bunch of documentation useful for those unfamiliar with the core library
2017-10-24 06:12:58 +00:00
/// <summary>
/// Static Encounter Data
/// </summary>
/// <remarks>
/// Static Encounters are fixed position encounters with properties that are not subject to Wild Encounter conditions.
/// </remarks>
Sword/Shield Update
2019-11-16 01:34:18 +00:00
public class EncounterStatic : IEncounterable, IMoveset, IGeneration, ILocation, IContestStats, IVersion, IRelearn
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
Minor refactoring Switch EncounterGeneric to IEncounterable. A way to tie together all encounters. Added a few setters for mystery gifts if the code is ever reused in other projects for that purpose. No functional change.
2017-01-05 06:25:45 +00:00
public int Species { get; set; }
Make Move[] readonly list contract: don't modify the template movesets mystery gift now exposes IRelearn, remove unnecessary type checks
2020-01-19 00:46:38 +00:00
public IReadOnlyList<int> Moves { get; set; } = Array.Empty<int>();
Make level min/max virtual for nest Closes #2566 be sure to set the correct flawless IV count & dynamax level so that the encounter matches
2019-12-07 03:17:26 +00:00
public virtual int Level { get; set; }
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
Make level min/max virtual for nest Closes #2566 be sure to set the correct flawless IV count & dynamax level so that the encounter matches
2019-12-07 03:17:26 +00:00
public virtual int LevelMin => Level;
public virtual int LevelMax => Level;
Gen 1 move analysis improvement. Adapted the valid moves to take into account that move deleter and move reminder do not exits in generation 1 (#1037) * Fix getMoves with min level, when SkipWhile and TakeWhile is used together the index i in TakeWhile is calculated from the enumerator that results of the SkipWhile function, not the index of the initial array, those giving an incorrect index to check Levels array in the TakeWhile * Fix getMoves when levelmin or levelmax is above max level in the levels array, TakeWhile and SkipWhile return empty list if the while goes beyond the last element of the array * Include player hatched egg in the list of possible encounters for parseMoves only if the pokemon was an egg Also change the valur of WasEgg for gen1,2,3 pokemon if the encounter analyzed is not an egg add the non egg encounters to the list instead of checking the non-egg encounter inside parseMovesWasEggPreRelearn * Fix for gen3 egg encounters Remove non-egg encounters without special moves if there is an egg encounter because egg encounter already cover every possible move combination Do not add daycare egg encounter for gen3 unhatched egg if there is another encounter, that means is an event or gift egg, not a daycare egg Remove duplicate encounters * Gift egg should not allow inherited moves even it they dont have special moves Those gift eggs are hatched only with the species base moves * Added getEncounterMoves functions, to be used for generation 1 encounters to find what moves have a pokemon at the moment of being caught because there is no move reminder in generation 1 * Added GBEncounterData, structure for refactor the tuples used in generation 1 and 2 encounters * Add LevelMin and LevelMax to IEncounterable to get the encounter moves by the min level of the generation 1 EncounterLink Add iGeneration to difference generation 1 and generation 2 encounters for GB Era pokemon * Mark generation in gen 1 and 2 encounters There is no need to mark the generation in gen 3 to 7 encounters because in that generations it match the pokemon generation number * Add min level for generation 1 moves in getMoves functions Add function to return the default moves for a GB encounters, for generation 1 games that included both moves from level up table and level 1 moves from personal table Fix getMoves with min level when the moves list is empty, like Raichu generation 1 * Add maxSpecies to getBaseSpecies function for gen1 pokemon with a gen2 egg encounter Refactor VC Encounter changing Tuples for GBData class * Fixed for gen 2 Checks Also do not search for generation1 encounter if the gen2 pokemon have met location from crystal * Fix VC wild encounters, should be stored as array or else other verifyEncounter functions wont work * Add generation 1 parse moves function including default moves * Clean-up get encounters * Verify empty moves for generation 1 encounters, in generation 1 does not exits move deleter That means when a move slot have been used by a level up move or a TM/HM/Tutor move it cant be empty again Does not apply if generation 2 tradeback is allowed, in generation 2 there is a move deleter * Added two edge cases for pokemon that learn in red/blue and yellow different moves at the same level, this combinations can not exits until a later level when they learn again one of the levels in the other game, only happen for flareon and vaporeon * Check incompatible moves between evolution species, it is for species that learn a move in a level as an evolved species and a move at a upper level as a preevolution Also added most edge cases for the min slots used for generation 1 games, i think every weird combination is already covered * Fix gen 1 eevee and evolutions move checks * Cleanup * Move the code to change valid moves for generation 1 to a function * Fix getMoveMinLevelGBEncounter * getUsedMoveSlots, removed wild Butterfree edge case, it is not possible * Filter the min level of the encounter by the possible games the pokemon could be originated, yellow pikachu and kadabra can be detected
2017-04-09 00:17:20 +00:00
public int Generation { get; set; } = -1;
Initial rough draft of nest location matching nest data doesn't match what's expected, but recognition is ready for tweaks
2019-11-21 01:07:51 +00:00
public virtual int Location { get; set; }
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public int Ability { get; set; }
public int Form { get; set; }
Merge PIDType and bool? shiny property Gen5 does not follow the same convention, 0 = non, 1 = rnd, 2 = always; not gonna bother updating for just that one bool? occupies 2 bytes; enum:byte is 1 byte. should probably move validity checking logic into the IEncounterable objects instead...
2018-03-17 02:35:55 +00:00
public virtual Shiny Shiny { get; set; } = Shiny.Random;
Make Relearn array for encounters readonly No change em
2020-01-19 00:31:24 +00:00
public IReadOnlyList<int> Relearn { get; set; } = Array.Empty<int>();
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public int Gender { get; set; } = -1;
public int EggLocation { get; set; }
public Nature Nature { get; set; } = Nature.Random;
public bool Gift { get; set; }
public int Ball { get; set; } = 4; // Only checked when is Gift
Refactoring add IVersion interface with common interactions
2018-03-30 23:31:40 +00:00
public GameVersion Version { get; set; } = GameVersion.Any;
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
public int[] IVs { get; set; } = Array.Empty<int>();
Replace IV3 with FlawlessIVCount Other games may vary the flawless IV count so best to have consistent declarations (the vc transfer encounter has 5 or 3 depending if it's a mew/celebi)
2018-12-30 18:33:00 +00:00
public int FlawlessIVCount { get; set; }
Pull out Contest Stat logic to interface
2018-03-24 17:36:48 +00:00
public int[] Contest { set => this.SetContestStats(value); }
public int CNT_Cool { get; set; }
public int CNT_Beauty { get; set; }
public int CNT_Cute { get; set; }
public int CNT_Smart { get; set; }
public int CNT_Tough { get; set; }
public int CNT_Sheen { get; set; }
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
public int HeldItem { get; set; }
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public int EggCycles { get; set; }
Add magearna Add fallthrough for events that do not match (fateful/event location) so that magearna can be caught in the static encounter check Add fateful/wishing ribbon checks for Static Encounters Add Gen7 WC6DB beginnings
2016-11-13 17:37:28 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public bool Fateful { get; set; }
public bool RibbonWishing { get; set; }
public bool SkipFormCheck { get; set; }
public bool Roaming { get; set; }
Gen 1 move analysis improvement. Adapted the valid moves to take into account that move deleter and move reminder do not exits in generation 1 (#1037) * Fix getMoves with min level, when SkipWhile and TakeWhile is used together the index i in TakeWhile is calculated from the enumerator that results of the SkipWhile function, not the index of the initial array, those giving an incorrect index to check Levels array in the TakeWhile * Fix getMoves when levelmin or levelmax is above max level in the levels array, TakeWhile and SkipWhile return empty list if the while goes beyond the last element of the array * Include player hatched egg in the list of possible encounters for parseMoves only if the pokemon was an egg Also change the valur of WasEgg for gen1,2,3 pokemon if the encounter analyzed is not an egg add the non egg encounters to the list instead of checking the non-egg encounter inside parseMovesWasEggPreRelearn * Fix for gen3 egg encounters Remove non-egg encounters without special moves if there is an egg encounter because egg encounter already cover every possible move combination Do not add daycare egg encounter for gen3 unhatched egg if there is another encounter, that means is an event or gift egg, not a daycare egg Remove duplicate encounters * Gift egg should not allow inherited moves even it they dont have special moves Those gift eggs are hatched only with the species base moves * Added getEncounterMoves functions, to be used for generation 1 encounters to find what moves have a pokemon at the moment of being caught because there is no move reminder in generation 1 * Added GBEncounterData, structure for refactor the tuples used in generation 1 and 2 encounters * Add LevelMin and LevelMax to IEncounterable to get the encounter moves by the min level of the generation 1 EncounterLink Add iGeneration to difference generation 1 and generation 2 encounters for GB Era pokemon * Mark generation in gen 1 and 2 encounters There is no need to mark the generation in gen 3 to 7 encounters because in that generations it match the pokemon generation number * Add min level for generation 1 moves in getMoves functions Add function to return the default moves for a GB encounters, for generation 1 games that included both moves from level up table and level 1 moves from personal table Fix getMoves with min level when the moves list is empty, like Raichu generation 1 * Add maxSpecies to getBaseSpecies function for gen1 pokemon with a gen2 egg encounter Refactor VC Encounter changing Tuples for GBData class * Fixed for gen 2 Checks Also do not search for generation1 encounter if the gen2 pokemon have met location from crystal * Fix VC wild encounters, should be stored as array or else other verifyEncounter functions wont work * Add generation 1 parse moves function including default moves * Clean-up get encounters * Verify empty moves for generation 1 encounters, in generation 1 does not exits move deleter That means when a move slot have been used by a level up move or a TM/HM/Tutor move it cant be empty again Does not apply if generation 2 tradeback is allowed, in generation 2 there is a move deleter * Added two edge cases for pokemon that learn in red/blue and yellow different moves at the same level, this combinations can not exits until a later level when they learn again one of the levels in the other game, only happen for flareon and vaporeon * Check incompatible moves between evolution species, it is for species that learn a move in a level as an evolved species and a move at a upper level as a preevolution Also added most edge cases for the min slots used for generation 1 games, i think every weird combination is already covered * Fix gen 1 eevee and evolutions move checks * Cleanup * Move the code to change valid moves for generation 1 to a function * Fix getMoveMinLevelGBEncounter * getUsedMoveSlots, removed wild Butterfree edge case, it is not possible * Filter the min level of the encounter by the possible games the pokemon could be originated, yellow pikachu and kadabra can be detected
2017-04-09 00:17:20 +00:00
public bool EggEncounter => EggLocation > 0;
Add locations to roaming pokemon in gen 3 Add roaming flag to static pokemon, in gen 3 roaming pokemon have a different PID-IV generation
2017-03-20 12:35:12 +00:00
Refactoring relocate location of stuff
2018-03-09 05:18:32 +00:00
private void CloneArrays()
add b2w2 n's pokemon PIDs add b2w2 fixed PID encounters (N's Pokemon), move nsparkle to this class redo static encounter cloning
2017-12-18 23:25:40 +00:00
{
// dereference original arrays with new copies
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
IVs = IVs.Length == 0 ? IVs : (int[])IVs.Clone();
add b2w2 n's pokemon PIDs add b2w2 fixed PID encounters (N's Pokemon), move nsparkle to this class redo static encounter cloning
2017-12-18 23:25:40 +00:00
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Refactoring relocate location of stuff
2018-03-09 05:18:32 +00:00
internal virtual EncounterStatic Clone()
add b2w2 n's pokemon PIDs add b2w2 fixed PID encounters (N's Pokemon), move nsparkle to this class redo static encounter cloning
2017-12-18 23:25:40 +00:00
{
var result = (EncounterStatic)MemberwiseClone();
result.CloneArrays();
return result;
}
Add DreamRadar Encounter
2017-03-24 22:50:00 +00:00
Refactoring relocate location of stuff
2018-03-09 05:18:32 +00:00
private const string _name = "Static Encounter";
Add short/long name property differentiation
2019-03-18 05:19:37 +00:00
public string Name => _name;
public string LongName => Version == GameVersion.Any ? _name : $"{_name} ({Version})";
Add IEncounterable -> pkm interface method egg,slot,static,link,trade need to be implemented later remove IEncounterable from PL6
2018-03-29 03:38:07 +00:00
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
public PKM ConvertToPKM(ITrainerInfo SAV) => ConvertToPKM(SAV, EncounterCriteria.Unrestricted);
public PKM ConvertToPKM(ITrainerInfo SAV, EncounterCriteria criteria)
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
{
Fix broken tests rework getblank for version specific
2018-11-20 00:14:49 +00:00
var pk = PKMConverter.GetBlank(Generation, Version);
Refactoring & finish eevee test case generates a legal pk* for every possible encounter; there's likely other scenarios and more roughness to smooth out, but seems legit for now
2018-04-01 03:37:36 +00:00
SAV.ApplyToPKM(pk);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
pk.EncryptionConstant = Util.Rand32();
pk.Species = Species;
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.AltForm = Form;
Extract logic from PKX Extract Species Name logic to SpeciesName Extract Language logic to Language Remove FormConverter wrapper for string[] fetch Rearrange some logic to more appropriate locations, update access modifiers / types Move some pkm array methods to arrayutil, make generic PKX.GetVCLanguage was a dupe of _K12.GuessedLanguage() so just expose the method PKX is now back to pkm data manip only
2019-09-19 02:58:23 +00:00
int lang = (int)Language.GetSafeLanguage(Generation, (LanguageID)SAV.Language);
Sword/Shield Update
2019-11-16 01:34:18 +00:00
int level = GetMinimalLevel();
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
var version = this.GetCompatibleVersion((GameVersion)SAV.Game);
SanityCheckVersion(ref version);
Add exclusive encounter handling Handle Faraway Island Mew, handle DP Darkrai/Shaymin & Arceus, handle not-distributed WC3s. Now stopping at dex 154 -- one full generation of PKM species IDs can be completely spawned directly from IEncounterable data!
2018-05-08 05:12:12 +00:00
pk.Language = lang = GetEdgeCaseLanguage(pk, lang);
Extract logic from PKX Extract Species Name logic to SpeciesName Extract Language logic to Language Remove FormConverter wrapper for string[] fetch Rearrange some logic to more appropriate locations, update access modifiers / types Move some pkm array methods to arrayutil, make generic PKX.GetVCLanguage was a dupe of _K12.GuessedLanguage() so just expose the method PKX is now back to pkm data manip only
2019-09-19 02:58:23 +00:00
pk.Nickname = SpeciesName.GetSpeciesNameGeneration(Species, lang, Generation);
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
pk.CurrentLevel = level;
pk.Version = (int)version;
pk.Ball = Ball;
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
pk.HeldItem = HeldItem;
pk.OT_Friendship = pk.PersonalInfo.BaseFriendship;
Rework some more pkm generating logic can get all the way to caterpie - gen3/4 needs an antishiny, - gen5 needs shiny&antishiny mech - else case needs both as well.
2018-04-29 05:56:10 +00:00
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
var today = DateTime.Today;
SetMetData(pk, level, today);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
if (EggEncounter)
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
SetEggMetData(pk, SAV, today);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
SetPINGA(pk, criteria);
SetEncounterMoves(pk, version, level);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
switch (pk)
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
{
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
case PK3 pk3 when this is EncounterStaticShadow:
pk3.RibbonNational = true;
Rework some more pkm generating logic can get all the way to caterpie - gen3/4 needs an antishiny, - gen5 needs shiny&antishiny mech - else case needs both as well.
2018-04-29 05:56:10 +00:00
break;
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
case PK4 pk4 when this is EncounterStaticTyped t:
pk4.EncounterType = t.TypeEncounter.GetIndex();
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
break;
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
case PK6 pk6:
pk6.SetRandomMemory6();
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
break;
}
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
if (RibbonWishing && pk is IRibbonSetEvent4 e4)
e4.RibbonWishing = true;
if (this is EncounterStaticN n)
n.SetNPokemonData((PK5)pk, lang);
Simplify IContestStats usage remove new[] creating for checking if any contest stats exist (HasContestStats)
2018-06-03 04:19:03 +00:00
if (pk is IContestStats s)
this.CopyContestStatsTo(s);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
if (Fateful)
pk.FatefulEncounter = true;
if (pk.Format < 6)
return pk;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
pk.SetRelearnMoves(Relearn);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
SAV.ApplyHandlingTrainerInfo(pk);
pk.SetRandomEC();
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (this is IGigantamax g && pk is IGigantamax pg)
pg.CanGigantamax = g.CanGigantamax;
if (this is IDynamaxLevel d && pk is IDynamaxLevel pd)
pd.DynamaxLevel = d.DynamaxLevel;
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
return pk;
}
More generator fixes/improvements Fix/add missing gameversion references (BU instead of BW, pokewalker=HGSS) increase reuse of pidgenerator & add more generating methods. seems like it's generating pkm fine besides the PID edge cases, which is nice
2018-04-29 16:31:13 +00:00
Sword/Shield Update
2019-11-16 01:34:18 +00:00
protected virtual int GetMinimalLevel() => LevelMin;
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
protected virtual void SetPINGA(PKM pk, EncounterCriteria criteria)
{
int gender = criteria.GetGender(Gender, pk.PersonalInfo);
int nature = (int)criteria.GetNature(Nature);
Sword/Shield Update
2019-11-16 01:34:18 +00:00
int ability = GetRandomAbility(); // use criteria?
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
var pidtype = GetPIDType();
Sword/Shield Update
2019-11-16 01:34:18 +00:00
PIDGenerator.SetRandomWildPID(pk, pk.Format, nature, ability, gender, pidtype);
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
SetIVs(pk);
}
Sword/Shield Update
2019-11-16 01:34:18 +00:00
private int GetRandomAbility()
{
return Ability switch
{
0 => Util.Rand.Next(2),
-1 => Util.Rand.Next(3),
_ => (Ability >> 1)
};
}
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
private void SetEggMetData(PKM pk, ITrainerInfo tr, DateTime today)
{
pk.Met_Location = Math.Max(0, EncounterSuggestion.GetSuggestedEggMetLocation(pk));
pk.Met_Level = EncounterSuggestion.GetSuggestedEncounterEggMetLevel(pk);
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
if (Generation >= 4)
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
{
bool traded = (int)Version == tr.Game;
pk.Egg_Location = EncounterSuggestion.GetSuggestedEncounterEggLocationEgg(pk, traded);
pk.EggMetDate = today;
}
pk.Egg_Location = EggLocation;
pk.EggMetDate = today;
}
private void SetMetData(PKM pk, int level, DateTime today)
{
if (pk.Format > 2 || Version == GameVersion.C)
{
pk.Met_Location = Location;
pk.Met_Level = level;
if (Version == GameVersion.C && pk is PK2 pk2)
pk2.Met_TimeOfDay = EncounterTime.Any.RandomValidTime();
if (pk.Format >= 4)
pk.MetDate = today;
}
}
private void SetEncounterMoves(PKM pk, GameVersion version, int level)
{
Make Move[] readonly list contract: don't modify the template movesets mystery gift now exposes IRelearn, remove unnecessary type checks
2020-01-19 00:46:38 +00:00
var moves = Moves.Count > 0 ? Moves : MoveLevelUp.GetEncounterMoves(pk, level, version);
pk.SetMoves(moves);
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.SetMaximumPPCurrent(moves);
}
More generator updates Store 4g giratina held item for enc->pkm legality revise usages of GetSaneGender Rearrange some logic Better handle impossible version encounters (gen4) gen 1-5 done, stuck on 659 - bunnelby egg...?
2018-05-10 00:50:56 +00:00
private void SanityCheckVersion(ref GameVersion version)
{
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
if (Generation != 4 || version == GameVersion.Pt)
return;
More generator updates Store 4g giratina held item for enc->pkm legality revise usages of GetSaneGender Rearrange some logic Better handle impossible version encounters (gen4) gen 1-5 done, stuck on 659 - bunnelby egg...?
2018-05-10 00:50:56 +00:00
switch (Species)
{
use some explicit dex numbers as enum
2019-06-01 17:22:49 +00:00
case (int)Core.Species.Darkrai when Location == 079: // DP Darkrai
case (int)Core.Species.Shaymin when Location == 063: // DP Shaymin
More generator updates Store 4g giratina held item for enc->pkm legality revise usages of GetSaneGender Rearrange some logic Better handle impossible version encounters (gen4) gen 1-5 done, stuck on 659 - bunnelby egg...?
2018-05-10 00:50:56 +00:00
version = GameVersion.Pt;
return;
}
}
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
protected void SetIVs(PKM pk)
More generator updates Store 4g giratina held item for enc->pkm legality revise usages of GetSaneGender Rearrange some logic Better handle impossible version encounters (gen4) gen 1-5 done, stuck on 659 - bunnelby egg...?
2018-05-10 00:50:56 +00:00
{
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
if (IVs.Length != 0)
More generator updates Store 4g giratina held item for enc->pkm legality revise usages of GetSaneGender Rearrange some logic Better handle impossible version encounters (gen4) gen 1-5 done, stuck on 659 - bunnelby egg...?
2018-05-10 00:50:56 +00:00
pk.SetRandomIVs(IVs, FlawlessIVCount);
else if (FlawlessIVCount > 0)
pk.SetRandomIVs(flawless: FlawlessIVCount);
}
Add exclusive encounter handling Handle Faraway Island Mew, handle DP Darkrai/Shaymin & Arceus, handle not-distributed WC3s. Now stopping at dex 154 -- one full generation of PKM species IDs can be completely spawned directly from IEncounterable data!
2018-05-08 05:12:12 +00:00
private int GetEdgeCaseLanguage(PKM pk, int lang)
{
switch (pk.Format)
{
use some explicit dex numbers as enum
2019-06-01 17:22:49 +00:00
case 1 when Species == (int)Core.Species.Mew && Version == GameVersion.VCEvents: // VC Mew
Add exclusive encounter handling Handle Faraway Island Mew, handle DP Darkrai/Shaymin & Arceus, handle not-distributed WC3s. Now stopping at dex 154 -- one full generation of PKM species IDs can be completely spawned directly from IEncounterable data!
2018-05-08 05:12:12 +00:00
pk.TID = 22796;
Refactoring improve readability
2018-06-23 19:37:01 +00:00
pk.OT_Name = Legal.GetG1OT_GFMew(lang);
Add exclusive encounter handling Handle Faraway Island Mew, handle DP Darkrai/Shaymin & Arceus, handle not-distributed WC3s. Now stopping at dex 154 -- one full generation of PKM species IDs can be completely spawned directly from IEncounterable data!
2018-05-08 05:12:12 +00:00
return lang;
More generator updates * first case of EncounterLink, now works (version, ability, OT memory) * handle gen2 gb events (not even sure if they pop up, just in case) * handle gen3 ereader shadow mons * handle gen4 spiky pichu PID type * handle gen2 crystal egg met level
2018-05-08 05:53:36 +00:00
case 1 when Version == GameVersion.EventsGBGen1:
case 2 when Version == GameVersion.EventsGBGen2:
case 3 when this is EncounterStaticShadow s && s.EReader:
use some explicit dex numbers as enum
2019-06-01 17:22:49 +00:00
case 3 when Species == (int)Core.Species.Mew:
Add exclusive encounter handling Handle Faraway Island Mew, handle DP Darkrai/Shaymin & Arceus, handle not-distributed WC3s. Now stopping at dex 154 -- one full generation of PKM species IDs can be completely spawned directly from IEncounterable data!
2018-05-08 05:12:12 +00:00
pk.OT_Name = "ゲーフリ";
use some explicit dex numbers as enum
2019-06-01 17:22:49 +00:00
return (int)LanguageID.Japanese; // Old Sea Map was only distributed to Japanese games.
Add exclusive encounter handling Handle Faraway Island Mew, handle DP Darkrai/Shaymin & Arceus, handle not-distributed WC3s. Now stopping at dex 154 -- one full generation of PKM species IDs can be completely spawned directly from IEncounterable data!
2018-05-08 05:12:12 +00:00
default:
return lang;
}
}
More generator fixes/improvements Fix/add missing gameversion references (BU instead of BW, pokewalker=HGSS) increase reuse of pidgenerator & add more generating methods. seems like it's generating pkm fine besides the PID edge cases, which is nice
2018-04-29 16:31:13 +00:00
private PIDType GetPIDType()
{
Continued pkmgen updates * adds g4 forced shiny seed->pid (Chain Shiny Lake of Rage Gyarados) * adds cxd starter pid generating handling * adds g5 forced shiny seed->pid (MG5Shiny Shiny gift Dratini) * excludes gen4 route45 surf impossible encounters * actually use ingame trade edge case handler Up to dragonair (147) yay; yellow dragonair is likely the catch rate edge case.
2018-05-08 04:16:54 +00:00
switch (Generation)
{
More generator updates * B2 has an error in the encounter table for Route 3 Corphish Special water encounter; GF edited from Basculin-1 to Corphish-1 and forgot to update the form to 0. * Ranch Trade egg locations * Trade gender-PID set correctly * static roamer glitch does not apply for emerald * Mirage Island wild Wynaut case now allowed (collision with Gift Wynaut egg hatched on Mirage Island?) gen1-3 done; now at 413 (Wormadam) which currently yields an EncounterEgg AS wormadam, which isn't right...
2018-05-09 04:17:31 +00:00
case 3 when Roaming && Version != GameVersion.E: // Roamer IV glitch was fixed in Emerald
Continued pkmgen updates * adds g4 forced shiny seed->pid (Chain Shiny Lake of Rage Gyarados) * adds cxd starter pid generating handling * adds g5 forced shiny seed->pid (MG5Shiny Shiny gift Dratini) * excludes gen4 route45 surf impossible encounters * actually use ingame trade edge case handler Up to dragonair (147) yay; yellow dragonair is likely the catch rate edge case.
2018-05-08 04:16:54 +00:00
return PIDType.Method_1_Roamer;
case 4 when Shiny == Shiny.Always: // Lake of Rage Gyarados
return PIDType.ChainShiny;
use some explicit dex numbers as enum
2019-06-01 17:22:49 +00:00
case 4 when Species == (int)Core.Species.Pichu: // Spiky Eared Pichu
case 4 when Location == Locations.PokeWalker4: // Pokéwalker
Continued pkmgen updates * adds g4 forced shiny seed->pid (Chain Shiny Lake of Rage Gyarados) * adds cxd starter pid generating handling * adds g5 forced shiny seed->pid (MG5Shiny Shiny gift Dratini) * excludes gen4 route45 surf impossible encounters * actually use ingame trade edge case handler Up to dragonair (147) yay; yellow dragonair is likely the catch rate edge case.
2018-05-08 04:16:54 +00:00
return PIDType.Pokewalker;
case 5 when Shiny == Shiny.Always:
return PIDType.G5MGShiny;
default: return PIDType.None;
}
More generator fixes/improvements Fix/add missing gameversion references (BU instead of BW, pokewalker=HGSS) increase reuse of pidgenerator & add more generating methods. seems like it's generating pkm fine besides the PID edge cases, which is nice
2018-04-29 16:31:13 +00:00
}
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
Sword/Shield Update
2019-11-16 01:34:18 +00:00
public virtual bool IsMatch(PKM pkm, int lvl)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
{
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (Nature != Nature.Random && pkm.Nature != (int) Nature)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return false;
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
Remove WasEgg setter WasEgg (aka WasDefinitelyAnEgg) from stored properties is one thing, WasEgg from encounter info is another; don't mix
2019-07-26 00:42:15 +00:00
if (Generation > 3 && pkm.Format > 3 && pkm.WasEgg != EggEncounter && pkm.Egg_Location == 0 && !pkm.IsEgg)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return false;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (!IsMatchEggLocation(pkm, ref lvl))
return false;
Revisions for some static encounters Identified a few more
2019-11-17 23:50:41 +00:00
if (!IsMatchLocation(pkm))
return false;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (!IsMatchLevel(pkm, lvl))
return false;
if (!IsMatchGender(pkm))
return false;
if (!IsMatchForm(pkm))
return false;
Make Relearn array for encounters readonly No change em
2020-01-19 00:31:24 +00:00
if (EggLocation == Locations.Daycare5 && Relearn.Count == 0 && pkm.RelearnMoves.Any(z => z != 0)) // gen7 eevee edge case
Sword/Shield Update
2019-11-16 01:34:18 +00:00
return false;
if (!IsMatchIVs(pkm))
return false;
if (pkm is IContestStats s && s.IsContestBelow(this))
return false;
// Defer to EC/PID check
// if (e.Shiny != null && e.Shiny != pkm.IsShiny)
// continue;
// Defer ball check to later
// if (e.Gift && pkm.Ball != 4) // PokéBall
// continue;
return true;
}
private bool IsMatchIVs(PKM pkm)
{
if (IVs.Length == 0)
return true; // nothing to check, IVs are random
if (Generation <= 2 && pkm.Format > 2)
return true; // IVs are regenerated on VC transfer upward
return Legal.GetIsFixedIVSequenceValidSkipRand(IVs, pkm);
}
private bool IsMatchForm(PKM pkm)
{
if (SkipFormCheck)
return true;
if (Form != pkm.AltForm && !Legal.IsFormChangeable(pkm, Species))
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return false;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
return true;
}
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
Sword/Shield Update
2019-11-16 01:34:18 +00:00
private bool IsMatchEggLocation(PKM pkm, ref int lvl)
{
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
if (Generation == 3 && EggLocation != 0) // Gen3 Egg
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
{
if (pkm.Format == 3 && pkm.IsEgg && EggLocation != pkm.Met_Location)
return false;
}
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
else if (Generation <= 2 && EggLocation != 0) // Gen2 Egg
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
{
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (pkm.Format > 2)
return true;
if (pkm.IsEgg)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
{
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (pkm.Met_Location != 0 && pkm.Met_Level != 0)
return false;
}
else
{
switch (pkm.Met_Level)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
{
Sword/Shield Update
2019-11-16 01:34:18 +00:00
case 0 when pkm.Met_Location != 0:
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return false;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
case 1 when pkm.Met_Location == 0:
return false;
default:
if (pkm.Met_Location == 0 && pkm.Met_Level != 0)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return false;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
break;
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
}
}
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (pkm.Met_Level == 1) // Gen2 Eggs are met at 1, and hatch at level 5.
lvl = 5;
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
}
else if (EggLocation != pkm.Egg_Location)
{
if (pkm.IsEgg) // unhatched
{
if (EggLocation != pkm.Met_Location)
return false;
if (pkm.Egg_Location != 0)
return false;
}
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
else if (Generation == 4)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
{
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
if (pkm.Egg_Location != Locations.LinkTrade4) // Link Trade
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
{
// check Pt/HGSS data
if (pkm.Format <= 4)
Sword/Shield Update
2019-11-16 01:34:18 +00:00
return false;
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
if (!Locations.IsPtHGSSLocationEgg(EggLocation)) // non-Pt/HGSS egg gift
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return false;
// transferring 4->5 clears pt/hgss location value and keeps Faraway Place
if (pkm.Egg_Location != 3002) // Faraway Place
return false;
}
}
else
{
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
if (pkm.Egg_Location != Locations.LinkTrade6) // Link Trade
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return false;
}
}
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
else if (EggLocation != 0 && Generation == 4)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
{
// Check the inverse scenario for 4->5 eggs
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
if (Locations.IsPtHGSSLocationEgg(EggLocation)) // egg gift
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
{
if (pkm.Format > 4)
return false;
}
}
Sword/Shield Update
2019-11-16 01:34:18 +00:00
return true;
}
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
Sword/Shield Update
2019-11-16 01:34:18 +00:00
private bool IsMatchGender(PKM pkm)
{
if (Gender == -1 || Gender == pkm.Gender)
return true;
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (Species == (int) Core.Species.Azurill && Generation == 4 && Location == 233 && pkm.Gender == 0)
return PKX.GetGenderFromPIDAndRatio(pkm.PID, 0xBF) == 1;
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
Sword/Shield Update
2019-11-16 01:34:18 +00:00
return false;
}
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
Initial rough draft of nest location matching nest data doesn't match what's expected, but recognition is ready for tweaks
2019-11-21 01:07:51 +00:00
protected virtual bool IsMatchLocation(PKM pkm)
Revisions for some static encounters Identified a few more
2019-11-17 23:50:41 +00:00
{
if (EggEncounter)
return true;
if (Location == 0)
return true;
Rework evo tree chaining to track form Now recognizes & reverses form-changing evolution chains like Sirfetch'd basically the whole process is to build the tree but point in the opposite direction (for de-evolution paths)
2019-11-18 05:45:53 +00:00
if (!pkm.HasOriginalMetLocation)
return true;
Revisions for some static encounters Identified a few more
2019-11-17 23:50:41 +00:00
return Location == pkm.Met_Location;
}
Sword/Shield Update
2019-11-16 01:34:18 +00:00
protected virtual bool IsMatchLevel(PKM pkm, int lvl)
{
if (!pkm.HasOriginalMetLocation)
return lvl >= Level;
if (lvl == Level)
return true;
if (!(pkm.Format == 3 && EggEncounter && lvl == 0))
return false;
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return true;
}
Add encounter static deferral oop We've already been doing something similar for the deferral check; just merge the logic into the base object Closes #2489
2019-11-22 04:02:08 +00:00
public virtual bool IsMatchDeferred(PKM pkm)
{
if (pkm.FatefulEncounter != Fateful)
return true;
if (Ability == 4 && pkm.AbilityNumber != 4) // BW/2 Jellicent collision with wild surf slot, resolved by duplicating the encounter with any abil
return true;
return false;
}
Prep for next wave of implementation need to get a release out beforehand tho
2017-04-23 16:18:42 +00:00
}
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
}
Reference in a new issue Copy permalink