PKHeX/PKHeX.Core/Legality/Evolutions/EvoCriteria.cs

namespace PKHeX.Core
{
    public sealed class EvoCriteria : DexLevel
    {
        public EvoCriteria(int species, int form) : base(species, form)
        {
        }

        public int MinLevel { get; set; }
        public bool RequiresLvlUp { get; set; }
        public int Method { get; set; } = -1;

        public bool IsTradeRequired => ((EvolutionType) Method).IsTrade();

        public override string ToString() => $"{(Species) Species} [{MinLevel},{Level}] via {(EvolutionType) Method}";
    }
}
-												Refactoring

Split evolution data specific DexLevel properties from DexLevel

use IReadOnlyList instead of IList for covariant collection

											
										
										
											2018-06-19 02:10:21 +00:00
+								namespace PKHeX.Core
 								{
-												Misc simplifications

reduce nesting (evo.RequiresLevelUp is checked twice, only check once
and handle path)
compact some methods
seal some classes
add a little xmldoc to exposed members

											
										
										
											2018-07-02 02:55:23 +00:00
+								    public sealed class EvoCriteria : DexLevel
-												Refactoring

Split evolution data specific DexLevel properties from DexLevel

use IReadOnlyList instead of IList for covariant collection

											
										
										
											2018-06-19 02:10:21 +00:00
+								    {
-												Clean up dexlevel/evocriteria constructor usage

DexLevel was the initial abstraction, which was expanded/reused for
evolution details

I should probably merge the two classes since everything is passed as
EvoCriteria
The encounter generators do some silly form fuzzy match which can now be
more accurately checked since I've moved Form to DexLevel... maybe a
future commit can clean that up.

encounterarea2 was reusing this class, just use a throwaway readonly
struct as our temp value storage

											
										
										
											2019-12-06 07:04:24 +00:00
+								        public EvoCriteria(int species, int form) : base(species, form)
 								        {
 								        }
-												Refactoring

Split evolution data specific DexLevel properties from DexLevel

use IReadOnlyList instead of IList for covariant collection

											
										
										
											2018-06-19 02:10:21 +00:00
+								        public int MinLevel { get; set; }
 								        public bool RequiresLvlUp { get; set; }
-												Evo chain Simplifications

Rename "Flag" to "Method"; isn't used besides for indicating the evo
Method.
Remove some unnecessary duplicate checks
- always >=1 in chain at start
- mostEvolved already checked for > maxspeciesgen

											
										
										
											2018-06-21 02:42:45 +00:00
+								        public int Method { get; set; } = -1;
-												Misc updates

reducing allocations, increasing clarity by removing some magic numbers
probably can rewrite some of the evo loading/checking for even less, but
good for now.

											
										
										
											2019-01-07 00:22:45 +00:00
 								        public bool IsTradeRequired => ((EvolutionType) Method).IsTrade();
-												Finish splitting gen1/2 encounter types from parent class

Results in a little more code, but each path is less tangled
simplify some expressions
remove RBDragonair content in favor of a strict filter for catch rate

Move gen1 trade trainer names to stringconverter, since pk1/pk2 shouldn't refer to legality classes

											
										
										
											2020-07-19 18:32:40 +00:00
 								        public override string ToString() => $"{(Species) Species} [{MinLevel},{Level}] via {(EvolutionType) Method}";
-												Refactoring

Split evolution data specific DexLevel properties from DexLevel

use IReadOnlyList instead of IList for covariant collection

											
										
										
											2018-06-19 02:10:21 +00:00
+								    }
 								}