PKHeX/PKHeX.Core/Legality/Verifiers/Ribbons/RibbonResult.cs

namespace PKHeX.Core
{
    /// <summary>
    /// Legality Check Parse object containing information about a single ribbon.
    /// </summary>
    internal sealed class RibbonResult
    {
        /// <summary>Ribbon Display Name</summary>
        public string Name { get; private set; }

        /// <summary>Ribbon should not be present.</summary>
        /// <remarks>If this is false, the Ribbon is missing.</remarks>
        public bool Invalid { get; }

        public RibbonResult(string prop, bool invalid = true)
        {
            Name = RibbonStrings.GetName(prop);
            Invalid = invalid;
        }

        /// <summary>
        /// Merges the result name with another provided result.
        /// </summary>
        public void Combine(RibbonResult other)
        {
            Name += $" / {other.Name}";
        }
    }
}
-												Refactoring

relocate ribbon checks/class to more focused location
reduce amount of GenNumber checks (use stored Generation value instead)

											
										
										
											2017-09-04 02:51:29 +00:00
+								namespace PKHeX.Core
 								{
-												Add xmldoc

											
										
										
											2018-07-21 03:22:46 +00:00
+								    /// <summary>
 								    /// Legality Check Parse object containing information about a single ribbon.
 								    /// </summary>
-												seal hunting

Mark things as sealed as they shouldn't be inherited from or overriden in a derived class.

											
										
										
											2020-09-07 20:51:13 +00:00
+								    internal sealed class RibbonResult
-												Refactoring

relocate ribbon checks/class to more focused location
reduce amount of GenNumber checks (use stored Generation value instead)

											
										
										
											2017-09-04 02:51:29 +00:00
+								    {
 								        /// <summary>Ribbon Display Name</summary>
 								        public string Name { get; private set; }
 								        /// <summary>Ribbon should not be present.</summary>
 								        /// <remarks>If this is false, the Ribbon is missing.</remarks>
 								        public bool Invalid { get; }
 								        public RibbonResult(string prop, bool invalid = true)
 								        {
-												PKHeX.Core Nullable cleanup (#2401)

* Handle some nullable cases

Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization

* Handle bits more obviously without null

* Make SaveFile.BAK explicitly readonly again

* merge constructor methods to have readonly fields

* Inline some properties

* More nullable handling

* Rearrange box actions

define straightforward classes to not have any null properties

* Make extrabyte reference array immutable

* Move tooltip creation to designer

* Rearrange some logic to reduce nesting

* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum

* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case

* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable

* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator

* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever

* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)

* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
											
										
										
											2019-10-17 01:47:31 +00:00
+								            Name = RibbonStrings.GetName(prop);
-												Refactoring

relocate ribbon checks/class to more focused location
reduce amount of GenNumber checks (use stored Generation value instead)

											
										
										
											2017-09-04 02:51:29 +00:00
+								            Invalid = invalid;
 								        }
-												Add xmldoc

											
										
										
											2018-07-21 03:22:46 +00:00
+								        /// <summary>
 								        /// Merges the result name with another provided result.
 								        /// </summary>
-												Refactoring

relocate ribbon checks/class to more focused location
reduce amount of GenNumber checks (use stored Generation value instead)

											
										
										
											2017-09-04 02:51:29 +00:00
+								        public void Combine(RibbonResult other)
 								        {
-												interpolation++

no functional change (assumed)

											
										
										
											2017-09-30 05:58:25 +00:00
+								            Name += $" / {other.Name}";
-												Refactoring

relocate ribbon checks/class to more focused location
reduce amount of GenNumber checks (use stored Generation value instead)

											
										
										
											2017-09-04 02:51:29 +00:00
+								        }
 								    }
 								}