PKHeX/PKHeX.Core/Legality/Encounters/EncounterTrade/EncounterTradeGB.cs

namespace PKHeX.Core
{
    public abstract record EncounterTradeGB : EncounterTrade
    {
        protected EncounterTradeGB(int species, int level, GameVersion game) : base(game)
        {
            Species = species;
            Level = level;
        }

        public abstract override bool IsMatchExact(PKM pkm, DexLevel dl);
    }
}
-												Abstract some gen1/2 encounter types from their parent class

											
										
										
											2020-07-18 15:36:30 -05:00
+								namespace PKHeX.Core
 								{
-												Split IContestStats, mark trades as records

											
										
										
											2020-12-24 00:06:40 -08:00
+								    public abstract record EncounterTradeGB : EncounterTrade
-												Abstract some gen1/2 encounter types from their parent class

											
										
										
											2020-07-18 15:36:30 -05:00
+								    {
-												Mark encstatic version on init rather than post-init

											
										
										
											2021-01-03 16:49:49 -08:00
+								        protected EncounterTradeGB(int species, int level, GameVersion game) : base(game)
-												Abstract some gen1/2 encounter types from their parent class

											
										
										
											2020-07-18 15:36:30 -05:00
+								        {
 								            Species = species;
 								            Level = level;
 								        }
-												Fracture the encounter matching checks to allow progressive validation (#3137)

## Issue

We want to discard-but-remember any slots that aren't a perfect fit, on the off chance that a better one exists later in the search space. If there's no better match, then we gotta go with what we got.

## Example:
Wurmple exists in area `X`, and also has a more rare slot for Silcoon, with the same level for both slots. 
* We have a Silcoon that we've leveled up a few times.

Was our Silcoon originally a Wurmple, or was it caught as a Silcoon? 
* To be sure, we have to check the EC/PID if the Wurmple wouldn't evolve into Cascoon instead.
* We don't want to wholly reject that Wurmple slot, as maybe the Met Level isn't within Silcoon's slot range.

---

Existing implementation would store "deferred" matches in a list; we only need to keep 1 of these matches around (less allocation!). We also want to differentiate between a "good" deferral and a "bad" deferral; I don't think this is necessary but it's currently used by Mystery Gift matching (implemented for the Eeveelution mystery gifts which matter for evolution moves).

The existing logic didn't use inheritance, and instead had static methods being reused across generations. Quite kludgy. Also, the existing logic was a pain to modify the master encounter yield methods, as one generation's quirks had to not impact all other generations that used the method.

---

The new implementation splits out the encounter yielding methods to be separate for each generation / subset. Now, things don't have to check `WasLink` for Gen7 origin, because Pokémon Link wasn't a thing in Gen7.

---

## Future
Maybe refactoring yielders into "GameCores" that expose yielding behaviors / properties, rather than the static logic. As more generations and side-gamegroups get added (thanks LGPE/GO/GameCube), all this switch stuff gets annoying to maintain instead of just overriding/inheritance.

## Conclusion

This shouldn't impact any legality results negatively; if you notice any regressions, report them! This should reduce false flags where we didn't defer-discard an encounter when we should have (wild area mons being confused with raids).
											
										
										
											2021-01-29 17:55:27 -08:00
+								        public abstract override bool IsMatchExact(PKM pkm, DexLevel dl);
-												Abstract some gen1/2 encounter types from their parent class

											
										
										
											2020-07-18 15:36:30 -05:00
+								    }
 								}