Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-12 13:42:36 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Verifiers/MedalVerifier.cs

77 lines
2.7 KiB
C#
Raw Normal View History

Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
using System;
using static PKHeX.Core.LegalityCheckStrings;
namespace PKHeX.Core
{
Misc simplifications / xmldoc
2018-07-02 02:17:37 +00:00
/// <summary>
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
/// Verifies the <see cref="ISuperTrain.SuperTrainingMedalCount"/> and associated values.
Misc simplifications / xmldoc
2018-07-02 02:17:37 +00:00
/// </summary>
public sealed class MedalVerifier : Verifier
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
protected override CheckIdentifier Identifier => CheckIdentifier.Training;
public override void Verify(LegalityAnalysis data)
{
VerifyMedalsRegular(data);
VerifyMedalsEvent(data);
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
private void VerifyMedalsRegular(LegalityAnalysis data)
{
var pkm = data.pkm;
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
var train = (ISuperTrain)pkm;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
var Info = data.Info;
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
uint value = System.Buffers.Binary.BinaryPrimitives.ReadUInt32LittleEndian(data.pkm.Data.AsSpan(0x2C));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
if ((value & 3) != 0) // 2 unused flags
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
data.AddLine(GetInvalid(LSuperUnused));
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
int TrainCount = train.SuperTrainingMedalCount();
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
More super training checks Check the secret unlocked/complete flags for eggs Check the count for VC, and flags too (even though they're checked later, just do it here) #2353
2019-07-07 22:04:58 +00:00
if (pkm.IsEgg)
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
More super training checks Check the secret unlocked/complete flags for eggs Check the count for VC, and flags too (even though they're checked later, just do it here) #2353
2019-07-07 22:04:58 +00:00
// Can't have any super training data as an egg.
if (TrainCount > 0)
data.AddLine(GetInvalid(LSuperEgg));
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
if (train.SecretSuperTrainingUnlocked)
More super training checks Check the secret unlocked/complete flags for eggs Check the count for VC, and flags too (even though they're checked later, just do it here) #2353
2019-07-07 22:04:58 +00:00
data.AddLine(GetInvalid(LSuperNoUnlocked));
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
if (train.SecretSuperTrainingComplete)
More super training checks Check the secret unlocked/complete flags for eggs Check the count for VC, and flags too (even though they're checked later, just do it here) #2353
2019-07-07 22:04:58 +00:00
data.AddLine(GetInvalid(LSuperNoComplete));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
return;
}
More super training checks Check the secret unlocked/complete flags for eggs Check the count for VC, and flags too (even though they're checked later, just do it here) #2353
2019-07-07 22:04:58 +00:00
moar is or
2020-12-25 20:30:26 +00:00
if (Info.Generation is >= 7 or <= 2)
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
More super training checks Check the secret unlocked/complete flags for eggs Check the count for VC, and flags too (even though they're checked later, just do it here) #2353
2019-07-07 22:04:58 +00:00
// Can't have any super training data if it never visited Gen6.
if (TrainCount > 0)
data.AddLine(GetInvalid(LSuperUnavailable));
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
if (train.SecretSuperTrainingUnlocked)
More super training checks Check the secret unlocked/complete flags for eggs Check the count for VC, and flags too (even though they're checked later, just do it here) #2353
2019-07-07 22:04:58 +00:00
data.AddLine(GetInvalid(LSuperNoUnlocked));
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
if (train.SecretSuperTrainingComplete)
More super training checks Check the secret unlocked/complete flags for eggs Check the count for VC, and flags too (even though they're checked later, just do it here) #2353
2019-07-07 22:04:58 +00:00
data.AddLine(GetInvalid(LSuperNoComplete));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
return;
}
More super training checks Check the secret unlocked/complete flags for eggs Check the count for VC, and flags too (even though they're checked later, just do it here) #2353
2019-07-07 22:04:58 +00:00
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
if (pkm.Format >= 7)
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
{
More super training checks Check the secret unlocked/complete flags for eggs Check the count for VC, and flags too (even though they're checked later, just do it here) #2353
2019-07-07 22:04:58 +00:00
// Gen6->Gen7 transfer wipes the two Secret flags.
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
if (train.SecretSuperTrainingUnlocked)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
data.AddLine(GetInvalid(LSuperNoUnlocked));
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
if (train.SecretSuperTrainingComplete)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
data.AddLine(GetInvalid(LSuperNoComplete));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
return;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
More super training checks Check the secret unlocked/complete flags for eggs Check the count for VC, and flags too (even though they're checked later, just do it here) #2353
2019-07-07 22:04:58 +00:00
// Only reach here if Format==6.
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
if (TrainCount == 30 ^ train.SecretSuperTrainingComplete)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 21:11:12 +00:00
data.AddLine(GetInvalid(LSuperComplete));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
private void VerifyMedalsEvent(LegalityAnalysis data)
{
var pkm = data.pkm;
byte value = pkm.Data[0x3A];
Make Distribution Super Training missions invalid Was initially implemented as fishy during SM's initial implementation. Any nonzero value in this byte is invalid, don't even bother checking unused/count. Now that Gen6 (and Gen7) are no longer current gen, any hope for them being released is the same as hoping for Gen4's Azure Flute Arceus. Thus we mark as invalid :) Closes #2353 by effect of no longer flagging as Fishy. I think that my initial implementation of VC stuff had assumed the Generation==7, but later used 1/2 for factual correctness.
2019-07-08 19:12:16 +00:00
if (value != 0)
data.AddLine(GetInvalid(LSuperDistro));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-24 05:00:01 +00:00
}
}
}
Reference in a new issue Copy permalink