Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves
In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.
The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.
The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.
* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 23:15:27 +00:00
|
|
|
using System;
|
2020-10-08 14:10:10 +00:00
|
|
|
using System.Collections.Generic;
|
|
|
|
using System.Linq;
|
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
namespace PKHeX.Core;
|
|
|
|
|
|
|
|
/// <summary>
|
|
|
|
/// Event data for Generation 1
|
|
|
|
/// </summary>
|
|
|
|
/// <inheritdoc cref="EncounterStatic1"/>
|
|
|
|
public sealed record EncounterStatic1E : EncounterStatic1, IFixedGBLanguage
|
2020-10-07 02:35:03 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
public EncounterGBLanguage Language { get; init; } = EncounterGBLanguage.Japanese;
|
|
|
|
|
|
|
|
/// <summary> Trainer name for the event. </summary>
|
|
|
|
public string OT_Name { get; init; } = string.Empty;
|
|
|
|
|
|
|
|
public IReadOnlyList<string> OT_Names { get; init; } = Array.Empty<string>();
|
|
|
|
|
|
|
|
/// <summary> Trainer ID for the event. </summary>
|
|
|
|
public int TID { get; init; } = -1;
|
|
|
|
|
|
|
|
public EncounterStatic1E(byte species, byte level, GameVersion game) : base(species, level, game)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
public override bool IsMatchExact(PKM pk, EvoCriteria evo)
|
2020-10-07 02:35:03 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
if (!base.IsMatchExact(pk, evo))
|
|
|
|
return false;
|
2020-10-07 02:35:03 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
if (Language != EncounterGBLanguage.Any && pk.Japanese != (Language == EncounterGBLanguage.Japanese))
|
|
|
|
return false;
|
2020-10-07 02:35:03 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
// EC/PID check doesn't exist for these, so check Shiny state here.
|
|
|
|
if (!IsShinyValid(pk))
|
|
|
|
return false;
|
2020-10-08 14:10:10 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
if (TID != -1 && pk.TID != TID)
|
|
|
|
return false;
|
2020-10-07 02:35:03 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
if (OT_Name.Length != 0)
|
2020-10-07 02:35:03 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
if (pk.OT_Name != OT_Name)
|
|
|
|
return false;
|
2020-10-07 02:35:03 +00:00
|
|
|
}
|
2022-06-18 18:04:24 +00:00
|
|
|
else if (OT_Names.Count != 0)
|
2020-10-07 02:35:03 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
if (!OT_Names.Contains(pk.OT_Name))
|
2020-10-07 02:35:03 +00:00
|
|
|
return false;
|
2022-06-18 18:04:24 +00:00
|
|
|
}
|
2020-10-07 02:35:03 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
return true;
|
|
|
|
}
|
2020-10-07 02:35:03 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
private bool IsShinyValid(PKM pk) => Shiny switch
|
|
|
|
{
|
|
|
|
Shiny.Never => !pk.IsShiny,
|
|
|
|
Shiny.Always => pk.IsShiny,
|
|
|
|
_ => true,
|
|
|
|
};
|
2020-10-18 17:57:18 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
protected override PKM GetBlank(ITrainerInfo tr) => Language switch
|
|
|
|
{
|
|
|
|
EncounterGBLanguage.Japanese => new PK1(true),
|
|
|
|
EncounterGBLanguage.International => new PK1(),
|
|
|
|
_ => new PK1(tr.Language == 1),
|
|
|
|
};
|
2020-10-07 02:35:03 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
protected override void ApplyDetails(ITrainerInfo tr, EncounterCriteria criteria, PKM pk)
|
|
|
|
{
|
|
|
|
base.ApplyDetails(tr, criteria, pk);
|
2020-10-07 02:35:03 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
if (Version == GameVersion.Stadium)
|
2020-10-18 23:05:01 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
var pk1 = (PK1)pk;
|
|
|
|
// Amnesia Psyduck has different catch rates depending on language
|
|
|
|
if (Species == (int)Core.Species.Psyduck)
|
Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves
In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.
The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.
The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.
* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 23:15:27 +00:00
|
|
|
pk1.Catch_Rate = pk1.Japanese ? (byte)167 : (byte)168;
|
2022-06-18 18:04:24 +00:00
|
|
|
else
|
Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves
In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.
The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.
The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.
* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 23:15:27 +00:00
|
|
|
pk1.Catch_Rate = Util.Rand.Next(2) == 0 ? (byte)167 : (byte)168;
|
2022-06-18 18:04:24 +00:00
|
|
|
}
|
2020-10-18 23:05:01 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
if (TID != -1)
|
|
|
|
pk.TID = TID;
|
2021-02-03 06:14:33 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
if (OT_Name.Length != 0)
|
|
|
|
pk.OT_Name = OT_Name;
|
|
|
|
else if (OT_Names.Count != 0)
|
|
|
|
pk.OT_Name = OT_Names[Util.Rand.Next(OT_Names.Count)];
|
2020-10-07 02:35:03 +00:00
|
|
|
}
|
2022-06-18 18:04:24 +00:00
|
|
|
}
|
2020-10-07 02:35:03 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
public interface IFixedGBLanguage
|
|
|
|
{
|
|
|
|
EncounterGBLanguage Language { get; }
|
|
|
|
}
|
2020-12-11 03:49:53 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
/// <summary>
|
|
|
|
/// Generations 1 & 2 cannot communicate between Japanese & International versions.
|
|
|
|
/// </summary>
|
|
|
|
public enum EncounterGBLanguage
|
|
|
|
{
|
|
|
|
Japanese,
|
|
|
|
International,
|
|
|
|
Any,
|
2020-10-07 03:05:38 +00:00
|
|
|
}
|