PKHeX/PKHeX.Core/Saves/Substructures/Gen8/FieldMoveModelSave8.cs

using System;
using static System.Buffers.Binary.BinaryPrimitives;

namespace PKHeX.Core
{
    public sealed class FieldMoveModelSave8 : SaveBlock
    {
        public FieldMoveModelSave8(SAV8SWSH sav, SCBlock block) : base(sav, block.Data) { }

        public int M { get => ReadUInt16LittleEndian(Data.AsSpan(0x00)); set => WriteUInt16LittleEndian(Data.AsSpan(0x00), (ushort)value); }
        public float X { get => ReadSingleLittleEndian(Data.AsSpan(0x08)); set => WriteSingleLittleEndian(Data.AsSpan(0x08), value); }
        public float Z { get => ReadSingleLittleEndian(Data.AsSpan(0x10)); set => WriteSingleLittleEndian(Data.AsSpan(0x10), value); }
        public float Y { get => (int)ReadSingleLittleEndian(Data.AsSpan(0x18)); set => WriteSingleLittleEndian(Data.AsSpan(0x18), value); }
        public float R { get => (int)ReadSingleLittleEndian(Data.AsSpan(0x20)); set => WriteSingleLittleEndian(Data.AsSpan(0x20), value); }
    }
}
-												Add swsh content placeholders (#2392)

placeholder content until real data is dumped
											
										
										
											2019-09-23 23:56:47 +00:00
+								using System;
-												Refactoring: Span-based value writes and method signatures (#3361)

Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to.

`System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API.

The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder.

Other Fixes included:
- The Super Training UI for Gen6 has been reworked according to the latest block structure additions.
- Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list).
- Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
											
										
										
											2022-01-03 05:35:59 +00:00
+								using static System.Buffers.Binary.BinaryPrimitives;
-												Add swsh content placeholders (#2392)

placeholder content until real data is dumped
											
										
										
											2019-09-23 23:56:47 +00:00
 								namespace PKHeX.Core
 								{
-												sealed

sealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealed

											
										
										
											2019-10-04 02:09:02 +00:00
+								    public sealed class FieldMoveModelSave8 : SaveBlock
-												Add swsh content placeholders (#2392)

placeholder content until real data is dumped
											
										
										
											2019-09-23 23:56:47 +00:00
+								    {
-												Sword/Shield Update

											
										
										
											2019-11-16 01:34:18 +00:00
+								        public FieldMoveModelSave8(SAV8SWSH sav, SCBlock block) : base(sav, block.Data) { }
-												Add swsh content placeholders (#2392)

placeholder content until real data is dumped
											
										
										
											2019-09-23 23:56:47 +00:00
-												Refactoring: Span-based value writes and method signatures (#3361)

Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to.

`System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API.

The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder.

Other Fixes included:
- The Super Training UI for Gen6 has been reworked according to the latest block structure additions.
- Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list).
- Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
											
										
										
											2022-01-03 05:35:59 +00:00
+								        public int M { get => ReadUInt16LittleEndian(Data.AsSpan(0x00)); set => WriteUInt16LittleEndian(Data.AsSpan(0x00), (ushort)value); }
 								        public float X { get => ReadSingleLittleEndian(Data.AsSpan(0x08)); set => WriteSingleLittleEndian(Data.AsSpan(0x08), value); }
 								        public float Z { get => ReadSingleLittleEndian(Data.AsSpan(0x10)); set => WriteSingleLittleEndian(Data.AsSpan(0x10), value); }
 								        public float Y { get => (int)ReadSingleLittleEndian(Data.AsSpan(0x18)); set => WriteSingleLittleEndian(Data.AsSpan(0x18), value); }
 								        public float R { get => (int)ReadSingleLittleEndian(Data.AsSpan(0x20)); set => WriteSingleLittleEndian(Data.AsSpan(0x20), value); }
-												Add swsh content placeholders (#2392)

placeholder content until real data is dumped
											
										
										
											2019-09-23 23:56:47 +00:00
+								    }
 								}