PKHeX/PKHeX.Core/PersonalInfo/PersonalInfoGG.cs

using System;
using static System.Buffers.Binary.BinaryPrimitives;

namespace PKHeX.Core
{
    /// <summary>
    /// <see cref="PersonalInfo"/> class with values from the <see cref="GameVersion.GG"/> games.
    /// </summary>
    public class PersonalInfoGG : PersonalInfoSM
    {
        public PersonalInfoGG(byte[] data) : base(data)
        {
            TMHM = GetBits(Data.AsSpan(0x28, 8)); // only 60 TMs used
            TypeTutors = GetBits(Data.AsSpan(0x38, 1)); // at most 8 flags used
        }

        public int GoSpecies { get => ReadUInt16LittleEndian(Data.AsSpan(0x48)); set => WriteUInt16LittleEndian(Data.AsSpan(0x48), (ushort)value); }
    }
}
-												Add personal info structure update changes

One field added to indicate the GO species or whatever; the 891/892
meltan values match here. Might not be only for GO species translation,
might be for fetching models idk

											
										
										
											2018-11-11 04:59:55 +00:00
+								using System;
-												Refactoring: Span-based value writes and method signatures (#3361)

Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to.

`System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API.

The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder.

Other Fixes included:
- The Super Training UI for Gen6 has been reworked according to the latest block structure additions.
- Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list).
- Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
											
										
										
											2022-01-03 05:35:59 +00:00
+								using static System.Buffers.Binary.BinaryPrimitives;
-												Add personal info structure update changes

One field added to indicate the GO species or whatever; the 891/892
meltan values match here. Might not be only for GO species translation,
might be for fetching models idk

											
										
										
											2018-11-11 04:59:55 +00:00
 								namespace PKHeX.Core
 								{
 								    /// <summary>
-												Add swsh content placeholders (#2392)

placeholder content until real data is dumped
											
										
										
											2019-09-23 23:56:47 +00:00
+								    /// <see cref="PersonalInfo"/> class with values from the <see cref="GameVersion.GG"/> games.
-												Add personal info structure update changes

One field added to indicate the GO species or whatever; the 891/892
meltan values match here. Might not be only for GO species translation,
might be for fetching models idk

											
										
										
											2018-11-11 04:59:55 +00:00
+								    /// </summary>
 								    public class PersonalInfoGG : PersonalInfoSM
 								    {
-												PKHeX.Core Nullable cleanup (#2401)

* Handle some nullable cases

Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization

* Handle bits more obviously without null

* Make SaveFile.BAK explicitly readonly again

* merge constructor methods to have readonly fields

* Inline some properties

* More nullable handling

* Rearrange box actions

define straightforward classes to not have any null properties

* Make extrabyte reference array immutable

* Move tooltip creation to designer

* Rearrange some logic to reduce nesting

* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum

* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case

* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable

* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator

* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever

* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)

* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
											
										
										
											2019-10-17 01:47:31 +00:00
+								        public PersonalInfoGG(byte[] data) : base(data)
-												Remove some unused bitflag regions

cuts down memory footprint by quite a bit (bool[] is 4bytes per bool)

											
										
										
											2019-01-07 06:21:25 +00:00
+								        {
-												Make bitflag get/set span-based

no temp array on write (unused in pkhex anyways)
no length checking on read

											
										
										
											2021-10-09 00:48:34 +00:00
+								            TMHM = GetBits(Data.AsSpan(0x28, 8)); // only 60 TMs used
 								            TypeTutors = GetBits(Data.AsSpan(0x38, 1)); // at most 8 flags used
-												Remove some unused bitflag regions

cuts down memory footprint by quite a bit (bool[] is 4bytes per bool)

											
										
										
											2019-01-07 06:21:25 +00:00
+								        }
-												Refactoring: Span-based value writes and method signatures (#3361)

Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to.

`System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API.

The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder.

Other Fixes included:
- The Super Training UI for Gen6 has been reworked according to the latest block structure additions.
- Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list).
- Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
											
										
										
											2022-01-03 05:35:59 +00:00
+								        public int GoSpecies { get => ReadUInt16LittleEndian(Data.AsSpan(0x48)); set => WriteUInt16LittleEndian(Data.AsSpan(0x48), (ushort)value); }
-												Add personal info structure update changes

One field added to indicate the GO species or whatever; the 891/892
meltan values match here. Might not be only for GO species translation,
might be for fetching models idk

											
										
										
											2018-11-11 04:59:55 +00:00
+								    }
 								}