Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves
In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.
The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.
The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.
* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 23:15:27 +00:00
|
|
|
using System;
|
2022-02-05 01:35:15 +00:00
|
|
|
using static PKHeX.Core.BinLinkerAccessor;
|
2016-02-23 06:52:48 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
namespace PKHeX.Core;
|
|
|
|
|
2022-08-21 08:39:16 +00:00
|
|
|
/// <summary>
|
|
|
|
/// Loosely aggregated legality logic.
|
|
|
|
/// </summary>
|
2022-06-18 18:04:24 +00:00
|
|
|
public static partial class Legal
|
2016-02-23 06:52:48 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
// Gen 1
|
|
|
|
internal static readonly Learnset[] LevelUpRB = LearnsetReader.GetArray(Util.GetBinaryResource("lvlmove_rb.pkl"), MaxSpeciesID_1);
|
|
|
|
internal static readonly Learnset[] LevelUpY = LearnsetReader.GetArray(Util.GetBinaryResource("lvlmove_y.pkl"), MaxSpeciesID_1);
|
|
|
|
|
|
|
|
// Gen 2
|
|
|
|
internal static readonly EggMoves2[] EggMovesGS = EggMoves2.GetArray(Util.GetBinaryResource("eggmove_gs.pkl"), MaxSpeciesID_2);
|
|
|
|
internal static readonly Learnset[] LevelUpGS = LearnsetReader.GetArray(Util.GetBinaryResource("lvlmove_gs.pkl"), MaxSpeciesID_2);
|
|
|
|
internal static readonly EggMoves2[] EggMovesC = EggMoves2.GetArray(Util.GetBinaryResource("eggmove_c.pkl"), MaxSpeciesID_2);
|
|
|
|
internal static readonly Learnset[] LevelUpC = LearnsetReader.GetArray(Util.GetBinaryResource("lvlmove_c.pkl"), MaxSpeciesID_2);
|
|
|
|
|
|
|
|
// Gen 3
|
|
|
|
internal static readonly Learnset[] LevelUpE = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_e.pkl"), "em"));
|
|
|
|
internal static readonly Learnset[] LevelUpRS = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_rs.pkl"), "rs"));
|
|
|
|
internal static readonly Learnset[] LevelUpFR = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_fr.pkl"), "fr"));
|
|
|
|
internal static readonly Learnset[] LevelUpLG = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_lg.pkl"), "lg"));
|
|
|
|
internal static readonly EggMoves6[] EggMovesRS = EggMoves6.GetArray(Get(Util.GetBinaryResource("eggmove_rs.pkl"), "rs"));
|
|
|
|
|
|
|
|
// Gen 4
|
|
|
|
internal static readonly Learnset[] LevelUpDP = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_dp.pkl"), "dp"));
|
|
|
|
internal static readonly Learnset[] LevelUpPt = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_pt.pkl"), "pt"));
|
|
|
|
internal static readonly Learnset[] LevelUpHGSS = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_hgss.pkl"), "hs"));
|
|
|
|
internal static readonly EggMoves6[] EggMovesDPPt = EggMoves6.GetArray(Get(Util.GetBinaryResource("eggmove_dppt.pkl"), "dp"));
|
|
|
|
internal static readonly EggMoves6[] EggMovesHGSS = EggMoves6.GetArray(Get(Util.GetBinaryResource("eggmove_hgss.pkl"), "hs"));
|
|
|
|
|
|
|
|
// Gen 5
|
|
|
|
internal static readonly Learnset[] LevelUpBW = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_bw.pkl"), "51"));
|
|
|
|
internal static readonly Learnset[] LevelUpB2W2 = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_b2w2.pkl"), "52"));
|
|
|
|
internal static readonly EggMoves6[] EggMovesBW = EggMoves6.GetArray(Get(Util.GetBinaryResource("eggmove_bw.pkl"), "bw"));
|
|
|
|
|
|
|
|
// Gen 6
|
|
|
|
internal static readonly EggMoves6[] EggMovesXY = EggMoves6.GetArray(Get(Util.GetBinaryResource("eggmove_xy.pkl"), "xy"));
|
|
|
|
internal static readonly Learnset[] LevelUpXY = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_xy.pkl"), "xy"));
|
|
|
|
internal static readonly EggMoves6[] EggMovesAO = EggMoves6.GetArray(Get(Util.GetBinaryResource("eggmove_ao.pkl"), "ao"));
|
|
|
|
internal static readonly Learnset[] LevelUpAO = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_ao.pkl"), "ao"));
|
|
|
|
|
|
|
|
// Gen 7
|
|
|
|
internal static readonly EggMoves7[] EggMovesSM = EggMoves7.GetArray(Get(Util.GetBinaryResource("eggmove_sm.pkl"), "sm"));
|
|
|
|
internal static readonly Learnset[] LevelUpSM = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_sm.pkl"), "sm"));
|
|
|
|
internal static readonly EggMoves7[] EggMovesUSUM = EggMoves7.GetArray(Get(Util.GetBinaryResource("eggmove_uu.pkl"), "uu"));
|
|
|
|
internal static readonly Learnset[] LevelUpUSUM = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_uu.pkl"), "uu"));
|
|
|
|
internal static readonly Learnset[] LevelUpGG = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_gg.pkl"), "gg"));
|
|
|
|
|
|
|
|
// Gen 8
|
|
|
|
internal static readonly EggMoves7[] EggMovesSWSH = EggMoves7.GetArray(Get(Util.GetBinaryResource("eggmove_swsh.pkl"), "ss"));
|
|
|
|
internal static readonly Learnset[] LevelUpSWSH = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_swsh.pkl"), "ss"));
|
|
|
|
internal static readonly EggMoves6[] EggMovesBDSP = EggMoves6.GetArray(Get(Util.GetBinaryResource("eggmove_bdsp.pkl"), "bs"));
|
|
|
|
internal static readonly Learnset[] LevelUpBDSP = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_bdsp.pkl"), "bs"));
|
|
|
|
internal static readonly Learnset[] LevelUpLA = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_la.pkl"), "la"));
|
|
|
|
internal static readonly Learnset[] MasteryLA = LearnsetReader.GetArray(Get(Util.GetBinaryResource("mastery_la.pkl"), "la"));
|
|
|
|
|
2022-11-25 01:42:17 +00:00
|
|
|
// Gen 9
|
|
|
|
internal static readonly ushort[][] EggMovesSV = EggMoves9.GetArray(Get(Util.GetBinaryResource("eggmove_sv.pkl"), "sv"));
|
|
|
|
internal static readonly ushort[][] ReminderSV = EggMoves9.GetArray(Get(Util.GetBinaryResource("reminder_sv.pkl"), "sv"));
|
|
|
|
internal static readonly Learnset[] LevelUpSV = LearnsetReader.GetArray(Get(Util.GetBinaryResource("lvlmove_sv.pkl"), "sv"));
|
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
internal static int GetMaxSpeciesOrigin(int generation) => generation switch
|
|
|
|
{
|
|
|
|
1 => MaxSpeciesID_1,
|
|
|
|
2 => MaxSpeciesID_2,
|
|
|
|
3 => MaxSpeciesID_3,
|
|
|
|
4 => MaxSpeciesID_4,
|
|
|
|
5 => MaxSpeciesID_5,
|
|
|
|
6 => MaxSpeciesID_6,
|
|
|
|
7 => MaxSpeciesID_7b,
|
|
|
|
8 => MaxSpeciesID_8a,
|
2022-11-25 01:42:17 +00:00
|
|
|
9 => MaxSpeciesID_9,
|
2022-06-18 18:04:24 +00:00
|
|
|
_ => -1,
|
|
|
|
};
|
|
|
|
|
|
|
|
internal static int GetMaxLanguageID(int generation) => generation switch
|
|
|
|
{
|
|
|
|
1 => (int) LanguageID.Spanish, // 1-7 except 6
|
|
|
|
3 => (int) LanguageID.Spanish, // 1-7 except 6
|
|
|
|
2 => (int) LanguageID.Korean,
|
|
|
|
4 => (int) LanguageID.Korean,
|
|
|
|
5 => (int) LanguageID.Korean,
|
|
|
|
6 => (int) LanguageID.Korean,
|
|
|
|
7 => (int) LanguageID.ChineseT,
|
|
|
|
8 => (int) LanguageID.ChineseT,
|
2022-11-25 01:42:17 +00:00
|
|
|
9 => (int) LanguageID.ChineseT,
|
2022-06-18 18:04:24 +00:00
|
|
|
_ => -1,
|
|
|
|
};
|
|
|
|
|
|
|
|
/// <summary>
|
|
|
|
/// Checks if the relearn moves should be wiped.
|
|
|
|
/// </summary>
|
|
|
|
/// <remarks>Already checked for generations < 8.</remarks>
|
|
|
|
/// <param name="pk">Entity to check</param>
|
2022-09-02 03:57:39 +00:00
|
|
|
internal static bool IsOriginalMovesetDeleted(this PKM pk) => pk switch
|
2022-08-25 06:49:00 +00:00
|
|
|
{
|
|
|
|
PA8 pa8 => !pa8.LA,
|
|
|
|
PB8 pb8 => !pb8.BDSP,
|
2022-09-02 03:57:39 +00:00
|
|
|
PK8 pk8 => pk8.IsSideTransfer || pk8.BattleVersion != 0,
|
2023-01-22 04:02:33 +00:00
|
|
|
PK9 pk9 => !(pk9.SV || pk9 is { IsEgg: true, Version: 0 }),
|
2022-08-25 06:49:00 +00:00
|
|
|
_ => false,
|
|
|
|
};
|
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
/// <summary>
|
|
|
|
/// Indicates if PP Ups are available for use.
|
|
|
|
/// </summary>
|
|
|
|
/// <param name="pk">Entity to check</param>
|
|
|
|
public static bool IsPPUpAvailable(PKM pk)
|
|
|
|
{
|
|
|
|
return pk is not PA8;
|
|
|
|
}
|
2019-01-05 18:51:41 +00:00
|
|
|
|
2022-12-17 21:29:06 +00:00
|
|
|
/// <summary>
|
|
|
|
/// Indicate if PP Ups are available for use.
|
|
|
|
/// </summary>
|
|
|
|
/// <param name="moveID">Move ID</param>
|
|
|
|
public static bool IsPPUpAvailable(ushort moveID) => moveID switch
|
|
|
|
{
|
|
|
|
0 => false,
|
2022-12-17 22:04:22 +00:00
|
|
|
(int)Move.Sketch => false, // BD/SP v1.0 could use PP Ups on Sketch, but not in later versions. Disallow anyways.
|
2022-12-17 21:29:06 +00:00
|
|
|
(int)Move.RevivalBlessing => false,
|
|
|
|
_ => true,
|
|
|
|
};
|
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
public static int GetMaxLengthOT(int generation, LanguageID language) => language switch
|
|
|
|
{
|
|
|
|
LanguageID.ChineseS or LanguageID.ChineseT => 6,
|
|
|
|
LanguageID.Japanese or LanguageID.Korean => generation >= 6 ? 6 : 5,
|
|
|
|
_ => generation >= 6 ? 12 : 7,
|
|
|
|
};
|
|
|
|
|
|
|
|
public static int GetMaxLengthNickname(int generation, LanguageID language) => language switch
|
|
|
|
{
|
|
|
|
LanguageID.ChineseS or LanguageID.ChineseT => 6,
|
|
|
|
LanguageID.Japanese or LanguageID.Korean => generation >= 6 ? 6 : 5,
|
|
|
|
_ => generation >= 6 ? 12 : 10,
|
|
|
|
};
|
2019-01-05 18:51:41 +00:00
|
|
|
|
2023-01-22 04:02:33 +00:00
|
|
|
public static bool GetIsFixedIVSequenceValidSkipRand(ReadOnlySpan<int> IVs, PKM pk, uint max = 31)
|
2022-06-18 18:04:24 +00:00
|
|
|
{
|
|
|
|
for (int i = 0; i < 6; i++)
|
2019-01-05 18:51:41 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
if ((uint) IVs[i] > max) // random
|
|
|
|
continue;
|
|
|
|
if (IVs[i] != pk.GetIV(i))
|
|
|
|
return false;
|
2019-01-05 18:51:41 +00:00
|
|
|
}
|
2022-06-18 18:04:24 +00:00
|
|
|
return true;
|
|
|
|
}
|
2022-05-31 04:43:52 +00:00
|
|
|
|
2022-08-22 00:34:32 +00:00
|
|
|
public static bool GetIsFixedIVSequenceValidSkipRand(IndividualValueSet IVs, PKM pk, int max = 31)
|
2022-06-18 18:04:24 +00:00
|
|
|
{
|
2022-08-22 00:34:32 +00:00
|
|
|
// Template IVs not in the [0,max] range are random. Only check for IVs within the "specified" range.
|
|
|
|
if ((uint)IVs.HP <= max && IVs.HP != pk.IV_HP ) return false;
|
|
|
|
if ((uint)IVs.ATK <= max && IVs.ATK != pk.IV_ATK) return false;
|
|
|
|
if ((uint)IVs.DEF <= max && IVs.DEF != pk.IV_DEF) return false;
|
|
|
|
if ((uint)IVs.SPE <= max && IVs.SPE != pk.IV_SPE) return false;
|
|
|
|
if ((uint)IVs.SPA <= max && IVs.SPA != pk.IV_SPA) return false;
|
|
|
|
if ((uint)IVs.SPD <= max && IVs.SPD != pk.IV_SPD) return false;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
public static bool GetIsFixedIVSequenceValidNoRand(IndividualValueSet IVs, PKM pk)
|
|
|
|
{
|
|
|
|
if (IVs.HP != pk.IV_HP ) return false;
|
|
|
|
if (IVs.ATK != pk.IV_ATK) return false;
|
|
|
|
if (IVs.DEF != pk.IV_DEF) return false;
|
|
|
|
if (IVs.SPE != pk.IV_SPE) return false;
|
|
|
|
if (IVs.SPA != pk.IV_SPA) return false;
|
|
|
|
if (IVs.SPD != pk.IV_SPD) return false;
|
2022-06-18 18:04:24 +00:00
|
|
|
return true;
|
2016-02-23 06:52:48 +00:00
|
|
|
}
|
|
|
|
}
|