Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves
In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.
The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.
The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.
* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 23:15:27 +00:00
|
|
|
using System.Runtime.InteropServices;
|
2021-08-22 01:24:38 +00:00
|
|
|
using FluentAssertions;
|
2021-08-21 02:52:31 +00:00
|
|
|
using PKHeX.Core;
|
|
|
|
using Xunit;
|
|
|
|
|
2022-03-26 02:47:23 +00:00
|
|
|
namespace PKHeX.Tests.General;
|
|
|
|
|
|
|
|
public class MarshalTests
|
2021-08-21 02:52:31 +00:00
|
|
|
{
|
2022-03-26 02:47:23 +00:00
|
|
|
[Fact]
|
|
|
|
public void MarshalSize()
|
2021-08-21 02:52:31 +00:00
|
|
|
{
|
2022-03-26 02:47:23 +00:00
|
|
|
Marshal.SizeOf(typeof(NPCLock)).Should().Be(8);
|
|
|
|
Marshal.SizeOf(typeof(PIDIV)).Should().Be(8);
|
Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves
In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.
The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.
The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.
* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 23:15:27 +00:00
|
|
|
Marshal.SizeOf(typeof(MoveResult)).Should().Be(8);
|
|
|
|
Marshal.SizeOf(typeof(EvolutionMethod)).Should().Be(8);
|
2022-08-22 00:34:32 +00:00
|
|
|
Marshal.SizeOf(typeof(Moveset)).Should().Be(8);
|
|
|
|
Marshal.SizeOf(typeof(IndividualValueSet)).Should().BeLessOrEqualTo(8);
|
2022-12-02 06:40:11 +00:00
|
|
|
Marshal.SizeOf(typeof(GenerateParam9)).Should().BeLessOrEqualTo(16);
|
2021-08-21 02:52:31 +00:00
|
|
|
}
|
|
|
|
}
|