Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves
In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.
The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.
The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.
* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 23:15:27 +00:00
|
|
|
namespace PKHeX.Core;
|
2022-06-18 18:04:24 +00:00
|
|
|
|
|
|
|
/// <summary>
|
|
|
|
/// Generation 4 Trade Encounter
|
|
|
|
/// </summary>
|
|
|
|
/// <inheritdoc cref="EncounterTradeGB"/>
|
|
|
|
public abstract record EncounterTrade4(GameVersion Version) : EncounterTrade(Version)
|
2018-03-09 05:18:32 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
public sealed override int Generation => 4;
|
Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves
In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.
The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.
The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.
* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 23:15:27 +00:00
|
|
|
public override EntityContext Context => EntityContext.Gen4;
|
2021-01-04 00:49:49 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
protected static readonly string[] RanchOTNames = { string.Empty, "ユカリ", "Hayley", "EULALIE", "GIULIA", "EUKALIA", string.Empty, "Eulalia" };
|
|
|
|
}
|
2020-08-30 22:35:59 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
/// <summary>
|
|
|
|
/// Generation 4 Trade Encounter with a fixed PID value.
|
|
|
|
/// </summary>
|
|
|
|
/// <inheritdoc cref="EncounterTrade4"/>
|
2022-11-25 01:42:17 +00:00
|
|
|
public sealed record EncounterTrade4PID : EncounterTrade4, IContestStatsReadOnly
|
2022-06-18 18:04:24 +00:00
|
|
|
{
|
2021-09-16 01:13:17 +00:00
|
|
|
/// <summary>
|
2022-06-18 18:04:24 +00:00
|
|
|
/// Fixed <see cref="PKM.PID"/> value the encounter must have.
|
2021-09-16 01:13:17 +00:00
|
|
|
/// </summary>
|
2022-06-18 18:04:24 +00:00
|
|
|
public readonly uint PID;
|
2020-03-14 04:39:35 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
public override Shiny Shiny => Shiny.FixedValue;
|
2022-03-06 05:04:18 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
public EncounterTrade4PID(GameVersion game, uint pid, ushort species, byte level) : base(game)
|
|
|
|
{
|
|
|
|
PID = pid;
|
|
|
|
Species = species;
|
|
|
|
Level = level;
|
|
|
|
}
|
2019-09-10 07:21:51 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
public byte CNT_Cool { get; init; }
|
|
|
|
public byte CNT_Beauty { get; init; }
|
|
|
|
public byte CNT_Cute { get; init; }
|
|
|
|
public byte CNT_Smart { get; init; }
|
|
|
|
public byte CNT_Tough { get; init; }
|
|
|
|
public byte CNT_Sheen { get; init; }
|
2020-12-24 08:06:40 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
public byte Contest
|
|
|
|
{
|
|
|
|
init
|
2020-12-24 08:06:40 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
CNT_Cool = value;
|
|
|
|
CNT_Beauty = value;
|
|
|
|
CNT_Cute = value;
|
|
|
|
CNT_Smart = value;
|
|
|
|
CNT_Tough = value;
|
|
|
|
//CNT_Sheen = value;
|
2020-12-24 08:06:40 +00:00
|
|
|
}
|
2022-06-18 18:04:24 +00:00
|
|
|
}
|
2020-08-30 22:35:59 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
public int MetLocation { get; init; }
|
|
|
|
public override int Location => MetLocation == default ? Locations.LinkTrade4NPC : MetLocation;
|
2021-05-19 00:14:17 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
public override bool IsMatchExact(PKM pk, EvoCriteria evo)
|
|
|
|
{
|
|
|
|
if (!base.IsMatchExact(pk, evo))
|
|
|
|
return false;
|
2020-08-30 22:35:59 +00:00
|
|
|
|
2022-11-25 01:42:17 +00:00
|
|
|
if (pk is IContestStatsReadOnly s && s.IsContestBelow(this))
|
2022-06-18 18:04:24 +00:00
|
|
|
return false;
|
2020-08-30 22:35:59 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
return true;
|
|
|
|
}
|
2020-08-30 22:35:59 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
protected override void ApplyDetails(ITrainerInfo sav, EncounterCriteria criteria, PKM pk)
|
|
|
|
{
|
|
|
|
base.ApplyDetails(sav, criteria, pk);
|
|
|
|
var pk4 = (PK4) pk;
|
2020-08-30 22:35:59 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
if (Version == GameVersion.DPPt)
|
2019-02-09 19:37:20 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
// Has German Language ID for all except German origin, which is English
|
|
|
|
if (Species == (int)Core.Species.Magikarp)
|
|
|
|
pk4.Language = (int)(pk4.Language == (int)LanguageID.German ? LanguageID.English : LanguageID.German);
|
|
|
|
// All other trades received (DP only): English games have a Japanese language ID instead of English.
|
|
|
|
else if (pk4.Version is not (int)GameVersion.Pt && pk4.Language == (int)LanguageID.English)
|
|
|
|
pk4.Language = (int)LanguageID.Japanese;
|
2019-02-09 19:37:20 +00:00
|
|
|
}
|
2022-06-18 18:04:24 +00:00
|
|
|
else // HGSS
|
2019-11-16 01:34:18 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
// Has English Language ID for all except English origin, which is French
|
|
|
|
if (Species == (int)Core.Species.Pikachu)
|
|
|
|
pk4.Language = (int)(pk4.Language == (int)LanguageID.English ? LanguageID.French : LanguageID.English);
|
2019-11-16 01:34:18 +00:00
|
|
|
}
|
2022-06-18 18:04:24 +00:00
|
|
|
|
|
|
|
this.CopyContestStatsTo(pk4);
|
2018-03-09 05:18:32 +00:00
|
|
|
}
|
2020-08-21 23:35:49 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
protected override void SetPINGA(PKM pk, EncounterCriteria criteria)
|
2020-08-21 23:35:49 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
pk.PID = PID;
|
|
|
|
pk.Nature = (int)(PID % 25);
|
|
|
|
pk.Gender = Gender;
|
|
|
|
pk.RefreshAbility(Ability.GetSingleValue());
|
|
|
|
SetIVs(pk);
|
|
|
|
}
|
2020-12-24 23:23:26 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
protected override bool IsMatchNatureGenderShiny(PKM pk)
|
|
|
|
{
|
|
|
|
return PID == pk.EncryptionConstant;
|
|
|
|
}
|
|
|
|
}
|
2021-05-19 00:14:17 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
/// <summary>
|
|
|
|
/// Generation 4 Trade Encounter with a fixed PID value, met location, and version.
|
|
|
|
/// </summary>
|
|
|
|
/// <inheritdoc cref="EncounterTradeGB"/>
|
|
|
|
public sealed record EncounterTrade4RanchGift : EncounterTrade4
|
|
|
|
{
|
|
|
|
/// <summary>
|
|
|
|
/// Fixed <see cref="PKM.PID"/> value the encounter must have.
|
|
|
|
/// </summary>
|
|
|
|
public readonly uint PID;
|
2020-12-24 23:23:26 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
public int MetLocation { private get; init; }
|
|
|
|
public override int Location => MetLocation;
|
|
|
|
public override Shiny Shiny => Shiny.FixedValue;
|
2020-09-13 21:40:10 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
public EncounterTrade4RanchGift(uint pid, ushort species, byte level) : base(GameVersion.D)
|
|
|
|
{
|
|
|
|
PID = pid;
|
|
|
|
Species = species;
|
|
|
|
Level = level;
|
|
|
|
TrainerNames = RanchOTNames;
|
2020-12-24 23:23:26 +00:00
|
|
|
}
|
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
protected override bool IsMatchNatureGenderShiny(PKM pk)
|
2020-12-24 23:23:26 +00:00
|
|
|
{
|
2022-06-18 18:04:24 +00:00
|
|
|
return PID == pk.EncryptionConstant;
|
|
|
|
}
|
2021-05-19 00:14:17 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
protected override void SetPINGA(PKM pk, EncounterCriteria criteria)
|
|
|
|
{
|
|
|
|
pk.PID = PID;
|
|
|
|
pk.Nature = (int)(PID % 25);
|
|
|
|
pk.Gender = Gender;
|
|
|
|
pk.RefreshAbility(Ability.GetSingleValue());
|
|
|
|
SetIVs(pk);
|
|
|
|
}
|
|
|
|
}
|
2020-09-13 21:40:10 +00:00
|
|
|
|
2022-06-18 18:04:24 +00:00
|
|
|
/// <summary>
|
|
|
|
/// Generation 4 Trade Encounter with a fixed location and version, as well as special details.
|
|
|
|
/// </summary>
|
|
|
|
/// <inheritdoc cref="EncounterTrade4"/>
|
|
|
|
public sealed record EncounterTrade4RanchSpecial : EncounterTrade4
|
|
|
|
{
|
|
|
|
public override int Location => 3000;
|
|
|
|
|
|
|
|
public EncounterTrade4RanchSpecial(ushort species, byte level) : base(GameVersion.D)
|
|
|
|
{
|
|
|
|
Species = species;
|
|
|
|
Level = level;
|
|
|
|
Ball = 0x10;
|
|
|
|
OTGender = 1;
|
|
|
|
TrainerNames = RanchOTNames;
|
|
|
|
}
|
|
|
|
|
|
|
|
protected override void ApplyDetails(ITrainerInfo sav, EncounterCriteria criteria, PKM pk)
|
|
|
|
{
|
|
|
|
base.ApplyDetails(sav, criteria, pk);
|
|
|
|
pk.FatefulEncounter = true;
|
2020-08-21 23:35:49 +00:00
|
|
|
}
|
|
|
|
}
|