Mirrors/BackgroundMusic
2
0
Fork 0
mirror of https://github.com/kyleneideck/BackgroundMusic synced 2024-11-26 06:00:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add new QuickLook bundle ID to fix App Volumes for Finder.

Browse source 
QuickLook's bundle ID has changed in High Sierra, which broke the
workaround that BGMApp uses to change QuickLook's app volume when
Finder's is changed.

Reported in #134.
This commit is contained in:
Kyle Neideck 2017-11-25 13:28:43 +11:00
parent ec81520379
commit 4c6de2f77f
No known key found for this signature in database
GPG key ID: CAA8D9B8E39EC18C
2 changed files with 21 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
BGMApp/BGMApp/BGMAppVolumes.m
View file

@ -377,7 +377,10 @@ static NSString* const kMoreAppsMenuTitle = @"More Apps";
- (void) appVolumeChanged {
// TODO: This (sending updates to the driver) should probably be rate-limited. It uses a fair bit of CPU for me.
DebugMsg("BGMAppVolumes::appVolumeChanged: App volume for %s changed to %d", appBundleID.UTF8String, self.intValue);
DebugMsg("BGMAppVolumes::appVolumeChanged: App volume for %s (%d) changed to %d",
appBundleID.UTF8String,
appProcessID,
self.intValue);
[self snap];

32
BGMApp/BGMApp/BGMBackgroundMusicDevice.cpp
View file

@ -218,21 +218,23 @@ BGMBackgroundMusicDevice::ResponsibleBundleIDsOf(CACFString inParentBundleID)
}
std::map<CACFString, std::vector<CACFString>> bundleIDMap = {
// Finder
{ "com.apple.finder", { "com.apple.quicklook.ui.helper" } },
// Safari
{ "com.apple.Safari", { "com.apple.WebKit.WebContent" } },
// Firefox
{ "org.mozilla.firefox", { "org.mozilla.plugincontainer" } },
// Firefox Nightly
{ "org.mozilla.nightly", { "org.mozilla.plugincontainer" } },
// VMWare Fusion
{ "com.vmware.fusion", { "com.vmware.vmware-vmx" } },
// Parallels
{ "com.parallels.desktop.console", { "com.parallels.vm" } },
// MPlayer OSX Extended
{ "hu.mplayerhq.mplayerosx.extended",
{ "ch.sttz.mplayerosx.extended.binaries.officialsvn" } }
// Finder
{ "com.apple.finder",
{ "com.apple.quicklook.ui.helper",
"com.apple.quicklook.QuickLookUIService" } },
// Safari
{ "com.apple.Safari", { "com.apple.WebKit.WebContent" } },
// Firefox
{ "org.mozilla.firefox", { "org.mozilla.plugincontainer" } },
// Firefox Nightly
{ "org.mozilla.nightly", { "org.mozilla.plugincontainer" } },
// VMWare Fusion
{ "com.vmware.fusion", { "com.vmware.vmware-vmx" } },
// Parallels
{ "com.parallels.desktop.console", { "com.parallels.vm" } },
// MPlayer OSX Extended
{ "hu.mplayerhq.mplayerosx.extended",
{ "ch.sttz.mplayerosx.extended.binaries.officialsvn" } }
};
// Parallels' VM "dock helper" apps have bundle IDs like