From 24b248e09d727db5fdf1ca1a33efc839d537f1e7 Mon Sep 17 00:00:00 2001 From: Jon Egan Date: Wed, 19 Jan 2022 07:01:13 -0500 Subject: [PATCH 1/2] Fix for issue #475 dropdown arrows move instead of doing something --- BGMApp/BGMApp/BGMAppVolumes.m | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/BGMApp/BGMApp/BGMAppVolumes.m b/BGMApp/BGMApp/BGMAppVolumes.m index ffe2aea..e6c35fc 100644 --- a/BGMApp/BGMApp/BGMAppVolumes.m +++ b/BGMApp/BGMApp/BGMAppVolumes.m @@ -284,7 +284,16 @@ static NSString* const kMoreAppsMenuTitle = @"More Apps"; return fabs(x - y) < 0.01; // We don't need much precision. }; - if (nearEnough(button.frameCenterRotation, 0.0)) { + bool allSubviewsShowing = true; + for (NSView* subview in menuItem.view.subviews) { + if (subview.hidden) { + allSubviewsShowing = false; + break; + } + //DebugMsg("BGMAppVolumes:: subview hash / hidden: (%lu) / (%hhd)", (unsigned long)subview.hash, subview.hidden); + } + + if (allSubviewsShowing) { // Hide extra controls DebugMsg("BGMAppVolumes::showHideExtraControls: Hiding extra controls (%s)", appName); From 3bfd68615f319f793c448a88508b51985bbbd744 Mon Sep 17 00:00:00 2001 From: Jon Egan Date: Wed, 19 Jan 2022 07:16:17 -0500 Subject: [PATCH 2/2] added copyright --- BGMApp/BGMApp/BGMAppVolumes.m | 1 + 1 file changed, 1 insertion(+) diff --git a/BGMApp/BGMApp/BGMAppVolumes.m b/BGMApp/BGMApp/BGMAppVolumes.m index e6c35fc..8393ce6 100644 --- a/BGMApp/BGMApp/BGMAppVolumes.m +++ b/BGMApp/BGMApp/BGMAppVolumes.m @@ -20,6 +20,7 @@ // Copyright © 2016-2020 Kyle Neideck // Copyright © 2017 Andrew Tonner // Copyright © 2021 Marcus Wu +// Copyright © 2022 Jon Egan // // Self Include