Commit graph

24 commits

Author SHA1 Message Date
JustArchi
4e1a03222b Fix potential STM logic exploit
Previously we calculated amounts (and therefore, differences) based on cards only, which means that user could earn some extra 'points' in our calculation for giving us many trash cards that we miss, and in exchange for that swap cards from some other game that would normally results in non-neutral difference on that game basis, but neutral+ in overall basis (that we operated on).
This would not cause any serious problem, because ASF ensures that trade is fair before calculating actual neutrality, but it could result in accepting a trade that is neutral+ only at first sight, and non-neutral+ when we take a closer look what we're actually swapping.
The logic was enhanced to handle differences on per-game basis now, and taking minimum in account, so all swaps on per-game basis have to be neutral+ now
2017-04-08 04:33:01 +02:00
JustArchi
adfc992f26 Resharper Cleanup v2 2017-04-05 17:23:18 +02:00
JustArchi
fcf9686a79 Revert "Resharper cleanup"
This reverts commit 7c8d7b5ada.

Bad cleanup.
2017-04-05 17:01:18 +02:00
JustArchi
7c8d7b5ada Resharper cleanup 2017-04-05 16:59:48 +02:00
JustArchi
fbadc748c1 ReSharper code style update 2017-03-01 23:03:13 +01:00
JustArchi
a502826586 Update Resharper code style 2017-03-01 22:21:53 +01:00
JustArchi
24350dcba5 Closes #448
Everything works on Windows, pending tests on Mono
2017-02-03 09:54:09 +01:00
JustArchi
3e2679a57d Ignore missing translations for resharper 2017-01-08 06:18:46 +01:00
JustArchi
b2b11fe807 Localizing... 2017-01-06 13:20:36 +01:00
JustArchi
b7f15daa91 Misc 2016-11-24 07:49:44 +01:00
JustArchi
137a53ef89 Improve readability of some specific segments 2016-11-24 07:46:37 +01:00
JustArchi
df218074ad Gigantic code cleanup
Time to enforce some common file layout, as general mess started to annoying me. Sorry in advance for people using custom forks and having merge conflicts, this will help everybody in long-run
2016-11-24 07:32:16 +01:00
JustArchi
102caac4f0 Silent some more intrusive ReSharper inspections 2016-10-05 07:31:27 +02:00
JustArchi
2aec630b71 Final code review for today 2016-10-01 01:02:16 +02:00
JustArchi
d9e241a1b4 Code review 2016-10-01 00:25:15 +02:00
JustArchi
4a0866f93f Add family sharing inactivity timer 2016-09-30 04:02:25 +02:00
JustArchi
72b0ae21df EXPERIMENTAL: Make GetConfirmations() recursive 2016-09-29 21:04:34 +02:00
JustArchi
d517562467 Add more farming orders 2016-07-30 20:55:43 +02:00
stackia
5596e55c7b
Update ReSharper DotSettings file
This purges all green squiggly underlines on my machine.
2016-07-30 06:39:46 +08:00
JustArchi
feb3fbfe59 Get used to null propagation 2016-07-10 20:17:35 +02:00
JustArchi
1fe5cfff49 Fix broken Mono after #268 2016-06-28 10:36:28 +02:00
JustArchi
8d9fbce2ed Add support for encrypted passwords, closes #267 2016-06-28 04:32:48 +02:00
JustArchi
2ebce59ee7 WIP: Gigantic work on #252
TODO: Market confirmations, cleanup, code review, shitload of tests...
2016-06-19 05:40:46 +02:00
JustArchi
aae41d5c1f Add IsBotAccount + misc 2016-06-04 22:02:38 +02:00